4 weeks agofix typo in conn.c master
salaaad2 [Thu, 27 May 2021 16:19:30 +0000 (18:19 +0200)]
fix typo in conn.c

11 months ago2022 =:)
Alexander Barton [Sat, 1 Jan 2022 15:05:09 +0000 (16:05 +0100)]
2022 =:)

Happy new year!

11 months agoFix a possible race condition in Client_Introduce()
Alexander Barton [Thu, 30 Dec 2021 19:31:41 +0000 (20:31 +0100)]
Fix a possible race condition in Client_Introduce()

Conf_GetServer() can return NULL when the server introducing the client
had a write error for example, and is being disconnected.

So make sure that we have a valid server before calling Conf_NickIsService()!

11 months agoEnhance documentation a bit, add doc/
Alexander Barton [Thu, 30 Dec 2021 19:01:44 +0000 (20:01 +0100)]
Enhance documentation a bit, add doc/

And this file could well be expanded!

13 months agodoc/HowToRelease.txt: "dist-tarZ" and "dist-xz" make targets can't be combined
Alexander Barton [Sun, 31 Oct 2021 12:41:20 +0000 (13:41 +0100)]
doc/HowToRelease.txt: "dist-tarZ" and "dist-xz" make targets can't be combined

23 months agongIRCd Release 26.1 rel-26.1
Alexander Barton [Sat, 2 Jan 2021 13:32:48 +0000 (14:32 +0100)]
ngIRCd Release 26.1

23 months agoUpdate AUTHORS file
Alexander Barton [Sat, 2 Jan 2021 13:23:45 +0000 (14:23 +0100)]
Update AUTHORS file

23 months agoUpdate config.guess and config.sub to recent versions
Alexander Barton [Sat, 2 Jan 2021 12:36:45 +0000 (13:36 +0100)]
Update config.guess and config.sub to recent versions

- config.guess: 2020-12-22
- config.sub: 2020-12-22

23 months agoUpdate NEWS and ChangeLog files
Alexander Barton [Fri, 1 Jan 2021 19:07:47 +0000 (20:07 +0100)]
Update NEWS and ChangeLog files

23 months agoUpdate Platforms.txt
Alexander Barton [Fri, 1 Jan 2021 15:12:46 +0000 (16:12 +0100)]
Update Platforms.txt

- Add aarch64/apple/darwin (Apple CLang 12.0.0)
- Add x86_64/unknown/openbsd6.7 (gcc 4.2.1)

Thanks to Götz Hoffart <>

23 months ago2021! :-)
Alexander Barton [Fri, 1 Jan 2021 14:38:26 +0000 (15:38 +0100)]
2021! :-)

Happy new year!

23 months agoExplicitely cast Conf_MaxPenaltyTime (time_t) to "long"
Alexander Barton [Tue, 29 Dec 2020 20:45:09 +0000 (21:45 +0100)]
Explicitely cast Conf_MaxPenaltyTime (time_t) to "long"

This fixes the following compiler warning, for example on OpenBSD:

  conf.c: In function 'Conf_Test':
  conf.c:391: warning: format '%ld' expects type 'long int', but argument
                       2 has type 'time_t'

Thanks to Götz Hoffart for reporting this!

23 months agoDon't set AI_ADDRCONFIG, even when it exists
Alexander Barton [Tue, 29 Dec 2020 20:12:43 +0000 (21:12 +0100)]
Don't set AI_ADDRCONFIG, even when it exists

Basically, the issue described in #281 is that the test suite uses the
IPv4 address on an IPv6-only host. But this is the "safest"
thing to do in (almost) all other setups: relaying on DNS host names
makes things even more complex, as different systems map
differently (including the reverse lookup; that's why we switched to back in 2014, see commit 3f807e10457).

But with AI_ADDRCONFIG set, on an IPv6-only host, we prevent
to get translated properly, even when the loopback interface has this
address configured! So don't set it any more.

The drawback is that the resolver possibly returns more addresses now,
even of an unsupported/not connected address family; but this shouldn't
do much harm in practice, as ngIRCd iterates over all returned addresses
while trying to establish an outgoing connection.

Closes #281.

2 years agoFAQ.txt: There is no "CVS" anymore, we use Git!
Alexander Barton [Sat, 28 Nov 2020 20:21:47 +0000 (21:21 +0100)]
FAQ.txt: There is no "CVS" anymore, we use Git!

2 years agoFix typo in comment: operaor -> operator
Rolf Eike Beer [Sun, 1 Nov 2020 17:00:22 +0000 (18:00 +0100)]
Fix typo in comment: operaor -> operator

2 years agoRevert "Show allowed channel types in ISUPPORT(005) numeric only"
Alexander Barton [Mon, 2 Nov 2020 10:45:41 +0000 (11:45 +0100)]
Revert "Show allowed channel types in ISUPPORT(005) numeric only"

The ISUPPORT(005) numeric lists only channel prefixes which are listed
in the "AllowedChannelTypes" configuration option. And if this is the
empty string ("") for example, this now results in IRC clients assuming
"oh, no channel prefix characters at all, so no channels at all, so no
PRIVMSG can go to any channel" -- which is not the case when there are
pre-defined channel set up or other servers still having channels!

So "allowed channel types" != "supported channel types", and we always
have to list all supported ones in the ISUPPORT(005) numeric!

This reverts commit 4b7e8db418340576c95f1edad8470b66d6fe886d.

Closes #285.

2 years agoTest suite: Wait 2 seconds after reloading the daemon
Alexander Barton [Sun, 1 Nov 2020 16:25:39 +0000 (17:25 +0100)]
Test suite: Wait 2 seconds after reloading the daemon

On reload, all listening ports are closed, configuration updated, and
then opened again. Which leads to subsequent tests running while the
daemon isn't listening on any ports, and that's why the tests fail.

The "proper" way whould be to loop and check for open ports, but waiting
is what the script does right now, so stick with this in for now as well.

This fixes the issue, at least on my RaspberryPi ...

Closes #280.

2 years agoUpdate Platforms.txt
Alexander Barton [Tue, 20 Oct 2020 19:48:16 +0000 (21:48 +0200)]
Update Platforms.txt

- Update powerpc/apple/darwin8.11.0 (gcc 4.0.1)
- Add x86_64/apple/darwin19.6.0 (Apple clang 12.0.0)
- Add x86_64/unknown/freebsd12.1 (FreeBSD clang 8.0.1)
- Update x86_64/pc/linux-gnu (gcc 8.3.0)
- Add x86_64/unknown/netbsd9.0 (gcc 7.4.0)
- Add x86_64/unknown/openbsd6.6 (gcc 4.2.1)
- Add x86_64/unknown/openbsd6.6 (OpenBSD clang 8.0.1)

Thanks to Götz Hoffart <> for the PowerPC test!

2 years Try to mangle CLang name more intellligently
Alexander Barton [Tue, 20 Oct 2020 19:47:10 +0000 (21:47 +0200)] Try to mangle CLang name more intellligently

2 years agoFixed Atheme Links
xnaas [Tue, 4 Aug 2020 03:17:04 +0000 (22:17 -0500)]
Fixed Atheme Links

.org and not .net

2 years agongIRCd Release 26 rel-26
Alexander Barton [Sat, 20 Jun 2020 13:54:19 +0000 (15:54 +0200)]
ngIRCd Release 26

2 years Add instructions for ArchLinux (pacman)
Alexander Barton [Sat, 20 Jun 2020 13:54:02 +0000 (15:54 +0200)] Add instructions for ArchLinux (pacman)

2 years agongIRCd Release 26~rc2 rel-26-rc2
Alexander Barton [Thu, 11 Jun 2020 15:22:08 +0000 (17:22 +0200)]
ngIRCd Release 26~rc2

2 years agoUpdate NEWS, ChangeLog and doc/Platforms.txt files
Alexander Barton [Thu, 11 Jun 2020 15:13:06 +0000 (17:13 +0200)]
Update NEWS, ChangeLog and doc/Platforms.txt files

2 years agoAdd AppStream metadata file: contrib/de.barton.ngircd.metainfo.xml
Alexander Barton [Thu, 11 Jun 2020 15:11:15 +0000 (17:11 +0200)]
Add AppStream metadata file: contrib/de.barton.ngircd.metainfo.xml

2 years agoDon't send invalid CHANINFO commands when no key is set
Alexander Barton [Thu, 11 Jun 2020 14:45:30 +0000 (16:45 +0200)]
Don't send invalid CHANINFO commands when no key is set

It can happen that a channel is +k, but no key is set: for example by
misconfiguring a pre-defined channel. In this case, ngIRCd sent an
invalud CHANINFO command ("CHANINFO #test +Pk  0 :'", note the unset
key represented by the two spaces) to its peers.

Fix this and enhance the CHANINFO documentation.

2 years agoUpdate NEWS and ChangeLog files
Alexander Barton [Sun, 31 May 2020 17:38:59 +0000 (19:38 +0200)]
Update NEWS and ChangeLog files

2 years agoUpdate description text in manual page, too!
Alexander Barton [Tue, 26 May 2020 21:00:25 +0000 (23:00 +0200)]
Update description text in manual page, too!

2 years agongircd.spec: Fix name of and
Alexander Barton [Tue, 26 May 2020 17:55:01 +0000 (19:55 +0200)]
ngircd.spec: Fix name of and

2 years agoUpdate description texts
Alexander Barton [Tue, 26 May 2020 17:43:11 +0000 (19:43 +0200)]
Update description texts

Bring them in line with the updated texts on the homepage.

2 years agoIRC_SQUIT(): Fix use-after-free when unregistering the sending client
Alexander Barton [Mon, 25 May 2020 22:05:22 +0000 (00:05 +0200)]
IRC_SQUIT(): Fix use-after-free when unregistering the sending client

2 years agoIRC_SERVER: Make sure that the client sent a prefix
Alexander Barton [Mon, 25 May 2020 21:43:29 +0000 (23:43 +0200)]
IRC_SERVER: Make sure that the client sent a prefix

The SERVER command is only valid with a prefix when received from other
servers, so make sure that there is one and disconnect the peer if not
(instead of crashing ...).

This obsoletes PR #275.

Thanks Hilko Bengen (hillu) for finding & reporting this as well for the
patch & pull request! But I think this is the "more correct" fix.

2 years agoEnhance debug logging for PONG commands
Alexander Barton [Mon, 25 May 2020 21:30:07 +0000 (23:30 +0200)]
Enhance debug logging for PONG commands

Distinguish between expected and unexpected PONG commands.

2 years agoFix PING-PONG handling when processing backlog in read buffers
Alexander Barton [Mon, 25 May 2020 17:02:16 +0000 (19:02 +0200)]
Fix PING-PONG handling when processing backlog in read buffers

Prior to this commit, the PONG wasn't registered correctly, becauuse the
"last ping" time was set to time(NULL), which could be bigger than the
"last data" time stamp, for example when handling the read buffer took
more than 1 second -- and this resulted in the PONG time out kicking in
effectively disconnecting a newly linked server for example, because
ngIRCd thought it was still waiting for a PONG: last data < last ping.

Now the "last ping" value has three possible values:

    0: new connection, no PING, no PONG so far.
    1: got a PONG, no longer waiting for a PONG.
  <t>: time stamp of last sent out PING command.

2 years agoRevert "Set the "last data" time to "last ping" time when updating the latter"
Alexander Barton [Sun, 24 May 2020 21:24:51 +0000 (23:24 +0200)]
Revert "Set the "last data" time to "last ping" time when updating the latter"

This patch completely broke the PING-PONG logic: now ngIRCd never
disconnects any stale peers but keeps sending out PINGs over and over
again ...

The real issue (server disconnects right after connect) will be fixed in
the next commit, but let's revert to the somewhat "half-broken but
'known' state" first ...

This reverts commit 79a917f954bef8089967786bd3597a6e5ff5c336.

2 years agotestsuite: Add missing files to EXTRA_DIST
Hilko Bengen [Fri, 22 May 2020 10:29:09 +0000 (12:29 +0200)]
testsuite: Add missing files to EXTRA_DIST

26~rc1 as extracted from tarball cannot be built/tested with SSL
support because of a missing script and certificates.

2 years agongIRCd Release 26~rc1 rel-26-rc1
Alexander Barton [Sun, 10 May 2020 15:13:51 +0000 (17:13 +0200)]
ngIRCd Release 26~rc1

2 years agoUpdate config.guess and config.sub to recent versions
Alexander Barton [Sun, 10 May 2020 15:06:27 +0000 (17:06 +0200)]
Update config.guess and config.sub to recent versions

- config.guess: 2020-04-26
- config.sub: 2020-05-04

And set both scripts +x, they are executable.

2 years agoUpdate NEWS and ChangeLog files
Alexander Barton [Sat, 9 May 2020 23:09:34 +0000 (01:09 +0200)]
Update NEWS and ChangeLog files

2 years agoAdd missing authors to AUTHORS, tweak ".mailmap" file
Alexander Barton [Sat, 9 May 2020 22:16:11 +0000 (00:16 +0200)]
Add missing authors to AUTHORS, tweak ".mailmap" file

2 years agoTweak & update doc/HowToRelease.txt a bit ...
Alexander Barton [Sat, 9 May 2020 22:14:04 +0000 (00:14 +0200)]
Tweak & update doc/HowToRelease.txt a bit ...

2 years agoAllow more characters per line in MOTD and help text files
Alexander Barton [Thu, 7 May 2020 16:10:41 +0000 (18:10 +0200)]
Allow more characters per line in MOTD and help text files

Change the line buffer in the Read_TextFile() function from 127 to
COMMAND_LEN (=512) bytes. Lines can't even get that long, because they
have to be prefixed before being sent to the client, so this is a sane

This allows for even more "fancy" and "wider" MOTDs :-)

Closes #271.

2 years agoShow allowed channel types in ISUPPORT(005) numeric only
Alexander Barton [Thu, 7 May 2020 16:03:06 +0000 (18:03 +0200)]
Show allowed channel types in ISUPPORT(005) numeric only

Don't show the static list of all possibly available channel types ...

Closes #273.

2 years agoPlatforms.txt: Add x86_64/apple/darwin19.0.0
Alexander Barton [Mon, 16 Dec 2019 16:06:51 +0000 (17:06 +0100)]
Platforms.txt: Add x86_64/apple/darwin19.0.0

- Add x86_64/apple/darwin19.0.0 (Apple clang 11.0)

2 years agoUpdate Platforms.txt
Alexander Barton [Mon, 16 Dec 2019 16:05:39 +0000 (17:05 +0100)]
Update Platforms.txt

- Update powerpc/apple/darwin8.11.0 (gcc 4.0.1)
- Add mips/sgi/irix6.5 (SGI C compiler)
- Add mipsel/unknown/netbsd8.0 (gcc 5.5.0)

Thanks to Götz Hoffart <>!

2 years agoSSL test server: Use port 6790, like "test server #2"
Alexander Barton [Wed, 6 May 2020 21:55:23 +0000 (23:55 +0200)]
SSL test server: Use port 6790, like "test server #2"

Don't use the "standard" IRC SSL port 6697, as this easily collides with
real (ng)IRCd instances running on the same machine.

And by reusing port 6790, which is already used by the "test server #2",
we don't need any other port than the test suite already uses.

2 years agoGit: Ignore generated files of SSL tests
Alexander Barton [Thu, 30 Apr 2020 10:15:54 +0000 (12:15 +0200)]
Git: Ignore generated files of SSL tests

2 years agoMerge pull request #269 from hillu/gnutls-reload-cert
Alexander Barton [Wed, 6 May 2020 21:36:19 +0000 (23:36 +0200)]
Merge pull request #269 from hillu/gnutls-reload-cert

Add support for GnuTLS certificate reload.

Thanks a lot, Hilko Bengen!

2 years agoUpdate Client_SetHostname() to not use strpbrk()
Alexander Barton [Sun, 3 May 2020 22:55:25 +0000 (00:55 +0200)]
Update Client_SetHostname() to not use strpbrk()

Not sure about the portability of strpbrk() in really ancient OS, and
this was the only place where it became used recently in ngIRCd ...
So let's play it safe! ;-)

2 years agoAllow hostmask cloaking when rDNS is disabled
michi [Tue, 21 Apr 2020 11:02:08 +0000 (13:02 +0200)]
Allow hostmask cloaking when rDNS is disabled

2 years agoDon't wait for the network when read buffers possibly hold commands
Alexander Barton [Sun, 3 May 2020 00:55:34 +0000 (02:55 +0200)]
Don't wait for the network when read buffers possibly hold commands

There is no point in waiting up to one second for the network receiving
new data when there is still a read buffer holding at least one command;
we shouldn't waste time but handle it immediately!

2 years agoHandle commands in the read buffer before reading more data
Alexander Barton [Fri, 1 May 2020 21:55:28 +0000 (23:55 +0200)]
Handle commands in the read buffer before reading more data

If there are more bytes in the read buffer already than a single valid
IRC command can get long (513 bytes, COMMAND_LEN), wait for this/those
command(s) to be handled first and don't try to read even more data from
the network (which most probably would overflow the read buffer of this
connection soon).

2 years agoRead_Request(): Clean up code and add some more comments
Alexander Barton [Fri, 1 May 2020 21:41:49 +0000 (23:41 +0200)]
Read_Request(): Clean up code and add some more comments

No functional changes.

2 years agoRevert "Increase read buffer size for server connections"
Alexander Barton [Fri, 1 May 2020 20:38:41 +0000 (22:38 +0200)]
Revert "Increase read buffer size for server connections"

This reverts commit c6e3c13f27744971fcb1d2de4e561d3bcdaa5aed.

This sounded like the right approach at first, but I'm not that sure
that it really makes sense to have different sizes of read buffers: the
per-connection read buffer only needs to keep data that is needed to
parse one full command, be it plain text, encrypted and/or compressed.
Then ngIRCd should handle this one command, move leftover data to the
beginning of the buffer and read the next chunk from the network that is
missing to get the next complete command (512 bytes at max).

So I revert this for now and try to fix the logic in Read_Request(),
which is broken nevertheless, as it results in servers becoming
disconnected during "server burst" when "big" lists are transferred.

2 years agoCorrectly use Config_Error() instead of Log() in Read_Config()
Alexander Barton [Sun, 3 May 2020 15:08:51 +0000 (17:08 +0200)]
Correctly use Config_Error() instead of Log() in Read_Config()

The name of the Config_Error() function is misleading: it is not only
used to show configuraton errors, but all messages shown during normal
operation as well as for "config testing": it takes care of the correct
formatting of the messages (syslog, forground logging, config testing).

This fixes commit bb1d014abad8.

2 years agocontrib/ Looks like GNU awk (gawk) is needed ...
Alexander Barton [Sun, 3 May 2020 15:07:51 +0000 (17:07 +0200)]
contrib/ Looks like GNU awk (gawk) is needed ...

2 years agoUpdate Travis-CI configuration, "sudo" is depreacted
Alexander Barton [Sun, 3 May 2020 01:11:25 +0000 (03:11 +0200)]
Update Travis-CI configuration, "sudo" is depreacted

2 years agoLog G-/K-Line changes only when not initiated by a server
Alexander Barton [Sun, 3 May 2020 01:08:41 +0000 (03:08 +0200)]
Log G-/K-Line changes only when not initiated by a server

This prevents the log from becomming spammed during "net bursts".

2 years agoSet the "last data" time to "last ping" time when updating the latter
Alexander Barton [Sun, 3 May 2020 01:04:29 +0000 (03:04 +0200)]
Set the "last data" time to "last ping" time when updating the latter

This is required because the PING can be received quite a bit earlier
than it is actually handled, for example during "server burst" or other
heavy operations:
So the times won't match and PING-PONG logic would become garbled,
because we test for "last ping > last data" to determine if a PING
already was sent or not.

2 years agoupdating testsuite to support ssl-tests
Johann Hartwig Hauschild [Fri, 24 Apr 2020 22:04:38 +0000 (00:04 +0200)]
updating testsuite to support ssl-tests

2 years Add not about removed legacy options
Alexander Barton [Mon, 20 Apr 2020 17:31:57 +0000 (19:31 +0200)] Add not about removed legacy options

2 years Replace make with ${MAKE} (#270)
sam_c [Mon, 20 Apr 2020 17:29:16 +0000 (18:29 +0100)] Replace make with ${MAKE} (#270)

Fixes warnings such as:
"warning: jobserver unavailable: using -j1. Add `+' to parent make rule."

Signed-off-by: Sam James (sam_c) <>
2 years agoUpdate AUTHORS file
Alexander Barton [Mon, 20 Apr 2020 17:25:28 +0000 (19:25 +0200)]
Update AUTHORS file

2 years agoChangeLog: Add missing patch attribution
Alexander Barton [Mon, 20 Apr 2020 17:25:02 +0000 (19:25 +0200)]
ChangeLog: Add missing patch attribution

2 years agoUpdate NEWS and ChangeLog files
Alexander Barton [Mon, 20 Apr 2020 17:14:54 +0000 (19:14 +0200)]
Update NEWS and ChangeLog files

2 years agocontrib/ Use bash(1) as interpreter
Alexander Barton [Mon, 20 Apr 2020 08:01:01 +0000 (10:01 +0200)]
contrib/ Use bash(1) as interpreter

bash(1) is required to handle the forking and output redirection
connectly, sh(1) -- at least dash(1) on Debian -- fails ...

This fixes the last commit, 14777c18c.

2 years agocontrib/ Fork awk(1), deal better with signals (CTRL-C)
Alexander Barton [Sun, 19 Apr 2020 22:55:24 +0000 (00:55 +0200)]
contrib/ Fork awk(1), deal better with signals (CTRL-C)

2 years agoUpdate Xcode project for latest Xcode version (11.4.1)
Alexander Barton [Sun, 19 Apr 2020 22:54:06 +0000 (00:54 +0200)]
Update Xcode project for latest Xcode version (11.4.1)

2 years agoRemove legacy configuration options
michi [Thu, 16 Apr 2020 09:25:44 +0000 (11:25 +0200)]
Remove legacy configuration options

Remove legacy configuration options and related functions that have
been marked for removal for some time:

- PredefChannelsOnly (v22)
- NoticeAuth (v24)
- NoXXX (v19)
- Old '[GLOBAL]' section handling (v19)

2 years agoIncrease read buffer size for server connections
michi [Wed, 15 Apr 2020 08:32:08 +0000 (10:32 +0200)]
Increase read buffer size for server connections

This applies the same logic we have for write buffers to distinguish
between server and client connections and sets the maximum buffer size
accordingly. As a result peering with servers with many GLINE/KLINEs
does not kill the connecting server connection anymore.

2 years agoFix recursion bug on write error
michi [Tue, 14 Apr 2020 15:41:52 +0000 (17:41 +0200)]
Fix recursion bug on write error

Depending on the stack size, too many clients on the same channel
quitting at the same time would trigger a crash due to too many
recursive calls to Conn_Close().

2 years agoFix hostmask cloaking bug for IPv6 too
michi [Tue, 14 Apr 2020 14:58:04 +0000 (16:58 +0200)]
Fix hostmask cloaking bug for IPv6 too

2 years agoUnbreak GCC 10 (-fno-common) build
michi [Tue, 14 Apr 2020 14:53:02 +0000 (16:53 +0200)]
Unbreak GCC 10 (-fno-common) build

2 years agoGnuTLS: Eliminate memory leaks for DH parameters, priorities cache
Hilko Bengen [Sun, 19 Apr 2020 19:20:43 +0000 (21:20 +0200)]
GnuTLS: Eliminate memory leaks for DH parameters, priorities cache

The DH parameters reference has to be stored next to the x509_cred
which holds a reference to it.

2 years agoAdd support for GnuTLS certificate reload
Hilko Bengen [Fri, 17 Apr 2020 15:34:12 +0000 (17:34 +0200)]
Add support for GnuTLS certificate reload

This requires keeping track of currently active certificates, so those
are stored separately, along with a reference counter, and discarded
when they are no longer in use.

2 years agoUpdate documentation to reflect "[Channel]->Modes" changes
Alexander Barton [Sun, 29 Mar 2020 21:17:21 +0000 (23:17 +0200)]
Update documentation to reflect "[Channel]->Modes" changes

No longer mention "[Channel]->Key" and "[Channel]->MaxUsers".

2 years agoConvert INSTALL and README files to Markdown
Alexander Barton [Tue, 11 Feb 2020 20:00:18 +0000 (21:00 +0100)]
Convert INSTALL and README files to Markdown

This requires some changes to the build system, for example to comply
with the expectations of the GNU autoconf/automake tools ...

2 years agoAdd deprecation warnings for "Key" and "MaxUsers" in [Channel]
Alexander Barton [Sun, 29 Mar 2020 20:30:47 +0000 (22:30 +0200)]
Add deprecation warnings for "Key" and "MaxUsers" in [Channel]

2 years agoTest suite: Test multiple "Modes" lines in [Channel] sections
Alexander Barton [Sun, 29 Mar 2020 00:15:39 +0000 (01:15 +0100)]
Test suite: Test multiple "Modes" lines in [Channel] sections

2 years agoPredefined channles: Fix handling of legacy configuration options
Alexander Barton [Sat, 28 Mar 2020 22:37:47 +0000 (23:37 +0100)]
Predefined channles: Fix handling of legacy configuration options

Fix the handling of legacy "Key" and "MaxUsers" [Channel] settings:

- Activate them before evaluating the "Modes" parameter, to allow the
  latter to override those legacy options.
- Enforce setting the respective +k/+l mode(s) to support the legacy
  "Mode = kl" notation, which was valid but is an invalid MODE string:
  key and limit are missing! So set them manually when "k" or "l" are
  detected in the first MODE parameter.
- Sort modes +kl alphabetically, adjust test suite accordingly.

2 years agoEnhance logging while setting up predefined channels
Alexander Barton [Sat, 28 Mar 2020 22:33:03 +0000 (23:33 +0100)]
Enhance logging while setting up predefined channels

2 years agoAllow multiple "Modes =" lines per [Channel] section
michi [Sat, 29 Feb 2020 16:32:52 +0000 (16:32 +0000)]
Allow multiple "Modes =" lines per [Channel] section

2 years agoEvaluate initial channel modes
michi [Wed, 19 Feb 2020 09:26:21 +0000 (09:26 +0000)]
Evaluate initial channel modes

Allow setting arbitrary channel modes in the config file.

Closes #55.

2 years agoXcode: add missing files in src/testsuite, and sort them
Alexander Barton [Sat, 28 Mar 2020 22:46:16 +0000 (23:46 +0100)]
Xcode: add missing files in src/testsuite, and sort them

2 years agoAdd "FNC" (forced nick changes) to ISUPPORT(005) numeric
Alexander Barton [Sun, 22 Mar 2020 13:07:32 +0000 (14:07 +0100)]
Add "FNC" (forced nick changes) to ISUPPORT(005) numeric

Most probably this doesn't make any difference to any client, but it
seems correct. See <> for details.

2 years agoFix memory leak in portabtest Check_strtok_r()
Alexander Barton [Sat, 15 Feb 2020 13:56:07 +0000 (14:56 +0100)]
Fix memory leak in portabtest Check_strtok_r()

Fix the following Clang "LeakSanitizer" error (which isn't quite
relevant in this test program, but anyway):

  ERROR: LeakSanitizer: detected memory leaks

  Direct leak of 7 byte(s) in 1 object(s) allocated from:
      #0 0x7f8c4d022810 in strdup (/lib/x86_64-linux-gnu/
      #1 0x5601a801491a in Check_strtok_r (/net/arthur/home/alex/Develop/ngIRCd/ngIRCd.git/src/portab/portabtest+0x291a)
      #2 0x5601a8014d77 in main (/net/arthur/home/alex/Develop/ngIRCd/ngIRCd.git/src/portab/portabtest+0x2d77)
      #3 0x7f8c4c69009a in __libc_start_main ../csu/libc-start.c:308

  SUMMARY: AddressSanitizer: 7 byte(s) leaked in 1 allocation(s).
  FAIL: portabtest

2 years agoReuse old SSL key if loading a new one failed
michi [Fri, 14 Feb 2020 12:44:10 +0000 (12:44 +0000)]
Reuse old SSL key if loading a new one failed

2 years agoUpdate Xcode project for latest Xcode version (11.3.1)
Alexander Barton [Tue, 11 Feb 2020 19:33:44 +0000 (20:33 +0100)]
Update Xcode project for latest Xcode version (11.3.1)

2 years agoRemove outdated OpenBSD/NetBSD systrace.policy
Alexander Barton [Tue, 11 Feb 2020 19:20:45 +0000 (20:20 +0100)]
Remove outdated OpenBSD/NetBSD systrace.policy

Systrace was removed from OpenBSD and NetBSD, so remove this (old and
outdated?) configuration file from the ./contrib directory.

See <>.

Thanks to "michi" for pointing this out on #ngircd!

2 years ago2020!
Alexander Barton [Tue, 21 Jan 2020 21:02:40 +0000 (22:02 +0100)]

2 years agoEnhance handling of command line errors, and "--help" & "--version"
Alexander Barton [Tue, 31 Dec 2019 15:34:23 +0000 (16:34 +0100)]
Enhance handling of command line errors, and "--help" & "--version"

Return with exit code 0 ("no error") when "--help" or "--version" was
used (this resulted in exit code 1, "error" before).

And exit with code 2 ("command line error") for all invalid command
line options, and show the error message on stderr (message was printed
to stdout before, and exit code was 1, "generic error").

This new behaviour is more in line with the GNU "coding standards",
see <>.

2 years agoFix and update Xcode project
Alexander Barton [Mon, 16 Dec 2019 15:57:56 +0000 (16:57 +0100)]
Fix and update Xcode project

- Reference correct contrib/ file
- Correctly sort contrib/

2 years agoUpdate name in Makefile and Xcode project, too
Alexander Barton [Mon, 16 Dec 2019 15:54:13 +0000 (16:54 +0100)]
Update name in Makefile and Xcode project, too

2 years agocontrib/README: Add script to the list
Alexander Barton [Sat, 7 Dec 2019 00:43:00 +0000 (01:43 +0100)]
contrib/README: Add script to the list

2 years agocontrib/ Use bright colors for warning & error messages
Alexander Barton [Sat, 7 Dec 2019 00:42:33 +0000 (01:42 +0100)]
contrib/ Use bright colors for warning & error messages

2 years agocontrib/ Enhance and rename script
Alexander Barton [Sat, 7 Dec 2019 00:41:39 +0000 (01:41 +0100)]
contrib/ Enhance and rename script

Add more GNU indent options for better results, and add the ".sh" suffix
to bring this script in line with the others in the contrib/ folder.

3 years agoUpdate install documentation: libgnutls-dev
Windree [Sun, 1 Dec 2019 23:45:09 +0000 (02:45 +0300)]
Update install documentation: libgnutls-dev

in Ubuntu and Debian libgnutls-dev package name is libgnutls28-dev

Closes #264.

Thanks Windree!

3 years agoAdd simple log colorization script: ./contrib/
Alexander Barton [Sun, 10 Nov 2019 21:07:26 +0000 (22:07 +0100)]
Add simple log colorization script: ./contrib/

This script parses the log output of ngircd(8), and colorizes the
messages accoring to their log level. Example usage:

ngircd -f $PWD/doc/sample-ngircd.conf -np | ./contrib/

3 years agoLog received signals (using strsignal(3), when available)
Alexander Barton [Sun, 10 Nov 2019 20:12:39 +0000 (21:12 +0100)]
Log received signals (using strsignal(3), when available)

3 years agoMake test suite compatible with Haiku
Alexander Barton [Sun, 3 Nov 2019 14:15:59 +0000 (15:15 +0100)]
Make test suite compatible with Haiku