]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/conn.c
Fixed a memory leak when resizing the connection pool and realloc() failed.
[ngircd-alex.git] / src / ngircd / conn.c
index cea5c4bed55924888aa996f06a446ec1c7308e4d..aad61494a0a62e70d2fa8679006af15735a1afee 100644 (file)
 
 #include "portab.h"
 
-static char UNUSED id[] = "$Id: conn.c,v 1.132 2004/02/28 02:01:01 alex Exp $";
+static char UNUSED id[] = "$Id: conn.c,v 1.142 2005/01/17 11:57:39 alex Exp $";
 
 #include "imp.h"
 #include <assert.h>
-#include <stdarg.h>
+#ifdef PROTOTYPES
+#      include <stdarg.h>
+#else
+#      include <varargs.h>
+#endif
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
@@ -117,7 +121,7 @@ Conn_Init( VOID )
                /* konfiguriertes Limit beachten */
                if( Pool_Size > Conf_MaxConnections ) Pool_Size = Conf_MaxConnections;
        }
-       My_Connections = malloc( sizeof( CONNECTION ) * Pool_Size );
+       My_Connections = (CONNECTION *)malloc( sizeof( CONNECTION ) * Pool_Size );
        if( ! My_Connections )
        {
                /* Speicher konnte nicht alloziert werden! */
@@ -622,16 +626,20 @@ Conn_Close( CONN_ID Idx, CHAR *LogMsg, CHAR *FwdMsg, BOOLEAN InformClient )
 #endif
 
        assert( Idx > NONE );
-       assert( My_Connections[Idx].sock > NONE );
 
        /* Is this link already shutting down? */
        if( My_Connections[Idx].options & CONN_ISCLOSING )
        {
                /* Conn_Close() has been called recursively for this link;
                 * probabe reason: Try_Write() failed  -- see below. */
+#ifdef DEBUG
+               Log( LOG_DEBUG, "Recursive request to close connection: %d", Idx );
+#endif
                return;
        }
 
+       assert( My_Connections[Idx].sock > NONE );
+
        /* Mark link as "closing" */
        My_Connections[Idx].options |= CONN_ISCLOSING;
                
@@ -722,6 +730,10 @@ Conn_Close( CONN_ID Idx, CHAR *LogMsg, CHAR *FwdMsg, BOOLEAN InformClient )
 
        /* Clean up connection structure (=free it) */
        Init_Conn_Struct( Idx );
+
+#ifdef DEBUG
+       Log( LOG_DEBUG, "Shutdown of connection %d completed.", Idx );
+#endif
 } /* Conn_Close */
 
 
@@ -963,9 +975,9 @@ New_Connection( INT Sock )
        cnt = Count_Connections( new_addr );
        if(( Conf_MaxConnectionsIP > 0 ) && ( cnt >= Conf_MaxConnectionsIP ))
        {
-               /* Access denied, too many connections from this IP! */
-               Log( LOG_ERR, "Refused connection from %s: too may connections (%ld) from this IP!", inet_ntoa( new_addr.sin_addr ), cnt);
-               Simple_Message( new_sock, "ERROR :Connection refused, too many connections from your IP!" );
+               /* Access denied, too many connections from this IP address! */
+               Log( LOG_ERR, "Refused connection from %s: too may connections (%ld) from this IP address!", inet_ntoa( new_addr.sin_addr ), cnt);
+               Simple_Message( new_sock, "ERROR :Connection refused, too many connections from your IP address!" );
                close( new_sock );
                return;
        }
@@ -1000,36 +1012,21 @@ New_Connection( INT Sock )
                        return;
                }
 
-               /* zunaechst realloc() versuchen; wenn das scheitert, malloc() versuchen
-                * und Daten ggf. "haendisch" umkopieren. (Haesslich! Eine wirklich
-                * dynamische Verwaltung waere wohl _deutlich_ besser ...) */
-               ptr = realloc( My_Connections, sizeof( CONNECTION ) * new_size );
+               ptr = (POINTER *)realloc( My_Connections, sizeof( CONNECTION ) * new_size );
                if( ! ptr )
                {
-                       /* realloc() ist fehlgeschlagen. Nun malloc() probieren: */
-                       ptr = malloc( sizeof( CONNECTION ) * new_size );
-                       if( ! ptr )
-                       {
-                               /* Offenbar steht kein weiterer Sepeicher zur Verfuegung :-( */
-                               Log( LOG_EMERG, "Can't allocate memory! [New_Connection]" );
-                               Simple_Message( new_sock, "ERROR: Internal error" );
-                               close( new_sock );
-                               return;
-                       }
-
-                       /* Struktur umkopieren ... */
-                       memcpy( ptr, My_Connections, sizeof( CONNECTION ) * Pool_Size );
-
-#ifdef DEBUG
-                       Log( LOG_DEBUG, "Allocated new connection pool for %ld items (%ld bytes). [malloc()/memcpy()]", new_size, sizeof( CONNECTION ) * new_size );
-#endif
+                       Log( LOG_EMERG, "Can't allocate memory! [New_Connection]" );
+                       Simple_Message( new_sock, "ERROR: Internal error" );
+                       close( new_sock );
+                       return;
                }
+
 #ifdef DEBUG
-               else Log( LOG_DEBUG, "Allocated new connection pool for %ld items (%ld bytes). [realloc()]", new_size, sizeof( CONNECTION ) * new_size );
+               Log( LOG_DEBUG, "Allocated new connection pool for %ld items (%ld bytes). [realloc()]", new_size, sizeof( CONNECTION ) * new_size );
 #endif
 
                /* Adjust pointer to new block */
-               My_Connections = ptr;
+               My_Connections = (CONNECTION *)ptr;
 
                /* Initialize new items */
                for( idx = Pool_Size; idx < new_size; idx++ ) Init_Conn_Struct( idx );
@@ -1132,8 +1129,8 @@ Read_Request( CONN_ID Idx )
 #endif
        {
                /* Der Lesepuffer ist voll */
-               Log( LOG_ERR, "Read buffer overflow (connection %d): %d bytes!", Idx, My_Connections[Idx].rdatalen );
-               Conn_Close( Idx, "Read buffer overflow!", NULL, FALSE );
+               Log( LOG_ERR, "Receive buffer overflow (connection %d): %d bytes!", Idx, My_Connections[Idx].rdatalen );
+               Conn_Close( Idx, "Receive buffer overflow!", NULL, FALSE );
                return;
        }
 
@@ -1271,22 +1268,20 @@ Handle_Buffer( CONN_ID Idx )
                                /* Mit dem letzten Befehl wurde Socket-Kompression aktiviert.
                                 * Evtl. schon vom Socket gelesene Daten in den Unzip-Puffer
                                 * umkopieren, damit diese nun zunaechst entkomprimiert werden */
+                               if( My_Connections[Idx].rdatalen > ZREADBUFFER_LEN )
                                {
-                                       if( My_Connections[Idx].rdatalen > ZREADBUFFER_LEN )
-                                       {
-                                               /* Hupsa! Soviel Platz haben wir aber gar nicht! */
-                                               Log( LOG_ALERT, "Can't move read buffer: No space left in unzip buffer (need %d bytes)!", My_Connections[Idx].rdatalen );
-                                               return FALSE;
-                                       }
-                                       memcpy( My_Connections[Idx].zip.rbuf, My_Connections[Idx].rbuf, My_Connections[Idx].rdatalen );
-                                       My_Connections[Idx].zip.rdatalen = My_Connections[Idx].rdatalen;
-                                       My_Connections[Idx].rdatalen = 0;
-#ifdef DEBUG
-                                       Log( LOG_DEBUG, "Moved already received data (%d bytes) to uncompression buffer.", My_Connections[Idx].zip.rdatalen );
-#endif
+                                       /* Hupsa! Soviel Platz haben wir aber gar nicht! */
+                                       Log( LOG_ALERT, "Can't move receive buffer: No space left in unzip buffer (need %d bytes)!", My_Connections[Idx].rdatalen );
+                                       return FALSE;
                                }
+                               memcpy( My_Connections[Idx].zip.rbuf, My_Connections[Idx].rbuf, My_Connections[Idx].rdatalen );
+                               My_Connections[Idx].zip.rdatalen = My_Connections[Idx].rdatalen;
+                               My_Connections[Idx].rdatalen = 0;
+#ifdef DEBUG
+                               Log( LOG_DEBUG, "Moved already received data (%d bytes) to uncompression buffer.", My_Connections[Idx].zip.rdatalen );
+#endif /* DEBUG */
                        }
-#endif
+#endif /* ZLIB */
                }
 
                if( action ) result = TRUE;
@@ -1599,35 +1594,28 @@ Init_Socket( INT Sock )
 LOCAL VOID
 Read_Resolver_Result( INT r_fd )
 {
-       /* Ergebnis von Resolver Sub-Prozess aus Pipe lesen
-        * und entsprechende Connection aktualisieren */
+       /* Read result of resolver sub-process from pipe and update the
+        * apropriate connection/client structure(s): hostname and/or
+        * IDENT user name.*/
 
-       CHAR result[HOST_LEN];
        CLIENT *c;
        INT len, i, n;
-
-       FD_CLR( r_fd, &Resolver_FDs );
-
-       /* Read result from pipe */
-       len = read( r_fd, result, HOST_LEN - 1 );
-       if( len < 0 )
-       {
-               /* Error! */
-               close( r_fd );
-               Log( LOG_CRIT, "Resolver: Can't read result: %s!", strerror( errno ));
-               return;
-       }
-       result[len] = '\0';
+       RES_STAT *s;
+       CHAR *ptr;
 
        /* Search associated connection ... */
        for( i = 0; i < Pool_Size; i++ )
        {
-               if(( My_Connections[i].sock != NONE ) && ( My_Connections[i].res_stat ) && ( My_Connections[i].res_stat->pipe[0] == r_fd )) break;
+               if(( My_Connections[i].sock != NONE )
+                 && ( My_Connections[i].res_stat != NULL )
+                 && ( My_Connections[i].res_stat->pipe[0] == r_fd ))
+                       break;
        }
        if( i >= Pool_Size )
        {
                /* Ops, none found? Probably the connection has already
-                * been closed. */
+                * been closed!? We'll ignore that ... */
+               FD_CLR( r_fd, &Resolver_FDs );
                close( r_fd );
 #ifdef DEBUG
                Log( LOG_DEBUG, "Resolver: Got result for unknown connection!?" );
@@ -1635,61 +1623,102 @@ Read_Resolver_Result( INT r_fd )
                return;
        }
 
-#ifdef DEBUG
-       Log( LOG_DEBUG, "Resolver: %s is \"%s\".", My_Connections[i].host, result );
+       /* Get resolver structure */
+       s = My_Connections[i].res_stat;
+       assert( s != NULL );
+
+       /* Read result from pipe */
+       len = read( r_fd, s->buffer + s->bufpos, sizeof( s->buffer ) - s->bufpos - 1 );
+       if( len < 0 )
+       {
+               /* Error! */
+               close( r_fd );
+               Log( LOG_CRIT, "Resolver: Can't read result: %s!", strerror( errno ));
+               return;
+       }
+       s->bufpos += len;
+       s->buffer[s->bufpos] = '\0';
+
+       /* If the result string is incomplete, return to main loop and
+        * wait until we can read in more bytes. */
+#ifdef IDENTAUTH
+try_resolve:
 #endif
+       ptr = strchr( s->buffer, '\n' );
+       if( ! ptr ) return;
+       *ptr = '\0';
 
-       /* Clean up ... */
-       close( My_Connections[i].res_stat->pipe[0] );
-       close( My_Connections[i].res_stat->pipe[1] );
-       free( My_Connections[i].res_stat );
-       My_Connections[i].res_stat = NULL;
+#ifdef DEBUG
+       Log( LOG_DEBUG, "Got result from resolver: \"%s\" (%d bytes), stage %d.", s->buffer, len, s->stage );
+#endif
 
+       /* Okay, we got a complete result: this is a host name for outgoing
+        * connections and a host name or IDENT user name (if enabled) for
+        * incoming conneciions.*/
        if( My_Connections[i].sock > NONE )
        {
                /* Incoming connection */
-#ifdef IDENTAUTH
-               CHAR *ident;
-#endif
 
                /* Search client ... */
                c = Client_GetFromConn( i );
                assert( c != NULL );
 
                /* Only update client information of unregistered clients */
-               if( Client_Type( c ) != CLIENT_UNKNOWN )
+               if( Client_Type( c ) == CLIENT_UNKNOWN )
                {
-#ifdef DEBUG
-                       Log( LOG_DEBUG, "Resolver: discarding result for already registered connection %d.", i );
-#endif
-                       return;
-               }               
-
-               /* Set hostname */
-               strlcpy( My_Connections[i].host, result, sizeof( My_Connections[i].host ));
-               Client_SetHostname( c, result );
+                       if( s->stage == 0 )
+                       {
+                               /* host name */
+                               strlcpy( My_Connections[i].host, s->buffer, sizeof( My_Connections[i].host ));
+                               Client_SetHostname( c, s->buffer );
 
 #ifdef IDENTAUTH
-               ident = strchr( result, 0 );
-               ident++;
-
-               /* Do we have a result of the IDENT lookup? If so, set it as the user name */
-               if( *ident )
-               {
-                       Log( LOG_INFO, "IDENT lookup for connection %ld: \"%s\".", i, ident );
-                       Client_SetUser( c, ident, TRUE );
+                               /* clean up buffer for IDENT result */
+                               len = strlen( s->buffer ) + 1;
+                               memmove( s->buffer, s->buffer + len, sizeof( s->buffer ) - len );
+                               s->bufpos -= len;
+
+                               /* Don't close pipe and clean up, but
+                                * instead wait for IDENT result */
+                               s->stage = 1;
+                               goto try_resolve;
+                       }
+                       else if( s->stage == 1 )
+                       {
+                               /* IDENT user name */
+                               if( s->buffer[0] )
+                               {
+                                       Log( LOG_INFO, "IDENT lookup for connection %ld: \"%s\".", i, s->buffer );
+                                       Client_SetUser( c, s->buffer, TRUE );
+                               }
+                               else Log( LOG_INFO, "IDENT lookup for connection %ld: no result.", i );
+#endif
+                       }
+                       else Log( LOG_ERR, "Resolver: got result for unknown stage %d!?", s->stage );
                }
-               else Log( LOG_INFO, "IDENT lookup for connection %ld: no result.", i );
+#ifdef DEBUG
+               else Log( LOG_DEBUG, "Resolver: discarding result for already registered connection %d.", i );
 #endif
        }
        else
        {
-               /* Outgoing connection (server link!): set IP address */
+               /* Outgoing connection (server link): set the IP address
+                * so that we can connect to it in the main loop. */
+
+               /* Search server ... */
                n = Conf_GetServer( i );
                assert( n > NONE );
-               strlcpy( Conf_Server[n].ip, result, sizeof( Conf_Server[n].ip ));
+
+               strlcpy( Conf_Server[n].ip, s->buffer, sizeof( Conf_Server[n].ip ));
        }
 
+       /* Clean up ... */
+       FD_CLR( r_fd, &Resolver_FDs );
+       close( My_Connections[i].res_stat->pipe[0] );
+       close( My_Connections[i].res_stat->pipe[1] );
+       free( My_Connections[i].res_stat );
+       My_Connections[i].res_stat = NULL;
+
        /* Reset penalty time */
        Conn_ResetPenalty( i );
 } /* Read_Resolver_Result */