]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/conn.c
Fixed format string bug in "connection statistics" message; code cleanups.
[ngircd-alex.git] / src / ngircd / conn.c
index ed89c85df14d3ba80e975233a354389dbe20824e..714ebe6f34e611c45e36596c8e7b0278d6380cad 100644 (file)
@@ -17,7 +17,7 @@
 #include "portab.h"
 #include "io.h"
 
-static char UNUSED id[] = "$Id: conn.c,v 1.163 2005/07/12 20:44:46 fw Exp $";
+static char UNUSED id[] = "$Id: conn.c,v 1.170 2005/08/15 23:02:40 alex Exp $";
 
 #include "imp.h"
 #include <assert.h>
@@ -82,19 +82,19 @@ static char UNUSED id[] = "$Id: conn.c,v 1.163 2005/07/12 20:44:46 fw Exp $";
 #define SERVER_WAIT (NONE - 1)
 
 
-LOCAL bool Handle_Write PARAMS(( CONN_ID Idx ));
-LOCAL void New_Connection PARAMS(( int Sock ));
-LOCAL CONN_ID Socket2Index PARAMS(( int Sock ));
-LOCAL void Read_Request PARAMS(( CONN_ID Idx ));
-LOCAL bool Handle_Buffer PARAMS(( CONN_ID Idx ));
-LOCAL void Check_Connections PARAMS(( void ));
-LOCAL void Check_Servers PARAMS(( void ));
-LOCAL void Init_Conn_Struct PARAMS(( CONN_ID Idx ));
-LOCAL bool Init_Socket PARAMS(( int Sock ));
-LOCAL void New_Server PARAMS(( int Server, CONN_ID Idx ));
-LOCAL void Simple_Message PARAMS(( int Sock, char *Msg ));
-LOCAL int Count_Connections PARAMS(( struct sockaddr_in addr ));
-LOCAL int NewListener PARAMS(( const UINT16 Port ));
+static bool Handle_Write PARAMS(( CONN_ID Idx ));
+static int New_Connection PARAMS(( int Sock ));
+static CONN_ID Socket2Index PARAMS(( int Sock ));
+static void Read_Request PARAMS(( CONN_ID Idx ));
+static bool Handle_Buffer PARAMS(( CONN_ID Idx ));
+static void Check_Connections PARAMS(( void ));
+static void Check_Servers PARAMS(( void ));
+static void Init_Conn_Struct PARAMS(( CONN_ID Idx ));
+static bool Init_Socket PARAMS(( int Sock ));
+static void New_Server PARAMS(( int Server, CONN_ID Idx ));
+static void Simple_Message PARAMS(( int Sock, char *Msg ));
+static int Count_Connections PARAMS(( struct sockaddr_in addr ));
+static int NewListener PARAMS(( const UINT16 Port ));
 
 static array My_Listeners;
 
@@ -103,6 +103,7 @@ int allow_severity = LOG_INFO;
 int deny_severity = LOG_ERR;
 #endif
 
+static void server_login PARAMS((CONN_ID idx));
 
 static void cb_clientserver PARAMS((int sock, short what));
 
@@ -115,7 +116,7 @@ cb_listen(int sock, short irrelevant)
 
 
 static void
-cb_connserver(int sock, short what)
+cb_connserver(int sock, UNUSED short what)
 {
        int res, err;
        socklen_t sock_len;
@@ -158,7 +159,13 @@ cb_connserver(int sock, short what)
        }
 
        Conn_OPTION_DEL( &My_Connections[idx], CONN_ISCONNECTING );
+       server_login(idx);
+}
+
 
+static void
+server_login(CONN_ID idx)
+{
        Log( LOG_INFO, "Connection %d with \"%s:%d\" established. Now logging in ...", idx,
                        My_Connections[idx].host, Conf_Server[Conf_GetServer( idx )].port );
 
@@ -191,7 +198,7 @@ cb_clientserver(int sock, short what)
 }
 
 
-LOCAL void
+static void
 FreeRes_stat( CONNECTION *c )
 {
        assert( c != NULL );
@@ -201,6 +208,7 @@ FreeRes_stat( CONNECTION *c )
 
        io_close( c->res_stat->pipe[0] );
 
+       array_free(&c->res_stat->buffer);
        free( c->res_stat );
        c->res_stat = NULL;
 }
@@ -274,34 +282,50 @@ Conn_Exit( void )
 } /* Conn_Exit */
 
 
+static unsigned int
+ports_initlisteners(array *a, void (*func)(int,short))
+{
+       unsigned int created = 0, len;
+       int fd;
+       UINT16 *port;
+
+       len = array_length(a, sizeof (UINT16));
+       port = array_start(a);
+       while(len--) {
+               fd = NewListener( *port );
+               if (fd < 0) {
+                       port++;
+                       continue;
+               }
+               if (!io_event_create( fd, IO_WANTREAD, func )) {
+                       Log( LOG_ERR, "io_event_create(): Could not add listening fd %d (port %u): %s!",
+                                                       fd, (unsigned int) *port, strerror(errno));
+                       close(fd);
+                       port++;
+                       continue;
+               }
+               created++;
+               port++;
+       }
+
+       return created;
+}
+
+
 GLOBAL int
 Conn_InitListeners( void )
 {
        /* Initialize ports on which the server should accept connections */
 
-       int created, fd;
-       unsigned int i;
+       unsigned int created;
 
        if (!io_library_init(CONNECTION_POOL)) {
                Log(LOG_EMERG, "Cannot initialize IO routines: %s", strerror(errno));
                return -1;
        }
 
-       created = 0;
-       for( i = 0; i < Conf_ListenPorts_Count; i++ ) {
-               fd = NewListener( Conf_ListenPorts[i] );
-               if (fd < 0) {
-                       Log( LOG_ERR, "Can't listen on port %u!", (unsigned int) Conf_ListenPorts[i] );
-                       continue;
-               }
-               if (!io_event_create( fd, IO_WANTREAD, cb_listen )) {
-                       Log( LOG_ERR, "io_event_create(): Could not add listening fd %d (port %u): %s!",
-                                               fd, (unsigned int) Conf_ListenPorts[i], strerror(errno));
-                       close(fd);
-                       continue;
-               }
-               created++;
-       }
+       created = ports_initlisteners(&Conf_ListenPorts, cb_listen);
+
        return created;
 } /* Conn_InitListeners */
 
@@ -334,7 +358,7 @@ Conn_ExitListeners( void )
 
 
 /* return new listening port file descriptor or -1 on failure */
-LOCAL int
+static int
 NewListener( const UINT16 Port )
 {
        /* Create new listening socket on specified port */
@@ -712,19 +736,23 @@ Conn_Close( CONN_ID Idx, char *LogMsg, char *FwdMsg, bool InformClient )
        c = Client_GetFromConn( Idx );
 
        /* Should the client be informed? */
-       if( InformClient )
-       {
+       if (InformClient) {
 #ifndef STRICT_RFC
                /* Send statistics to client if registered as user: */
-               if(( c != NULL ) && ( Client_Type( c ) == CLIENT_USER ))
-               {
-                       Conn_WriteStr( Idx, "NOTICE %s :%sConnection statistics: client %.1f kb, server %.1f kb.", Client_ThisServer( ), NOTICE_TXTPREFIX, (double)My_Connections[Idx].bytes_in / 1024,  (double)My_Connections[Idx].bytes_out / 1024 );
+               if ((c != NULL) && (Client_Type(c) == CLIENT_USER)) {
+                       Conn_WriteStr( Idx,
+                        "NOTICE %s :%sConnection statistics: client %.1f kb, server %.1f kb.",
+                        Client_ID(Client_ThisServer()), NOTICE_TXTPREFIX,
+                        (double)My_Connections[Idx].bytes_in / 1024,
+                        (double)My_Connections[Idx].bytes_out / 1024);
                }
 #endif
 
                /* Send ERROR to client (see RFC!) */
-               if( FwdMsg ) Conn_WriteStr( Idx, "ERROR :%s", FwdMsg );
-               else Conn_WriteStr( Idx, "ERROR :Closing connection." );
+               if (FwdMsg)
+                       Conn_WriteStr(Idx, "ERROR :%s", FwdMsg);
+               else
+                       Conn_WriteStr(Idx, "ERROR :Closing connection.");
        }
 
        /* Try to write out the write buffer */
@@ -819,7 +847,7 @@ Conn_SyncServerStruct( void )
 } /* SyncServerStruct */
 
 
-LOCAL bool
+static bool
 Handle_Write( CONN_ID Idx )
 {
        /* Daten aus Schreibpuffer versenden bzw. Connection aufbauen */
@@ -835,7 +863,6 @@ Handle_Write( CONN_ID Idx )
        }
        assert( My_Connections[Idx].sock > NONE );
 
-
        wdatalen = array_bytes(&My_Connections[Idx].wbuf );
 #ifdef ZLIB
        if(( wdatalen == 0 ) && ( ! array_bytes(&My_Connections[Idx].zip.wbuf))) {
@@ -871,7 +898,7 @@ Handle_Write( CONN_ID Idx )
 } /* Handle_Write */
 
 
-LOCAL void
+static int
 New_Connection( int Sock )
 {
        /* Neue Client-Verbindung von Listen-Socket annehmen und
@@ -895,7 +922,7 @@ New_Connection( int Sock )
        if( new_sock < 0 )
        {
                Log( LOG_CRIT, "Can't accept connection: %s!", strerror( errno ));
-               return;
+               return -1;
        }
 
 #ifdef TCPWRAP
@@ -908,7 +935,7 @@ New_Connection( int Sock )
                Log( deny_severity, "Refused connection from %s (by TCP Wrappers)!", inet_ntoa( new_addr.sin_addr ));
                Simple_Message( new_sock, "ERROR :Connection refused" );
                close( new_sock );
-               return;
+               return -1;
        }
 #endif
 
@@ -923,7 +950,7 @@ New_Connection( int Sock )
                Log( LOG_ERR, "Refused connection from %s: too may connections (%ld) from this IP address!", inet_ntoa( new_addr.sin_addr ), cnt);
                Simple_Message( new_sock, "ERROR :Connection refused, too many connections from your IP address!" );
                close( new_sock );
-               return;
+               return -1;
        }
 
        /* Freie Connection-Struktur suchen */
@@ -944,7 +971,7 @@ New_Connection( int Sock )
                                Log( LOG_ALERT, "Can't accept connection: limit (%d) reached!", Pool_Size );
                                Simple_Message( new_sock, "ERROR :Connection limit reached" );
                                close( new_sock );
-                               return;
+                               return -1;
                        }
                        if( new_size > Conf_MaxConnections ) new_size = Conf_MaxConnections;
                }
@@ -953,7 +980,7 @@ New_Connection( int Sock )
                        Log( LOG_ALERT, "Can't accept connection: limit (%d) reached -- overflow!", Pool_Size );
                        Simple_Message( new_sock, "ERROR :Connection limit reached" );
                        close( new_sock );
-                       return;
+                       return -1;
                }
 
                ptr = (POINTER *)realloc( My_Connections, sizeof( CONNECTION ) * new_size );
@@ -961,7 +988,7 @@ New_Connection( int Sock )
                        Log( LOG_EMERG, "Can't allocate memory! [New_Connection]" );
                        Simple_Message( new_sock, "ERROR: Internal error" );
                        close( new_sock );
-                       return;
+                       return -1;
                }
 
 #ifdef DEBUG
@@ -985,7 +1012,7 @@ New_Connection( int Sock )
                Log( LOG_ALERT, "Can't accept connection: can't create client structure!" );
                Simple_Message( new_sock, "ERROR :Internal error" );
                close( new_sock );
-               return;
+               return -1;
        }
 
        /* Verbindung registrieren */
@@ -997,7 +1024,7 @@ New_Connection( int Sock )
        if (!io_event_create( new_sock, IO_WANTREAD, cb_clientserver)) {
                Simple_Message( new_sock, "ERROR :Internal error" );
                Conn_Close( idx, "io_event_create() failed", NULL, false );
-               return;
+               return -1;
        }
 
        Log( LOG_INFO, "Accepted connection %d from %s:%d on socket %d.", idx, inet_ntoa( new_addr.sin_addr ), ntohs( new_addr.sin_port), Sock );
@@ -1015,10 +1042,11 @@ New_Connection( int Sock )
 
        /* Penalty-Zeit setzen */
        Conn_SetPenalty( idx, 4 );
+       return new_sock;
 } /* New_Connection */
 
 
-LOCAL CONN_ID
+static CONN_ID
 Socket2Index( int Sock )
 {
        /* zum Socket passende Connection suchen */
@@ -1042,32 +1070,19 @@ Socket2Index( int Sock )
 } /* Socket2Index */
 
 
-LOCAL void
+static void
 Read_Request( CONN_ID Idx )
 {
        /* Daten von Socket einlesen und entsprechend behandeln.
         * Tritt ein Fehler auf, so wird der Socket geschlossen. */
 
-       unsigned int bsize;
        int len;
        char readbuf[1024];
-#ifdef ZLIB
-       CLIENT *c;
-#endif
 
        assert( Idx > NONE );
        assert( My_Connections[Idx].sock > NONE );
 
-       /* wenn noch nicht registriert: maximal mit ZREADBUFFER_LEN arbeiten,
-        * ansonsten koennen Daten ggf. nicht umkopiert werden. */
-       bsize = READBUFFER_LEN;
 #ifdef ZLIB
-       c = Client_GetFromConn( Idx );
-
-       if(( Client_Type( c ) != CLIENT_USER ) && ( Client_Type( c ) != CLIENT_SERVER ) &&
-                       ( Client_Type( c ) != CLIENT_SERVICE ) && ( bsize > ZREADBUFFER_LEN ))
-               bsize = ZREADBUFFER_LEN;
-
        if (( array_bytes(&My_Connections[Idx].rbuf) >= READBUFFER_LEN ) ||
                ( array_bytes(&My_Connections[Idx].zip.rbuf) >= ZREADBUFFER_LEN ))
 #else
@@ -1124,7 +1139,7 @@ Read_Request( CONN_ID Idx )
 } /* Read_Request */
 
 
-LOCAL bool
+static bool
 Handle_Buffer( CONN_ID Idx )
 {
        /* Handle Data in Connections Read-Buffer.
@@ -1134,7 +1149,6 @@ Handle_Buffer( CONN_ID Idx )
 #endif
        char *ptr;
        int len, delta;
-       unsigned int arraylen;
        bool action, result;
 #ifdef ZLIB
        bool old_z;
@@ -1150,16 +1164,12 @@ Handle_Buffer( CONN_ID Idx )
                        if( ! Unzip_Buffer( Idx )) return false;
 #endif
 
-               arraylen = array_bytes(&My_Connections[Idx].rbuf);
-               if (arraylen == 0)
+               if (0 == array_bytes(&My_Connections[Idx].rbuf))
                        break;
 
-               if (!array_cat0(&My_Connections[Idx].rbuf)) /* make sure buf is NULL terminated */
+               if (!array_cat0_temporary(&My_Connections[Idx].rbuf)) /* make sure buf is NULL terminated */
                        return false;
 
-               array_truncate(&My_Connections[Idx].rbuf, 1, arraylen); /* do not count trailing NULL */
-
-
                /* A Complete Request end with CR+LF, see RFC 2812. */
                ptr = strstr( array_start(&My_Connections[Idx].rbuf), "\r\n" );
 
@@ -1240,7 +1250,7 @@ Handle_Buffer( CONN_ID Idx )
 } /* Handle_Buffer */
 
 
-LOCAL void
+static void
 Check_Connections( void )
 {
        /* check if connections are alive. if not, play PING-PONG first.
@@ -1290,7 +1300,7 @@ Check_Connections( void )
 } /* Check_Connections */
 
 
-LOCAL void
+static void
 Check_Servers( void )
 {
        /* Check if we can establish further server links */
@@ -1358,7 +1368,7 @@ Check_Servers( void )
 } /* Check_Servers */
 
 
-LOCAL void
+static void
 New_Server( int Server, CONN_ID Idx )
 {
        /* Establish new server link */
@@ -1450,7 +1460,7 @@ out:
 } /* New_Server */
 
 
-LOCAL void
+static void
 Init_Conn_Struct( CONN_ID Idx )
 {
        time_t now = time( NULL );
@@ -1463,7 +1473,7 @@ Init_Conn_Struct( CONN_ID Idx )
 } /* Init_Conn_Struct */
 
 
-LOCAL bool
+static bool
 Init_Socket( int Sock )
 {
        /* Initialize socket (set options) */
@@ -1509,11 +1519,14 @@ void Read_Resolver_Result( int r_fd )
         * IDENT user name.*/
 
        CLIENT *c;
-       int len, i, n;
+       int bytes_read, i, n;
+       unsigned int len;
        RES_STAT *s;
        char *ptr;
+       char *bufptr;
+       char readbuf[HOST_LEN];
 
-       Log( LOG_DEBUG, "Resolver: started, fd %d\n", r_fd );
+       Log( LOG_DEBUG, "Resolver: started, fd %d", r_fd );
        /* Search associated connection ... */
        for( i = 0; i < Pool_Size; i++ )
        {
@@ -1538,28 +1551,40 @@ void Read_Resolver_Result( int r_fd )
        assert( s != NULL );
 
        /* Read result from pipe */
-       len = read( r_fd, s->buffer + s->bufpos, sizeof( s->buffer ) - s->bufpos - 1 );
-       if( len < 0 )
-       {
+       bytes_read = read( r_fd, readbuf, sizeof readbuf -1 );
+       if( bytes_read < 0 ) {
                /* Error! */
                Log( LOG_CRIT, "Resolver: Can't read result: %s!", strerror( errno ));
                FreeRes_stat( &My_Connections[i] );
                return;
        }
-       s->bufpos += len;
-       s->buffer[s->bufpos] = '\0';
+       len = (unsigned int) bytes_read;
+       readbuf[len] = '\0';
+       if (!array_catb(&s->buffer, readbuf, len)) {
+               Log( LOG_CRIT, "Resolver: Can't append result %s to buffer: %s", readbuf, strerror( errno ));
+               FreeRes_stat(&My_Connections[i]);
+               return;
+       }
+
+       if (!array_cat0_temporary(&s->buffer)) {
+               Log( LOG_CRIT, "Resolver: Can't append result %s to buffer: %s", readbuf, strerror( errno ));
+               FreeRes_stat(&My_Connections[i]);
+               return;
+       }
 
        /* If the result string is incomplete, return to main loop and
         * wait until we can read in more bytes. */
 #ifdef IDENTAUTH
 try_resolve:
 #endif
-       ptr = strchr( s->buffer, '\n' );
+       bufptr = (char*) array_start(&s->buffer);
+       assert(bufptr != NULL);
+       ptr = strchr( bufptr, '\n' );
        if( ! ptr ) return;
        *ptr = '\0';
 
 #ifdef DEBUG
-       Log( LOG_DEBUG, "Got result from resolver: \"%s\" (%d bytes), stage %d.", s->buffer, len, s->stage );
+       Log( LOG_DEBUG, "Got result from resolver: \"%s\" (%u bytes read), stage %d.", bufptr, len, s->stage);
 #endif
 
        /* Okay, we got a complete result: this is a host name for outgoing
@@ -1576,15 +1601,14 @@ try_resolve:
                {
                        switch(s->stage) {
                                case 0: /* host name */
-                               strlcpy( My_Connections[i].host, s->buffer, sizeof( My_Connections[i].host ));
-                               Client_SetHostname( c, s->buffer );
+                               strlcpy( My_Connections[i].host, bufptr, sizeof( My_Connections[i].host));
+
+                               Client_SetHostname( c, bufptr);
 #ifdef IDENTAUTH
                                /* clean up buffer for IDENT result */
-                               len = strlen( s->buffer ) + 1;
-                               assert((size_t) len <= sizeof( s->buffer ));
-                               memmove( s->buffer, s->buffer + len, sizeof( s->buffer ) - len );
-                               assert(len <= s->bufpos );
-                               s->bufpos -= len;
+                               len = strlen(bufptr) + 1;
+                               assert(len <= array_bytes(&s->buffer));
+                               array_moveleft(&s->buffer, 1, len);
 
                                /* Don't close pipe and clean up, but
                                 * instead wait for IDENT result */
@@ -1592,10 +1616,10 @@ try_resolve:
                                goto try_resolve;
 
                                case 1: /* IDENT user name */
-                               if( s->buffer[0] )
-                               {
-                                       Log( LOG_INFO, "IDENT lookup for connection %ld: \"%s\".", i, s->buffer );
-                                       Client_SetUser( c, s->buffer, true );
+                               if (array_bytes(&s->buffer)) {
+                                       bufptr = (char*) array_start(&s->buffer);
+                                       Log( LOG_INFO, "IDENT lookup for connection %ld: \"%s\".", i, bufptr);
+                                       Client_SetUser( c, bufptr, true );
                                }
                                else Log( LOG_INFO, "IDENT lookup for connection %ld: no result.", i );
 #endif
@@ -1617,7 +1641,8 @@ try_resolve:
                n = Conf_GetServer( i );
                assert( n > NONE );
 
-               strlcpy( Conf_Server[n].ip, s->buffer, sizeof( Conf_Server[n].ip ));
+               bufptr = (char*) array_start(&s->buffer);
+               strlcpy( Conf_Server[n].ip, bufptr, sizeof( Conf_Server[n].ip ));
        }
 
        /* Clean up ... */
@@ -1628,7 +1653,7 @@ try_resolve:
 } /* Read_Resolver_Result */
 
 
-LOCAL void
+static void
 Simple_Message( int Sock, char *Msg )
 {
        char buf[COMMAND_LEN];
@@ -1644,7 +1669,7 @@ Simple_Message( int Sock, char *Msg )
 } /* Simple_Error */
 
 
-LOCAL int
+static int
 Count_Connections( struct sockaddr_in addr_in )
 {
        int i, cnt;