Log all non-OK status codes to syslog
authorAlexander Barton <alex@barton.de>
Thu, 21 Jan 2010 12:27:42 +0000 (13:27 +0100)
committerAlexander Barton <alex@barton.de>
Thu, 21 Jan 2010 12:27:42 +0000 (13:27 +0100)
Logging to the Apache error log has been removed.

server/web/nagcollect.php

index 38fc338..3f07341 100644 (file)
@@ -51,7 +51,6 @@ function checkKey($key, $host)
                }
        }
        fclose($fh);
-       error_log("NagCollect: received invalid key \"$key\"!");
        return false;
 }
 
@@ -96,12 +95,21 @@ function getHttpStatusText($status)
        }
 }
 
+openlog("NagCollect", LOG_ODELAY, LOG_DAEMON);
+
 $httpStatus = processRequest($_POST);
 $httpStatusText = getHttpStatusText($httpStatus);
 
 $statusText = $httpStatus . ' - ' . $httpStatusText;
 
-header("HTTP/1.0 $httpStatus $ttpStatusText");
+if ($httpStatus != 200) {
+       syslog(LOG_WARNING, "Warning: $httpStatusText ($httpStatus) from "
+                  . "\"{$_SERVER['REMOTE_ADDR']}\" ({$_SERVER['HTTP_USER_AGENT']})");
+}
+
+closelog();
+
+header("HTTP/1.0 $httpStatus $httpStatusText");
 
 ?><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
        "http://www.w3.org/TR/html4/strict.dtd">