/*
* ngIRCd -- The Next Generation IRC Daemon
- * Copyright (c)2001-2013 Alexander Barton (alex@barton.de)
+ * Copyright (c)2001-2018 Alexander Barton (alex@barton.de) and Contributors.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* IRC channel commands
*/
-#include "imp.h"
#include <assert.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
-#include "defines.h"
#include "conn.h"
#include "channel.h"
#include "conn-func.h"
#include "irc-write.h"
#include "conf.h"
-#include "exp.h"
#include "irc-channel.h"
/**
const char *key)
{
bool is_invited, is_banned, is_exception;
- const char *channel_modes;
/* Allow IRC operators to overwrite channel limits */
- if (strchr(Client_Modes(Client), 'o'))
+ if (Client_HasMode(Client, 'o'))
return true;
is_banned = Lists_Check(Channel_GetListBans(chan), Client);
if (is_banned && !is_invited && !is_exception) {
/* Client is banned from channel (and not on invite list) */
- IRC_WriteStrClient(Client, ERR_BANNEDFROMCHAN_MSG,
+ IRC_WriteErrClient(Client, ERR_BANNEDFROMCHAN_MSG,
Client_ID(Client), channame);
return false;
}
- channel_modes = Channel_Modes(chan);
- if (strchr(channel_modes, 'i') && !is_invited) {
+ if (Channel_HasMode(chan, 'i') && !is_invited) {
/* Channel is "invite-only" and client is not on invite list */
- IRC_WriteStrClient(Client, ERR_INVITEONLYCHAN_MSG,
+ IRC_WriteErrClient(Client, ERR_INVITEONLYCHAN_MSG,
Client_ID(Client), channame);
return false;
}
if (!Channel_CheckKey(chan, Client, key ? key : "")) {
/* Channel is protected by a channel key and the client
* didn't specify the correct one */
- IRC_WriteStrClient(Client, ERR_BADCHANNELKEY_MSG,
+ IRC_WriteErrClient(Client, ERR_BADCHANNELKEY_MSG,
Client_ID(Client), channame);
return false;
}
- if (strchr(channel_modes, 'l') &&
+ if (Channel_HasMode(chan, 'l') &&
(Channel_MaxUsers(chan) <= Channel_MemberCount(chan))) {
/* There are more clints joined to this channel than allowed */
- IRC_WriteStrClient(Client, ERR_CHANNELISFULL_MSG,
+ IRC_WriteErrClient(Client, ERR_CHANNELISFULL_MSG,
Client_ID(Client), channame);
return false;
}
- if (strchr(channel_modes, 'z') && !Conn_UsesSSL(Client_Conn(Client))) {
+ if (Channel_HasMode(chan, 'z') && !Conn_UsesSSL(Client_Conn(Client))) {
/* Only "secure" clients are allowed, but clients doesn't
* use SSL encryption */
- IRC_WriteStrClient(Client, ERR_SECURECHANNEL_MSG,
+ IRC_WriteErrClient(Client, ERR_SECURECHANNEL_MSG,
Client_ID(Client), channame);
return false;
}
- if (strchr(channel_modes, 'O') && !Client_OperByMe(Client)) {
+ if (Channel_HasMode(chan, 'O') && !Client_HasMode(Client, 'o')) {
/* Only IRC operators are allowed! */
- IRC_WriteStrClient(Client, ERR_OPONLYCHANNEL_MSG,
+ IRC_WriteErrClient(Client, ERR_OPONLYCHANNEL_MSG,
Client_ID(Client), channame);
return false;
}
- if (strchr(channel_modes, 'R') && !strchr(Client_Modes(Client), 'R')) {
+ if (Channel_HasMode(chan, 'R') && !Client_HasMode(Client, 'R')) {
/* Only registered users are allowed! */
- IRC_WriteStrClient(Client, ERR_REGONLYCHANNEL_MSG,
+ IRC_WriteErrClient(Client, ERR_REGONLYCHANNEL_MSG,
Client_ID(Client), channame);
return false;
}
/* If the channel is persistent (+P) and client is an IRC op:
* make client chanop, if not disabled in configuration. */
- if (strchr(Channel_Modes(chan), 'P') && Conf_OperChanPAutoOp
- && strchr(Client_Modes(target), 'o'))
+ if (Channel_HasMode(chan, 'P') && Conf_OperChanPAutoOp
+ && Client_HasMode(target, 'o'))
Channel_UserModeAdd(chan, target, 'o');
} /* join_set_channelmodes */
* and MODE commands.
*
* @param To Forward JOIN (and MODE) command to this peer server
- * @param Prefix Client used to prefix the genrated commands
+ * @param Prefix Client used to prefix the generated commands
* @param Data Parameters of JOIN command to forward, probably
* containing channel modes separated by ASCII 7.
*/
* This function calls cb_join_forward(), which differentiates between
* protocol implementations (e.g. RFC 2812, RFC 1459).
*
- * @param Client Client used to prefix the genrated commands
+ * @param Client Client used to prefix the generated commands
* @param target Forward JOIN (and MODE) command to this peer server
* @param chan Channel structure
* @param channame Channel name
} /* join_forward */
/**
- * Acknowledge user JOIN request and send "channel info" numerics.
+ * Send channel TOPIC and NAMES list to a newly (N)JOIN'ed client.
*
- * @param Client Client used to prefix the genrated commands
- * @param target Forward commands/numerics to this user
- * @param chan Channel structure
- * @param channame Channel name
+ * @param Client Client used to prefix the generated commands
+ * @param Chan Channel structure
*/
-static bool
-join_send_topic(CLIENT *Client, CLIENT *target, CHANNEL *chan,
- const char *channame)
+GLOBAL bool
+IRC_Send_Channel_Info(CLIENT *Client, CHANNEL *Chan)
{
const char *topic;
- if (Client_Type(Client) != CLIENT_USER)
- return true;
- /* acknowledge join */
- if (!IRC_WriteStrClientPrefix(Client, target, "JOIN :%s", channame))
- return false;
-
- /* Send topic to client, if any */
- topic = Channel_Topic(chan);
+ /* Send the topic (if any) to the new client: */
+ topic = Channel_Topic(Chan);
assert(topic != NULL);
if (*topic) {
if (!IRC_WriteStrClient(Client, RPL_TOPIC_MSG,
- Client_ID(Client), channame, topic))
+ Client_ID(Client), Channel_Name(Chan), topic))
return false;
#ifndef STRICT_RFC
if (!IRC_WriteStrClient(Client, RPL_TOPICSETBY_MSG,
- Client_ID(Client), channame,
- Channel_TopicWho(chan),
- Channel_TopicTime(chan)))
+ Client_ID(Client), Channel_Name(Chan),
+ Channel_TopicWho(Chan),
+ Channel_TopicTime(Chan)))
return false;
#endif
}
- /* send list of channel members to client */
- if (!IRC_Send_NAMES(Client, chan))
+
+ /* Send list of channel members to the new client: */
+ if (!IRC_Send_NAMES(Client, Chan))
return false;
- return IRC_WriteStrClient(Client, RPL_ENDOFNAMES_MSG, Client_ID(Client),
- Channel_Name(chan));
-} /* join_send_topic */
+ return IRC_WriteStrClient(Client, RPL_ENDOFNAMES_MSG,
+ Client_ID(Client), Channel_Name(Chan));
+}
/**
* Handler for the IRC "JOIN" command.
assert (Client != NULL);
assert (Req != NULL);
- _IRC_ARGC_GE_OR_RETURN_(Client, Req, 1)
- _IRC_ARGC_LE_OR_RETURN_(Client, Req, 2)
_IRC_GET_SENDER_OR_RETURN_(target, Req, Client)
/* Is argument "0"? */
channame = strtok_r(channame, ",", &lastchan);
/* Make sure that "channame" is not the empty string ("JOIN :") */
- if (! channame)
- return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+ if (!channame)
+ return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
Client_ID(Client), Req->command);
while (channame) {
}
chan = Channel_Search(channame);
- if (!chan && Conf_PredefChannelsOnly) {
- /* channel must be created, but forbidden by config */
- IRC_WriteStrClient(Client, ERR_NOSUCHCHANNEL_MSG,
- Client_ID(Client), channame);
- goto join_next;
- }
/* Local client? */
if (Client_Type(Client) == CLIENT_USER) {
/* Already existing channel: already member? */
if (Channel_IsMemberOf(chan, Client))
goto join_next;
+ } else {
+ /* Channel must be created */
+ if (!strchr(Conf_AllowedChannelTypes, channame[0])) {
+ /* ... but channel type is not allowed! */
+ IRC_WriteErrClient(Client,
+ ERR_NOSUCHCHANNEL_MSG,
+ Client_ID(Client), channame);
+ goto join_next;
+ }
}
/* Test if the user has reached the channel limit */
if ((Conf_MaxJoins > 0) &&
(Channel_CountForUser(Client) >= Conf_MaxJoins)) {
- if (!IRC_WriteStrClient(Client,
+ if (!IRC_WriteErrClient(Client,
ERR_TOOMANYCHANNELS_MSG,
Client_ID(Client), channame))
return DISCONNECTED;
join_forward(Client, target, chan, channame);
- if (!join_send_topic(Client, target, chan, channame))
- break; /* write error */
+ if (Client_Type(Client) == CLIENT_USER) {
+ /* Acknowledge join ... */
+ if (!IRC_WriteStrClientPrefix(Client, target,
+ "JOIN :%s", channame))
+ break; /* write error */
+ /* ... and greet new user: */
+ if (!IRC_Send_Channel_Info(Client, chan))
+ break; /* write error */
+ }
join_next:
/* next channel? */
assert(Client != NULL);
assert(Req != NULL);
- _IRC_ARGC_GE_OR_RETURN_(Client, Req, 1)
- _IRC_ARGC_LE_OR_RETURN_(Client, Req, 2)
_IRC_GET_SENDER_OR_RETURN_(target, Req, Client)
/* Loop over all the given channel names */
chan = strtok(Req->argv[0], ",");
/* Make sure that "chan" is not the empty string ("PART :") */
- if (! chan)
- return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+ if (!chan)
+ return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
Client_ID(Client), Req->command);
while (chan) {
Channel_Part(target, Client, chan,
- Req->argc > 1 ? Req->argv[1] : Client_ID(target));
+ Req->argc > 1 ? Req->argv[1] : "");
chan = strtok(NULL, ",");
}
assert( Client != NULL );
assert( Req != NULL );
- IRC_SetPenalty(Client, 1);
-
- _IRC_ARGC_GE_OR_RETURN_(Client, Req, 1)
- _IRC_ARGC_LE_OR_RETURN_(Client, Req, 2)
_IRC_GET_SENDER_OR_RETURN_(from, Req, Client)
chan = Channel_Search(Req->argv[0]);
if (!chan)
- return IRC_WriteStrClient(from, ERR_NOSUCHCHANNEL_MSG,
+ return IRC_WriteErrClient(from, ERR_NOSUCHCHANNEL_MSG,
Client_ID(from), Req->argv[0]);
/* Only remote servers and channel members are allowed to change the
topic_power = Client_HasMode(from, 'o');
if (!Channel_IsMemberOf(chan, from)
&& !(Conf_OperCanMode && topic_power))
- return IRC_WriteStrClient(from, ERR_NOTONCHANNEL_MSG,
+ return IRC_WriteErrClient(from, ERR_NOTONCHANNEL_MSG,
Client_ID(from), Req->argv[0]);
} else
topic_power = true;
if (Req->argc == 1) {
- /* Request actual topic */
+ /* Request current topic */
topic = Channel_Topic(chan);
if (*topic) {
r = IRC_WriteStrClient(from, RPL_TOPIC_MSG,
Channel_Name(chan));
}
- if (strchr(Channel_Modes(chan), 't')) {
+ if (Channel_HasMode(chan, 't')) {
/* Topic Lock. Is the user a channel op or IRC operator? */
if(!topic_power &&
- !strchr(Channel_UserModes(chan, from), 'h') &&
- !strchr(Channel_UserModes(chan, from), 'o') &&
- !strchr(Channel_UserModes(chan, from), 'a') &&
- !strchr(Channel_UserModes(chan, from), 'q'))
- return IRC_WriteStrClient(from, ERR_CHANOPRIVSNEEDED_MSG,
+ !Channel_UserHasMode(chan, from, 'h') &&
+ !Channel_UserHasMode(chan, from, 'o') &&
+ !Channel_UserHasMode(chan, from, 'a') &&
+ !Channel_UserHasMode(chan, from, 'q'))
+ return IRC_WriteErrClient(from, ERR_CHANOPRIVSNEEDED_MSG,
Client_ID(from),
Channel_Name(chan));
}
- /* Set new topic */
- Channel_SetTopic(chan, from, Req->argv[1]);
LogDebug("%s \"%s\" set topic on \"%s\": %s",
Client_TypeText(from), Client_Mask(from), Channel_Name(chan),
Req->argv[1][0] ? Req->argv[1] : "<none>");
if (!Channel_IsLocal(chan))
IRC_WriteStrServersPrefix(Client, from, "TOPIC %s :%s",
Req->argv[0], Req->argv[1]);
- IRC_WriteStrChannelPrefix(Client, chan, from, false, "TOPIC %s :%s",
- Req->argv[0], Req->argv[1]);
+ /* Infrom local clients, but only when the topic really changed. */
+ if (strcmp(Req->argv[1], Channel_Topic(chan)) != 0)
+ IRC_WriteStrChannelPrefix(Client, chan, from, false,
+ "TOPIC %s :%s", Req->argv[0],
+ Req->argv[1]);
+
+ /* Update topic, setter, and timestamp. */
+ Channel_SetTopic(chan, from, Req->argv[1]);
+
+ /* Send confirmation when the local client is a user. */
if (Client_Type(Client) == CLIENT_USER)
return IRC_WriteStrClientPrefix(Client, Client, "TOPIC %s :%s",
Req->argv[0], Req->argv[1]);
assert(Client != NULL);
assert(Req != NULL);
- IRC_SetPenalty(Client, 2);
-
- _IRC_ARGC_LE_OR_RETURN_(Client, Req, 2)
_IRC_GET_SENDER_OR_RETURN_(from, Req, Client)
if (Req->argc > 0)
/* Forward to other server? */
target = Client_Search(Req->argv[1]);
if (! target || Client_Type(target) != CLIENT_SERVER)
- return IRC_WriteStrClient(from, ERR_NOSUCHSERVER_MSG,
+ return IRC_WriteErrClient(from, ERR_NOSUCHSERVER_MSG,
Client_ID(Client),
Req->argv[1]);
}
}
+ /* Send list head */
+ if (!IRC_WriteStrClient(from, RPL_LISTSTART_MSG, Client_ID(from)))
+ return DISCONNECTED;
+
while (pattern) {
/* Loop through all the channels */
if (Req->argc > 0)
/* Check search pattern */
if (MatchCaseInsensitive(pattern, Channel_Name(chan))) {
/* Gotcha! */
- if (!strchr(Channel_Modes(chan), 's')
+ if (!Channel_HasMode(chan, 's')
|| Channel_IsMemberOf(chan, from)
- || (!Conf_MorePrivacy && Client_OperByMe(Client))) {
+ || Client_HasMode(from, 'o'))
+ {
if ((Conf_MaxListSize > 0)
&& IRC_CheckListTooBig(from, count,
Conf_MaxListSize,
GLOBAL bool
IRC_CHANINFO( CLIENT *Client, REQUEST *Req )
{
- char modes_add[COMMAND_LEN], l[16], *ptr;
+ char modes_add[COMMAND_LEN], l[16];
CLIENT *from;
CHANNEL *chan;
int arg_topic;
/* Bad number of parameters? */
if (Req->argc < 2 || Req->argc == 4 || Req->argc > 5)
- return IRC_WriteStrClient(Client, ERR_NEEDMOREPARAMS_MSG,
+ return IRC_WriteErrClient(Client, ERR_NEEDMOREPARAMS_MSG,
Client_ID(Client), Req->command);
/* Compatibility kludge */
return CONNECTED;
if (Req->argv[1][0] == '+') {
- ptr = Channel_Modes(chan);
- if (!*ptr) {
- /* OK, this channel doesn't have modes jet,
+ if (!*Channel_Modes(chan)) {
+ /* OK, this channel doesn't have modes yet,
* set the received ones: */
Channel_SetModes(chan, &Req->argv[1][1]);
if(Req->argc == 5) {
- if(strchr(Channel_Modes(chan), 'k'))
+ if(Channel_HasMode(chan, 'k'))
Channel_SetKey(chan, Req->argv[2]);
- if(strchr(Channel_Modes(chan), 'l'))
+ if(Channel_HasMode(chan, 'l'))
Channel_SetMaxUsers(chan, atol(Req->argv[3]));
} else {
/* Delete modes which we never want to inherit */
}
strcpy(modes_add, "");
- ptr = Channel_Modes(chan);
- while (*ptr) {
- if (*ptr == 'l') {
- snprintf(l, sizeof(l), " %lu",
- Channel_MaxUsers(chan));
- strlcat(modes_add, l,
- sizeof(modes_add));
- }
- if (*ptr == 'k') {
- strlcat(modes_add, " ",
- sizeof(modes_add));
- strlcat(modes_add, Channel_Key(chan),
- sizeof(modes_add));
- }
- ptr++;
+ if (Channel_HasMode(chan, 'l')) {
+ snprintf(l, sizeof(l), " %lu",
+ Channel_MaxUsers(chan));
+ strlcat(modes_add, l, sizeof(modes_add));
+ }
+ if (Channel_HasMode(chan, 'k')) {
+ strlcat(modes_add, " ", sizeof(modes_add));
+ strlcat(modes_add, Channel_Key(chan),
+ sizeof(modes_add));
}
/* Inform members of this channel */
if (arg_topic > 0) {
/* We got a topic */
- ptr = Channel_Topic( chan );
- if (!*ptr && Req->argv[arg_topic][0]) {
+ if (!*Channel_Topic(chan) && Req->argv[arg_topic][0]) {
/* OK, there is no topic jet */
Channel_SetTopic(chan, Client, Req->argv[arg_topic]);
IRC_WriteStrChannelPrefix(Client, chan, from, false,