]> arthur.barton.de Git - ngircd-alex.git/blobdiff - src/ngircd/conn.c
Minimal changes (needed for merging resolver changes)
[ngircd-alex.git] / src / ngircd / conn.c
index 07c504cc506825275979f490821b1eda50854b02..8f04a1bb4534160fa16a0d26b224ba248f907f00 100644 (file)
@@ -17,7 +17,7 @@
 #include "portab.h"
 #include "io.h"
 
-static char UNUSED id[] = "$Id: conn.c,v 1.166 2005/07/28 16:13:09 fw Exp $";
+static char UNUSED id[] = "$Id: conn.c,v 1.180 2005/09/11 11:42:48 fw Exp $";
 
 #include "imp.h"
 #include <assert.h>
@@ -82,19 +82,19 @@ static char UNUSED id[] = "$Id: conn.c,v 1.166 2005/07/28 16:13:09 fw Exp $";
 #define SERVER_WAIT (NONE - 1)
 
 
-LOCAL bool Handle_Write PARAMS(( CONN_ID Idx ));
-LOCAL void New_Connection PARAMS(( int Sock ));
-LOCAL CONN_ID Socket2Index PARAMS(( int Sock ));
-LOCAL void Read_Request PARAMS(( CONN_ID Idx ));
-LOCAL bool Handle_Buffer PARAMS(( CONN_ID Idx ));
-LOCAL void Check_Connections PARAMS(( void ));
-LOCAL void Check_Servers PARAMS(( void ));
-LOCAL void Init_Conn_Struct PARAMS(( CONN_ID Idx ));
-LOCAL bool Init_Socket PARAMS(( int Sock ));
-LOCAL void New_Server PARAMS(( int Server, CONN_ID Idx ));
-LOCAL void Simple_Message PARAMS(( int Sock, char *Msg ));
-LOCAL int Count_Connections PARAMS(( struct sockaddr_in addr ));
-LOCAL int NewListener PARAMS(( const UINT16 Port ));
+static bool Handle_Write PARAMS(( CONN_ID Idx ));
+static int New_Connection PARAMS(( int Sock ));
+static CONN_ID Socket2Index PARAMS(( int Sock ));
+static void Read_Request PARAMS(( CONN_ID Idx ));
+static bool Handle_Buffer PARAMS(( CONN_ID Idx ));
+static void Check_Connections PARAMS(( void ));
+static void Check_Servers PARAMS(( void ));
+static void Init_Conn_Struct PARAMS(( CONN_ID Idx ));
+static bool Init_Socket PARAMS(( int Sock ));
+static void New_Server PARAMS(( int Server, CONN_ID Idx ));
+static void Simple_Message PARAMS(( int Sock, char *Msg ));
+static int Count_Connections PARAMS(( struct sockaddr_in addr ));
+static int NewListener PARAMS(( const UINT16 Port ));
 
 static array My_Listeners;
 
@@ -103,6 +103,7 @@ int allow_severity = LOG_INFO;
 int deny_severity = LOG_ERR;
 #endif
 
+static void server_login PARAMS((CONN_ID idx));
 
 static void cb_clientserver PARAMS((int sock, short what));
 
@@ -158,7 +159,13 @@ cb_connserver(int sock, UNUSED short what)
        }
 
        Conn_OPTION_DEL( &My_Connections[idx], CONN_ISCONNECTING );
+       server_login(idx);
+}
+
 
+static void
+server_login(CONN_ID idx)
+{
        Log( LOG_INFO, "Connection %d with \"%s:%d\" established. Now logging in ...", idx,
                        My_Connections[idx].host, Conf_Server[Conf_GetServer( idx )].port );
 
@@ -191,7 +198,7 @@ cb_clientserver(int sock, short what)
 }
 
 
-LOCAL void
+static void
 FreeRes_stat( CONNECTION *c )
 {
        assert( c != NULL );
@@ -275,34 +282,50 @@ Conn_Exit( void )
 } /* Conn_Exit */
 
 
+static unsigned int
+ports_initlisteners(array *a, void (*func)(int,short))
+{
+       unsigned int created = 0, len;
+       int fd;
+       UINT16 *port;
+
+       len = array_length(a, sizeof (UINT16));
+       port = array_start(a);
+       while(len--) {
+               fd = NewListener( *port );
+               if (fd < 0) {
+                       port++;
+                       continue;
+               }
+               if (!io_event_create( fd, IO_WANTREAD, func )) {
+                       Log( LOG_ERR, "io_event_create(): Could not add listening fd %d (port %u): %s!",
+                                                       fd, (unsigned int) *port, strerror(errno));
+                       close(fd);
+                       port++;
+                       continue;
+               }
+               created++;
+               port++;
+       }
+
+       return created;
+}
+
+
 GLOBAL int
 Conn_InitListeners( void )
 {
        /* Initialize ports on which the server should accept connections */
 
-       int created, fd;
-       unsigned int i;
+       unsigned int created;
 
        if (!io_library_init(CONNECTION_POOL)) {
                Log(LOG_EMERG, "Cannot initialize IO routines: %s", strerror(errno));
                return -1;
        }
 
-       created = 0;
-       for( i = 0; i < Conf_ListenPorts_Count; i++ ) {
-               fd = NewListener( Conf_ListenPorts[i] );
-               if (fd < 0) {
-                       Log( LOG_ERR, "Can't listen on port %u!", (unsigned int) Conf_ListenPorts[i] );
-                       continue;
-               }
-               if (!io_event_create( fd, IO_WANTREAD, cb_listen )) {
-                       Log( LOG_ERR, "io_event_create(): Could not add listening fd %d (port %u): %s!",
-                                               fd, (unsigned int) Conf_ListenPorts[i], strerror(errno));
-                       close(fd);
-                       continue;
-               }
-               created++;
-       }
+       created = ports_initlisteners(&Conf_ListenPorts, cb_listen);
+
        return created;
 } /* Conn_InitListeners */
 
@@ -335,7 +358,7 @@ Conn_ExitListeners( void )
 
 
 /* return new listening port file descriptor or -1 on failure */
-LOCAL int
+static int
 NewListener( const UINT16 Port )
 {
        /* Create new listening socket on specified port */
@@ -713,19 +736,24 @@ Conn_Close( CONN_ID Idx, char *LogMsg, char *FwdMsg, bool InformClient )
        c = Client_GetFromConn( Idx );
 
        /* Should the client be informed? */
-       if( InformClient )
-       {
+       if (InformClient) {
 #ifndef STRICT_RFC
                /* Send statistics to client if registered as user: */
-               if(( c != NULL ) && ( Client_Type( c ) == CLIENT_USER ))
-               {
-                       Conn_WriteStr( Idx, "NOTICE %s :%sConnection statistics: client %.1f kb, server %.1f kb.", Client_ThisServer( ), NOTICE_TXTPREFIX, (double)My_Connections[Idx].bytes_in / 1024,  (double)My_Connections[Idx].bytes_out / 1024 );
+               if ((c != NULL) && (Client_Type(c) == CLIENT_USER)) {
+                       Conn_WriteStr( Idx,
+                        ":%s NOTICE %s :%sConnection statistics: client %.1f kb, server %.1f kb.",
+                        Client_ID(Client_ThisServer()), Client_ID(c),
+                        NOTICE_TXTPREFIX,
+                        (double)My_Connections[Idx].bytes_in / 1024,
+                        (double)My_Connections[Idx].bytes_out / 1024);
                }
 #endif
 
                /* Send ERROR to client (see RFC!) */
-               if( FwdMsg ) Conn_WriteStr( Idx, "ERROR :%s", FwdMsg );
-               else Conn_WriteStr( Idx, "ERROR :Closing connection." );
+               if (FwdMsg)
+                       Conn_WriteStr(Idx, "ERROR :%s", FwdMsg);
+               else
+                       Conn_WriteStr(Idx, "ERROR :Closing connection.");
        }
 
        /* Try to write out the write buffer */
@@ -820,7 +848,7 @@ Conn_SyncServerStruct( void )
 } /* SyncServerStruct */
 
 
-LOCAL bool
+static bool
 Handle_Write( CONN_ID Idx )
 {
        /* Daten aus Schreibpuffer versenden bzw. Connection aufbauen */
@@ -828,40 +856,50 @@ Handle_Write( CONN_ID Idx )
        int len;
        unsigned int wdatalen;
 
-       Log(LOG_DEBUG, "Handle_Write");
        assert( Idx > NONE );
        if ( My_Connections[Idx].sock < 0 ) {
-               Log(LOG_WARNING, "Handle_Write() on closed socket, idx %d", Idx);
+#ifdef DEBUG
+               Log(LOG_DEBUG,
+                   "Handle_Write() on closed socket, connection %d", Idx);
+#endif
                return false;
        }
-       assert( My_Connections[Idx].sock > NONE );
 
+#ifdef DEBUG
+       Log(LOG_DEBUG, "Handle_Write() called for connection %d ...", Idx);
+#endif
 
        wdatalen = array_bytes(&My_Connections[Idx].wbuf );
 #ifdef ZLIB
-       if(( wdatalen == 0 ) && ( ! array_bytes(&My_Connections[Idx].zip.wbuf))) {
+       if (wdatalen == 0 && !array_bytes(&My_Connections[Idx].zip.wbuf)) {
                io_event_del(My_Connections[Idx].sock, IO_WANTWRITE );
                return true;
        }
 
-       /* write buffer empty, but not compression buf? -> flush compression buf. */
-       if( wdatalen == 0 ) Zip_Flush( Idx );
+       /* write buffer empty, but not compression buffer?
+         * -> flush compression buffer! */
+       if (wdatalen == 0)
+               Zip_Flush(Idx);
 #else
-       if( wdatalen == 0 ) {
+       if (wdatalen == 0) {
                io_event_del(My_Connections[Idx].sock, IO_WANTWRITE );
                return true;
        }
 #endif
 
-       wdatalen = array_bytes(&My_Connections[Idx].wbuf ); /* Zip_Flush may change wbuf  */
-       len = write( My_Connections[Idx].sock, array_start(&My_Connections[Idx].wbuf), wdatalen );
+       /* Zip_Flush() may have changed the write buffer ... */
+       wdatalen = array_bytes(&My_Connections[Idx].wbuf);
+
+       len = write(My_Connections[Idx].sock,
+                   array_start(&My_Connections[Idx].wbuf), wdatalen );
+
        if( len < 0 ) {
-               iferrno == EAGAIN || errno == EINTR)
+               if (errno == EAGAIN || errno == EINTR)
                        return true;
 
-               Log( LOG_ERR, "Write error on connection %d (socket %d): %s!", Idx,
-                                       My_Connections[Idx].sock, strerror( errno ));
-               Conn_Close( Idx, "Write error!", NULL, false );
+               Log(LOG_ERR, "Write error on connection %d (socket %d): %s!",
+                   Idx, My_Connections[Idx].sock, strerror(errno));
+               Conn_Close(Idx, "Write error!", NULL, false);
                return false;
        }
 
@@ -872,7 +910,7 @@ Handle_Write( CONN_ID Idx )
 } /* Handle_Write */
 
 
-LOCAL void
+static int
 New_Connection( int Sock )
 {
        /* Neue Client-Verbindung von Listen-Socket annehmen und
@@ -896,7 +934,7 @@ New_Connection( int Sock )
        if( new_sock < 0 )
        {
                Log( LOG_CRIT, "Can't accept connection: %s!", strerror( errno ));
-               return;
+               return -1;
        }
 
 #ifdef TCPWRAP
@@ -909,7 +947,7 @@ New_Connection( int Sock )
                Log( deny_severity, "Refused connection from %s (by TCP Wrappers)!", inet_ntoa( new_addr.sin_addr ));
                Simple_Message( new_sock, "ERROR :Connection refused" );
                close( new_sock );
-               return;
+               return -1;
        }
 #endif
 
@@ -924,7 +962,7 @@ New_Connection( int Sock )
                Log( LOG_ERR, "Refused connection from %s: too may connections (%ld) from this IP address!", inet_ntoa( new_addr.sin_addr ), cnt);
                Simple_Message( new_sock, "ERROR :Connection refused, too many connections from your IP address!" );
                close( new_sock );
-               return;
+               return -1;
        }
 
        /* Freie Connection-Struktur suchen */
@@ -945,7 +983,7 @@ New_Connection( int Sock )
                                Log( LOG_ALERT, "Can't accept connection: limit (%d) reached!", Pool_Size );
                                Simple_Message( new_sock, "ERROR :Connection limit reached" );
                                close( new_sock );
-                               return;
+                               return -1;
                        }
                        if( new_size > Conf_MaxConnections ) new_size = Conf_MaxConnections;
                }
@@ -954,7 +992,7 @@ New_Connection( int Sock )
                        Log( LOG_ALERT, "Can't accept connection: limit (%d) reached -- overflow!", Pool_Size );
                        Simple_Message( new_sock, "ERROR :Connection limit reached" );
                        close( new_sock );
-                       return;
+                       return -1;
                }
 
                ptr = (POINTER *)realloc( My_Connections, sizeof( CONNECTION ) * new_size );
@@ -962,7 +1000,7 @@ New_Connection( int Sock )
                        Log( LOG_EMERG, "Can't allocate memory! [New_Connection]" );
                        Simple_Message( new_sock, "ERROR: Internal error" );
                        close( new_sock );
-                       return;
+                       return -1;
                }
 
 #ifdef DEBUG
@@ -986,7 +1024,7 @@ New_Connection( int Sock )
                Log( LOG_ALERT, "Can't accept connection: can't create client structure!" );
                Simple_Message( new_sock, "ERROR :Internal error" );
                close( new_sock );
-               return;
+               return -1;
        }
 
        /* Verbindung registrieren */
@@ -998,7 +1036,7 @@ New_Connection( int Sock )
        if (!io_event_create( new_sock, IO_WANTREAD, cb_clientserver)) {
                Simple_Message( new_sock, "ERROR :Internal error" );
                Conn_Close( idx, "io_event_create() failed", NULL, false );
-               return;
+               return -1;
        }
 
        Log( LOG_INFO, "Accepted connection %d from %s:%d on socket %d.", idx, inet_ntoa( new_addr.sin_addr ), ntohs( new_addr.sin_port), Sock );
@@ -1016,10 +1054,11 @@ New_Connection( int Sock )
 
        /* Penalty-Zeit setzen */
        Conn_SetPenalty( idx, 4 );
+       return new_sock;
 } /* New_Connection */
 
 
-LOCAL CONN_ID
+static CONN_ID
 Socket2Index( int Sock )
 {
        /* zum Socket passende Connection suchen */
@@ -1043,7 +1082,7 @@ Socket2Index( int Sock )
 } /* Socket2Index */
 
 
-LOCAL void
+static void
 Read_Request( CONN_ID Idx )
 {
        /* Daten von Socket einlesen und entsprechend behandeln.
@@ -1051,6 +1090,7 @@ Read_Request( CONN_ID Idx )
 
        int len;
        char readbuf[1024];
+       CLIENT *c;
 
        assert( Idx > NONE );
        assert( My_Connections[Idx].sock > NONE );
@@ -1102,17 +1142,25 @@ Read_Request( CONN_ID Idx )
                }
        }
 
-       /* Connection-Statistik aktualisieren */
+       /* Update connection statistics */
        My_Connections[Idx].bytes_in += len;
 
-       /* Timestamp aktualisieren */
-       My_Connections[Idx].lastdata = time( NULL );
-
-       Handle_Buffer( Idx );
+       /* Update timestamp of last data received if this connection is
+        * registered as a user, server or service connection. Don't update
+        * otherwise, so users have at least Conf_PongTimeout seconds time to
+        * register with the IRC server -- see Check_Connections(). */
+       c = Client_GetFromConn(Idx);
+       if (c && (Client_Type(c) == CLIENT_USER
+                 || Client_Type(c) == CLIENT_SERVER
+                 || Client_Type(c) == CLIENT_SERVICE))
+               My_Connections[Idx].lastdata = time(NULL);
+
+       /* Look at the data in the (read-) buffer of this connection */
+       Handle_Buffer(Idx);
 } /* Read_Request */
 
 
-LOCAL bool
+static bool
 Handle_Buffer( CONN_ID Idx )
 {
        /* Handle Data in Connections Read-Buffer.
@@ -1122,13 +1170,13 @@ Handle_Buffer( CONN_ID Idx )
 #endif
        char *ptr;
        int len, delta;
-       bool action, result;
+       bool result;
 #ifdef ZLIB
        bool old_z;
 #endif
 
        result = false;
-       do {
+       for (;;) {
                /* Check penalty */
                if( My_Connections[Idx].delaytime > time( NULL )) return result;
 #ifdef ZLIB
@@ -1160,7 +1208,6 @@ Handle_Buffer( CONN_ID Idx )
                }
 #endif
 
-               action = false;
                if( ! ptr )
                        break;
 
@@ -1178,33 +1225,37 @@ Handle_Buffer( CONN_ID Idx )
                        return false;
                }
 
+               if (len <= 2) { /* request was empty (only '\r\n') */
+                       array_moveleft(&My_Connections[Idx].rbuf, 1, delta); /* delta is either 1 or 2 */
+                       break;
+               }
 #ifdef ZLIB
                /* remember if stream is already compressed */
                old_z = My_Connections[Idx].options & CONN_ZIP;
 #endif
 
-               if( len > delta )
-               {
-                       /* A Request was read */
-                       My_Connections[Idx].msg_in++;
-                       if( ! Parse_Request( Idx, (char*)array_start(&My_Connections[Idx].rbuf) )) return false;
-                       else action = true;
+               My_Connections[Idx].msg_in++;
+               if (!Parse_Request(Idx, (char*)array_start(&My_Connections[Idx].rbuf) ))
+                       return false;
 
-                       array_moveleft(&My_Connections[Idx].rbuf, 1, len);
+               result = true;
+
+               array_moveleft(&My_Connections[Idx].rbuf, 1, len);
 #ifdef DEBUG
-                       Log(LOG_DEBUG, "%d byte left in rbuf", array_bytes(&My_Connections[Idx].rbuf));
+               Log(LOG_DEBUG,
+                   "Connection %d: %d bytes left in read buffer.",
+                   Idx, array_bytes(&My_Connections[Idx].rbuf));
 #endif
-               }
-
 #ifdef ZLIB
-               if(( ! old_z ) && ( My_Connections[Idx].options & CONN_ZIP ) && ( array_bytes(&My_Connections[Idx].rbuf) > 0 ))
+               if(( ! old_z ) && ( My_Connections[Idx].options & CONN_ZIP ) &&
+                               ( array_bytes(&My_Connections[Idx].rbuf) > 0 ))
                {
                        /* The last Command activated Socket-Compression.
                         * Data that was read after that needs to be copied to Unzip-buf
                         * for decompression */
                        if( array_bytes(&My_Connections[Idx].rbuf)> ZREADBUFFER_LEN ) {
-                               /* No space left */
-                               Log( LOG_ALERT, "Can't move receive buffer: No space left in unzip buffer (need %d bytes)!", array_bytes(&My_Connections[Idx].rbuf ));
+                               Log( LOG_ALERT, "Connection %d: No space left in unzip buf (need %u bytes)!",
+                                                               Idx, array_bytes(&My_Connections[Idx].rbuf ));
                                return false;
                        }
                        if (!array_copy( &My_Connections[Idx].zip.rbuf, &My_Connections[Idx].rbuf ))
@@ -1212,18 +1263,18 @@ Handle_Buffer( CONN_ID Idx )
 
                        array_trunc(&My_Connections[Idx].rbuf);
 #ifdef DEBUG
-                       Log( LOG_DEBUG, "Moved already received data (%d bytes) to uncompression buffer.", array_bytes(&My_Connections[Idx].zip.rbuf));
+                       Log( LOG_DEBUG, "Moved already received data (%u bytes) to uncompression buffer.",
+                                                               array_bytes(&My_Connections[Idx].zip.rbuf));
 #endif /* DEBUG */
                }
 #endif /* ZLIB */
-               if( action ) result = true;
-       } while( action );
+       }
 
        return result;
 } /* Handle_Buffer */
 
 
-LOCAL void
+static void
 Check_Connections( void )
 {
        /* check if connections are alive. if not, play PING-PONG first.
@@ -1232,7 +1283,8 @@ Check_Connections( void )
        CONN_ID i;
 
        for( i = 0; i < Pool_Size; i++ ) {
-               if( My_Connections[i].sock == NONE ) continue;
+               if (My_Connections[i].sock < 0)
+                       continue;
 
                c = Client_GetFromConn( i );
                if( c && (( Client_Type( c ) == CLIENT_USER ) || ( Client_Type( c ) == CLIENT_SERVER ) || ( Client_Type( c ) == CLIENT_SERVICE )))
@@ -1259,21 +1311,26 @@ Check_Connections( void )
                }
                else
                {
-                       /* connection is not fully established yet */
-                       if( My_Connections[i].lastdata < time( NULL ) - Conf_PingTimeout )
-                       {
-                               /* Timeout */
+                       /* The connection is not fully established yet, so
+                        * we don't do the PING-PONG game here but instead
+                        * disconnect the client after "a short time" if it's
+                        * still not registered. */
+
+                       if (My_Connections[i].lastdata <
+                           time(NULL) - Conf_PongTimeout) {
 #ifdef DEBUG
-                               Log( LOG_DEBUG, "Connection %d timed out ...", i );
+                               Log(LOG_DEBUG,
+                                   "Unregistered connection %d timed out ...",
+                                   i);
 #endif
-                               Conn_Close( i, NULL, "Timeout", false );
+                               Conn_Close(i, NULL, "Timeout", false);
                        }
                }
        }
 } /* Check_Connections */
 
 
-LOCAL void
+static void
 Check_Servers( void )
 {
        /* Check if we can establish further server links */
@@ -1282,9 +1339,8 @@ Check_Servers( void )
        CONN_ID idx;
        int i, n;
 
-       /* Serach all connections, are there results from the resolver? */
-       for( idx = 0; idx < Pool_Size; idx++ )
-       {
+       /* Search all connections, are there results from the resolver? */
+       for( idx = 0; idx < Pool_Size; idx++ ) {
                if( My_Connections[idx].sock != SERVER_WAIT ) continue;
 
                /* IP resolved? */
@@ -1292,33 +1348,35 @@ Check_Servers( void )
        }
 
        /* Check all configured servers */
-       for( i = 0; i < MAX_SERVERS; i++ )
-       {
+       for( i = 0; i < MAX_SERVERS; i++ ) {
                /* Valid outgoing server which isn't already connected or disabled? */
-               if(( ! Conf_Server[i].host[0] ) || ( ! Conf_Server[i].port > 0 ) || ( Conf_Server[i].conn_id > NONE ) || ( Conf_Server[i].flags & CONF_SFLAG_DISABLED )) continue;
+               if(( ! Conf_Server[i].host[0] ) || ( ! Conf_Server[i].port > 0 ) ||
+                       ( Conf_Server[i].conn_id > NONE ) || ( Conf_Server[i].flags & CONF_SFLAG_DISABLED ))
+                               continue;
 
                /* Is there already a connection in this group? */
-               if( Conf_Server[i].group > NONE )
-               {
-                       for( n = 0; n < MAX_SERVERS; n++ )
-                       {
-                               if( n == i ) continue;
-                               if(( Conf_Server[n].conn_id > NONE ) && ( Conf_Server[n].group == Conf_Server[i].group )) break;
+               if( Conf_Server[i].group > NONE ) {
+                       for (n = 0; n < MAX_SERVERS; n++) {
+                               if (n == i) continue;
+                               if ((Conf_Server[n].conn_id > NONE) &&
+                                       (Conf_Server[n].group == Conf_Server[i].group))
+                                               break;
                        }
-                       if( n < MAX_SERVERS ) continue;
+                       if (n < MAX_SERVERS) continue;
                }
 
                /* Check last connect attempt? */
-               if( Conf_Server[i].lasttry > time( NULL ) - Conf_ConnectRetry ) continue;
+               if( Conf_Server[i].lasttry > time( NULL ) - Conf_ConnectRetry )
+                       continue;
 
                /* Okay, try to connect now */
                Conf_Server[i].lasttry = time( NULL );
 
                /* Search free connection structure */
                for( idx = 0; idx < Pool_Size; idx++ ) if( My_Connections[idx].sock == NONE ) break;
-               if( idx >= Pool_Size )
-               {
-                       Log( LOG_ALERT, "Can't establist server connection: connection limit reached (%d)!", Pool_Size );
+               if (idx >= Pool_Size) {
+                       Log( LOG_ALERT, "Can't establist server connection: connection limit reached (%d)!",
+                                                                                       Pool_Size );
                        return;
                }
 #ifdef DEBUG
@@ -1341,7 +1399,7 @@ Check_Servers( void )
 } /* Check_Servers */
 
 
-LOCAL void
+static void
 New_Server( int Server, CONN_ID Idx )
 {
        /* Establish new server link */
@@ -1357,11 +1415,14 @@ New_Server( int Server, CONN_ID Idx )
        /* Did we get a valid IP address? */
        if( ! Conf_Server[Server].ip[0] ) {
                /* No. Free connection structure and abort: */
-               Log( LOG_ERR, "Can't connect to \"%s\" (connection %d): ip address unknown!", Conf_Server[Server].host, Idx );
-               goto out;
+               Log( LOG_ERR, "Can't connect to \"%s\": ip address unknown!", Conf_Server[Server].host );
+               Init_Conn_Struct( Idx );
+               Conf_Server[Server].conn_id = NONE;
+               return;
        }
 
-       Log( LOG_INFO, "Establishing connection to \"%s\", %s, port %d (connection %d) ... ", Conf_Server[Server].host, Conf_Server[Server].ip, Conf_Server[Server].port, Idx );
+       Log( LOG_INFO, "Establishing connection to \"%s\", %s, port %d ... ", Conf_Server[Server].host,
+                                                       Conf_Server[Server].ip, Conf_Server[Server].port );
 
 #ifdef HAVE_INET_ATON
        if( inet_aton( Conf_Server[Server].ip, &inaddr ) == 0 )
@@ -1433,7 +1494,7 @@ out:
 } /* New_Server */
 
 
-LOCAL void
+static void
 Init_Conn_Struct( CONN_ID Idx )
 {
        time_t now = time( NULL );
@@ -1446,7 +1507,7 @@ Init_Conn_Struct( CONN_ID Idx )
 } /* Init_Conn_Struct */
 
 
-LOCAL bool
+static bool
 Init_Socket( int Sock )
 {
        /* Initialize socket (set options) */
@@ -1499,17 +1560,15 @@ void Read_Resolver_Result( int r_fd )
        char *bufptr;
        char readbuf[HOST_LEN];
 
-       Log( LOG_DEBUG, "Resolver: started, fd %d\n", r_fd );
+       Log( LOG_DEBUG, "Resolver: started, fd %d", r_fd );
        /* Search associated connection ... */
-       for( i = 0; i < Pool_Size; i++ )
-       {
+       for( i = 0; i < Pool_Size; i++ ) {
                if(( My_Connections[i].sock != NONE )
                  && ( My_Connections[i].res_stat != NULL )
                  && ( My_Connections[i].res_stat->pipe[0] == r_fd ))
                        break;
        }
-       if( i >= Pool_Size )
-       {
+       if( i >= Pool_Size ) {
                /* Ops, none found? Probably the connection has already
                 * been closed!? We'll ignore that ... */
                io_close( r_fd );
@@ -1525,8 +1584,7 @@ void Read_Resolver_Result( int r_fd )
 
        /* Read result from pipe */
        bytes_read = read( r_fd, readbuf, sizeof readbuf -1 );
-       if( bytes_read < 0 )
-       {
+       if( bytes_read < 0 ) {
                /* Error! */
                Log( LOG_CRIT, "Resolver: Can't read result: %s!", strerror( errno ));
                FreeRes_stat( &My_Connections[i] );
@@ -1534,7 +1592,7 @@ void Read_Resolver_Result( int r_fd )
        }
        len = (unsigned int) bytes_read;
        readbuf[len] = '\0';
-       if (!array_catb(&s->buffer, readbuf, len)) { 
+       if (!array_catb(&s->buffer, readbuf, len)) {
                Log( LOG_CRIT, "Resolver: Can't append result %s to buffer: %s", readbuf, strerror( errno ));
                FreeRes_stat(&My_Connections[i]);
                return;
@@ -1614,7 +1672,7 @@ try_resolve:
                /* Search server ... */
                n = Conf_GetServer( i );
                assert( n > NONE );
-               
+
                bufptr = (char*) array_start(&s->buffer);
                strlcpy( Conf_Server[n].ip, bufptr, sizeof( Conf_Server[n].ip ));
        }
@@ -1627,7 +1685,7 @@ try_resolve:
 } /* Read_Resolver_Result */
 
 
-LOCAL void
+static void
 Simple_Message( int Sock, char *Msg )
 {
        char buf[COMMAND_LEN];
@@ -1643,14 +1701,13 @@ Simple_Message( int Sock, char *Msg )
 } /* Simple_Error */
 
 
-LOCAL int
+static int
 Count_Connections( struct sockaddr_in addr_in )
 {
        int i, cnt;
        
        cnt = 0;
-       for( i = 0; i < Pool_Size; i++ )
-       {
+       for( i = 0; i < Pool_Size; i++ ) {
                if(( My_Connections[i].sock > NONE ) && ( My_Connections[i].addr.sin_addr.s_addr == addr_in.sin_addr.s_addr )) cnt++;
        }
        return cnt;