more HTTP compliance

diff --git a/charts.d/squid.chart.sh b/charts.d/squid.chart.sh
index 564ba4f212502d51d270b379947896c77056d8f4..64ab4783b4f1a4fc311cd242f53f7f5539bdefef 100755 (executable)
--- a/charts.d/squid.chart.sh
+++ b/charts.d/squid.chart.sh
@@ -8,13 +8,16 @@ squid_update_every=5
 squid_get_stats() {
 nc $squid_host $squid_port <<EOF
 GET $squid_url HTTP/1.0
+Host: $squid_host:$squid_port
+Accept: */*
+User-Agent: netdata (charts.d/squid.chart.sh)
 
 EOF
 }
 
 squid_check() {
        # check once if the url works
-       local x=`squid_get_stats | grep client_http.requests`
+       local x="$(squid_get_stats | grep client_http.requests)"
        if [ ! $? -eq 0 -o -z "$x" ]
        then
                echo >&2 "squid: cannot fetch URL '$squid_url' by connecting to $squid_host:$squid_port. Please set squid_url='url' and squid_host='host' and squid_port='port' in $confd/squid.conf"
@@ -69,9 +72,9 @@ squid_update() {
        # prepare the script and always grep at the end the lines that are usefull, so that
        # even if something goes wrong, no other code can be executed
 
-       eval "`squid_get_stats |\
+       eval "$(squid_get_stats |\
                 sed -e "s/ \+/ /g" -e "s/\./_/g" -e "s/^\([a-z0-9_]\+\) *= *\([0-9]\+\)$/local squid_\1=\2/g" |\
-               egrep "^local squid_(client_http|server_all)_[a-z0-9_]+=[0-9]+$"`"
+               egrep "^local squid_(client_http|server_all)_[a-z0-9_]+=[0-9]+$")"
 
        # write the result of the work.
        cat <<VALUESEOF