src/sys_fs_cgroup.c

   1 #include "common.h"
   2
   3 // ----------------------------------------------------------------------------
   4 // cgroup globals
   5
   6 #define CHART_PRIORITY_SYSTEMD_SERVICES 19000
   7 #define CHART_PRIORITY_CONTAINERS       40000
   8
   9 static long system_page_size = 4096; // system will be queried via sysconf() in configuration()
  10
  11 static int cgroup_enable_cpuacct_stat = CONFIG_BOOLEAN_AUTO;
  12 static int cgroup_enable_cpuacct_usage = CONFIG_BOOLEAN_AUTO;
  13 static int cgroup_enable_memory = CONFIG_BOOLEAN_AUTO;
  14 static int cgroup_enable_detailed_memory = CONFIG_BOOLEAN_AUTO;
  15 static int cgroup_enable_memory_failcnt = CONFIG_BOOLEAN_AUTO;
  16 static int cgroup_enable_swap = CONFIG_BOOLEAN_AUTO;
  17 static int cgroup_enable_blkio_io = CONFIG_BOOLEAN_AUTO;
  18 static int cgroup_enable_blkio_ops = CONFIG_BOOLEAN_AUTO;
  19 static int cgroup_enable_blkio_throttle_io = CONFIG_BOOLEAN_AUTO;
  20 static int cgroup_enable_blkio_throttle_ops = CONFIG_BOOLEAN_AUTO;
  21 static int cgroup_enable_blkio_merged_ops = CONFIG_BOOLEAN_AUTO;
  22 static int cgroup_enable_blkio_queued_ops = CONFIG_BOOLEAN_AUTO;
  23
  24 static int cgroup_enable_systemd_services = CONFIG_BOOLEAN_YES;
  25 static int cgroup_enable_systemd_services_detailed_memory = CONFIG_BOOLEAN_NO;
  26 static int cgroup_used_memory_without_cache = CONFIG_BOOLEAN_YES;
  27
  28 static int cgroup_search_in_devices = 1;
  29
  30 static int cgroup_enable_new_cgroups_detected_at_runtime = 1;
  31 static int cgroup_check_for_new_every = 10;
  32 static int cgroup_update_every = 1;
  33
  34 static int cgroup_recheck_zero_blkio_every_iterations = 10;
  35 static int cgroup_recheck_zero_mem_failcnt_every_iterations = 10;
  36 static int cgroup_recheck_zero_mem_detailed_every_iterations = 10;
  37
  38 static char *cgroup_cpuacct_base = NULL;
  39 static char *cgroup_blkio_base = NULL;
  40 static char *cgroup_memory_base = NULL;
  41 static char *cgroup_devices_base = NULL;
  42
  43 static int cgroup_root_count = 0;
  44 static int cgroup_root_max = 500;
  45 static int cgroup_max_depth = 0;
  46
  47 static SIMPLE_PATTERN *enabled_cgroup_patterns = NULL;
  48 static SIMPLE_PATTERN *enabled_cgroup_paths = NULL;
  49 static SIMPLE_PATTERN *enabled_cgroup_renames = NULL;
  50 static SIMPLE_PATTERN *systemd_services_cgroups = NULL;
  51
  52 static char *cgroups_rename_script = NULL;
  53
  54 static uint32_t Read_hash = 0;
  55 static uint32_t Write_hash = 0;
  56 static uint32_t user_hash = 0;
  57 static uint32_t system_hash = 0;
  58
  59 void read_cgroup_plugin_configuration() {
  60     system_page_size = sysconf(_SC_PAGESIZE);
  61
  62     Read_hash = simple_hash("Read");
  63     Write_hash = simple_hash("Write");
  64     user_hash = simple_hash("user");
  65     system_hash = simple_hash("system");
  66
  67     cgroup_update_every = (int)config_get_number("plugin:cgroups", "update every", localhost->rrd_update_every);
  68     if(cgroup_update_every < localhost->rrd_update_every)
  69         cgroup_update_every = localhost->rrd_update_every;
  70
  71     cgroup_check_for_new_every = (int)config_get_number("plugin:cgroups", "check for new cgroups every", cgroup_check_for_new_every * cgroup_update_every);
  72     if(cgroup_check_for_new_every < cgroup_update_every)
  73         cgroup_check_for_new_every = cgroup_update_every;
  74
  75     cgroup_enable_cpuacct_stat = config_get_boolean_ondemand("plugin:cgroups", "enable cpuacct stat (total CPU)", cgroup_enable_cpuacct_stat);
  76     cgroup_enable_cpuacct_usage = config_get_boolean_ondemand("plugin:cgroups", "enable cpuacct usage (per core CPU)", cgroup_enable_cpuacct_usage);
  77
  78     cgroup_enable_memory = config_get_boolean_ondemand("plugin:cgroups", "enable memory (used mem including cache)", cgroup_enable_memory);
  79     cgroup_enable_detailed_memory = config_get_boolean_ondemand("plugin:cgroups", "enable detailed memory", cgroup_enable_detailed_memory);
  80     cgroup_enable_memory_failcnt = config_get_boolean_ondemand("plugin:cgroups", "enable memory limits fail count", cgroup_enable_memory_failcnt);
  81     cgroup_enable_swap = config_get_boolean_ondemand("plugin:cgroups", "enable swap memory", cgroup_enable_swap);
  82
  83     cgroup_enable_blkio_io = config_get_boolean_ondemand("plugin:cgroups", "enable blkio bandwidth", cgroup_enable_blkio_io);
  84     cgroup_enable_blkio_ops = config_get_boolean_ondemand("plugin:cgroups", "enable blkio operations", cgroup_enable_blkio_ops);
  85     cgroup_enable_blkio_throttle_io = config_get_boolean_ondemand("plugin:cgroups", "enable blkio throttle bandwidth", cgroup_enable_blkio_throttle_io);
  86     cgroup_enable_blkio_throttle_ops = config_get_boolean_ondemand("plugin:cgroups", "enable blkio throttle operations", cgroup_enable_blkio_throttle_ops);
  87     cgroup_enable_blkio_queued_ops = config_get_boolean_ondemand("plugin:cgroups", "enable blkio queued operations", cgroup_enable_blkio_queued_ops);
  88     cgroup_enable_blkio_merged_ops = config_get_boolean_ondemand("plugin:cgroups", "enable blkio merged operations", cgroup_enable_blkio_merged_ops);
  89
  90     cgroup_recheck_zero_blkio_every_iterations = (int)config_get_number("plugin:cgroups", "recheck zero blkio every iterations", cgroup_recheck_zero_blkio_every_iterations);
  91     cgroup_recheck_zero_mem_failcnt_every_iterations = (int)config_get_number("plugin:cgroups", "recheck zero memory failcnt every iterations", cgroup_recheck_zero_mem_failcnt_every_iterations);
  92     cgroup_recheck_zero_mem_detailed_every_iterations = (int)config_get_number("plugin:cgroups", "recheck zero detailed memory every iterations", cgroup_recheck_zero_mem_detailed_every_iterations);
  93
  94     cgroup_enable_systemd_services = config_get_boolean("plugin:cgroups", "enable systemd services", cgroup_enable_systemd_services);
  95     cgroup_enable_systemd_services_detailed_memory = config_get_boolean("plugin:cgroups", "enable systemd services detailed memory", cgroup_enable_systemd_services_detailed_memory);
  96     cgroup_used_memory_without_cache = config_get_boolean("plugin:cgroups", "report used memory without cache", cgroup_used_memory_without_cache);
  97
  98     char filename[FILENAME_MAX + 1], *s;
  99     struct mountinfo *mi, *root = mountinfo_read(0);
 100
 101     mi = mountinfo_find_by_filesystem_super_option(root, "cgroup", "cpuacct");
 102     if(!mi) mi = mountinfo_find_by_filesystem_mount_source(root, "cgroup", "cpuacct");
 103     if(!mi) {
 104         error("Cannot find cgroup cpuacct mountinfo. Assuming default: /sys/fs/cgroup/cpuacct");
 105         s = "/sys/fs/cgroup/cpuacct";
 106     }
 107     else s = mi->mount_point;
 108     snprintfz(filename, FILENAME_MAX, "%s%s", netdata_configured_host_prefix, s);
 109     cgroup_cpuacct_base = config_get("plugin:cgroups", "path to /sys/fs/cgroup/cpuacct", filename);
 110
 111     mi = mountinfo_find_by_filesystem_super_option(root, "cgroup", "blkio");
 112     if(!mi) mi = mountinfo_find_by_filesystem_mount_source(root, "cgroup", "blkio");
 113     if(!mi) {
 114         error("Cannot find cgroup blkio mountinfo. Assuming default: /sys/fs/cgroup/blkio");
 115         s = "/sys/fs/cgroup/blkio";
 116     }
 117     else s = mi->mount_point;
 118     snprintfz(filename, FILENAME_MAX, "%s%s", netdata_configured_host_prefix, s);
 119     cgroup_blkio_base = config_get("plugin:cgroups", "path to /sys/fs/cgroup/blkio", filename);
 120
 121     mi = mountinfo_find_by_filesystem_super_option(root, "cgroup", "memory");
 122     if(!mi) mi = mountinfo_find_by_filesystem_mount_source(root, "cgroup", "memory");
 123     if(!mi) {
 124         error("Cannot find cgroup memory mountinfo. Assuming default: /sys/fs/cgroup/memory");
 125         s = "/sys/fs/cgroup/memory";
 126     }
 127     else s = mi->mount_point;
 128     snprintfz(filename, FILENAME_MAX, "%s%s", netdata_configured_host_prefix, s);
 129     cgroup_memory_base = config_get("plugin:cgroups", "path to /sys/fs/cgroup/memory", filename);
 130
 131     mi = mountinfo_find_by_filesystem_super_option(root, "cgroup", "devices");
 132     if(!mi) mi = mountinfo_find_by_filesystem_mount_source(root, "cgroup", "devices");
 133     if(!mi) {
 134         error("Cannot find cgroup devices mountinfo. Assuming default: /sys/fs/cgroup/devices");
 135         s = "/sys/fs/cgroup/devices";
 136     }
 137     else s = mi->mount_point;
 138     snprintfz(filename, FILENAME_MAX, "%s%s", netdata_configured_host_prefix, s);
 139     cgroup_devices_base = config_get("plugin:cgroups", "path to /sys/fs/cgroup/devices", filename);
 140
 141     cgroup_root_max = (int)config_get_number("plugin:cgroups", "max cgroups to allow", cgroup_root_max);
 142     cgroup_max_depth = (int)config_get_number("plugin:cgroups", "max cgroups depth to monitor", cgroup_max_depth);
 143
 144     cgroup_enable_new_cgroups_detected_at_runtime = config_get_boolean("plugin:cgroups", "enable new cgroups detected at run time", cgroup_enable_new_cgroups_detected_at_runtime);
 145
 146     enabled_cgroup_patterns = simple_pattern_create(
 147             config_get("plugin:cgroups", "enable by default cgroups matching",
 148                     " /system.slice/docker-*.scope "
 149                     " !*.mount "
 150                     " !*.partition "
 151                     " !*.scope "
 152                     " !*.service "
 153                     " !*.slice "
 154                     " !*.swap "
 155                     " !*.user "
 156                     " !/ "
 157                     " !/docker "
 158                     " !/libvirt "
 159                     " !/lxc "
 160                     " !/lxc/*/ns "         //  #1397
 161                     " !/machine "
 162                     " !/qemu "
 163                     " !/system "
 164                     " !/systemd "
 165                     " !/user "
 166                     " * "                  // enable anything else
 167             ), SIMPLE_PATTERN_EXACT);
 168
 169     enabled_cgroup_paths = simple_pattern_create(
 170             config_get("plugin:cgroups", "search for cgroups in subpaths matching",
 171                     " !*-qemu "            //  #345
 172                     " !/init.scope "
 173                     " !/system "
 174                     " !/systemd "
 175                     " !/user "
 176                     " !/user.slice "
 177                     " * "
 178             ), SIMPLE_PATTERN_EXACT);
 179
 180     snprintfz(filename, FILENAME_MAX, "%s/cgroup-name.sh", netdata_configured_plugins_dir);
 181     cgroups_rename_script = config_get("plugin:cgroups", "script to get cgroup names", filename);
 182
 183     enabled_cgroup_renames = simple_pattern_create(
 184             config_get("plugin:cgroups", "run script to rename cgroups matching",
 185                     " *docker* "
 186                     " *lxc* "
 187                     " !/ "
 188                     " !*.mount "
 189                     " !*.partition "
 190                     " !*.scope "
 191                     " !*.service "
 192                     " !*.slice "
 193                     " !*.swap "
 194                     " !*.user "
 195                     " * "
 196             ), SIMPLE_PATTERN_EXACT);
 197
 198     if(cgroup_enable_systemd_services) {
 199         systemd_services_cgroups = simple_pattern_create(
 200                 config_get("plugin:cgroups", "cgroups to match as systemd services",
 201                         " !/system.slice/*/*.service "
 202                         " /system.slice/*.service "
 203                 ), SIMPLE_PATTERN_EXACT);
 204     }
 205
 206     mountinfo_free(root);
 207 }
 208
 209 // ----------------------------------------------------------------------------
 210 // cgroup objects
 211
 212 struct blkio {
 213     int updated;
 214     int enabled; // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 215     int delay_counter;
 216
 217     char *filename;
 218
 219     unsigned long long Read;
 220     unsigned long long Write;
 221 /*
 222     unsigned long long Sync;
 223     unsigned long long Async;
 224     unsigned long long Total;
 225 */
 226 };
 227
 228 // https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
 229 struct memory {
 230     ARL_BASE *arl_base;
 231     ARL_ENTRY *arl_dirty;
 232     ARL_ENTRY *arl_swap;
 233
 234     int updated_detailed;
 235     int updated_usage_in_bytes;
 236     int updated_msw_usage_in_bytes;
 237     int updated_failcnt;
 238
 239     int enabled_detailed;           // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 240     int enabled_usage_in_bytes;     // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 241     int enabled_msw_usage_in_bytes; // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 242     int enabled_failcnt;            // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 243
 244     int delay_counter_detailed;
 245     int delay_counter_failcnt;
 246
 247     char *filename_detailed;
 248     char *filename_usage_in_bytes;
 249     char *filename_msw_usage_in_bytes;
 250     char *filename_failcnt;
 251
 252     int detailed_has_dirty;
 253     int detailed_has_swap;
 254
 255     // detailed metrics
 256     unsigned long long cache;
 257     unsigned long long rss;
 258     unsigned long long rss_huge;
 259     unsigned long long mapped_file;
 260     unsigned long long writeback;
 261     unsigned long long dirty;
 262     unsigned long long swap;
 263     unsigned long long pgpgin;
 264     unsigned long long pgpgout;
 265     unsigned long long pgfault;
 266     unsigned long long pgmajfault;
 267 /*
 268     unsigned long long inactive_anon;
 269     unsigned long long active_anon;
 270     unsigned long long inactive_file;
 271     unsigned long long active_file;
 272     unsigned long long unevictable;
 273     unsigned long long hierarchical_memory_limit;
 274     unsigned long long total_cache;
 275     unsigned long long total_rss;
 276     unsigned long long total_rss_huge;
 277     unsigned long long total_mapped_file;
 278     unsigned long long total_writeback;
 279     unsigned long long total_dirty;
 280     unsigned long long total_swap;
 281     unsigned long long total_pgpgin;
 282     unsigned long long total_pgpgout;
 283     unsigned long long total_pgfault;
 284     unsigned long long total_pgmajfault;
 285     unsigned long long total_inactive_anon;
 286     unsigned long long total_active_anon;
 287     unsigned long long total_inactive_file;
 288     unsigned long long total_active_file;
 289     unsigned long long total_unevictable;
 290 */
 291
 292     // single file metrics
 293     unsigned long long usage_in_bytes;
 294     unsigned long long msw_usage_in_bytes;
 295     unsigned long long failcnt;
 296 };
 297
 298 // https://www.kernel.org/doc/Documentation/cgroup-v1/cpuacct.txt
 299 struct cpuacct_stat {
 300     int updated;
 301     int enabled; // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 302
 303     char *filename;
 304
 305     unsigned long long user;
 306     unsigned long long system;
 307 };
 308
 309 // https://www.kernel.org/doc/Documentation/cgroup-v1/cpuacct.txt
 310 struct cpuacct_usage {
 311     int updated;
 312     int enabled; // CONFIG_BOOLEAN_YES or CONFIG_BOOLEAN_AUTO
 313
 314     char *filename;
 315
 316     unsigned int cpus;
 317     unsigned long long *cpu_percpu;
 318 };
 319
 320 #define CGROUP_OPTIONS_DISABLED_DUPLICATE   0x00000001
 321 #define CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE 0x00000002
 322
 323 struct cgroup {
 324     uint32_t options;
 325
 326     char available;      // found in the filesystem
 327     char enabled;        // enabled in the config
 328
 329     char *id;
 330     uint32_t hash;
 331
 332     char *chart_id;
 333     uint32_t hash_chart;
 334
 335     char *chart_title;
 336
 337     struct cpuacct_stat cpuacct_stat;
 338     struct cpuacct_usage cpuacct_usage;
 339
 340     struct memory memory;
 341
 342     struct blkio io_service_bytes;              // bytes
 343     struct blkio io_serviced;                   // operations
 344
 345     struct blkio throttle_io_service_bytes;     // bytes
 346     struct blkio throttle_io_serviced;          // operations
 347
 348     struct blkio io_merged;                     // operations
 349     struct blkio io_queued;                     // operations
 350
 351     // per cgroup charts
 352     RRDSET *st_cpu;
 353     RRDSET *st_cpu_per_core;
 354     RRDSET *st_mem;
 355     RRDSET *st_writeback;
 356     RRDSET *st_mem_activity;
 357     RRDSET *st_pgfaults;
 358     RRDSET *st_mem_usage;
 359     RRDSET *st_mem_failcnt;
 360     RRDSET *st_io;
 361     RRDSET *st_serviced_ops;
 362     RRDSET *st_throttle_io;
 363     RRDSET *st_throttle_serviced_ops;
 364     RRDSET *st_queued_ops;
 365     RRDSET *st_merged_ops;
 366
 367     // services
 368     RRDDIM *rd_cpu;
 369     RRDDIM *rd_mem_usage;
 370     RRDDIM *rd_mem_failcnt;
 371     RRDDIM *rd_swap_usage;
 372
 373     RRDDIM *rd_mem_detailed_cache;
 374     RRDDIM *rd_mem_detailed_rss;
 375     RRDDIM *rd_mem_detailed_mapped;
 376     RRDDIM *rd_mem_detailed_writeback;
 377     RRDDIM *rd_mem_detailed_pgpgin;
 378     RRDDIM *rd_mem_detailed_pgpgout;
 379     RRDDIM *rd_mem_detailed_pgfault;
 380     RRDDIM *rd_mem_detailed_pgmajfault;
 381
 382     RRDDIM *rd_io_service_bytes_read;
 383     RRDDIM *rd_io_serviced_read;
 384     RRDDIM *rd_throttle_io_read;
 385     RRDDIM *rd_throttle_io_serviced_read;
 386     RRDDIM *rd_io_queued_read;
 387     RRDDIM *rd_io_merged_read;
 388
 389     RRDDIM *rd_io_service_bytes_write;
 390     RRDDIM *rd_io_serviced_write;
 391     RRDDIM *rd_throttle_io_write;
 392     RRDDIM *rd_throttle_io_serviced_write;
 393     RRDDIM *rd_io_queued_write;
 394     RRDDIM *rd_io_merged_write;
 395
 396     struct cgroup *next;
 397
 398 } *cgroup_root = NULL;
 399
 400 // ----------------------------------------------------------------------------
 401 // read values from /sys
 402
 403 static inline void cgroup_read_cpuacct_stat(struct cpuacct_stat *cp) {
 404     static procfile *ff = NULL;
 405
 406     if(likely(cp->filename)) {
 407         ff = procfile_reopen(ff, cp->filename, NULL, PROCFILE_FLAG_DEFAULT);
 408         if(unlikely(!ff)) {
 409             cp->updated = 0;
 410             return;
 411         }
 412
 413         ff = procfile_readall(ff);
 414         if(unlikely(!ff)) {
 415             cp->updated = 0;
 416             return;
 417         }
 418
 419         unsigned long i, lines = procfile_lines(ff);
 420
 421         if(unlikely(lines < 1)) {
 422             error("File '%s' should have 1+ lines.", cp->filename);
 423             cp->updated = 0;
 424             return;
 425         }
 426
 427         for(i = 0; i < lines ; i++) {
 428             char *s = procfile_lineword(ff, i, 0);
 429             uint32_t hash = simple_hash(s);
 430
 431             if(unlikely(hash == user_hash && !strcmp(s, "user")))
 432                 cp->user = str2ull(procfile_lineword(ff, i, 1));
 433
 434             else if(unlikely(hash == system_hash && !strcmp(s, "system")))
 435                 cp->system = str2ull(procfile_lineword(ff, i, 1));
 436         }
 437
 438         cp->updated = 1;
 439
 440         if(unlikely(cp->enabled == CONFIG_BOOLEAN_AUTO && (cp->user || cp->system)))
 441             cp->enabled = CONFIG_BOOLEAN_YES;
 442     }
 443 }
 444
 445 static inline void cgroup_read_cpuacct_usage(struct cpuacct_usage *ca) {
 446     static procfile *ff = NULL;
 447
 448     if(likely(ca->filename)) {
 449         ff = procfile_reopen(ff, ca->filename, NULL, PROCFILE_FLAG_DEFAULT);
 450         if(unlikely(!ff)) {
 451             ca->updated = 0;
 452             return;
 453         }
 454
 455         ff = procfile_readall(ff);
 456         if(unlikely(!ff)) {
 457             ca->updated = 0;
 458             return;
 459         }
 460
 461         if(unlikely(procfile_lines(ff) < 1)) {
 462             error("File '%s' should have 1+ lines but has %zu.", ca->filename, procfile_lines(ff));
 463             ca->updated = 0;
 464             return;
 465         }
 466
 467         unsigned long i = procfile_linewords(ff, 0);
 468         if(unlikely(i == 0)) {
 469             return;
 470             ca->updated = 0;
 471         }
 472
 473         // we may have 1 more CPU reported
 474         while(i > 0) {
 475             char *s = procfile_lineword(ff, 0, i - 1);
 476             if(!*s) i--;
 477             else break;
 478         }
 479
 480         if(unlikely(i != ca->cpus)) {
 481             freez(ca->cpu_percpu);
 482             ca->cpu_percpu = mallocz(sizeof(unsigned long long) * i);
 483             ca->cpus = (unsigned int)i;
 484         }
 485
 486         unsigned long long total = 0;
 487         for(i = 0; i < ca->cpus ;i++) {
 488             unsigned long long n = str2ull(procfile_lineword(ff, 0, i));
 489             ca->cpu_percpu[i] = n;
 490             total += n;
 491         }
 492
 493         ca->updated = 1;
 494
 495         if(unlikely(ca->enabled == CONFIG_BOOLEAN_AUTO && total))
 496             ca->enabled = CONFIG_BOOLEAN_YES;
 497     }
 498 }
 499
 500 static inline void cgroup_read_blkio(struct blkio *io) {
 501     static procfile *ff = NULL;
 502
 503     if(unlikely(io->enabled == CONFIG_BOOLEAN_AUTO && io->delay_counter > 0)) {
 504         io->delay_counter--;
 505         return;
 506     }
 507
 508     if(likely(io->filename)) {
 509         ff = procfile_reopen(ff, io->filename, NULL, PROCFILE_FLAG_DEFAULT);
 510         if(unlikely(!ff)) {
 511             io->updated = 0;
 512             return;
 513         }
 514
 515         ff = procfile_readall(ff);
 516         if(unlikely(!ff)) {
 517             io->updated = 0;
 518             return;
 519         }
 520
 521         unsigned long i, lines = procfile_lines(ff);
 522
 523         if(unlikely(lines < 1)) {
 524             error("File '%s' should have 1+ lines.", io->filename);
 525             io->updated = 0;
 526             return;
 527         }
 528
 529         io->Read = 0;
 530         io->Write = 0;
 531 /*
 532         io->Sync = 0;
 533         io->Async = 0;
 534         io->Total = 0;
 535 */
 536
 537         for(i = 0; i < lines ; i++) {
 538             char *s = procfile_lineword(ff, i, 1);
 539             uint32_t hash = simple_hash(s);
 540
 541             if(unlikely(hash == Read_hash && !strcmp(s, "Read")))
 542                 io->Read += str2ull(procfile_lineword(ff, i, 2));
 543
 544             else if(unlikely(hash == Write_hash && !strcmp(s, "Write")))
 545                 io->Write += str2ull(procfile_lineword(ff, i, 2));
 546
 547 /*
 548             else if(unlikely(hash == Sync_hash && !strcmp(s, "Sync")))
 549                 io->Sync += str2ull(procfile_lineword(ff, i, 2));
 550
 551             else if(unlikely(hash == Async_hash && !strcmp(s, "Async")))
 552                 io->Async += str2ull(procfile_lineword(ff, i, 2));
 553
 554             else if(unlikely(hash == Total_hash && !strcmp(s, "Total")))
 555                 io->Total += str2ull(procfile_lineword(ff, i, 2));
 556 */
 557         }
 558
 559         io->updated = 1;
 560
 561         if(unlikely(io->enabled == CONFIG_BOOLEAN_AUTO)) {
 562             if(unlikely(io->Read || io->Write))
 563                 io->enabled = CONFIG_BOOLEAN_YES;
 564             else
 565                 io->delay_counter = cgroup_recheck_zero_blkio_every_iterations;
 566         }
 567     }
 568 }
 569
 570 static inline void cgroup_read_memory(struct memory *mem) {
 571     static procfile *ff = NULL;
 572
 573     // read detailed ram usage
 574     if(likely(mem->filename_detailed)) {
 575         if(unlikely(mem->enabled_detailed == CONFIG_BOOLEAN_AUTO && mem->delay_counter_detailed > 0)) {
 576             mem->delay_counter_detailed--;
 577             goto memory_next;
 578         }
 579
 580         ff = procfile_reopen(ff, mem->filename_detailed, NULL, PROCFILE_FLAG_DEFAULT);
 581         if(unlikely(!ff)) {
 582             mem->updated_detailed = 0;
 583             goto memory_next;
 584         }
 585
 586         ff = procfile_readall(ff);
 587         if(unlikely(!ff)) {
 588             mem->updated_detailed = 0;
 589             goto memory_next;
 590         }
 591
 592         unsigned long i, lines = procfile_lines(ff);
 593
 594         if(unlikely(lines < 1)) {
 595             error("File '%s' should have 1+ lines.", mem->filename_detailed);
 596             mem->updated_detailed = 0;
 597             goto memory_next;
 598         }
 599
 600         if(unlikely(!mem->arl_base)) {
 601             mem->arl_base = arl_create("cgroup/memory", NULL, 60);
 602
 603             arl_expect(mem->arl_base, "cache", &mem->cache);
 604             arl_expect(mem->arl_base, "rss", &mem->rss);
 605             arl_expect(mem->arl_base, "rss_huge", &mem->rss_huge);
 606             arl_expect(mem->arl_base, "mapped_file", &mem->mapped_file);
 607             arl_expect(mem->arl_base, "writeback", &mem->writeback);
 608             mem->arl_dirty = arl_expect(mem->arl_base, "dirty", &mem->dirty);
 609             mem->arl_swap  = arl_expect(mem->arl_base, "swap", &mem->swap);
 610             arl_expect(mem->arl_base, "pgpgin", &mem->pgpgin);
 611             arl_expect(mem->arl_base, "pgpgout", &mem->pgpgout);
 612             arl_expect(mem->arl_base, "pgfault", &mem->pgfault);
 613             arl_expect(mem->arl_base, "pgmajfault", &mem->pgmajfault);
 614         }
 615
 616         arl_begin(mem->arl_base);
 617
 618         for(i = 0; i < lines ; i++) {
 619             if(arl_check(mem->arl_base,
 620                     procfile_lineword(ff, i, 0),
 621                     procfile_lineword(ff, i, 1))) break;
 622         }
 623
 624         if(unlikely(mem->arl_dirty->flags & ARL_ENTRY_FLAG_FOUND))
 625             mem->detailed_has_dirty = 1;
 626
 627         if(unlikely(mem->arl_swap->flags & ARL_ENTRY_FLAG_FOUND))
 628             mem->detailed_has_swap = 1;
 629
 630         // fprintf(stderr, "READ: '%s', cache: %llu, rss: %llu, rss_huge: %llu, mapped_file: %llu, writeback: %llu, dirty: %llu, swap: %llu, pgpgin: %llu, pgpgout: %llu, pgfault: %llu, pgmajfault: %llu, inactive_anon: %llu, active_anon: %llu, inactive_file: %llu, active_file: %llu, unevictable: %llu, hierarchical_memory_limit: %llu, total_cache: %llu, total_rss: %llu, total_rss_huge: %llu, total_mapped_file: %llu, total_writeback: %llu, total_dirty: %llu, total_swap: %llu, total_pgpgin: %llu, total_pgpgout: %llu, total_pgfault: %llu, total_pgmajfault: %llu, total_inactive_anon: %llu, total_active_anon: %llu, total_inactive_file: %llu, total_active_file: %llu, total_unevictable: %llu\n", mem->filename, mem->cache, mem->rss, mem->rss_huge, mem->mapped_file, mem->writeback, mem->dirty, mem->swap, mem->pgpgin, mem->pgpgout, mem->pgfault, mem->pgmajfault, mem->inactive_anon, mem->active_anon, mem->inactive_file, mem->active_file, mem->unevictable, mem->hierarchical_memory_limit, mem->total_cache, mem->total_rss, mem->total_rss_huge, mem->total_mapped_file, mem->total_writeback, mem->total_dirty, mem->total_swap, mem->total_pgpgin, mem->total_pgpgout, mem->total_pgfault, mem->total_pgmajfault, mem->total_inactive_anon, mem->total_active_anon, mem->total_inactive_file, mem->total_active_file, mem->total_unevictable);
 631
 632         mem->updated_detailed = 1;
 633
 634         if(unlikely(mem->enabled_detailed == CONFIG_BOOLEAN_AUTO)) {
 635             if(mem->cache || mem->dirty || mem->rss || mem->rss_huge || mem->mapped_file || mem->writeback || mem->swap || mem->pgpgin || mem->pgpgout || mem->pgfault || mem->pgmajfault)
 636                 mem->enabled_detailed = CONFIG_BOOLEAN_YES;
 637             else
 638                 mem->delay_counter_detailed = cgroup_recheck_zero_mem_detailed_every_iterations;
 639         }
 640     }
 641
 642 memory_next:
 643
 644     // read usage_in_bytes
 645     if(likely(mem->filename_usage_in_bytes)) {
 646         mem->updated_usage_in_bytes = !read_single_number_file(mem->filename_usage_in_bytes, &mem->usage_in_bytes);
 647         if(unlikely(mem->updated_usage_in_bytes && mem->enabled_usage_in_bytes == CONFIG_BOOLEAN_AUTO && mem->usage_in_bytes))
 648             mem->enabled_usage_in_bytes = CONFIG_BOOLEAN_YES;
 649     }
 650
 651     // read msw_usage_in_bytes
 652     if(likely(mem->filename_msw_usage_in_bytes)) {
 653         mem->updated_msw_usage_in_bytes = !read_single_number_file(mem->filename_msw_usage_in_bytes, &mem->msw_usage_in_bytes);
 654         if(unlikely(mem->updated_msw_usage_in_bytes && mem->enabled_msw_usage_in_bytes == CONFIG_BOOLEAN_AUTO && mem->msw_usage_in_bytes))
 655             mem->enabled_msw_usage_in_bytes = CONFIG_BOOLEAN_YES;
 656     }
 657
 658     // read failcnt
 659     if(likely(mem->filename_failcnt)) {
 660         if(unlikely(mem->enabled_failcnt == CONFIG_BOOLEAN_AUTO && mem->delay_counter_failcnt > 0)) {
 661             mem->updated_failcnt = 0;
 662             mem->delay_counter_failcnt--;
 663         }
 664         else {
 665             mem->updated_failcnt = !read_single_number_file(mem->filename_failcnt, &mem->failcnt);
 666             if(unlikely(mem->updated_failcnt && mem->enabled_failcnt == CONFIG_BOOLEAN_AUTO)) {
 667                 if(unlikely(!mem->failcnt))
 668                     mem->delay_counter_failcnt = cgroup_recheck_zero_mem_failcnt_every_iterations;
 669                 else
 670                     mem->enabled_failcnt = CONFIG_BOOLEAN_YES;
 671             }
 672         }
 673     }
 674 }
 675
 676 static inline void cgroup_read(struct cgroup *cg) {
 677     debug(D_CGROUP, "reading metrics for cgroups '%s'", cg->id);
 678
 679     cgroup_read_cpuacct_stat(&cg->cpuacct_stat);
 680     cgroup_read_cpuacct_usage(&cg->cpuacct_usage);
 681     cgroup_read_memory(&cg->memory);
 682     cgroup_read_blkio(&cg->io_service_bytes);
 683     cgroup_read_blkio(&cg->io_serviced);
 684     cgroup_read_blkio(&cg->throttle_io_service_bytes);
 685     cgroup_read_blkio(&cg->throttle_io_serviced);
 686     cgroup_read_blkio(&cg->io_merged);
 687     cgroup_read_blkio(&cg->io_queued);
 688 }
 689
 690 static inline void read_all_cgroups(struct cgroup *root) {
 691     debug(D_CGROUP, "reading metrics for all cgroups");
 692
 693     struct cgroup *cg;
 694
 695     for(cg = root; cg ; cg = cg->next)
 696         if(cg->enabled && cg->available)
 697             cgroup_read(cg);
 698 }
 699
 700 // ----------------------------------------------------------------------------
 701 // add/remove/find cgroup objects
 702
 703 #define CGROUP_CHARTID_LINE_MAX 1024
 704
 705 static inline char *cgroup_title_strdupz(const char *s) {
 706     if(!s || !*s) s = "/";
 707
 708     if(*s == '/' && s[1] != '\0') s++;
 709
 710     char *r = strdupz(s);
 711     netdata_fix_chart_name(r);
 712
 713     return r;
 714 }
 715
 716 static inline char *cgroup_chart_id_strdupz(const char *s) {
 717     if(!s || !*s) s = "/";
 718
 719     if(*s == '/' && s[1] != '\0') s++;
 720
 721     char *r = strdupz(s);
 722     netdata_fix_chart_id(r);
 723
 724     return r;
 725 }
 726
 727 static inline void cgroup_get_chart_name(struct cgroup *cg) {
 728     debug(D_CGROUP, "looking for the name of cgroup '%s' with chart id '%s' and title '%s'", cg->id, cg->chart_id, cg->chart_title);
 729
 730     pid_t cgroup_pid;
 731     char buffer[CGROUP_CHARTID_LINE_MAX + 1];
 732
 733     snprintfz(buffer, CGROUP_CHARTID_LINE_MAX, "exec %s '%s'", cgroups_rename_script, cg->chart_id);
 734
 735     debug(D_CGROUP, "executing command '%s' for cgroup '%s'", buffer, cg->id);
 736     FILE *fp = mypopen(buffer, &cgroup_pid);
 737     if(fp) {
 738         // debug(D_CGROUP, "reading from command '%s' for cgroup '%s'", buffer, cg->id);
 739         char *s = fgets(buffer, CGROUP_CHARTID_LINE_MAX, fp);
 740         // debug(D_CGROUP, "closing command for cgroup '%s'", cg->id);
 741         mypclose(fp, cgroup_pid);
 742         // debug(D_CGROUP, "closed command for cgroup '%s'", cg->id);
 743
 744         if(s && *s && *s != '\n') {
 745             debug(D_CGROUP, "cgroup '%s' should be renamed to '%s'", cg->id, s);
 746
 747             trim(s);
 748
 749             freez(cg->chart_title);
 750             cg->chart_title = cgroup_title_strdupz(s);
 751
 752             freez(cg->chart_id);
 753             cg->chart_id = cgroup_chart_id_strdupz(s);
 754             cg->hash_chart = simple_hash(cg->chart_id);
 755         }
 756     }
 757     else
 758         error("CGROUP: Cannot popen(\"%s\", \"r\").", buffer);
 759 }
 760
 761 static inline struct cgroup *cgroup_add(const char *id) {
 762     if(!id || !*id) id = "/";
 763     debug(D_CGROUP, "adding to list, cgroup with id '%s'", id);
 764
 765     if(cgroup_root_count >= cgroup_root_max) {
 766         info("Maximum number of cgroups reached (%d). Not adding cgroup '%s'", cgroup_root_count, id);
 767         return NULL;
 768     }
 769
 770     int def = simple_pattern_matches(enabled_cgroup_patterns, id)?cgroup_enable_new_cgroups_detected_at_runtime:0;
 771     struct cgroup *cg = callocz(1, sizeof(struct cgroup));
 772
 773     cg->id = strdupz(id);
 774     cg->hash = simple_hash(cg->id);
 775
 776     cg->chart_title = cgroup_title_strdupz(id);
 777
 778     cg->chart_id = cgroup_chart_id_strdupz(id);
 779     cg->hash_chart = simple_hash(cg->chart_id);
 780
 781     if(!cgroup_root)
 782         cgroup_root = cg;
 783     else {
 784         // append it
 785         struct cgroup *e;
 786         for(e = cgroup_root; e->next ;e = e->next) ;
 787         e->next = cg;
 788     }
 789
 790     cgroup_root_count++;
 791
 792     // fix the chart_id and title by calling the external script
 793     if(simple_pattern_matches(enabled_cgroup_renames, cg->id)) {
 794
 795         cgroup_get_chart_name(cg);
 796
 797         debug(D_CGROUP, "cgroup '%s' renamed to '%s' (title: '%s')", cg->id, cg->chart_id, cg->chart_title);
 798     }
 799     else
 800         debug(D_CGROUP, "cgroup '%s' will not be renamed - it matches the list of disabled cgroup renames (will be shown as '%s')", cg->id, cg->chart_id);
 801
 802     int user_configurable = 1;
 803
 804     // check if this cgroup should be a systemd service
 805     if(cgroup_enable_systemd_services) {
 806         if(simple_pattern_matches(systemd_services_cgroups, cg->id) ||
 807                 simple_pattern_matches(systemd_services_cgroups, cg->chart_id)) {
 808             debug(D_CGROUP, "cgroup '%s' with chart id '%s' (title: '%s') matches systemd services cgroups", cg->id, cg->chart_id, cg->chart_title);
 809
 810             char buffer[CGROUP_CHARTID_LINE_MAX + 1];
 811             cg->options |= CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE;
 812
 813             strncpy(buffer, cg->id, CGROUP_CHARTID_LINE_MAX);
 814             char *s = buffer;
 815
 816             //freez(cg->chart_id);
 817             //cg->chart_id = cgroup_chart_id_strdupz(s);
 818             //cg->hash_chart = simple_hash(cg->chart_id);
 819
 820             // skip to the last slash
 821             size_t len = strlen(s);
 822             while(len--) if(unlikely(s[len] == '/')) break;
 823             if(len) s = &s[len + 1];
 824
 825             // remove extension
 826             len = strlen(s);
 827             while(len--) if(unlikely(s[len] == '.')) break;
 828             if(len) s[len] = '\0';
 829
 830             freez(cg->chart_title);
 831             cg->chart_title = cgroup_title_strdupz(s);
 832
 833             cg->enabled = 1;
 834             user_configurable = 0;
 835
 836             debug(D_CGROUP, "cgroup '%s' renamed to '%s' (title: '%s')", cg->id, cg->chart_id, cg->chart_title);
 837         }
 838         else
 839             debug(D_CGROUP, "cgroup '%s' with chart id '%s' (title: '%s') does not match systemd services groups", cg->id, cg->chart_id, cg->chart_title);
 840     }
 841
 842     if(user_configurable) {
 843         // allow the user to enable/disable this individualy
 844         char option[FILENAME_MAX + 1];
 845         snprintfz(option, FILENAME_MAX, "enable cgroup %s", cg->chart_title);
 846         cg->enabled = (char) config_get_boolean("plugin:cgroups", option, def);
 847     }
 848
 849     // detect duplicate cgroups
 850     if(cg->enabled) {
 851         struct cgroup *t;
 852         for (t = cgroup_root; t; t = t->next) {
 853             if (t != cg && t->enabled && t->hash_chart == cg->hash_chart && !strcmp(t->chart_id, cg->chart_id)) {
 854                 if (!strncmp(t->chart_id, "/system.slice/", 14) && !strncmp(cg->chart_id, "/init.scope/system.slice/", 25)) {
 855                     error("Control group with chart id '%s' already exists with id '%s' and is enabled. Swapping them by enabling cgroup with id '%s' and disabling cgroup with id '%s'.",
 856                           cg->chart_id, t->id, cg->id, t->id);
 857                     debug(D_CGROUP, "Control group with chart id '%s' already exists with id '%s' and is enabled. Swapping them by enabling cgroup with id '%s' and disabling cgroup with id '%s'.",
 858                           cg->chart_id, t->id, cg->id, t->id);
 859                     t->enabled = 0;
 860                     t->options |= CGROUP_OPTIONS_DISABLED_DUPLICATE;
 861                 }
 862                 else {
 863                     error("Control group with chart id '%s' already exists with id '%s' and is enabled and available. Disabling cgroup with id '%s'.",
 864                           cg->chart_id, t->id, cg->id);
 865                     debug(D_CGROUP, "Control group with chart id '%s' already exists with id '%s' and is enabled and available. Disabling cgroup with id '%s'.",
 866                           cg->chart_id, t->id, cg->id);
 867                     cg->enabled = 0;
 868                     cg->options |= CGROUP_OPTIONS_DISABLED_DUPLICATE;
 869                 }
 870
 871                 break;
 872             }
 873         }
 874     }
 875
 876     debug(D_CGROUP, "ADDED CGROUP: '%s' with chart id '%s' and title '%s' as %s (default was %s)", cg->id, cg->chart_id, cg->chart_title, (cg->enabled)?"enabled":"disabled", (def)?"enabled":"disabled");
 877
 878     return cg;
 879 }
 880
 881 static inline void cgroup_free(struct cgroup *cg) {
 882     debug(D_CGROUP, "Removing cgroup '%s' with chart id '%s' (was %s and %s)", cg->id, cg->chart_id, (cg->enabled)?"enabled":"disabled", (cg->available)?"available":"not available");
 883
 884     if(cg->st_cpu)                   rrdset_flag_set(cg->st_cpu,                   RRDSET_FLAG_OBSOLETE);
 885     if(cg->st_cpu_per_core)          rrdset_flag_set(cg->st_cpu_per_core,          RRDSET_FLAG_OBSOLETE);
 886     if(cg->st_mem)                   rrdset_flag_set(cg->st_mem,                   RRDSET_FLAG_OBSOLETE);
 887     if(cg->st_writeback)             rrdset_flag_set(cg->st_writeback,             RRDSET_FLAG_OBSOLETE);
 888     if(cg->st_mem_activity)          rrdset_flag_set(cg->st_mem_activity,          RRDSET_FLAG_OBSOLETE);
 889     if(cg->st_pgfaults)              rrdset_flag_set(cg->st_pgfaults,              RRDSET_FLAG_OBSOLETE);
 890     if(cg->st_mem_usage)             rrdset_flag_set(cg->st_mem_usage,             RRDSET_FLAG_OBSOLETE);
 891     if(cg->st_mem_failcnt)           rrdset_flag_set(cg->st_mem_failcnt,           RRDSET_FLAG_OBSOLETE);
 892     if(cg->st_io)                    rrdset_flag_set(cg->st_io,                    RRDSET_FLAG_OBSOLETE);
 893     if(cg->st_serviced_ops)          rrdset_flag_set(cg->st_serviced_ops,          RRDSET_FLAG_OBSOLETE);
 894     if(cg->st_throttle_io)           rrdset_flag_set(cg->st_throttle_io,           RRDSET_FLAG_OBSOLETE);
 895     if(cg->st_throttle_serviced_ops) rrdset_flag_set(cg->st_throttle_serviced_ops, RRDSET_FLAG_OBSOLETE);
 896     if(cg->st_queued_ops)            rrdset_flag_set(cg->st_queued_ops,            RRDSET_FLAG_OBSOLETE);
 897     if(cg->st_merged_ops)            rrdset_flag_set(cg->st_merged_ops,            RRDSET_FLAG_OBSOLETE);
 898
 899     freez(cg->cpuacct_usage.cpu_percpu);
 900
 901     freez(cg->cpuacct_stat.filename);
 902     freez(cg->cpuacct_usage.filename);
 903
 904     arl_free(cg->memory.arl_base);
 905     freez(cg->memory.filename_detailed);
 906     freez(cg->memory.filename_failcnt);
 907     freez(cg->memory.filename_usage_in_bytes);
 908     freez(cg->memory.filename_msw_usage_in_bytes);
 909
 910     freez(cg->io_service_bytes.filename);
 911     freez(cg->io_serviced.filename);
 912
 913     freez(cg->throttle_io_service_bytes.filename);
 914     freez(cg->throttle_io_serviced.filename);
 915
 916     freez(cg->io_merged.filename);
 917     freez(cg->io_queued.filename);
 918
 919     freez(cg->id);
 920     freez(cg->chart_id);
 921     freez(cg->chart_title);
 922
 923     freez(cg);
 924
 925     cgroup_root_count--;
 926 }
 927
 928 // find if a given cgroup exists
 929 static inline struct cgroup *cgroup_find(const char *id) {
 930     debug(D_CGROUP, "searching for cgroup '%s'", id);
 931
 932     uint32_t hash = simple_hash(id);
 933
 934     struct cgroup *cg;
 935     for(cg = cgroup_root; cg ; cg = cg->next) {
 936         if(hash == cg->hash && strcmp(id, cg->id) == 0)
 937             break;
 938     }
 939
 940     debug(D_CGROUP, "cgroup '%s' %s in memory", id, (cg)?"found":"not found");
 941     return cg;
 942 }
 943
 944 // ----------------------------------------------------------------------------
 945 // detect running cgroups
 946
 947 // callback for find_file_in_subdirs()
 948 static inline void found_subdir_in_dir(const char *dir) {
 949     debug(D_CGROUP, "examining cgroup dir '%s'", dir);
 950
 951     struct cgroup *cg = cgroup_find(dir);
 952     if(!cg) {
 953         if(*dir && cgroup_max_depth > 0) {
 954             int depth = 0;
 955             const char *s;
 956
 957             for(s = dir; *s ;s++)
 958                 if(unlikely(*s == '/'))
 959                     depth++;
 960
 961             if(depth > cgroup_max_depth) {
 962                 info("cgroup '%s' is too deep (%d, while max is %d)", dir, depth, cgroup_max_depth);
 963                 return;
 964             }
 965         }
 966         // debug(D_CGROUP, "will add dir '%s' as cgroup", dir);
 967         cg = cgroup_add(dir);
 968     }
 969
 970     if(cg) cg->available = 1;
 971 }
 972
 973 static inline int find_dir_in_subdirs(const char *base, const char *this, void (*callback)(const char *)) {
 974     if(!this) this = base;
 975     debug(D_CGROUP, "searching for directories in '%s' (base '%s')", this?this:"", base);
 976
 977     size_t dirlen = strlen(this), baselen = strlen(base);
 978
 979     int ret = -1;
 980     int enabled = -1;
 981
 982     const char *relative_path = &this[baselen];
 983     if(!*relative_path) relative_path = "/";
 984
 985     DIR *dir = opendir(this);
 986     if(!dir) {
 987         error("Cannot read cgroups directory '%s'", base);
 988         return ret;
 989     }
 990     ret = 1;
 991
 992     callback(relative_path);
 993
 994     struct dirent *de = NULL;
 995     while((de = readdir(dir))) {
 996         if(de->d_type == DT_DIR
 997             && (
 998                 (de->d_name[0] == '.' && de->d_name[1] == '\0')
 999                 || (de->d_name[0] == '.' && de->d_name[1] == '.' && de->d_name[2] == '\0')
1000                 ))
1001             continue;
1002
1003         if(de->d_type == DT_DIR) {
1004             if(enabled == -1) {
1005                 const char *r = relative_path;
1006                 if(*r == '\0') r = "/";
1007
1008                 // do not decent in directories we are not interested
1009                 int def = simple_pattern_matches(enabled_cgroup_paths, r);
1010
1011                 // we check for this option here
1012                 // so that the config will not have settings
1013                 // for leaf directories
1014                 char option[FILENAME_MAX + 1];
1015                 snprintfz(option, FILENAME_MAX, "search for cgroups under %s", r);
1016                 option[FILENAME_MAX] = '\0';
1017                 enabled = config_get_boolean("plugin:cgroups", option, def);
1018             }
1019
1020             if(enabled) {
1021                 char *s = mallocz(dirlen + strlen(de->d_name) + 2);
1022                 strcpy(s, this);
1023                 strcat(s, "/");
1024                 strcat(s, de->d_name);
1025                 int ret2 = find_dir_in_subdirs(base, s, callback);
1026                 if(ret2 > 0) ret += ret2;
1027                 freez(s);
1028             }
1029         }
1030     }
1031
1032     closedir(dir);
1033     return ret;
1034 }
1035
1036 static inline void mark_all_cgroups_as_not_available() {
1037     debug(D_CGROUP, "marking all cgroups as not available");
1038
1039     struct cgroup *cg;
1040
1041     // mark all as not available
1042     for(cg = cgroup_root; cg ; cg = cg->next) {
1043         cg->available = 0;
1044     }
1045 }
1046
1047 static inline void cleanup_all_cgroups() {
1048     struct cgroup *cg = cgroup_root, *last = NULL;
1049
1050     for(; cg ;) {
1051         if(!cg->available) {
1052             // enable the first duplicate cgroup
1053             {
1054                 struct cgroup *t;
1055                 for(t = cgroup_root; t ; t = t->next) {
1056                     if(t != cg && t->available && !t->enabled && t->options & CGROUP_OPTIONS_DISABLED_DUPLICATE && t->hash_chart == cg->hash_chart && !strcmp(t->chart_id, cg->chart_id)) {
1057                         debug(D_CGROUP, "Enabling duplicate of cgroup '%s' with id '%s', because the original with id '%s' stopped.", t->chart_id, t->id, cg->id);
1058                         t->enabled = 1;
1059                         t->options &= ~CGROUP_OPTIONS_DISABLED_DUPLICATE;
1060                         break;
1061                     }
1062                 }
1063             }
1064
1065             if(!last)
1066                 cgroup_root = cg->next;
1067             else
1068                 last->next = cg->next;
1069
1070             cgroup_free(cg);
1071
1072             if(!last)
1073                 cg = cgroup_root;
1074             else
1075                 cg = last->next;
1076         }
1077         else {
1078             last = cg;
1079             cg = cg->next;
1080         }
1081     }
1082 }
1083
1084 static inline void find_all_cgroups() {
1085     debug(D_CGROUP, "searching for cgroups");
1086
1087     mark_all_cgroups_as_not_available();
1088
1089     if(cgroup_enable_cpuacct_stat || cgroup_enable_cpuacct_usage) {
1090         if(find_dir_in_subdirs(cgroup_cpuacct_base, NULL, found_subdir_in_dir) == -1) {
1091             cgroup_enable_cpuacct_stat =
1092             cgroup_enable_cpuacct_usage = CONFIG_BOOLEAN_NO;
1093             error("disabled CGROUP cpu statistics.");
1094         }
1095     }
1096
1097     if(cgroup_enable_blkio_io || cgroup_enable_blkio_ops || cgroup_enable_blkio_throttle_io || cgroup_enable_blkio_throttle_ops || cgroup_enable_blkio_merged_ops || cgroup_enable_blkio_queued_ops) {
1098         if(find_dir_in_subdirs(cgroup_blkio_base, NULL, found_subdir_in_dir) == -1) {
1099             cgroup_enable_blkio_io =
1100             cgroup_enable_blkio_ops =
1101             cgroup_enable_blkio_throttle_io =
1102             cgroup_enable_blkio_throttle_ops =
1103             cgroup_enable_blkio_merged_ops =
1104             cgroup_enable_blkio_queued_ops = CONFIG_BOOLEAN_NO;
1105             error("disabled CGROUP blkio statistics.");
1106         }
1107     }
1108
1109     if(cgroup_enable_memory || cgroup_enable_detailed_memory || cgroup_enable_swap || cgroup_enable_memory_failcnt) {
1110         if(find_dir_in_subdirs(cgroup_memory_base, NULL, found_subdir_in_dir) == -1) {
1111             cgroup_enable_memory =
1112             cgroup_enable_detailed_memory =
1113             cgroup_enable_swap =
1114             cgroup_enable_memory_failcnt = CONFIG_BOOLEAN_NO;
1115             error("disabled CGROUP memory statistics.");
1116         }
1117     }
1118
1119     if(cgroup_search_in_devices) {
1120         if(find_dir_in_subdirs(cgroup_devices_base, NULL, found_subdir_in_dir) == -1) {
1121             cgroup_search_in_devices = 0;
1122             error("disabled CGROUP devices statistics.");
1123         }
1124     }
1125
1126     // remove any non-existing cgroups
1127     cleanup_all_cgroups();
1128
1129     struct cgroup *cg;
1130     struct stat buf;
1131     for(cg = cgroup_root; cg ; cg = cg->next) {
1132         // fprintf(stderr, " >>> CGROUP '%s' (%u - %s) with name '%s'\n", cg->id, cg->hash, cg->available?"available":"stopped", cg->name);
1133
1134         if(unlikely(!cg->available))
1135             continue;
1136
1137         debug(D_CGROUP, "checking paths for cgroup '%s'", cg->id);
1138
1139         // check for newly added cgroups
1140         // and update the filenames they read
1141         char filename[FILENAME_MAX + 1];
1142         if(unlikely(cgroup_enable_cpuacct_stat && !cg->cpuacct_stat.filename)) {
1143             snprintfz(filename, FILENAME_MAX, "%s%s/cpuacct.stat", cgroup_cpuacct_base, cg->id);
1144             if(likely(stat(filename, &buf) != -1)) {
1145                 cg->cpuacct_stat.filename = strdupz(filename);
1146                 cg->cpuacct_stat.enabled = cgroup_enable_cpuacct_stat;
1147                 debug(D_CGROUP, "cpuacct.stat filename for cgroup '%s': '%s'", cg->id, cg->cpuacct_stat.filename);
1148             }
1149             else
1150                 debug(D_CGROUP, "cpuacct.stat file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1151         }
1152
1153         if(unlikely(cgroup_enable_cpuacct_usage && !cg->cpuacct_usage.filename && !(cg->options & CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE))) {
1154             snprintfz(filename, FILENAME_MAX, "%s%s/cpuacct.usage_percpu", cgroup_cpuacct_base, cg->id);
1155             if(likely(stat(filename, &buf) != -1)) {
1156                 cg->cpuacct_usage.filename = strdupz(filename);
1157                 cg->cpuacct_usage.enabled = cgroup_enable_cpuacct_usage;
1158                 debug(D_CGROUP, "cpuacct.usage_percpu filename for cgroup '%s': '%s'", cg->id, cg->cpuacct_usage.filename);
1159             }
1160             else
1161                 debug(D_CGROUP, "cpuacct.usage_percpu file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1162         }
1163
1164         if(unlikely((cgroup_enable_detailed_memory || cgroup_used_memory_without_cache) && !cg->memory.filename_detailed && (cgroup_used_memory_without_cache || cgroup_enable_systemd_services_detailed_memory || !(cg->options & CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE)))) {
1165             snprintfz(filename, FILENAME_MAX, "%s%s/memory.stat", cgroup_memory_base, cg->id);
1166             if(likely(stat(filename, &buf) != -1)) {
1167                 cg->memory.filename_detailed = strdupz(filename);
1168                 cg->memory.enabled_detailed = (cgroup_enable_detailed_memory == CONFIG_BOOLEAN_YES)?CONFIG_BOOLEAN_YES:CONFIG_BOOLEAN_AUTO;
1169                 debug(D_CGROUP, "memory.stat filename for cgroup '%s': '%s'", cg->id, cg->memory.filename_detailed);
1170             }
1171             else
1172                 debug(D_CGROUP, "memory.stat file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1173         }
1174
1175         if(unlikely(cgroup_enable_memory && !cg->memory.filename_usage_in_bytes)) {
1176             snprintfz(filename, FILENAME_MAX, "%s%s/memory.usage_in_bytes", cgroup_memory_base, cg->id);
1177             if(likely(stat(filename, &buf) != -1)) {
1178                 cg->memory.filename_usage_in_bytes = strdupz(filename);
1179                 cg->memory.enabled_usage_in_bytes = cgroup_enable_memory;
1180                 debug(D_CGROUP, "memory.usage_in_bytes filename for cgroup '%s': '%s'", cg->id, cg->memory.filename_usage_in_bytes);
1181             }
1182             else
1183                 debug(D_CGROUP, "memory.usage_in_bytes file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1184         }
1185
1186         if(unlikely(cgroup_enable_swap && !cg->memory.filename_msw_usage_in_bytes)) {
1187             snprintfz(filename, FILENAME_MAX, "%s%s/memory.msw_usage_in_bytes", cgroup_memory_base, cg->id);
1188             if(likely(stat(filename, &buf) != -1)) {
1189                 cg->memory.filename_msw_usage_in_bytes = strdupz(filename);
1190                 cg->memory.enabled_msw_usage_in_bytes = cgroup_enable_swap;
1191                 debug(D_CGROUP, "memory.msw_usage_in_bytes filename for cgroup '%s': '%s'", cg->id, cg->memory.filename_msw_usage_in_bytes);
1192             }
1193             else
1194                 debug(D_CGROUP, "memory.msw_usage_in_bytes file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1195         }
1196
1197         if(unlikely(cgroup_enable_memory_failcnt && !cg->memory.filename_failcnt)) {
1198             snprintfz(filename, FILENAME_MAX, "%s%s/memory.failcnt", cgroup_memory_base, cg->id);
1199             if(likely(stat(filename, &buf) != -1)) {
1200                 cg->memory.filename_failcnt = strdupz(filename);
1201                 cg->memory.enabled_failcnt = cgroup_enable_memory_failcnt;
1202                 debug(D_CGROUP, "memory.failcnt filename for cgroup '%s': '%s'", cg->id, cg->memory.filename_failcnt);
1203             }
1204             else
1205                 debug(D_CGROUP, "memory.failcnt file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1206         }
1207
1208         if(unlikely(cgroup_enable_blkio_io && !cg->io_service_bytes.filename)) {
1209             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.io_service_bytes", cgroup_blkio_base, cg->id);
1210             if(likely(stat(filename, &buf) != -1)) {
1211                 cg->io_service_bytes.filename = strdupz(filename);
1212                 cg->io_service_bytes.enabled = cgroup_enable_blkio_io;
1213                 debug(D_CGROUP, "io_service_bytes filename for cgroup '%s': '%s'", cg->id, cg->io_service_bytes.filename);
1214             }
1215             else
1216                 debug(D_CGROUP, "io_service_bytes file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1217         }
1218
1219         if(unlikely(cgroup_enable_blkio_ops && !cg->io_serviced.filename)) {
1220             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.io_serviced", cgroup_blkio_base, cg->id);
1221             if(likely(stat(filename, &buf) != -1)) {
1222                 cg->io_serviced.filename = strdupz(filename);
1223                 cg->io_serviced.enabled = cgroup_enable_blkio_ops;
1224                 debug(D_CGROUP, "io_serviced filename for cgroup '%s': '%s'", cg->id, cg->io_serviced.filename);
1225             }
1226             else
1227                 debug(D_CGROUP, "io_serviced file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1228         }
1229
1230         if(unlikely(cgroup_enable_blkio_throttle_io && !cg->throttle_io_service_bytes.filename)) {
1231             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.throttle.io_service_bytes", cgroup_blkio_base, cg->id);
1232             if(likely(stat(filename, &buf) != -1)) {
1233                 cg->throttle_io_service_bytes.filename = strdupz(filename);
1234                 cg->throttle_io_service_bytes.enabled = cgroup_enable_blkio_throttle_io;
1235                 debug(D_CGROUP, "throttle_io_service_bytes filename for cgroup '%s': '%s'", cg->id, cg->throttle_io_service_bytes.filename);
1236             }
1237             else
1238                 debug(D_CGROUP, "throttle_io_service_bytes file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1239         }
1240
1241         if(unlikely(cgroup_enable_blkio_throttle_ops && !cg->throttle_io_serviced.filename)) {
1242             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.throttle.io_serviced", cgroup_blkio_base, cg->id);
1243             if(likely(stat(filename, &buf) != -1)) {
1244                 cg->throttle_io_serviced.filename = strdupz(filename);
1245                 cg->throttle_io_serviced.enabled = cgroup_enable_blkio_throttle_ops;
1246                 debug(D_CGROUP, "throttle_io_serviced filename for cgroup '%s': '%s'", cg->id, cg->throttle_io_serviced.filename);
1247             }
1248             else
1249                 debug(D_CGROUP, "throttle_io_serviced file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1250         }
1251
1252         if(unlikely(cgroup_enable_blkio_merged_ops && !cg->io_merged.filename)) {
1253             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.io_merged", cgroup_blkio_base, cg->id);
1254             if(likely(stat(filename, &buf) != -1)) {
1255                 cg->io_merged.filename = strdupz(filename);
1256                 cg->io_merged.enabled = cgroup_enable_blkio_merged_ops;
1257                 debug(D_CGROUP, "io_merged filename for cgroup '%s': '%s'", cg->id, cg->io_merged.filename);
1258             }
1259             else
1260                 debug(D_CGROUP, "io_merged file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1261         }
1262
1263         if(unlikely(cgroup_enable_blkio_queued_ops && !cg->io_queued.filename)) {
1264             snprintfz(filename, FILENAME_MAX, "%s%s/blkio.io_queued", cgroup_blkio_base, cg->id);
1265             if(likely(stat(filename, &buf) != -1)) {
1266                 cg->io_queued.filename = strdupz(filename);
1267                 cg->io_queued.enabled = cgroup_enable_blkio_queued_ops;
1268                 debug(D_CGROUP, "io_queued filename for cgroup '%s': '%s'", cg->id, cg->io_queued.filename);
1269             }
1270             else
1271                 debug(D_CGROUP, "io_queued file for cgroup '%s': '%s' does not exist.", cg->id, filename);
1272         }
1273     }
1274
1275     debug(D_CGROUP, "done searching for cgroups");
1276     return;
1277 }
1278
1279 // ----------------------------------------------------------------------------
1280 // generate charts
1281
1282 #define CHART_TITLE_MAX 300
1283
1284 void update_systemd_services_charts(
1285           int update_every
1286         , int do_cpu
1287         , int do_mem_usage
1288         , int do_mem_detailed
1289         , int do_mem_failcnt
1290         , int do_swap_usage
1291         , int do_io
1292         , int do_io_ops
1293         , int do_throttle_io
1294         , int do_throttle_ops
1295         , int do_queued_ops
1296         , int do_merged_ops
1297 ) {
1298     static RRDSET
1299         *st_cpu = NULL,
1300         *st_mem_usage = NULL,
1301         *st_mem_failcnt = NULL,
1302         *st_swap_usage = NULL,
1303
1304         *st_mem_detailed_cache = NULL,
1305         *st_mem_detailed_rss = NULL,
1306         *st_mem_detailed_mapped = NULL,
1307         *st_mem_detailed_writeback = NULL,
1308         *st_mem_detailed_pgfault = NULL,
1309         *st_mem_detailed_pgmajfault = NULL,
1310         *st_mem_detailed_pgpgin = NULL,
1311         *st_mem_detailed_pgpgout = NULL,
1312
1313         *st_io_read = NULL,
1314         *st_io_serviced_read = NULL,
1315         *st_throttle_io_read = NULL,
1316         *st_throttle_ops_read = NULL,
1317         *st_queued_ops_read = NULL,
1318         *st_merged_ops_read = NULL,
1319
1320         *st_io_write = NULL,
1321         *st_io_serviced_write = NULL,
1322         *st_throttle_io_write = NULL,
1323         *st_throttle_ops_write = NULL,
1324         *st_queued_ops_write = NULL,
1325         *st_merged_ops_write = NULL;
1326
1327     // create the charts
1328
1329     if(likely(do_cpu)) {
1330         if(unlikely(!st_cpu)) {
1331             char title[CHART_TITLE_MAX + 1];
1332             snprintfz(title, CHART_TITLE_MAX, "Systemd Services CPU utilization (%d%% = %d core%s)", (processors * 100), processors, (processors > 1) ? "s" : "");
1333
1334             st_cpu = rrdset_create_localhost(
1335                     "services"
1336                     , "cpu"
1337                     , NULL
1338                     , "cpu"
1339                     , "services.cpu"
1340                     , title
1341                     , "%"
1342                     , CHART_PRIORITY_SYSTEMD_SERVICES
1343                     , update_every
1344                     , RRDSET_TYPE_STACKED
1345             );
1346
1347         }
1348         else
1349             rrdset_next(st_cpu);
1350     }
1351
1352     if(likely(do_mem_usage)) {
1353         if(unlikely(!st_mem_usage)) {
1354
1355             st_mem_usage = rrdset_create_localhost(
1356                     "services"
1357                     , "mem_usage"
1358                     , NULL
1359                     , "mem"
1360                     , "services.mem_usage"
1361                     , (cgroup_used_memory_without_cache) ? "Systemd Services Used Memory without Cache"
1362                                                          : "Systemd Services Used Memory"
1363                     , "MB"
1364                     , CHART_PRIORITY_SYSTEMD_SERVICES + 10
1365                     , update_every
1366                     , RRDSET_TYPE_STACKED
1367             );
1368
1369         }
1370         else
1371             rrdset_next(st_mem_usage);
1372     }
1373
1374     if(likely(do_mem_detailed)) {
1375         if(unlikely(!st_mem_detailed_rss)) {
1376
1377             st_mem_detailed_rss = rrdset_create_localhost(
1378                     "services"
1379                     , "mem_rss"
1380                     , NULL
1381                     , "mem"
1382                     , "services.mem_rss"
1383                     , "Systemd Services RSS Memory"
1384                     , "MB"
1385                     , CHART_PRIORITY_SYSTEMD_SERVICES + 20
1386                     , update_every
1387                     , RRDSET_TYPE_STACKED
1388             );
1389
1390         }
1391         else
1392             rrdset_next(st_mem_detailed_rss);
1393
1394         if(unlikely(!st_mem_detailed_mapped)) {
1395
1396             st_mem_detailed_mapped = rrdset_create_localhost(
1397                     "services"
1398                     , "mem_mapped"
1399                     , NULL
1400                     , "mem"
1401                     , "services.mem_mapped"
1402                     , "Systemd Services Mapped Memory"
1403                     , "MB"
1404                     , CHART_PRIORITY_SYSTEMD_SERVICES + 30
1405                     , update_every
1406                     , RRDSET_TYPE_STACKED
1407             );
1408
1409         }
1410         else
1411             rrdset_next(st_mem_detailed_mapped);
1412
1413         if(unlikely(!st_mem_detailed_cache)) {
1414
1415             st_mem_detailed_cache = rrdset_create_localhost(
1416                     "services"
1417                     , "mem_cache"
1418                     , NULL
1419                     , "mem"
1420                     , "services.mem_cache"
1421                     , "Systemd Services Cache Memory"
1422                     , "MB"
1423                     , CHART_PRIORITY_SYSTEMD_SERVICES + 40
1424                     , update_every
1425                     , RRDSET_TYPE_STACKED
1426             );
1427
1428         }
1429         else
1430             rrdset_next(st_mem_detailed_cache);
1431
1432         if(unlikely(!st_mem_detailed_writeback)) {
1433
1434             st_mem_detailed_writeback = rrdset_create_localhost(
1435                     "services"
1436                     , "mem_writeback"
1437                     , NULL
1438                     , "mem"
1439                     , "services.mem_writeback"
1440                     , "Systemd Services Writeback Memory"
1441                     , "MB"
1442                     , CHART_PRIORITY_SYSTEMD_SERVICES + 50
1443                     , update_every
1444                     , RRDSET_TYPE_STACKED
1445             );
1446
1447         }
1448         else
1449             rrdset_next(st_mem_detailed_writeback);
1450
1451         if(unlikely(!st_mem_detailed_pgfault)) {
1452
1453             st_mem_detailed_pgfault = rrdset_create_localhost(
1454                     "services"
1455                     , "mem_pgfault"
1456                     , NULL
1457                     , "mem"
1458                     , "services.mem_pgfault"
1459                     , "Systemd Services Memory Minor Page Faults"
1460                     , "MB/s"
1461                     , CHART_PRIORITY_SYSTEMD_SERVICES + 60
1462                     , update_every
1463                     , RRDSET_TYPE_STACKED
1464             );
1465         }
1466         else
1467             rrdset_next(st_mem_detailed_pgfault);
1468
1469         if(unlikely(!st_mem_detailed_pgmajfault)) {
1470
1471             st_mem_detailed_pgmajfault = rrdset_create_localhost(
1472                     "services"
1473                     , "mem_pgmajfault"
1474                     , NULL
1475                     , "mem"
1476                     , "services.mem_pgmajfault"
1477                     , "Systemd Services Memory Major Page Faults"
1478                     , "MB/s"
1479                     , CHART_PRIORITY_SYSTEMD_SERVICES + 70
1480                     , update_every
1481                     , RRDSET_TYPE_STACKED
1482             );
1483
1484         }
1485         else
1486             rrdset_next(st_mem_detailed_pgmajfault);
1487
1488         if(unlikely(!st_mem_detailed_pgpgin)) {
1489
1490             st_mem_detailed_pgpgin = rrdset_create_localhost(
1491                     "services"
1492                     , "mem_pgpgin"
1493                     , NULL
1494                     , "mem"
1495                     , "services.mem_pgpgin"
1496                     , "Systemd Services Memory Charging Activity"
1497                     , "MB/s"
1498                     , CHART_PRIORITY_SYSTEMD_SERVICES + 80
1499                     , update_every
1500                     , RRDSET_TYPE_STACKED
1501             );
1502
1503         }
1504         else
1505             rrdset_next(st_mem_detailed_pgpgin);
1506
1507         if(unlikely(!st_mem_detailed_pgpgout)) {
1508
1509             st_mem_detailed_pgpgout = rrdset_create_localhost(
1510                     "services"
1511                     , "mem_pgpgout"
1512                     , NULL
1513                     , "mem"
1514                     , "services.mem_pgpgout"
1515                     , "Systemd Services Memory Uncharging Activity"
1516                     , "MB/s"
1517                     , CHART_PRIORITY_SYSTEMD_SERVICES + 90
1518                     , update_every
1519                     , RRDSET_TYPE_STACKED
1520             );
1521
1522         }
1523         else
1524             rrdset_next(st_mem_detailed_pgpgout);
1525     }
1526
1527     if(likely(do_mem_failcnt)) {
1528         if(unlikely(!st_mem_failcnt)) {
1529
1530             st_mem_failcnt = rrdset_create_localhost(
1531                     "services"
1532                     , "mem_failcnt"
1533                     , NULL
1534                     , "mem"
1535                     , "services.mem_failcnt"
1536                     , "Systemd Services Memory Limit Failures"
1537                     , "MB"
1538                     , CHART_PRIORITY_SYSTEMD_SERVICES + 110
1539                     , update_every
1540                     , RRDSET_TYPE_STACKED
1541             );
1542
1543         }
1544         else
1545             rrdset_next(st_mem_failcnt);
1546     }
1547
1548     if(likely(do_swap_usage)) {
1549         if(unlikely(!st_swap_usage)) {
1550
1551             st_swap_usage = rrdset_create_localhost(
1552                     "services"
1553                     , "swap_usage"
1554                     , NULL
1555                     , "swap"
1556                     , "services.swap_usage"
1557                     , "Systemd Services Swap Memory Used"
1558                     , "MB"
1559                     , CHART_PRIORITY_SYSTEMD_SERVICES + 100
1560                     , update_every
1561                     , RRDSET_TYPE_STACKED
1562             );
1563
1564         }
1565         else
1566             rrdset_next(st_swap_usage);
1567     }
1568
1569     if(likely(do_io)) {
1570         if(unlikely(!st_io_read)) {
1571
1572             st_io_read = rrdset_create_localhost(
1573                     "services"
1574                     , "io_read"
1575                     , NULL
1576                     , "disk"
1577                     , "services.io_read"
1578                     , "Systemd Services Disk Read Bandwidth"
1579                     , "KB/s"
1580                     , CHART_PRIORITY_SYSTEMD_SERVICES + 120
1581                     , update_every
1582                     , RRDSET_TYPE_STACKED
1583             );
1584
1585         }
1586         else
1587             rrdset_next(st_io_read);
1588
1589         if(unlikely(!st_io_write)) {
1590
1591             st_io_write = rrdset_create_localhost(
1592                     "services"
1593                     , "io_write"
1594                     , NULL
1595                     , "disk"
1596                     , "services.io_write"
1597                     , "Systemd Services Disk Write Bandwidth"
1598                     , "KB/s"
1599                     , CHART_PRIORITY_SYSTEMD_SERVICES + 130
1600                     , update_every
1601                     , RRDSET_TYPE_STACKED
1602             );
1603
1604         }
1605         else
1606             rrdset_next(st_io_write);
1607     }
1608
1609     if(likely(do_io_ops)) {
1610         if(unlikely(!st_io_serviced_read)) {
1611
1612             st_io_serviced_read = rrdset_create_localhost(
1613                     "services"
1614                     , "io_ops_read"
1615                     , NULL
1616                     , "disk"
1617                     , "services.io_ops_read"
1618                     , "Systemd Services Disk Read Operations"
1619                     , "operations/s"
1620                     , CHART_PRIORITY_SYSTEMD_SERVICES + 140
1621                     , update_every
1622                     , RRDSET_TYPE_STACKED
1623             );
1624
1625         }
1626         else
1627             rrdset_next(st_io_serviced_read);
1628
1629         if(unlikely(!st_io_serviced_write)) {
1630
1631             st_io_serviced_write = rrdset_create_localhost(
1632                     "services"
1633                     , "io_ops_write"
1634                     , NULL
1635                     , "disk"
1636                     , "services.io_ops_write"
1637                     , "Systemd Services Disk Write Operations"
1638                     , "operations/s"
1639                     , CHART_PRIORITY_SYSTEMD_SERVICES + 150
1640                     , update_every
1641                     , RRDSET_TYPE_STACKED
1642             );
1643
1644         }
1645         else
1646             rrdset_next(st_io_serviced_write);
1647     }
1648
1649     if(likely(do_throttle_io)) {
1650         if(unlikely(!st_throttle_io_read)) {
1651
1652             st_throttle_io_read = rrdset_create_localhost(
1653                     "services"
1654                     , "throttle_io_read"
1655                     , NULL
1656                     , "disk"
1657                     , "services.throttle_io_read"
1658                     , "Systemd Services Throttle Disk Read Bandwidth"
1659                     , "KB/s"
1660                     , CHART_PRIORITY_SYSTEMD_SERVICES + 160
1661                     , update_every
1662                     , RRDSET_TYPE_STACKED
1663             );
1664
1665         }
1666         else
1667             rrdset_next(st_throttle_io_read);
1668
1669         if(unlikely(!st_throttle_io_write)) {
1670
1671             st_throttle_io_write = rrdset_create_localhost(
1672                     "services"
1673                     , "throttle_io_write"
1674                     , NULL
1675                     , "disk"
1676                     , "services.throttle_io_write"
1677                     , "Systemd Services Throttle Disk Write Bandwidth"
1678                     , "KB/s"
1679                     , CHART_PRIORITY_SYSTEMD_SERVICES + 170
1680                     , update_every
1681                     , RRDSET_TYPE_STACKED
1682             );
1683
1684         }
1685         else
1686             rrdset_next(st_throttle_io_write);
1687     }
1688
1689     if(likely(do_throttle_ops)) {
1690         if(unlikely(!st_throttle_ops_read)) {
1691
1692             st_throttle_ops_read = rrdset_create_localhost(
1693                     "services"
1694                     , "throttle_io_ops_read"
1695                     , NULL
1696                     , "disk"
1697                     , "services.throttle_io_ops_read"
1698                     , "Systemd Services Throttle Disk Read Operations"
1699                     , "operations/s"
1700                     , CHART_PRIORITY_SYSTEMD_SERVICES + 180
1701                     , update_every
1702                     , RRDSET_TYPE_STACKED
1703             );
1704
1705         }
1706         else
1707             rrdset_next(st_throttle_ops_read);
1708
1709         if(unlikely(!st_throttle_ops_write)) {
1710
1711             st_throttle_ops_write = rrdset_create_localhost(
1712                     "services"
1713                     , "throttle_io_ops_write"
1714                     , NULL
1715                     , "disk"
1716                     , "services.throttle_io_ops_write"
1717                     , "Systemd Services Throttle Disk Write Operations"
1718                     , "operations/s"
1719                     , CHART_PRIORITY_SYSTEMD_SERVICES + 190
1720                     , update_every
1721                     , RRDSET_TYPE_STACKED
1722             );
1723
1724         }
1725         else
1726             rrdset_next(st_throttle_ops_write);
1727     }
1728
1729     if(likely(do_queued_ops)) {
1730         if(unlikely(!st_queued_ops_read)) {
1731
1732             st_queued_ops_read = rrdset_create_localhost(
1733                     "services"
1734                     , "queued_io_ops_read"
1735                     , NULL
1736                     , "disk"
1737                     , "services.queued_io_ops_read"
1738                     , "Systemd Services Queued Disk Read Operations"
1739                     , "operations/s"
1740                     , CHART_PRIORITY_SYSTEMD_SERVICES + 200
1741                     , update_every
1742                     , RRDSET_TYPE_STACKED
1743             );
1744
1745         }
1746         else
1747             rrdset_next(st_queued_ops_read);
1748
1749         if(unlikely(!st_queued_ops_write)) {
1750
1751             st_queued_ops_write = rrdset_create_localhost(
1752                     "services"
1753                     , "queued_io_ops_write"
1754                     , NULL
1755                     , "disk"
1756                     , "services.queued_io_ops_write"
1757                     , "Systemd Services Queued Disk Write Operations"
1758                     , "operations/s"
1759                     , CHART_PRIORITY_SYSTEMD_SERVICES + 210
1760                     , update_every
1761                     , RRDSET_TYPE_STACKED
1762             );
1763
1764         }
1765         else
1766             rrdset_next(st_queued_ops_write);
1767     }
1768
1769     if(likely(do_merged_ops)) {
1770         if(unlikely(!st_merged_ops_read)) {
1771
1772             st_merged_ops_read = rrdset_create_localhost(
1773                     "services"
1774                     , "merged_io_ops_read"
1775                     , NULL
1776                     , "disk"
1777                     , "services.merged_io_ops_read"
1778                     , "Systemd Services Merged Disk Read Operations"
1779                     , "operations/s"
1780                     , CHART_PRIORITY_SYSTEMD_SERVICES + 220
1781                     , update_every
1782                     , RRDSET_TYPE_STACKED
1783             );
1784
1785         }
1786         else
1787             rrdset_next(st_merged_ops_read);
1788
1789         if(unlikely(!st_merged_ops_write)) {
1790
1791             st_merged_ops_write = rrdset_create_localhost(
1792                     "services"
1793                     , "merged_io_ops_write"
1794                     , NULL
1795                     , "disk"
1796                     , "services.merged_io_ops_write"
1797                     , "Systemd Services Merged Disk Write Operations"
1798                     , "operations/s"
1799                     , CHART_PRIORITY_SYSTEMD_SERVICES + 230
1800                     , update_every
1801                     , RRDSET_TYPE_STACKED
1802             );
1803
1804         }
1805         else
1806             rrdset_next(st_merged_ops_write);
1807     }
1808
1809     // update the values
1810     struct cgroup *cg;
1811     for(cg = cgroup_root; cg ; cg = cg->next) {
1812         if(unlikely(!cg->available || !cg->enabled || !(cg->options & CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE)))
1813             continue;
1814
1815         if(likely(do_cpu && cg->cpuacct_stat.updated)) {
1816             if(unlikely(!cg->rd_cpu))
1817                 cg->rd_cpu = rrddim_add(st_cpu, cg->chart_id, cg->chart_title, 100, hz, RRD_ALGORITHM_INCREMENTAL);
1818
1819             rrddim_set_by_pointer(st_cpu, cg->rd_cpu, cg->cpuacct_stat.user + cg->cpuacct_stat.system);
1820         }
1821
1822         if(likely(do_mem_usage && cg->memory.updated_usage_in_bytes)) {
1823             if(unlikely(!cg->rd_mem_usage))
1824                 cg->rd_mem_usage = rrddim_add(st_mem_usage, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1825
1826             rrddim_set_by_pointer(st_mem_usage, cg->rd_mem_usage, cg->memory.usage_in_bytes - ((cgroup_used_memory_without_cache)?cg->memory.cache:0));
1827         }
1828
1829         if(likely(do_mem_detailed && cg->memory.updated_detailed)) {
1830             if(unlikely(!cg->rd_mem_detailed_rss))
1831                 cg->rd_mem_detailed_rss = rrddim_add(st_mem_detailed_rss, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1832
1833             rrddim_set_by_pointer(st_mem_detailed_rss, cg->rd_mem_detailed_rss, cg->memory.rss + cg->memory.rss_huge);
1834
1835             if(unlikely(!cg->rd_mem_detailed_mapped))
1836                 cg->rd_mem_detailed_mapped = rrddim_add(st_mem_detailed_mapped, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1837
1838             rrddim_set_by_pointer(st_mem_detailed_mapped, cg->rd_mem_detailed_mapped, cg->memory.mapped_file);
1839
1840             if(unlikely(!cg->rd_mem_detailed_cache))
1841                 cg->rd_mem_detailed_cache = rrddim_add(st_mem_detailed_cache, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1842
1843             rrddim_set_by_pointer(st_mem_detailed_cache, cg->rd_mem_detailed_cache, cg->memory.cache);
1844
1845             if(unlikely(!cg->rd_mem_detailed_writeback))
1846                 cg->rd_mem_detailed_writeback = rrddim_add(st_mem_detailed_writeback, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1847
1848             rrddim_set_by_pointer(st_mem_detailed_writeback, cg->rd_mem_detailed_writeback, cg->memory.writeback);
1849
1850             if(unlikely(!cg->rd_mem_detailed_pgfault))
1851                 cg->rd_mem_detailed_pgfault = rrddim_add(st_mem_detailed_pgfault, cg->chart_id, cg->chart_title, system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
1852
1853             rrddim_set_by_pointer(st_mem_detailed_pgfault, cg->rd_mem_detailed_pgfault, cg->memory.pgfault);
1854
1855             if(unlikely(!cg->rd_mem_detailed_pgmajfault))
1856                 cg->rd_mem_detailed_pgmajfault = rrddim_add(st_mem_detailed_pgmajfault, cg->chart_id, cg->chart_title, system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
1857
1858             rrddim_set_by_pointer(st_mem_detailed_pgmajfault, cg->rd_mem_detailed_pgmajfault, cg->memory.pgmajfault);
1859
1860             if(unlikely(!cg->rd_mem_detailed_pgpgin))
1861                 cg->rd_mem_detailed_pgpgin = rrddim_add(st_mem_detailed_pgpgin, cg->chart_id, cg->chart_title, system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
1862
1863             rrddim_set_by_pointer(st_mem_detailed_pgpgin, cg->rd_mem_detailed_pgpgin, cg->memory.pgpgin);
1864
1865             if(unlikely(!cg->rd_mem_detailed_pgpgout))
1866                 cg->rd_mem_detailed_pgpgout = rrddim_add(st_mem_detailed_pgpgout, cg->chart_id, cg->chart_title, system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
1867
1868             rrddim_set_by_pointer(st_mem_detailed_pgpgout, cg->rd_mem_detailed_pgpgout, cg->memory.pgpgout);
1869         }
1870
1871         if(likely(do_mem_failcnt && cg->memory.updated_failcnt)) {
1872             if(unlikely(!cg->rd_mem_failcnt))
1873                 cg->rd_mem_failcnt = rrddim_add(st_mem_failcnt, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1874
1875             rrddim_set_by_pointer(st_mem_failcnt, cg->rd_mem_failcnt, cg->memory.failcnt);
1876         }
1877
1878         if(likely(do_swap_usage && cg->memory.updated_msw_usage_in_bytes)) {
1879             if(unlikely(!cg->rd_swap_usage))
1880                 cg->rd_swap_usage = rrddim_add(st_swap_usage, cg->chart_id, cg->chart_title, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
1881
1882             rrddim_set_by_pointer(st_swap_usage, cg->rd_swap_usage, cg->memory.msw_usage_in_bytes);
1883         }
1884
1885         if(likely(do_io && cg->io_service_bytes.updated)) {
1886             if(unlikely(!cg->rd_io_service_bytes_read))
1887                 cg->rd_io_service_bytes_read = rrddim_add(st_io_read, cg->chart_id, cg->chart_title, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
1888
1889             rrddim_set_by_pointer(st_io_read, cg->rd_io_service_bytes_read, cg->io_service_bytes.Read);
1890
1891             if(unlikely(!cg->rd_io_service_bytes_write))
1892                 cg->rd_io_service_bytes_write = rrddim_add(st_io_write, cg->chart_id, cg->chart_title, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
1893
1894             rrddim_set_by_pointer(st_io_write, cg->rd_io_service_bytes_write, cg->io_service_bytes.Write);
1895         }
1896
1897         if(likely(do_io_ops && cg->io_serviced.updated)) {
1898             if(unlikely(!cg->rd_io_serviced_read))
1899                 cg->rd_io_serviced_read = rrddim_add(st_io_serviced_read, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1900
1901             rrddim_set_by_pointer(st_io_serviced_read, cg->rd_io_serviced_read, cg->io_serviced.Read);
1902
1903             if(unlikely(!cg->rd_io_serviced_write))
1904                 cg->rd_io_serviced_write = rrddim_add(st_io_serviced_write, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1905
1906             rrddim_set_by_pointer(st_io_serviced_write, cg->rd_io_serviced_write, cg->io_serviced.Write);
1907         }
1908
1909         if(likely(do_throttle_io && cg->throttle_io_service_bytes.updated)) {
1910             if(unlikely(!cg->rd_throttle_io_read))
1911                 cg->rd_throttle_io_read = rrddim_add(st_throttle_io_read, cg->chart_id, cg->chart_title, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
1912
1913             rrddim_set_by_pointer(st_throttle_io_read, cg->rd_throttle_io_read, cg->throttle_io_service_bytes.Read);
1914
1915             if(unlikely(!cg->rd_throttle_io_write))
1916                 cg->rd_throttle_io_write = rrddim_add(st_throttle_io_write, cg->chart_id, cg->chart_title, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
1917
1918             rrddim_set_by_pointer(st_throttle_io_write, cg->rd_throttle_io_write, cg->throttle_io_service_bytes.Write);
1919         }
1920
1921         if(likely(do_throttle_ops && cg->throttle_io_serviced.updated)) {
1922             if(unlikely(!cg->rd_throttle_io_serviced_read))
1923                 cg->rd_throttle_io_serviced_read = rrddim_add(st_throttle_ops_read, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1924
1925             rrddim_set_by_pointer(st_throttle_ops_read, cg->rd_throttle_io_serviced_read, cg->throttle_io_serviced.Read);
1926
1927             if(unlikely(!cg->rd_throttle_io_serviced_write))
1928                 cg->rd_throttle_io_serviced_write = rrddim_add(st_throttle_ops_write, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1929
1930             rrddim_set_by_pointer(st_throttle_ops_write, cg->rd_throttle_io_serviced_write, cg->throttle_io_serviced.Write);
1931         }
1932
1933         if(likely(do_queued_ops && cg->io_queued.updated)) {
1934             if(unlikely(!cg->rd_io_queued_read))
1935                 cg->rd_io_queued_read = rrddim_add(st_queued_ops_read, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1936
1937             rrddim_set_by_pointer(st_queued_ops_read, cg->rd_io_queued_read, cg->io_queued.Read);
1938
1939             if(unlikely(!cg->rd_io_queued_write))
1940                 cg->rd_io_queued_write = rrddim_add(st_queued_ops_write, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1941
1942             rrddim_set_by_pointer(st_queued_ops_write, cg->rd_io_queued_write, cg->io_queued.Write);
1943         }
1944
1945         if(likely(do_merged_ops && cg->io_merged.updated)) {
1946             if(unlikely(!cg->rd_io_merged_read))
1947                 cg->rd_io_merged_read = rrddim_add(st_merged_ops_read, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1948
1949             rrddim_set_by_pointer(st_merged_ops_read, cg->rd_io_merged_read, cg->io_merged.Read);
1950
1951             if(unlikely(!cg->rd_io_merged_write))
1952                 cg->rd_io_merged_write = rrddim_add(st_merged_ops_write, cg->chart_id, cg->chart_title, 1, 1, RRD_ALGORITHM_INCREMENTAL);
1953
1954             rrddim_set_by_pointer(st_merged_ops_write, cg->rd_io_merged_write, cg->io_merged.Write);
1955         }
1956     }
1957
1958     // complete the iteration
1959     if(likely(do_cpu))
1960         rrdset_done(st_cpu);
1961
1962     if(likely(do_mem_usage))
1963         rrdset_done(st_mem_usage);
1964
1965     if(unlikely(do_mem_detailed)) {
1966         rrdset_done(st_mem_detailed_cache);
1967         rrdset_done(st_mem_detailed_rss);
1968         rrdset_done(st_mem_detailed_mapped);
1969         rrdset_done(st_mem_detailed_writeback);
1970         rrdset_done(st_mem_detailed_pgfault);
1971         rrdset_done(st_mem_detailed_pgmajfault);
1972         rrdset_done(st_mem_detailed_pgpgin);
1973         rrdset_done(st_mem_detailed_pgpgout);
1974     }
1975
1976     if(likely(do_mem_failcnt))
1977         rrdset_done(st_mem_failcnt);
1978
1979     if(likely(do_swap_usage))
1980         rrdset_done(st_swap_usage);
1981
1982     if(likely(do_io)) {
1983         rrdset_done(st_io_read);
1984         rrdset_done(st_io_write);
1985     }
1986
1987     if(likely(do_io_ops)) {
1988         rrdset_done(st_io_serviced_read);
1989         rrdset_done(st_io_serviced_write);
1990     }
1991
1992     if(likely(do_throttle_io)) {
1993         rrdset_done(st_throttle_io_read);
1994         rrdset_done(st_throttle_io_write);
1995     }
1996
1997     if(likely(do_throttle_ops)) {
1998         rrdset_done(st_throttle_ops_read);
1999         rrdset_done(st_throttle_ops_write);
2000     }
2001
2002     if(likely(do_queued_ops)) {
2003         rrdset_done(st_queued_ops_read);
2004         rrdset_done(st_queued_ops_write);
2005     }
2006
2007     if(likely(do_merged_ops)) {
2008         rrdset_done(st_merged_ops_read);
2009         rrdset_done(st_merged_ops_write);
2010     }
2011 }
2012
2013 static inline char *cgroup_chart_type(char *buffer, const char *id, size_t len) {
2014     if(buffer[0]) return buffer;
2015
2016     if(id[0] == '\0' || (id[0] == '/' && id[1] == '\0'))
2017         strncpy(buffer, "cgroup_root", len);
2018     else
2019         snprintfz(buffer, len, "cgroup_%s", id);
2020
2021     netdata_fix_chart_id(buffer);
2022     return buffer;
2023 }
2024
2025 void update_cgroup_charts(int update_every) {
2026     debug(D_CGROUP, "updating cgroups charts");
2027
2028     char type[RRD_ID_LENGTH_MAX + 1];
2029     char title[CHART_TITLE_MAX + 1];
2030
2031     int services_do_cpu = 0,
2032             services_do_mem_usage = 0,
2033             services_do_mem_detailed = 0,
2034             services_do_mem_failcnt = 0,
2035             services_do_swap_usage = 0,
2036             services_do_io = 0,
2037             services_do_io_ops = 0,
2038             services_do_throttle_io = 0,
2039             services_do_throttle_ops = 0,
2040             services_do_queued_ops = 0,
2041             services_do_merged_ops = 0;
2042
2043     struct cgroup *cg;
2044     for(cg = cgroup_root; cg ; cg = cg->next) {
2045         if(unlikely(!cg->available || !cg->enabled))
2046             continue;
2047
2048         if(likely(cgroup_enable_systemd_services && cg->options & CGROUP_OPTIONS_SYSTEM_SLICE_SERVICE)) {
2049             if(cg->cpuacct_stat.updated && cg->cpuacct_stat.enabled == CONFIG_BOOLEAN_YES) services_do_cpu++;
2050
2051             if(cgroup_enable_systemd_services_detailed_memory && cg->memory.updated_detailed && cg->memory.enabled_detailed) services_do_mem_detailed++;
2052             if(cg->memory.updated_usage_in_bytes && cg->memory.enabled_usage_in_bytes == CONFIG_BOOLEAN_YES) services_do_mem_usage++;
2053             if(cg->memory.updated_failcnt && cg->memory.enabled_failcnt == CONFIG_BOOLEAN_YES) services_do_mem_failcnt++;
2054             if(cg->memory.updated_msw_usage_in_bytes && cg->memory.enabled_msw_usage_in_bytes == CONFIG_BOOLEAN_YES) services_do_swap_usage++;
2055
2056             if(cg->io_service_bytes.updated && cg->io_service_bytes.enabled == CONFIG_BOOLEAN_YES) services_do_io++;
2057             if(cg->io_serviced.updated && cg->io_serviced.enabled == CONFIG_BOOLEAN_YES) services_do_io_ops++;
2058             if(cg->throttle_io_service_bytes.updated && cg->throttle_io_service_bytes.enabled == CONFIG_BOOLEAN_YES) services_do_throttle_io++;
2059             if(cg->throttle_io_serviced.updated && cg->throttle_io_serviced.enabled == CONFIG_BOOLEAN_YES) services_do_throttle_ops++;
2060             if(cg->io_queued.updated && cg->io_queued.enabled == CONFIG_BOOLEAN_YES) services_do_queued_ops++;
2061             if(cg->io_merged.updated && cg->io_merged.enabled == CONFIG_BOOLEAN_YES) services_do_merged_ops++;
2062             continue;
2063         }
2064
2065         type[0] = '\0';
2066
2067         if(likely(cg->cpuacct_stat.updated && cg->cpuacct_stat.enabled == CONFIG_BOOLEAN_YES)) {
2068             if(unlikely(!cg->st_cpu)) {
2069                 snprintfz(title, CHART_TITLE_MAX, "CPU Usage (%d%% = %d core%s) for cgroup %s", (processors * 100), processors, (processors > 1) ? "s" : "", cg->chart_title);
2070
2071                 cg->st_cpu = rrdset_create_localhost(
2072                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2073                         , "cpu"
2074                         , NULL
2075                         , "cpu"
2076                         , "cgroup.cpu"
2077                         , title
2078                         , "%"
2079                         , CHART_PRIORITY_CONTAINERS
2080                         , update_every
2081                         , RRDSET_TYPE_STACKED
2082                 );
2083
2084                 rrddim_add(cg->st_cpu, "user", NULL, 100, hz, RRD_ALGORITHM_INCREMENTAL);
2085                 rrddim_add(cg->st_cpu, "system", NULL, 100, hz, RRD_ALGORITHM_INCREMENTAL);
2086             }
2087             else
2088                 rrdset_next(cg->st_cpu);
2089
2090             rrddim_set(cg->st_cpu, "user", cg->cpuacct_stat.user);
2091             rrddim_set(cg->st_cpu, "system", cg->cpuacct_stat.system);
2092             rrdset_done(cg->st_cpu);
2093         }
2094
2095         if(likely(cg->cpuacct_usage.updated && cg->cpuacct_usage.enabled == CONFIG_BOOLEAN_YES)) {
2096             char id[RRD_ID_LENGTH_MAX + 1];
2097             unsigned int i;
2098
2099             if(unlikely(!cg->st_cpu_per_core)) {
2100                 snprintfz(title, CHART_TITLE_MAX, "CPU Usage (%d%% = %d core%s) Per Core for cgroup %s", (processors * 100), processors, (processors > 1) ? "s" : "", cg->chart_title);
2101
2102                 cg->st_cpu_per_core = rrdset_create_localhost(
2103                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2104                         , "cpu_per_core"
2105                         , NULL
2106                         , "cpu"
2107                         , "cgroup.cpu_per_core"
2108                         , title
2109                         , "%"
2110                         , CHART_PRIORITY_CONTAINERS + 100
2111                         , update_every
2112                         , RRDSET_TYPE_STACKED
2113                 );
2114
2115                 for(i = 0; i < cg->cpuacct_usage.cpus; i++) {
2116                     snprintfz(id, CHART_TITLE_MAX, "cpu%u", i);
2117                     rrddim_add(cg->st_cpu_per_core, id, NULL, 100, 1000000000, RRD_ALGORITHM_INCREMENTAL);
2118                 }
2119             }
2120             else
2121                 rrdset_next(cg->st_cpu_per_core);
2122
2123             for(i = 0; i < cg->cpuacct_usage.cpus ;i++) {
2124                 snprintfz(id, CHART_TITLE_MAX, "cpu%u", i);
2125                 rrddim_set(cg->st_cpu_per_core, id, cg->cpuacct_usage.cpu_percpu[i]);
2126             }
2127             rrdset_done(cg->st_cpu_per_core);
2128         }
2129
2130         if(likely(cg->memory.updated_detailed && cg->memory.enabled_detailed == CONFIG_BOOLEAN_YES)) {
2131             if(unlikely(!cg->st_mem)) {
2132                 snprintfz(title, CHART_TITLE_MAX, "Memory Usage for cgroup %s", cg->chart_title);
2133
2134                 cg->st_mem = rrdset_create_localhost(
2135                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2136                         , "mem"
2137                         , NULL
2138                         , "mem"
2139                         , "cgroup.mem"
2140                         , title
2141                         , "MB"
2142                         , CHART_PRIORITY_CONTAINERS + 210
2143                         , update_every
2144                         , RRDSET_TYPE_STACKED
2145                 );
2146
2147                 rrddim_add(cg->st_mem, "cache", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2148                 rrddim_add(cg->st_mem, "rss", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2149
2150                 if(cg->memory.detailed_has_swap)
2151                     rrddim_add(cg->st_mem, "swap", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2152
2153                 rrddim_add(cg->st_mem, "rss_huge", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2154                 rrddim_add(cg->st_mem, "mapped_file", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2155             }
2156             else
2157                 rrdset_next(cg->st_mem);
2158
2159             rrddim_set(cg->st_mem, "cache", cg->memory.cache);
2160             rrddim_set(cg->st_mem, "rss", cg->memory.rss);
2161
2162             if(cg->memory.detailed_has_swap)
2163                 rrddim_set(cg->st_mem, "swap", cg->memory.swap);
2164
2165             rrddim_set(cg->st_mem, "rss_huge", cg->memory.rss_huge);
2166             rrddim_set(cg->st_mem, "mapped_file", cg->memory.mapped_file);
2167             rrdset_done(cg->st_mem);
2168
2169             if(unlikely(!cg->st_writeback)) {
2170                 snprintfz(title, CHART_TITLE_MAX, "Writeback Memory for cgroup %s", cg->chart_title);
2171
2172                 cg->st_writeback = rrdset_create_localhost(
2173                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2174                         , "writeback"
2175                         , NULL
2176                         , "mem"
2177                         , "cgroup.writeback"
2178                         , title
2179                         , "MB"
2180                         , CHART_PRIORITY_CONTAINERS + 300
2181                         , update_every
2182                         , RRDSET_TYPE_AREA
2183                 );
2184
2185                 if(cg->memory.detailed_has_dirty)
2186                     rrddim_add(cg->st_writeback, "dirty", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2187
2188                 rrddim_add(cg->st_writeback, "writeback", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2189             }
2190             else
2191                 rrdset_next(cg->st_writeback);
2192
2193             if(cg->memory.detailed_has_dirty)
2194                 rrddim_set(cg->st_writeback, "dirty", cg->memory.dirty);
2195
2196             rrddim_set(cg->st_writeback, "writeback", cg->memory.writeback);
2197             rrdset_done(cg->st_writeback);
2198
2199             if(unlikely(!cg->st_mem_activity)) {
2200                 snprintfz(title, CHART_TITLE_MAX, "Memory Activity for cgroup %s", cg->chart_title);
2201
2202                 cg->st_mem_activity = rrdset_create_localhost(
2203                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2204                         , "mem_activity"
2205                         , NULL
2206                         , "mem"
2207                         , "cgroup.mem_activity"
2208                         , title
2209                         , "MB/s"
2210                         , CHART_PRIORITY_CONTAINERS + 400
2211                         , update_every
2212                         , RRDSET_TYPE_LINE
2213                 );
2214
2215                 rrddim_add(cg->st_mem_activity, "pgpgin", "in", system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
2216                 rrddim_add(cg->st_mem_activity, "pgpgout", "out", -system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
2217             }
2218             else
2219                 rrdset_next(cg->st_mem_activity);
2220
2221             rrddim_set(cg->st_mem_activity, "pgpgin", cg->memory.pgpgin);
2222             rrddim_set(cg->st_mem_activity, "pgpgout", cg->memory.pgpgout);
2223             rrdset_done(cg->st_mem_activity);
2224
2225             if(unlikely(!cg->st_pgfaults)) {
2226                 snprintfz(title, CHART_TITLE_MAX, "Memory Page Faults for cgroup %s", cg->chart_title);
2227
2228                 cg->st_pgfaults = rrdset_create_localhost(
2229                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2230                         , "pgfaults"
2231                         , NULL
2232                         , "mem"
2233                         , "cgroup.pgfaults"
2234                         , title
2235                         , "MB/s"
2236                         , CHART_PRIORITY_CONTAINERS + 500
2237                         , update_every
2238                         , RRDSET_TYPE_LINE
2239                 );
2240
2241                 rrddim_add(cg->st_pgfaults, "pgfault", NULL, system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
2242                 rrddim_add(cg->st_pgfaults, "pgmajfault", "swap", -system_page_size, 1024 * 1024, RRD_ALGORITHM_INCREMENTAL);
2243             }
2244             else
2245                 rrdset_next(cg->st_pgfaults);
2246
2247             rrddim_set(cg->st_pgfaults, "pgfault", cg->memory.pgfault);
2248             rrddim_set(cg->st_pgfaults, "pgmajfault", cg->memory.pgmajfault);
2249             rrdset_done(cg->st_pgfaults);
2250         }
2251
2252         if(likely(cg->memory.updated_usage_in_bytes && cg->memory.enabled_usage_in_bytes == CONFIG_BOOLEAN_YES)) {
2253             if(unlikely(!cg->st_mem_usage)) {
2254                 snprintfz(title, CHART_TITLE_MAX, "Used Memory %sfor cgroup %s", (cgroup_used_memory_without_cache && cg->memory.updated_detailed)?"without Cache ":"", cg->chart_title);
2255
2256                 cg->st_mem_usage = rrdset_create_localhost(
2257                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2258                         , "mem_usage"
2259                         , NULL
2260                         , "mem"
2261                         , "cgroup.mem_usage"
2262                         , title
2263                         , "MB"
2264                         , CHART_PRIORITY_CONTAINERS + 200
2265                         , update_every
2266                         , RRDSET_TYPE_STACKED
2267                 );
2268
2269                 rrddim_add(cg->st_mem_usage, "ram", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2270                 rrddim_add(cg->st_mem_usage, "swap", NULL, 1, 1024 * 1024, RRD_ALGORITHM_ABSOLUTE);
2271             }
2272             else
2273                 rrdset_next(cg->st_mem_usage);
2274
2275             rrddim_set(cg->st_mem_usage, "ram", cg->memory.usage_in_bytes - ((cgroup_used_memory_without_cache)?cg->memory.cache:0));
2276             rrddim_set(cg->st_mem_usage, "swap", (cg->memory.msw_usage_in_bytes > cg->memory.usage_in_bytes)?cg->memory.msw_usage_in_bytes - cg->memory.usage_in_bytes:0);
2277             rrdset_done(cg->st_mem_usage);
2278         }
2279
2280         if(likely(cg->memory.updated_failcnt && cg->memory.enabled_failcnt == CONFIG_BOOLEAN_YES)) {
2281             if(unlikely(!cg->st_mem_failcnt)) {
2282                 snprintfz(title, CHART_TITLE_MAX, "Memory Limit Failures for cgroup %s", cg->chart_title);
2283
2284                 cg->st_mem_failcnt = rrdset_create_localhost(
2285                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2286                         , "mem_failcnt"
2287                         , NULL
2288                         , "mem"
2289                         , "cgroup.mem_failcnt"
2290                         , title
2291                         , "count"
2292                         , CHART_PRIORITY_CONTAINERS + 250
2293                         , update_every
2294                         , RRDSET_TYPE_LINE
2295                 );
2296
2297                 rrddim_add(cg->st_mem_failcnt, "failures", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2298             }
2299             else
2300                 rrdset_next(cg->st_mem_failcnt);
2301
2302             rrddim_set(cg->st_mem_failcnt, "failures", cg->memory.failcnt);
2303             rrdset_done(cg->st_mem_failcnt);
2304         }
2305
2306         if(likely(cg->io_service_bytes.updated && cg->io_service_bytes.enabled == CONFIG_BOOLEAN_YES)) {
2307             if(unlikely(!cg->st_io)) {
2308                 snprintfz(title, CHART_TITLE_MAX, "I/O Bandwidth (all disks) for cgroup %s", cg->chart_title);
2309
2310                 cg->st_io = rrdset_create_localhost(
2311                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2312                         , "io"
2313                         , NULL
2314                         , "disk"
2315                         , "cgroup.io"
2316                         , title
2317                         , "KB/s"
2318                         , CHART_PRIORITY_CONTAINERS + 1200
2319                         , update_every
2320                         , RRDSET_TYPE_AREA
2321                 );
2322
2323                 rrddim_add(cg->st_io, "read", NULL, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
2324                 rrddim_add(cg->st_io, "write", NULL, -1, 1024, RRD_ALGORITHM_INCREMENTAL);
2325             }
2326             else
2327                 rrdset_next(cg->st_io);
2328
2329             rrddim_set(cg->st_io, "read", cg->io_service_bytes.Read);
2330             rrddim_set(cg->st_io, "write", cg->io_service_bytes.Write);
2331             rrdset_done(cg->st_io);
2332         }
2333
2334         if(likely(cg->io_serviced.updated && cg->io_serviced.enabled == CONFIG_BOOLEAN_YES)) {
2335             if(unlikely(!cg->st_serviced_ops)) {
2336                 snprintfz(title, CHART_TITLE_MAX, "Serviced I/O Operations (all disks) for cgroup %s", cg->chart_title);
2337
2338                 cg->st_serviced_ops = rrdset_create_localhost(
2339                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2340                         , "serviced_ops"
2341                         , NULL
2342                         , "disk"
2343                         , "cgroup.serviced_ops"
2344                         , title
2345                         , "operations/s"
2346                         , CHART_PRIORITY_CONTAINERS + 1200
2347                         , update_every
2348                         , RRDSET_TYPE_LINE
2349                 );
2350
2351                 rrddim_add(cg->st_serviced_ops, "read", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2352                 rrddim_add(cg->st_serviced_ops, "write", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2353             }
2354             else
2355                 rrdset_next(cg->st_serviced_ops);
2356
2357             rrddim_set(cg->st_serviced_ops, "read", cg->io_serviced.Read);
2358             rrddim_set(cg->st_serviced_ops, "write", cg->io_serviced.Write);
2359             rrdset_done(cg->st_serviced_ops);
2360         }
2361
2362         if(likely(cg->throttle_io_service_bytes.updated && cg->throttle_io_service_bytes.enabled == CONFIG_BOOLEAN_YES)) {
2363             if(unlikely(!cg->st_throttle_io)) {
2364                 snprintfz(title, CHART_TITLE_MAX, "Throttle I/O Bandwidth (all disks) for cgroup %s", cg->chart_title);
2365
2366                 cg->st_throttle_io = rrdset_create_localhost(
2367                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2368                         , "throttle_io"
2369                         , NULL
2370                         , "disk"
2371                         , "cgroup.throttle_io"
2372                         , title
2373                         , "KB/s"
2374                         , CHART_PRIORITY_CONTAINERS + 1200
2375                         , update_every
2376                         , RRDSET_TYPE_AREA
2377                 );
2378
2379                 rrddim_add(cg->st_throttle_io, "read", NULL, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
2380                 rrddim_add(cg->st_throttle_io, "write", NULL, -1, 1024, RRD_ALGORITHM_INCREMENTAL);
2381             }
2382             else
2383                 rrdset_next(cg->st_throttle_io);
2384
2385             rrddim_set(cg->st_throttle_io, "read", cg->throttle_io_service_bytes.Read);
2386             rrddim_set(cg->st_throttle_io, "write", cg->throttle_io_service_bytes.Write);
2387             rrdset_done(cg->st_throttle_io);
2388         }
2389
2390         if(likely(cg->throttle_io_serviced.updated && cg->throttle_io_serviced.enabled == CONFIG_BOOLEAN_YES)) {
2391             if(unlikely(!cg->st_throttle_serviced_ops)) {
2392                 snprintfz(title, CHART_TITLE_MAX, "Throttle Serviced I/O Operations (all disks) for cgroup %s", cg->chart_title);
2393
2394                 cg->st_throttle_serviced_ops = rrdset_create_localhost(
2395                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2396                         , "throttle_serviced_ops"
2397                         , NULL
2398                         , "disk"
2399                         , "cgroup.throttle_serviced_ops"
2400                         , title
2401                         , "operations/s"
2402                         , CHART_PRIORITY_CONTAINERS + 1200
2403                         , update_every
2404                         , RRDSET_TYPE_LINE
2405                 );
2406
2407                 rrddim_add(cg->st_throttle_serviced_ops, "read", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
2408                 rrddim_add(cg->st_throttle_serviced_ops, "write", NULL, -1, 1, RRD_ALGORITHM_INCREMENTAL);
2409             }
2410             else
2411                 rrdset_next(cg->st_throttle_serviced_ops);
2412
2413             rrddim_set(cg->st_throttle_serviced_ops, "read", cg->throttle_io_serviced.Read);
2414             rrddim_set(cg->st_throttle_serviced_ops, "write", cg->throttle_io_serviced.Write);
2415             rrdset_done(cg->st_throttle_serviced_ops);
2416         }
2417
2418         if(likely(cg->io_queued.updated && cg->io_queued.enabled == CONFIG_BOOLEAN_YES)) {
2419             if(unlikely(!cg->st_queued_ops)) {
2420                 snprintfz(title, CHART_TITLE_MAX, "Queued I/O Operations (all disks) for cgroup %s", cg->chart_title);
2421
2422                 cg->st_queued_ops = rrdset_create_localhost(
2423                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2424                         , "queued_ops"
2425                         , NULL
2426                         , "disk"
2427                         , "cgroup.queued_ops"
2428                         , title
2429                         , "operations"
2430                         , CHART_PRIORITY_CONTAINERS + 2000
2431                         , update_every
2432                         , RRDSET_TYPE_LINE
2433                 );
2434
2435                 rrddim_add(cg->st_queued_ops, "read", NULL, 1, 1, RRD_ALGORITHM_ABSOLUTE);
2436                 rrddim_add(cg->st_queued_ops, "write", NULL, -1, 1, RRD_ALGORITHM_ABSOLUTE);
2437             }
2438             else
2439                 rrdset_next(cg->st_queued_ops);
2440
2441             rrddim_set(cg->st_queued_ops, "read", cg->io_queued.Read);
2442             rrddim_set(cg->st_queued_ops, "write", cg->io_queued.Write);
2443             rrdset_done(cg->st_queued_ops);
2444         }
2445
2446         if(likely(cg->io_merged.updated && cg->io_merged.enabled == CONFIG_BOOLEAN_YES)) {
2447             if(unlikely(!cg->st_merged_ops)) {
2448                 snprintfz(title, CHART_TITLE_MAX, "Merged I/O Operations (all disks) for cgroup %s", cg->chart_title);
2449
2450                 cg->st_merged_ops = rrdset_create_localhost(
2451                         cgroup_chart_type(type, cg->chart_id, RRD_ID_LENGTH_MAX)
2452                         , "merged_ops"
2453                         , NULL
2454                         , "disk"
2455                         , "cgroup.merged_ops"
2456                         , title
2457                         , "operations/s"
2458                         , CHART_PRIORITY_CONTAINERS + 2100
2459                         , update_every
2460                         , RRDSET_TYPE_LINE
2461                 );
2462
2463                 rrddim_add(cg->st_merged_ops, "read", NULL, 1, 1024, RRD_ALGORITHM_INCREMENTAL);
2464                 rrddim_add(cg->st_merged_ops, "write", NULL, -1, 1024, RRD_ALGORITHM_INCREMENTAL);
2465             }
2466             else
2467                 rrdset_next(cg->st_merged_ops);
2468
2469             rrddim_set(cg->st_merged_ops, "read", cg->io_merged.Read);
2470             rrddim_set(cg->st_merged_ops, "write", cg->io_merged.Write);
2471             rrdset_done(cg->st_merged_ops);
2472         }
2473     }
2474
2475     if(likely(cgroup_enable_systemd_services))
2476         update_systemd_services_charts(update_every, services_do_cpu, services_do_mem_usage, services_do_mem_detailed
2477                                        , services_do_mem_failcnt, services_do_swap_usage, services_do_io
2478                                        , services_do_io_ops, services_do_throttle_io, services_do_throttle_ops
2479                                        , services_do_queued_ops, services_do_merged_ops
2480         );
2481
2482     debug(D_CGROUP, "done updating cgroups charts");
2483 }
2484
2485 // ----------------------------------------------------------------------------
2486 // cgroups main
2487
2488 void *cgroups_main(void *ptr) {
2489     struct netdata_static_thread *static_thread = (struct netdata_static_thread *)ptr;
2490
2491     info("CGROUP Plugin thread created with task id %d", gettid());
2492
2493     if(pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL) != 0)
2494         error("Cannot set pthread cancel type to DEFERRED.");
2495
2496     if(pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL) != 0)
2497         error("Cannot set pthread cancel state to ENABLE.");
2498
2499     struct rusage thread;
2500
2501     // when ZERO, attempt to do it
2502     int vdo_cpu_netdata = config_get_boolean("plugin:cgroups", "cgroups plugin resource charts", 1);
2503
2504     read_cgroup_plugin_configuration();
2505
2506     RRDSET *stcpu_thread = NULL;
2507
2508     heartbeat_t hb;
2509     heartbeat_init(&hb);
2510     usec_t step = cgroup_update_every * USEC_PER_SEC;
2511     usec_t find_every = cgroup_check_for_new_every * USEC_PER_SEC, find_dt = 0;
2512     for(;;) {
2513         usec_t hb_dt = heartbeat_next(&hb, step);
2514         if(unlikely(netdata_exit)) break;
2515
2516         // BEGIN -- the job to be done
2517
2518         find_dt += hb_dt;
2519         if(unlikely(find_dt >= find_every)) {
2520             find_all_cgroups();
2521             find_dt = 0;
2522         }
2523
2524         read_all_cgroups(cgroup_root);
2525         update_cgroup_charts(cgroup_update_every);
2526
2527         // END -- the job is done
2528
2529         // --------------------------------------------------------------------
2530
2531         if(vdo_cpu_netdata) {
2532             getrusage(RUSAGE_THREAD, &thread);
2533
2534             if(unlikely(!stcpu_thread)) {
2535
2536                 stcpu_thread = rrdset_create_localhost(
2537                         "netdata"
2538                         , "plugin_cgroups_cpu"
2539                         , NULL
2540                         , "cgroups"
2541                         , NULL
2542                         , "NetData CGroups Plugin CPU usage"
2543                         , "milliseconds/s"
2544                         , 132000
2545                         , cgroup_update_every
2546                         , RRDSET_TYPE_STACKED
2547                 );
2548
2549                 rrddim_add(stcpu_thread, "user",  NULL,  1, 1000, RRD_ALGORITHM_INCREMENTAL);
2550                 rrddim_add(stcpu_thread, "system", NULL, 1, 1000, RRD_ALGORITHM_INCREMENTAL);
2551             }
2552             else
2553                 rrdset_next(stcpu_thread);
2554
2555             rrddim_set(stcpu_thread, "user"  , thread.ru_utime.tv_sec * 1000000ULL + thread.ru_utime.tv_usec);
2556             rrddim_set(stcpu_thread, "system", thread.ru_stime.tv_sec * 1000000ULL + thread.ru_stime.tv_usec);
2557             rrdset_done(stcpu_thread);
2558         }
2559     }
2560
2561     info("CGROUP thread exiting");
2562
2563     static_thread->enabled = 0;
2564     pthread_exit(NULL);
2565     return NULL;
2566 }