]> arthur.barton.de Git - netdata.git/blob - src/proc_diskstats.c
diskstats: fix compiler warnings.
[netdata.git] / src / proc_diskstats.c
1 #ifdef HAVE_CONFIG_H
2 #include <config.h>
3 #endif
4 #include <dirent.h>
5 #include <fcntl.h>
6 #include <stdio.h>
7 #include <stdlib.h>
8 #include <string.h>
9 #include <sys/stat.h>
10 #include <sys/statvfs.h>
11 #include <sys/types.h>
12 #include <unistd.h>
13
14
15 #include "common.h"
16 #include "log.h"
17 #include "appconfig.h"
18 #include "procfile.h"
19 #include "rrd.h"
20 #include "plugin_proc.h"
21
22 #include "proc_self_mountinfo.h"
23
24 #define RRD_TYPE_DISK "disk"
25
26 #define DISK_TYPE_PHYSICAL  1
27 #define DISK_TYPE_PARTITION 2
28 #define DISK_TYPE_CONTAINER 3
29
30 struct disk {
31         unsigned long major;
32         unsigned long minor;
33         int type;
34         char *mount_point;
35         struct disk *next;
36 } *disk_root = NULL;
37
38 struct disk *get_disk(unsigned long major, unsigned long minor) {
39         static char path_find_block_device[FILENAME_MAX + 1] = "";
40         static struct mountinfo *mountinfo_root = NULL;
41         struct disk *d;
42
43         // search for it in our RAM list.
44         // this is sequential, but since we just walk through
45         // and the number of disks / partitions in a system
46         // should not be that many, it should be acceptable
47         for(d = disk_root; d ; d = d->next)
48                 if(unlikely(d->major == major && d->minor == minor))
49                         break;
50
51         // if we found it, return it
52         if(likely(d))
53                 return d;
54
55         if(unlikely(!path_find_block_device[0])) {
56                 char dirname[FILENAME_MAX + 1];
57                 snprintfz(dirname, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/dev/block/%lu:%lu/%s");
58                 snprintfz(path_find_block_device, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get block device infos", dirname));
59         }
60
61         // not found
62         // create a new disk structure
63         d = (struct disk *)malloc(sizeof(struct disk));
64         if(!d) fatal("Cannot allocate memory for struct disk in proc_diskstats.");
65
66         d->major = major;
67         d->minor = minor;
68         d->type = DISK_TYPE_PHYSICAL; // Default type. Changed later if not correct.
69         d->next = NULL;
70
71         // append it to the list
72         if(!disk_root)
73                 disk_root = d;
74         else {
75                 struct disk *last;
76                 for(last = disk_root; last->next ;last = last->next);
77                 last->next = d;
78         }
79
80         // ------------------------------------------------------------------------
81         // find the type of the device
82
83         // find if it is a partition
84         // by checking if /sys/dev/block/MAJOR:MINOR/partition is readable.
85         char buffer[FILENAME_MAX + 1];
86         snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "partition");
87         if(access(buffer, R_OK) == 0) {
88                 d->type = DISK_TYPE_PARTITION;
89         } else {
90                 // find if it is a container
91                 // by checking if /sys/dev/block/MAJOR:MINOR/slaves has entries
92                 snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "slaves/");
93                 DIR *dirp = opendir(buffer);    
94                 if (dirp != NULL) {
95                 struct dirent *dp;
96                         while( (dp = readdir(dirp)) ) {
97                                 // . and .. are also files in empty folders.
98                                 if(strcmp(dp->d_name, ".") == 0 || strcmp(dp->d_name, "..") == 0) {
99                                         continue;
100                                 }
101                                 d->type = DISK_TYPE_CONTAINER;
102                                 // Stop the loop after we found one file.
103                                 break;
104                         }
105                         if(closedir(dirp) == -1)
106                                 error("Unable to close dir %s", buffer);
107                 }
108         }
109
110         // ------------------------------------------------------------------------
111         // check if we can find its mount point
112
113         // mountinfo_find() can be called with NULL mountinfo_root
114         struct mountinfo *mi = mountinfo_find(mountinfo_root, d->major, d->minor);
115         if(unlikely(!mi)) {
116                 // mountinfo_free() can be called with NULL mountinfo_root
117                 mountinfo_free(mountinfo_root);
118
119                 // re-read mountinfo in case something changed
120                 mountinfo_root = mountinfo_read();
121
122                 // search again for this disk
123                 mi = mountinfo_find(mountinfo_root, d->major, d->minor);
124         }
125
126         if(mi)
127                 d->mount_point = strdup(mi->mount_point);
128                 // no need to check for NULL
129         else
130                 d->mount_point = NULL;
131
132         return d;
133 }
134
135 int do_proc_diskstats(int update_every, unsigned long long dt) {
136         static procfile *ff = NULL;
137         static char path_to_get_hw_sector_size[FILENAME_MAX + 1] = "";
138         static int enable_autodetection;
139         static int enable_physical_disks, enable_virtual_disks, enable_partitions, enable_mountpoints, enable_space_metrics;
140         static int do_io, do_ops, do_mops, do_iotime, do_qops, do_util, do_backlog, do_space, do_inodes;
141         static struct statvfs buff_statvfs;
142         static struct stat buff_stat;
143
144         enable_autodetection = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "enable new disks detected at runtime", CONFIG_ONDEMAND_ONDEMAND);
145
146         enable_physical_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for physical disks", CONFIG_ONDEMAND_ONDEMAND);
147         enable_virtual_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for virtual disks", CONFIG_ONDEMAND_NO);
148         enable_partitions = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for partitions", CONFIG_ONDEMAND_NO);
149         enable_mountpoints = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for mounted filesystems", CONFIG_ONDEMAND_NO);
150         enable_space_metrics = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space metrics for mounted filesystems", CONFIG_ONDEMAND_ONDEMAND);
151
152         do_io      = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "bandwidth for all disks", CONFIG_ONDEMAND_ONDEMAND);
153         do_ops     = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
154         do_mops    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "merged operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
155         do_iotime  = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "i/o time for all disks", CONFIG_ONDEMAND_ONDEMAND);
156         do_qops    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "queued operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
157         do_util    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "utilization percentage for all disks", CONFIG_ONDEMAND_ONDEMAND);
158         do_backlog = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "backlog for all disks", CONFIG_ONDEMAND_ONDEMAND);
159         do_space   = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space usage for all disks", CONFIG_ONDEMAND_ONDEMAND);
160         do_inodes  = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "inodes usage for all disks", CONFIG_ONDEMAND_ONDEMAND);
161
162         if(!ff) {
163                 char filename[FILENAME_MAX + 1];
164                 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/proc/diskstats");
165                 ff = procfile_open(config_get("plugin:proc:/proc/diskstats", "filename to monitor", filename), " \t", PROCFILE_FLAG_DEFAULT);
166         }
167         if(!ff) return 1;
168
169         if(!path_to_get_hw_sector_size[0]) {
170                 char filename[FILENAME_MAX + 1];
171                 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/block/%s/queue/hw_sector_size");
172                 snprintfz(path_to_get_hw_sector_size, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get h/w sector size", filename));
173         }
174
175         ff = procfile_readall(ff);
176         if(!ff) return 0; // we return 0, so that we will retry to open it next time
177
178         uint32_t lines = procfile_lines(ff), l;
179         uint32_t words;
180
181         for(l = 0; l < lines ;l++) {
182                 // --------------------------------------------------------------------------
183                 // Read parameters
184                 char *disk;
185                 unsigned long long      major = 0, minor = 0,
186                                                         reads = 0,  mreads = 0,  readsectors = 0,  readms = 0,
187                                                         writes = 0, mwrites = 0, writesectors = 0, writems = 0,
188                                                         queued_ios = 0, busy_ms = 0, backlog_ms = 0,
189                                                         space_avail = 0, space_avail_root = 0, space_used = 0,
190                                                         inodes_avail = 0, inodes_avail_root = 0, inodes_used = 0;
191
192                 unsigned long long      last_reads = 0,  last_readsectors = 0,  last_readms = 0,
193                                                         last_writes = 0, last_writesectors = 0, last_writems = 0,
194                                                         last_busy_ms = 0;
195
196                 words = procfile_linewords(ff, l);
197                 if(words < 14) continue;
198
199                 major                   = strtoull(procfile_lineword(ff, l, 0), NULL, 10);
200                 minor                   = strtoull(procfile_lineword(ff, l, 1), NULL, 10);
201                 disk                    = procfile_lineword(ff, l, 2);
202
203                 // # of reads completed # of writes completed
204                 // This is the total number of reads or writes completed successfully.
205                 reads                   = strtoull(procfile_lineword(ff, l, 3), NULL, 10);      // rd_ios
206                 writes                  = strtoull(procfile_lineword(ff, l, 7), NULL, 10);      // wr_ios
207
208                 // # of reads merged # of writes merged
209                 // Reads and writes which are adjacent to each other may be merged for
210             // efficiency.  Thus two 4K reads may become one 8K read before it is
211             // ultimately handed to the disk, and so it will be counted (and queued)
212                 mreads                  = strtoull(procfile_lineword(ff, l, 4), NULL, 10);      // rd_merges_or_rd_sec
213                 mwrites                 = strtoull(procfile_lineword(ff, l, 8), NULL, 10);      // wr_merges
214
215                 // # of sectors read # of sectors written
216                 // This is the total number of sectors read or written successfully.
217                 readsectors     = strtoull(procfile_lineword(ff, l, 5), NULL, 10);      // rd_sec_or_wr_ios
218                 writesectors    = strtoull(procfile_lineword(ff, l, 9), NULL, 10);      // wr_sec
219
220                 // # of milliseconds spent reading # of milliseconds spent writing
221                 // This is the total number of milliseconds spent by all reads or writes (as
222                 // measured from __make_request() to end_that_request_last()).
223                 readms                  = strtoull(procfile_lineword(ff, l, 6), NULL, 10);      // rd_ticks_or_wr_sec
224                 writems                 = strtoull(procfile_lineword(ff, l, 10), NULL, 10);     // wr_ticks
225
226                 // # of I/Os currently in progress
227                 // The only field that should go to zero. Incremented as requests are
228                 // given to appropriate struct request_queue and decremented as they finish.
229                 queued_ios              = strtoull(procfile_lineword(ff, l, 11), NULL, 10);     // ios_pgr
230
231                 // # of milliseconds spent doing I/Os
232                 // This field increases so long as field queued_ios is nonzero.
233                 busy_ms                 = strtoull(procfile_lineword(ff, l, 12), NULL, 10);     // tot_ticks
234
235                 // weighted # of milliseconds spent doing I/Os
236                 // This field is incremented at each I/O start, I/O completion, I/O
237                 // merge, or read of these stats by the number of I/Os in progress
238                 // (field queued_ios) times the number of milliseconds spent doing I/O since the
239                 // last update of this field.  This can provide an easy measure of both
240                 // I/O completion time and the backlog that may be accumulating.
241                 backlog_ms              = strtoull(procfile_lineword(ff, l, 13), NULL, 10);     // rq_ticks
242
243                 // --------------------------------------------------------------------------
244                 // remove slashes from disk names
245                 char *s;
246                 for(s = disk; *s ;s++) if(*s == '/') *s = '_';
247                 struct disk *d = get_disk(major, minor);
248                 // Find mount point and family
249                 char *mount_point = d->mount_point;
250                 char *family = d->mount_point;
251                 if(!family) family = disk;
252
253                 // --------------------------------------------------------------------------
254                 // Check if device is enabled by autodetection or config
255                 int def_enable = -1;
256                 char var_name[4096 + 1];
257                 snprintfz(var_name, 4096, "plugin:proc:/proc/diskstats:%s", disk);
258
259                 if(def_enable == -1) def_enable = config_get_boolean_ondemand(var_name, "enable", CONFIG_ONDEMAND_ONDEMAND);
260                 if(def_enable == CONFIG_ONDEMAND_NO) continue;
261
262                 int def_performance = CONFIG_ONDEMAND_NO, def_space = CONFIG_ONDEMAND_NO;
263                 if(enable_autodetection)  {
264                         if(enable_physical_disks && (d->type == DISK_TYPE_PHYSICAL)) {
265                                 def_performance = enable_physical_disks;
266                         } else if(enable_virtual_disks && (d->type == DISK_TYPE_CONTAINER)) {
267                                 def_performance = enable_virtual_disks;
268                         } else if(enable_partitions && (d->type == DISK_TYPE_PARTITION)) {
269                                 def_performance = enable_partitions;
270                         } else if(enable_mountpoints && (d->mount_point != NULL)) {
271                                 def_performance = enable_mountpoints;
272                         }
273
274                         if(enable_space_metrics && (d->mount_point != NULL)) {
275                                 def_space = enable_space_metrics;
276                         }
277                 }
278
279                 RRDSET *st;
280
281                 // --------------------------------------------------------------------------
282                 // Do performance metrics
283                 def_performance = config_get_boolean_ondemand(var_name, "enable performance metrics", def_performance);
284                 if( (def_performance == CONFIG_ONDEMAND_YES) || (def_performance == CONFIG_ONDEMAND_ONDEMAND && reads && writes) ) {
285                         int ddo_io = do_io, ddo_ops = do_ops, ddo_mops = do_mops, ddo_iotime = do_iotime, ddo_qops = do_qops, ddo_util = do_util, ddo_backlog = do_backlog;
286
287                         ddo_io          = config_get_boolean_ondemand(var_name, "bandwidth", ddo_io);
288                         ddo_ops         = config_get_boolean_ondemand(var_name, "operations", ddo_ops);
289                         ddo_mops        = config_get_boolean_ondemand(var_name, "merged operations", ddo_mops);
290                         ddo_iotime      = config_get_boolean_ondemand(var_name, "i/o time", ddo_iotime);
291                         ddo_qops        = config_get_boolean_ondemand(var_name, "queued operations", ddo_qops);
292                         ddo_util        = config_get_boolean_ondemand(var_name, "utilization percentage", ddo_util);
293                         ddo_backlog = config_get_boolean_ondemand(var_name, "backlog", ddo_backlog);
294
295                         // by default, do not add charts that do not have values
296                         if(ddo_io == CONFIG_ONDEMAND_ONDEMAND && !reads && !writes) ddo_io = 0;
297                         if(ddo_mops == CONFIG_ONDEMAND_ONDEMAND && mreads == 0 && mwrites == 0) ddo_mops = 0;
298                         if(ddo_iotime == CONFIG_ONDEMAND_ONDEMAND && readms == 0 && writems == 0) ddo_iotime = 0;
299                         if(ddo_util == CONFIG_ONDEMAND_ONDEMAND && busy_ms == 0) ddo_util = 0;
300                         if(ddo_backlog == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_backlog = 0;
301                         if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_qops = 0;
302
303                         // for absolute values, we need to switch the setting to 'yes'
304                         // to allow it refresh from now on
305                         if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND) config_set(var_name, "queued operations", "yes");
306
307                         // --------------------------------------------------------------------
308                         int sector_size = 512;
309                         if(ddo_io) {
310                                 st = rrdset_find_bytype(RRD_TYPE_DISK, disk);
311                                 if(!st) {
312                                         char tf[FILENAME_MAX + 1], *t;
313                                         char ssfilename[FILENAME_MAX + 1];
314
315                                         strncpyz(tf, disk, FILENAME_MAX);
316
317                                         // replace all / with !
318                                         while((t = strchr(tf, '/'))) *t = '!';
319
320                                         snprintfz(ssfilename, FILENAME_MAX, path_to_get_hw_sector_size, tf);
321                                         FILE *fpss = fopen(ssfilename, "r");
322                                         if(fpss) {
323                                                 char ssbuffer[1025];
324                                                 char *tmp = fgets(ssbuffer, 1024, fpss);
325
326                                                 if(tmp) {
327                                                         sector_size = atoi(tmp);
328                                                         if(sector_size <= 0) {
329                                                                 error("Invalid sector size %d for device %s in %s. Assuming 512.", sector_size, disk, ssfilename);
330                                                                 sector_size = 512;
331                                                         }
332                                                 }
333                                                 else error("Cannot read data for sector size for device %s from %s. Assuming 512.", disk, ssfilename);
334
335                                                 fclose(fpss);
336                                         }
337                                         else error("Cannot read sector size for device %s from %s. Assuming 512.", disk, ssfilename);
338
339                                         st = rrdset_create(RRD_TYPE_DISK, disk, NULL, family, "disk.io", "Disk I/O Bandwidth", "kilobytes/s", 2000, update_every, RRDSET_TYPE_AREA);
340
341                                         rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_INCREMENTAL);
342                                         rrddim_add(st, "writes", NULL, sector_size * -1, 1024, RRDDIM_INCREMENTAL);
343                                 }
344                                 else rrdset_next_usec(st, dt);
345
346                                 last_readsectors  = rrddim_set(st, "reads", readsectors);
347                                 last_writesectors = rrddim_set(st, "writes", writesectors);
348                                 rrdset_done(st);
349                         }
350
351                         // --------------------------------------------------------------------
352                         if(ddo_ops) {
353                                 st = rrdset_find_bytype("disk_ops", disk);
354                                 if(!st) {
355                                         st = rrdset_create("disk_ops", disk, NULL, family, "disk.ops", "Disk Completed I/O Operations", "operations/s", 2001, update_every, RRDSET_TYPE_LINE);
356                                         st->isdetail = 1;
357
358                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
359                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
360                                 }
361                                 else rrdset_next_usec(st, dt);
362
363                                 last_reads  = rrddim_set(st, "reads", reads);
364                                 last_writes = rrddim_set(st, "writes", writes);
365                                 rrdset_done(st);
366                         }
367
368                         // --------------------------------------------------------------------
369                         if(ddo_qops) {
370                                 st = rrdset_find_bytype("disk_qops", disk);
371                                 if(!st) {
372                                         st = rrdset_create("disk_qops", disk, NULL, family, "disk.qops", "Disk Current I/O Operations", "operations", 2002, update_every, RRDSET_TYPE_LINE);
373                                         st->isdetail = 1;
374
375                                         rrddim_add(st, "operations", NULL, 1, 1, RRDDIM_ABSOLUTE);
376                                 }
377                                 else rrdset_next_usec(st, dt);
378
379                                 rrddim_set(st, "operations", queued_ios);
380                                 rrdset_done(st);
381                         }
382
383                         // --------------------------------------------------------------------
384                         if(ddo_backlog) {
385                                 st = rrdset_find_bytype("disk_backlog", disk);
386                                 if(!st) {
387                                         st = rrdset_create("disk_backlog", disk, NULL, family, "disk.backlog", "Disk Backlog", "backlog (ms)", 2003, update_every, RRDSET_TYPE_AREA);
388                                         st->isdetail = 1;
389
390                                         rrddim_add(st, "backlog", NULL, 1, 10, RRDDIM_INCREMENTAL);
391                                 }
392                                 else rrdset_next_usec(st, dt);
393
394                                 rrddim_set(st, "backlog", backlog_ms);
395                                 rrdset_done(st);
396                         }
397
398                         // --------------------------------------------------------------------
399                         if(ddo_util) {
400                                 st = rrdset_find_bytype("disk_util", disk);
401                                 if(!st) {
402                                         st = rrdset_create("disk_util", disk, NULL, family, "disk.util", "Disk Utilization Time", "% of time working", 2004, update_every, RRDSET_TYPE_AREA);
403                                         st->isdetail = 1;
404
405                                         rrddim_add(st, "utilization", NULL, 1, 10, RRDDIM_INCREMENTAL);
406                                 }
407                                 else rrdset_next_usec(st, dt);
408
409                                 last_busy_ms = rrddim_set(st, "utilization", busy_ms);
410                                 rrdset_done(st);
411                         }
412
413                         // --------------------------------------------------------------------
414                         if(ddo_mops) {
415                                 st = rrdset_find_bytype("disk_mops", disk);
416                                 if(!st) {
417                                         st = rrdset_create("disk_mops", disk, NULL, family, "disk.mops", "Disk Merged Operations", "merged operations/s", 2021, update_every, RRDSET_TYPE_LINE);
418                                         st->isdetail = 1;
419
420                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
421                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
422                                 }
423                                 else rrdset_next_usec(st, dt);
424
425                                 rrddim_set(st, "reads", mreads);
426                                 rrddim_set(st, "writes", mwrites);
427                                 rrdset_done(st);
428                         }
429
430                         // --------------------------------------------------------------------
431                         if(ddo_iotime) {
432                                 st = rrdset_find_bytype("disk_iotime", disk);
433                                 if(!st) {
434                                         st = rrdset_create("disk_iotime", disk, NULL, family, "disk.iotime", "Disk Total I/O Time", "milliseconds/s", 2022, update_every, RRDSET_TYPE_LINE);
435                                         st->isdetail = 1;
436
437                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
438                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
439                                 }
440                                 else rrdset_next_usec(st, dt);
441
442                                 last_readms  = rrddim_set(st, "reads", readms);
443                                 last_writems = rrddim_set(st, "writes", writems);
444                                 rrdset_done(st);
445                         }
446
447                         // --------------------------------------------------------------------
448                         // calculate differential charts
449                         // only if this is not the first time we run
450                         if(dt) {
451                                 if(ddo_iotime && ddo_ops) {
452                                         st = rrdset_find_bytype("disk_await", disk);
453                                         if(!st) {
454                                                 st = rrdset_create("disk_await", disk, NULL, family, "disk.await", "Average Completed I/O Operation Time", "ms per operation", 2005, update_every, RRDSET_TYPE_LINE);
455                                                 st->isdetail = 1;
456
457                                                 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_ABSOLUTE);
458                                                 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_ABSOLUTE);
459                                         }
460                                         else rrdset_next_usec(st, dt);
461
462                                         rrddim_set(st, "reads", (reads - last_reads) ? (readms - last_readms) / (reads - last_reads) : 0);
463                                         rrddim_set(st, "writes", (writes - last_writes) ? (writems - last_writems) / (writes - last_writes) : 0);
464                                         rrdset_done(st);
465                                 }
466
467                                 if(ddo_io && ddo_ops) {
468                                         st = rrdset_find_bytype("disk_avgsz", disk);
469                                         if(!st) {
470                                                 st = rrdset_create("disk_avgsz", disk, NULL, family, "disk.avgsz", "Average Completed I/O Operation Bandwidth", "kilobytes per operation", 2006, update_every, RRDSET_TYPE_AREA);
471                                                 st->isdetail = 1;
472
473                                                 rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_ABSOLUTE);
474                                                 rrddim_add(st, "writes", NULL, -sector_size, 1024, RRDDIM_ABSOLUTE);
475                                         }
476                                         else rrdset_next_usec(st, dt);
477
478                                         rrddim_set(st, "reads", (reads - last_reads) ? (readsectors - last_readsectors) / (reads - last_reads) : 0);
479                                         rrddim_set(st, "writes", (writes - last_writes) ? (writesectors - last_writesectors) / (writes - last_writes) : 0);
480                                         rrdset_done(st);
481                                 }
482
483                                 if(ddo_util && ddo_ops) {
484                                         st = rrdset_find_bytype("disk_svctm", disk);
485                                         if(!st) {
486                                                 st = rrdset_create("disk_svctm", disk, NULL, family, "disk.svctm", "Average Service Time", "ms per operation", 2007, update_every, RRDSET_TYPE_LINE);
487                                                 st->isdetail = 1;
488
489                                                 rrddim_add(st, "svctm", NULL, 1, 1, RRDDIM_ABSOLUTE);
490                                         }
491                                         else rrdset_next_usec(st, dt);
492
493                                         rrddim_set(st, "svctm", ((reads - last_reads) + (writes - last_writes)) ? (busy_ms - last_busy_ms) / ((reads - last_reads) + (writes - last_writes)) : 0);
494                                         rrdset_done(st);
495                                 }
496                         }
497                 }
498
499                 // --------------------------------------------------------------------------
500                 // Do space metrics
501                 def_space = config_get_boolean_ondemand(var_name, "enable space metrics", def_space);           
502                 if(def_space != CONFIG_ONDEMAND_NO) {
503                         int ddo_space = do_space, ddo_inodes = do_inodes;
504
505                         ddo_space = config_get_boolean_ondemand(var_name, "space", ddo_space);
506                         ddo_inodes = config_get_boolean_ondemand(var_name, "inodes", ddo_space);
507                         if(mount_point && (ddo_space || ddo_inodes) ) {
508                                 // collect space metrics using statvfs
509                                 if (statvfs(mount_point, &buff_statvfs) < 0) {
510                                         error("Failed checking disk space usage of %s", family);
511                                 } else {
512                                         // verify we collected the metrics for the right disk.
513                                         // if not the mountpoint has changed.
514                                         if(stat(mount_point, &buff_stat) == -1) {
515                                                 error("Failed to call stat for %s", family);
516                                         } else {
517                                                 if(major(buff_stat.st_dev) == major && minor(buff_stat.st_dev) == minor)
518                                                 {
519                                                         if(ddo_space) {
520                                                                 space_avail = buff_statvfs.f_bavail * buff_statvfs.f_bsize;
521                                                                 space_avail_root = (buff_statvfs.f_bfree - buff_statvfs.f_bavail) * buff_statvfs.f_bsize;
522                                                                 space_used = (buff_statvfs.f_blocks - buff_statvfs.f_bfree) * buff_statvfs.f_bsize;
523
524                                                                 st = rrdset_find_bytype("disk_space", disk);
525                                                                 if(!st) {
526                                                                         st = rrdset_create("disk_space", disk, NULL, family, "disk.space", "Disk Space Usage", "GB", 2023, update_every, RRDSET_TYPE_STACKED);
527                                                                         st->isdetail = 1;
528
529                                                                         rrddim_add(st, "avail", NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
530                                                                         rrddim_add(st, "reserved_for_root", "reserved for root", 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
531                                                                         rrddim_add(st, "used" , NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
532                                                                 }
533                                                                 else rrdset_next_usec(st, dt);
534
535                                                                 rrddim_set(st, "avail", space_avail);
536                                                                 rrddim_set(st, "reserved_for_root", space_avail_root);
537                                                                 rrddim_set(st, "used", space_used);
538                                                                 rrdset_done(st);
539                                                         }
540                                                         if(ddo_inodes) {
541                                                                 inodes_avail = buff_statvfs.f_favail;
542                                                                 inodes_avail_root = buff_statvfs.f_ffree - buff_statvfs.f_favail;
543                                                                 inodes_used = buff_statvfs.f_files - buff_statvfs.f_ffree;
544
545                                                                 st = rrdset_find_bytype("disk_inodes", disk);
546                                                                 if(!st) {
547                                                                         st = rrdset_create("disk_inodes", disk, NULL, family, "disk.inodes", "Disk Inodes Usage", "Inodes", 2024, update_every, RRDSET_TYPE_STACKED);
548                                                                         st->isdetail = 1;
549
550                                                                         rrddim_add(st, "avail", NULL, 1, 1, RRDDIM_ABSOLUTE);
551                                                                         rrddim_add(st, "reserved_for_root", "reserved for root", 1, 1, RRDDIM_ABSOLUTE);
552                                                                         rrddim_add(st, "used" , NULL, 1, 1, RRDDIM_ABSOLUTE);
553                                                                 }
554                                                                 else rrdset_next_usec(st, dt);
555
556                                                                 rrddim_set(st, "avail", inodes_avail);
557                                                                 rrddim_set(st, "reserved_for_root", inodes_avail_root);
558                                                                 rrddim_set(st, "used", inodes_used);
559                                                                 rrdset_done(st);
560                                                         }
561                                                 }
562                                         }
563                                 }
564                         }
565                 }
566         }
567         return 0;
568 }