]> arthur.barton.de Git - netatalk.git/commitdiff
afpd/volume: don't leak vol_mname in afp_openvol
authorRiccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Fri, 1 Feb 2013 18:21:01 +0000 (19:21 +0100)
committerRiccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Fri, 1 Feb 2013 18:21:01 +0000 (19:21 +0100)
Reported as Coverity by CID #201201

etc/afpd/volume.c

index 844444ba77498aa020875cd8c98413a78bcff5fe..8798635a07678150921e3b5139f54ec942269b73 100644 (file)
@@ -791,7 +791,6 @@ int afp_openvol(AFPObj *obj, char *ibuf, size_t ibuflen _U_, char *rbuf, size_t
         ret = AFPERR_MISC;
         goto openvol_err;
     }
-    free(vol_mname);
     volume->v_root = dir;
     curdir = dir;
 
@@ -829,6 +828,7 @@ int afp_openvol(AFPObj *obj, char *ibuf, size_t ibuflen _U_, char *rbuf, size_t
         if ((msg = iniparser_getstring(obj->iniconfig, volume->v_configname, "login message",  NULL)) != NULL)
             setmessage(msg);
 
+        free(vol_mname);
         return( AFP_OK );
     }
 
@@ -843,6 +843,7 @@ openvol_err:
         cnid_close(volume->v_cdb);
         volume->v_cdb = NULL;
     }
+    free(vol_mname);
     *rbuflen = 0;
     return ret;
 }