]> arthur.barton.de Git - bup.git/commitdiff
helpers: use float for format_filesize()
authorJohannes Berg <johannes@sipsolutions.net>
Sun, 17 May 2020 21:45:21 +0000 (23:45 +0200)
committerRob Browning <rlb@defaultvalue.org>
Wed, 20 May 2020 06:37:52 +0000 (01:37 -0500)
In format_filesize(), we really do want float division,
in order to display the value correctly. For example, if
there's a file with 45200000 bytes, that should be shown
as 43.1 MB, not 43.0. Fix this by using proper float
division here, not int division.

Fixes: a5809723352c ("helpers: use // not / for division")
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Rob Browning <rlb@defaultvalue.org>
Tested-by: Rob Browning <rlb@defaultvalue.org>
(cherry picked from commit 3912ff3aa3ef75f79ccc6ec014c4a691d0e3803b)

lib/bup/helpers.py

index b6196e4fe1745ed5dc6ab311c4964822cc872b76..5cad1d169b52aeaf80c81b122d8a0f6100939ea0 100644 (file)
@@ -476,7 +476,7 @@ def format_filesize(size):
         return "%d" % (size)
     exponent = int(math.log(size) // math.log(unit))
     size_prefix = "KMGTPE"[exponent - 1]
-    return "%.1f%s" % (size // math.pow(unit, exponent), size_prefix)
+    return "%.1f%s" % (size / math.pow(unit, exponent), size_prefix)
 
 
 class NotOk(Exception):