// According to Python, its header has to go first:
// http://docs.python.org/2/c-api/intro.html#include-files
+// http://docs.python.org/3/c-api/intro.html#include-files
#include <Python.h>
#include <arpa/inet.h>
#endif
#include "bupsplit.h"
+#include "bup/intprops.h"
#if defined(FS_IOC_GETFLAGS) && defined(FS_IOC_SETFLAGS)
#define BUP_HAVE_FILE_ATTRS 1
#endif
+#if PY_MAJOR_VERSION > 2
+# define BUP_USE_PYTHON_UTIME 1
+#endif
+
+#ifndef BUP_USE_PYTHON_UTIME // just for Python 2 now
/*
* Check for incomplete UTIMENSAT support (NetBSD 6), and if so,
* pretend we don't have it.
#if !defined(AT_FDCWD) || !defined(AT_SYMLINK_NOFOLLOW)
#undef HAVE_UTIMENSAT
#endif
+#endif // defined BUP_USE_PYTHON_UTIME
#ifndef FS_NOCOW_FL
// Of course, this assumes it's a bitfield value.
return result;
}
-#ifndef BUP_HAVE_BUILTIN_MUL_OVERFLOW
-
-#define checked_malloc checked_calloc
-
-#else // defined BUP_HAVE_BUILTIN_MUL_OVERFLOW
-
static void *checked_malloc(size_t n, size_t size)
{
size_t total;
- if (__builtin_mul_overflow(n, size, &total))
+ if (!INT_MULTIPLY_OK(n, size, &total))
{
PyErr_Format(PyExc_OverflowError,
"request to allocate %zu items of size %zu is too large",
return result;
}
-#endif // defined BUP_HAVE_BUILTIN_MUL_OVERFLOW
-
#ifndef htonll
// This function should technically be macro'd out if it's going to be used
}
#endif
+#define INTEGRAL_ASSIGNMENT_FITS(dest, src) INT_ADD_OK(src, 0, dest)
-// Disabling sign-compare here should be fine since we're explicitly
-// checking for a sign mismatch, i.e. if the signs don't match, then
-// it doesn't matter what the value comparison says.
-// FIXME: ... so should we reverse the order?
-#define INTEGRAL_ASSIGNMENT_FITS(dest, src) \
- ({ \
- _Pragma("GCC diagnostic push"); \
- _Pragma("GCC diagnostic ignored \"-Wsign-compare\""); \
- _Pragma("clang diagnostic push"); \
- _Pragma("clang diagnostic ignored \"-Wshorten-64-to-32\""); \
- *(dest) = (src); \
- int result = *(dest) == (src) && (*(dest) < 1) == ((src) < 1); \
- _Pragma("clang diagnostic pop"); \
- _Pragma("GCC diagnostic pop"); \
- result; \
- })
-
-
-#define INTEGER_TO_PY(x) \
- ({ \
- _Pragma("GCC diagnostic push"); \
- _Pragma("GCC diagnostic ignored \"-Wtype-limits\""); \
- _Pragma("clang diagnostic push"); \
- _Pragma("clang diagnostic ignored \"-Wtautological-compare\""); \
- PyObject *result = ((x) >= 0) ? PyLong_FromUnsignedLongLong(x) : PyLong_FromLongLong(x); \
- _Pragma("clang diagnostic pop"); \
- _Pragma("GCC diagnostic pop"); \
- result; \
- })
-
+#define INTEGER_TO_PY(x) \
+ EXPR_SIGNED(x) ? PyLong_FromLongLong(x) : PyLong_FromUnsignedLongLong(x)
#if PY_MAJOR_VERSION < 3
static int bup_ulong_from_pyint(unsigned long *x, PyObject *py,
}
-
-// Probably we should use autoconf or something and set HAVE_PY_GETARGCARGV...
-#if __WIN32__ || __CYGWIN__
-
-// There's no 'ps' on win32 anyway, and Py_GetArgcArgv() isn't available.
-static void unpythonize_argv(void) { }
-
-#else // not __WIN32__
-
-// For some reason this isn't declared in Python.h
-extern void Py_GetArgcArgv(int *argc, char ***argv);
-
-static void unpythonize_argv(void)
-{
- int argc, i;
- char **argv, *arge;
-
- Py_GetArgcArgv(&argc, &argv);
-
- for (i = 0; i < argc-1; i++)
- {
- if (argv[i] + strlen(argv[i]) + 1 != argv[i+1])
- {
- // The argv block doesn't work the way we expected; it's unsafe
- // to mess with it.
- return;
- }
- }
-
- arge = argv[argc-1] + strlen(argv[argc-1]) + 1;
-
- if (strstr(argv[0], "python") && argv[1] == argv[0] + strlen(argv[0]) + 1)
- {
- char *p;
- size_t len, diff;
- p = strrchr(argv[1], '/');
- if (p)
- {
- p++;
- diff = p - argv[0];
- len = arge - p;
- memmove(argv[0], p, len);
- memset(arge - diff, 0, diff);
- for (i = 0; i < argc; i++)
- argv[i] = argv[i+1] ? argv[i+1]-diff : NULL;
- }
- }
-}
-
-#endif // not __WIN32__ or __CYGWIN__
-
-
static int write_all(int fd, const void *buf, const size_t count)
{
size_t written = 0;
}
-static int uadd(unsigned long long *dest,
- const unsigned long long x,
- const unsigned long long y)
+static inline int uadd(unsigned long long *dest,
+ const unsigned long long x,
+ const unsigned long long y)
{
- const unsigned long long result = x + y;
- if (result < x || result < y)
- return 0;
- *dest = result;
- return 1;
+ return INT_ADD_OK(x, y, dest);
}
PyObject *part;
unsigned int total = 0;
uint32_t count;
- int i, ofs64_count;
+ int i;
uint32_t *fan_ptr, *crc_ptr, *ofs_ptr;
uint64_t *ofs64_ptr;
struct sha *sha_ptr;
ofs64_ptr = (uint64_t *)&ofs_ptr[total];
count = 0;
- ofs64_count = 0;
+ uint32_t ofs64_count = 0;
for (i = 0; i < FAN_ENTRIES; ++i)
{
part = PyList_GET_ITEM(idx, i);
#endif /* def BUP_HAVE_FILE_ATTRS */
+#ifndef BUP_USE_PYTHON_UTIME // just for Python 2 now
#ifndef HAVE_UTIMENSAT
#ifndef HAVE_UTIMES
#error "cannot find utimensat or utimes()"
#error "cannot find utimensat or lutimes()"
#endif
#endif
+#endif // defined BUP_USE_PYTHON_UTIME
#define ASSIGN_PYLONG_TO_INTEGRAL(dest, pylong, overflow) \
({ \
})
+#ifndef BUP_USE_PYTHON_UTIME // just for Python 2 now
#ifdef HAVE_UTIMENSAT
static PyObject *bup_utimensat(PyObject *self, PyObject *args)
}
#endif /* def HAVE_LUTIMES */
+#endif // defined BUP_USE_PYTHON_UTIME
+
#ifdef HAVE_STAT_ST_ATIM
# define BUP_STAT_ATIME_NS(st) (st)->st_atim.tv_nsec
}
#endif /* def BUP_MINCORE_BUF_TYPE */
+static unsigned int vuint_encode(long long val, char *buf)
+{
+ unsigned int len = 0;
+
+ if (val < 0) {
+ PyErr_SetString(PyExc_Exception, "vuints must not be negative");
+ return 0;
+ }
+
+ do {
+ buf[len] = val & 0x7f;
+
+ val >>= 7;
+ if (val)
+ buf[len] |= 0x80;
+
+ len++;
+ } while (val);
+
+ return len;
+}
+
+static unsigned int vint_encode(long long val, char *buf)
+{
+ unsigned int len = 1;
+ char sign = 0;
+
+ if (val < 0) {
+ sign = 0x40;
+ val = -val;
+ }
+
+ buf[0] = (val & 0x3f) | sign;
+ val >>= 6;
+ if (val)
+ buf[0] |= 0x80;
+
+ while (val) {
+ buf[len] = val & 0x7f;
+ val >>= 7;
+ if (val)
+ buf[len] |= 0x80;
+ len++;
+ }
+
+ return len;
+}
+
+static PyObject *bup_vuint_encode(PyObject *self, PyObject *args)
+{
+ long long val;
+ // size the buffer appropriately - need 8 bits to encode each 7
+ char buf[(sizeof(val) + 1) / 7 * 8];
+
+ if (!PyArg_ParseTuple(args, "L", &val))
+ return NULL;
+
+ unsigned int len = vuint_encode(val, buf);
+ if (!len)
+ return NULL;
+
+ return PyBytes_FromStringAndSize(buf, len);
+}
+
+static PyObject *bup_vint_encode(PyObject *self, PyObject *args)
+{
+ long long val;
+ // size the buffer appropriately - need 8 bits to encode each 7
+ char buf[(sizeof(val) + 1) / 7 * 8];
+
+ if (!PyArg_ParseTuple(args, "L", &val))
+ return NULL;
+
+ return PyBytes_FromStringAndSize(buf, vint_encode(val, buf));
+}
static PyObject *tuple_from_cstrs(char **cstrs)
{
static PyObject *
bup_get_completer_word_break_characters(PyObject *self, PyObject *args)
{
- if (!PyArg_ParseTuple(args, ""))
- return NULL;
return PyBytes_FromString(rl_completer_word_break_characters);
}
static PyObject *bup_get_line_buffer(PyObject *self, PyObject *args)
{
- if (!PyArg_ParseTuple(args, ""))
- return NULL;
return PyBytes_FromString(rl_line_buffer);
}
}
#endif
+static PyObject *bup_limited_vint_pack(PyObject *self, PyObject *args)
+{
+ const char *fmt;
+ PyObject *packargs, *result;
+ Py_ssize_t sz, i, bufsz;
+ char *buf, *pos, *end;
+
+ if (!PyArg_ParseTuple(args, "sO", &fmt, &packargs))
+ return NULL;
+
+ if (!PyTuple_Check(packargs))
+ return PyErr_Format(PyExc_Exception, "pack() arg must be tuple");
+
+ sz = PyTuple_GET_SIZE(packargs);
+ if (sz != (Py_ssize_t)strlen(fmt))
+ return PyErr_Format(PyExc_Exception,
+ "number of arguments (%ld) does not match format string (%ld)",
+ (unsigned long)sz, (unsigned long)strlen(fmt));
+
+ if (sz > INT_MAX / 20)
+ return PyErr_Format(PyExc_Exception, "format is far too long");
+
+ // estimate no more than 20 bytes for each on average, the maximum
+ // vint/vuint we can encode is anyway 10 bytes, so this gives us
+ // some headroom for a few strings before we need to realloc ...
+ bufsz = sz * 20;
+ buf = malloc(bufsz);
+ if (!buf)
+ return PyErr_NoMemory();
+
+ pos = buf;
+ end = buf + bufsz;
+ for (i = 0; i < sz; i++) {
+ PyObject *item = PyTuple_GET_ITEM(packargs, i);
+ const char *bytes;
+
+ switch (fmt[i]) {
+ case 'V': {
+ long long val = PyLong_AsLongLong(item);
+ if (val == -1 && PyErr_Occurred())
+ return PyErr_Format(PyExc_OverflowError,
+ "pack arg %d invalid", (int)i);
+ if (end - pos < 10)
+ goto overflow;
+ pos += vuint_encode(val, pos);
+ break;
+ }
+ case 'v': {
+ long long val = PyLong_AsLongLong(item);
+ if (val == -1 && PyErr_Occurred())
+ return PyErr_Format(PyExc_OverflowError,
+ "pack arg %d invalid", (int)i);
+ if (end - pos < 10)
+ goto overflow;
+ pos += vint_encode(val, pos);
+ break;
+ }
+ case 's': {
+ bytes = PyBytes_AsString(item);
+ if (!bytes)
+ goto error;
+ if (end - pos < 10)
+ goto overflow;
+ Py_ssize_t val = PyBytes_GET_SIZE(item);
+ pos += vuint_encode(val, pos);
+ if (end - pos < val)
+ goto overflow;
+ memcpy(pos, bytes, val);
+ pos += val;
+ break;
+ }
+ default:
+ PyErr_Format(PyExc_Exception, "unknown xpack format string item %c",
+ fmt[i]);
+ goto error;
+ }
+ }
+
+ result = PyBytes_FromStringAndSize(buf, pos - buf);
+ free(buf);
+ return result;
+
+ overflow:
+ PyErr_SetString(PyExc_OverflowError, "buffer (potentially) overflowed");
+ error:
+ free(buf);
+ return NULL;
+}
+
static PyMethodDef helper_methods[] = {
{ "write_sparsely", bup_write_sparsely, METH_VARARGS,
"Write buf excepting zeros at the end. Return trailing zero count." },
{ "set_linux_file_attr", bup_set_linux_file_attr, METH_VARARGS,
"Set the Linux attributes for the given file." },
#endif
+
+#ifndef BUP_USE_PYTHON_UTIME // just for Python 2 now
#ifdef HAVE_UTIMENSAT
{ "bup_utimensat", bup_utimensat, METH_VARARGS,
"Change path timestamps with nanosecond precision (POSIX)." },
"Change path timestamps with microsecond precision;"
" don't follow symlinks." },
#endif
+#endif // defined BUP_USE_PYTHON_UTIME
+
{ "stat", bup_stat, METH_VARARGS,
"Extended version of stat." },
{ "lstat", bup_lstat, METH_VARARGS,
"apply_acl(name, acl, def=None)\n\n"
"Given a file/dirname (bytes) and the ACLs to restore, do that." },
#endif /* HAVE_ACLS */
+ { "vuint_encode", bup_vuint_encode, METH_VARARGS, "encode an int to vuint" },
+ { "vint_encode", bup_vint_encode, METH_VARARGS, "encode an int to vint" },
+ { "limited_vint_pack", bup_limited_vint_pack, METH_VARARGS,
+ "Try to pack vint/vuint/str, throwing OverflowError when unable." },
{ NULL, NULL, 0, NULL }, // sentinel
};
// Just be sure (relevant when passing timestamps back to Python above).
assert(sizeof(PY_LONG_LONG) <= sizeof(long long));
assert(sizeof(unsigned PY_LONG_LONG) <= sizeof(unsigned long long));
+ // At least for INTEGER_TO_PY
+ assert(sizeof(intmax_t) <= sizeof(long long));
+ assert(sizeof(uintmax_t) <= sizeof(unsigned long long));
test_integral_assignment_fits();
PyObject_SetAttrString(m, "UINT_MAX", value);
Py_DECREF(value);
}
+
+#ifndef BUP_USE_PYTHON_UTIME // just for Python 2 now
#ifdef HAVE_UTIMENSAT
{
PyObject *value;
Py_DECREF(value);
}
#endif
+#endif // defined BUP_USE_PYTHON_UTIME
+
#ifdef BUP_HAVE_MINCORE_INCORE
{
PyObject *value;
e = getenv("BUP_FORCE_TTY");
get_state(m)->istty2 = isatty(2) || (atoi(e ? e : "0") & 2);
- unpythonize_argv();
return 1;
}
PyMODINIT_FUNC init_helpers(void)
{
PyObject *m = Py_InitModule("_helpers", helper_methods);
- if (m == NULL)
+ if (m == NULL) {
+ PyErr_SetString(PyExc_RuntimeError, "bup._helpers init failed");
return;
-
+ }
if (!setup_module(m))
{
+ PyErr_SetString(PyExc_RuntimeError, "bup._helpers set up failed");
Py_DECREF(m);
return;
}
projects / bup.git / blobdiff