]> arthur.barton.de Git - bup.git/blobdiff - Makefile
tests: partially convert to pytest
[bup.git] / Makefile
index ca22c0557e0b080a82d11da80790e69338d927e5..270653c777153b787d9dda39c30134ad4d8126ad 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,6 @@
 
+MAKEFLAGS += --warn-undefined-variables
+
 SHELL := bash
 .DEFAULT_GOAL := all
 
@@ -17,17 +19,18 @@ define shout
 $(if $(subst ok,,$(lastword $(1))),$(error $(2)),$(shell x="$(1)"; echo $${x%???}))
 endef
 
-sampledata_rev := $(shell t/configure-sampledata --revision $(isok))
+sampledata_rev := $(shell dev/configure-sampledata --revision $(isok))
 sampledata_rev := \
   $(call shout,$(sampledata_rev),Could not parse sampledata revision)
 
-current_sampledata := t/sampledata/var/rev/v$(sampledata_rev)
+current_sampledata := test/sampledata/var/rev/v$(sampledata_rev)
 
 os := $(shell ($(pf); uname | sed 's/[-_].*//') $(isok))
 os := $(call shout,$(os),Unable to determine OS)
 
-CFLAGS := -Wall -O2 -Werror -Wno-unknown-pragmas $(PYINCLUDE) $(CFLAGS)
-CFLAGS := -D_FILE_OFFSET_BITS=64 $(CFLAGS)
+CFLAGS := -O2 -Wall -Werror -Wformat=2 $(CFLAGS)
+CFLAGS := -Wno-unknown-pragmas -Wsign-compare $(CFLAGS)
+CFLAGS := -D_FILE_OFFSET_BITS=64 $(PYINCLUDE) $(CFLAGS)
 SOEXT:=.so
 
 ifeq ($(os),CYGWIN)
@@ -37,11 +40,11 @@ endif
 ifdef TMPDIR
   test_tmp := $(TMPDIR)
 else
-  test_tmp := $(CURDIR)/t/tmp
+  test_tmp := $(CURDIR)/test/tmp
 endif
 
-initial_setup := $(shell ./configure-version --update $(isok))
-initial_setup := $(call shout,$(initial_setup),Version configuration failed))
+initial_setup := $(shell dev/update-checkout-info lib/bup/checkout_info.py $(isok))
+initial_setup := $(call shout,$(initial_setup),update-checkout-info failed))
 
 config/config.vars: \
   configure config/configure config/configure.inc \
@@ -51,20 +54,21 @@ config/config.vars: \
 # On some platforms, Python.h and readline.h fight over the
 # _XOPEN_SOURCE version, i.e. -Werror crashes on a mismatch, so for
 # now, we're just going to let Python's version win.
-readline_cflags += $(shell pkg-config readline --cflags)
-readline_xopen := $(filter -D_XOPEN_SOURCE=%,$(readline_cflags))
-readline_xopen := $(subst -D_XOPEN_SOURCE=,,$(readline_xopen))
-ifneq ($(readline_xopen),600)
-  $(error "Unexpected pkg-config readline _XOPEN_SOURCE --cflags $(readline_cflags)")
+
+ifneq ($(strip $(bup_readline_cflags)),)
+  readline_cflags += $(bup_readline_cflags)
+  readline_xopen := $(filter -D_XOPEN_SOURCE=%,$(readline_cflags))
+  readline_xopen := $(subst -D_XOPEN_SOURCE=,,$(readline_xopen))
+  readline_cflags := $(filter-out -D_XOPEN_SOURCE=%,$(readline_cflags))
+  readline_cflags += $(addprefix -DBUP_RL_EXPECTED_XOPEN_SOURCE=,$(readline_xopen))
+  CFLAGS += $(readline_cflags)
 endif
-readline_cflags := $(filter-out -D_XOPEN_SOURCE=%,$(readline_cflags))
-readline_cflags += $(addprefix -DBUP_RL_EXPECTED_XOPEN_SOURCE=,$(readline_xopen))
-
-CFLAGS += $(readline_cflags)
-LDFLAGS += $(shell pkg-config readline --libs)
-ifeq ($(BUP_HAVE_LIBACL),yes)
-  CFLAGS += $(shell pkg-config libacl --cflags)
-  LDFLAGS += $(shell pkg-config libacl --libs)
+
+LDFLAGS += $(bup_readline_ldflags)
+
+ifeq ($(bup_have_libacl),1)
+  CFLAGS += $(bup_libacl_cflags)
+  LDFLAGS += $(bup_libacl_ldflags)
 endif
 
 config/bin/python: config/config.vars
@@ -73,12 +77,12 @@ bup_cmds := \
   $(patsubst cmd/%-cmd.py,cmd/bup-%,$(wildcard cmd/*-cmd.py)) \
   $(patsubst cmd/%-cmd.sh,cmd/bup-%,$(wildcard cmd/*-cmd.sh))
 
-bup_deps := lib/bup/_checkout.py lib/bup/_helpers$(SOEXT) $(bup_cmds)
+bup_deps := lib/bup/_helpers$(SOEXT) $(bup_cmds)
 
 all: $(bup_deps) Documentation/all $(current_sampledata)
 
 $(current_sampledata):
-       t/configure-sampledata --setup
+       dev/configure-sampledata --setup
 
 PANDOC ?= $(shell type -p pandoc)
 
@@ -132,6 +136,13 @@ install: all
        $(INSTALL) -pm 0644 \
                lib/web/*.html \
                $(dest_libdir)/web/
+       if test -e lib/bup/checkout_info.py; then \
+           $(INSTALL) -pm 0644 lib/bup/checkout_info.py \
+               $(dest_libdir)/bup/source_info.py; \
+       else \
+           ! grep -qF '$$Format' lib/bup/source_info.py; \
+           $(INSTALL) -pm 0644 lib/bup/source_info.py $(dest_libdir)/bup/; \
+       fi
 
 config/config.h: config/config.vars
 
@@ -145,87 +156,59 @@ lib/bup/_helpers$(SOEXT): \
          "import glob; assert(len(glob.glob('lib/bup/build/*/_helpers*$(SOEXT)')) == 1)"
        cp lib/bup/build/*/_helpers*$(SOEXT) "$@"
 
-lib/bup/_checkout.py:
-       @if grep -F '$Format' lib/bup/_release.py \
-           && ! test -e lib/bup/_checkout.py; then \
-         echo "Something has gone wrong; $@ should already exist."; \
-         echo 'Check "./configure-version --update"'; \
-         false; \
-       fi
-
-t/tmp:
-       mkdir t/tmp
+test/tmp:
+       mkdir test/tmp
 
 runtests: runtests-python runtests-cmdline
 
-python_tests := \
-  lib/bup/t/tbloom.py \
-  lib/bup/t/tclient.py \
-  lib/bup/t/tgit.py \
-  lib/bup/t/thashsplit.py \
-  lib/bup/t/thelpers.py \
-  lib/bup/t/tindex.py \
-  lib/bup/t/tmetadata.py \
-  lib/bup/t/toptions.py \
-  lib/bup/t/tresolve.py \
-  lib/bup/t/tshquote.py \
-  lib/bup/t/tvfs.py \
-  lib/bup/t/tvint.py \
-  lib/bup/t/txstat.py
-
-# The "pwd -P" here may not be appropriate in the long run, but we
-# need it until we settle the relevant drecurse/exclusion questions:
-# https://groups.google.com/forum/#!topic/bup-list/9ke-Mbp10Q0
-runtests-python: all t/tmp
-       mkdir -p t/tmp/test-log
-       $(pf); cd $$(pwd -P); TMPDIR="$(test_tmp)" \
-         ./wvtest.py  $(python_tests) 2>&1 \
-           | tee -a t/tmp/test-log/$$$$.log
+runtests-python: all test/tmp
+       ./pytest
 
 cmdline_tests := \
-  t/test.sh \
-  t/test-argv \
-  t/test-cat-file.sh \
-  t/test-command-without-init-fails.sh \
-  t/test-compression.sh \
-  t/test-drecurse.sh \
-  t/test-fsck.sh \
-  t/test-fuse.sh \
-  t/test-ftp \
-  t/test-web.sh \
-  t/test-gc.sh \
-  t/test-import-duplicity.sh \
-  t/test-import-rdiff-backup.sh \
-  t/test-index.sh \
-  t/test-index-check-device.sh \
-  t/test-index-clear.sh \
-  t/test-list-idx.sh \
-  t/test-ls \
-  t/test-ls-remote \
-  t/test-main.sh \
-  t/test-meta.sh \
-  t/test-on.sh \
-  t/test-packsizelimit \
-  t/test-prune-older \
-  t/test-redundant-saves.sh \
-  t/test-restore-map-owner.sh \
-  t/test-restore-single-file.sh \
-  t/test-rm.sh \
-  t/test-rm-between-index-and-save.sh \
-  t/test-save-creates-no-unrefs.sh \
-  t/test-save-restore \
-  t/test-save-errors \
-  t/test-save-restore-excludes.sh \
-  t/test-save-strip-graft.sh \
-  t/test-save-with-valid-parent.sh \
-  t/test-sparse-files.sh \
-  t/test-split-join.sh \
-  t/test-tz.sh \
-  t/test-xdev.sh
-
-tmp-target-run-test-get-%: all t/tmp
+  test/ext/test.sh \
+  test/ext/test-argv \
+  test/ext/test-cat-file.sh \
+  test/ext/test-command-without-init-fails.sh \
+  test/ext/test-compression.sh \
+  test/ext/test-drecurse.sh \
+  test/ext/test-fsck.sh \
+  test/ext/test-fuse.sh \
+  test/ext/test-ftp \
+  test/ext/test-help \
+  test/ext/test-web.sh \
+  test/ext/test-gc.sh \
+  test/ext/test-import-duplicity.sh \
+  test/ext/test-import-rdiff-backup.sh \
+  test/ext/test-index.sh \
+  test/ext/test-index-check-device.sh \
+  test/ext/test-index-clear.sh \
+  test/ext/test-list-idx.sh \
+  test/ext/test-ls \
+  test/ext/test-ls-remote \
+  test/ext/test-main.sh \
+  test/ext/test-meta.sh \
+  test/ext/test-on.sh \
+  test/ext/test-packsizelimit \
+  test/ext/test-prune-older \
+  test/ext/test-redundant-saves.sh \
+  test/ext/test-restore-map-owner.sh \
+  test/ext/test-restore-single-file.sh \
+  test/ext/test-rm.sh \
+  test/ext/test-rm-between-index-and-save.sh \
+  test/ext/test-save-creates-no-unrefs.sh \
+  test/ext/test-save-restore \
+  test/ext/test-save-errors \
+  test/ext/test-save-restore-excludes.sh \
+  test/ext/test-save-strip-graft.sh \
+  test/ext/test-save-with-valid-parent.sh \
+  test/ext/test-sparse-files.sh \
+  test/ext/test-split-join.sh \
+  test/ext/test-tz.sh \
+  test/ext/test-xdev.sh
+
+tmp-target-run-test-get-%: all test/tmp
        $(pf); cd $$(pwd -P); TMPDIR="$(test_tmp)" \
-         t/test-get $* 2>&1 | tee -a t/tmp/test-log/$$$$.log
+         test/ext/test-get $* 2>&1 | tee -a test/tmp/test-log/$$$$.log
 
 test_get_targets += \
   tmp-target-run-test-get-replace \
@@ -240,26 +223,27 @@ test_get_targets += \
 # The "pwd -P" here may not be appropriate in the long run, but we
 # need it until we settle the relevant drecurse/exclusion questions:
 # https://groups.google.com/forum/#!topic/bup-list/9ke-Mbp10Q0
-tmp-target-run-test%: all t/tmp
+tmp-target-run-test%: all test/tmp
        $(pf); cd $$(pwd -P); TMPDIR="$(test_tmp)" \
-         t/test$* 2>&1 | tee -a t/tmp/test-log/$$$$.log
+         test/ext/test$* 2>&1 | tee -a test/tmp/test-log/$$$$.log
 
-runtests-cmdline: $(test_get_targets) $(subst t/test,tmp-target-run-test,$(cmdline_tests))
+runtests-cmdline: $(test_get_targets) $(subst test/ext/test,tmp-target-run-test,$(cmdline_tests))
 
 stupid:
        PATH=/bin:/usr/bin $(MAKE) test
 
 test: all
-       if test -e t/tmp/test-log; then rm -r t/tmp/test-log; fi
-       mkdir -p t/tmp/test-log
+       if test -e test/tmp/test-log; then rm -r test/tmp/test-log; fi
+       mkdir -p test/tmp/test-log
+       $(MAKE) runtests-python
        ./wvtest watch --no-counts \
-         $(MAKE) runtests 2>t/tmp/test-log/$$$$.log
-       ./wvtest report t/tmp/test-log/*.log
+         $(MAKE) runtests-cmdline 2>test/tmp/test-log/$$$$.log
+       ./wvtest report test/tmp/test-log/*.log
 
 check: test
 
 distcheck: all
-       ./wvtest run t/test-release-archive.sh
+       ./wvtest run test/ext/test-release-archive.sh
 
 long-test: export BUP_TEST_LEVEL=11
 long-test: test
@@ -284,7 +268,7 @@ cmd/bup-%: cmd/%-cmd.sh
 Documentation/all: $(man_roff) $(man_html)
 
 Documentation/substvars: $(bup_deps)
-       echo "s,%BUP_VERSION%,$$(./bup version --tag),g" > $@
+       echo "s,%BUP_VERSION%,$$(./bup version),g" > $@
        echo "s,%BUP_DATE%,$$(./bup version --date),g" >> $@
 
 Documentation/%.1: Documentation/%.md Documentation/substvars
@@ -323,20 +307,20 @@ clean: Documentation/clean config/bin/python
        rm -f *.o lib/*/*.o *.so lib/*/*.so *.dll lib/*/*.dll *.exe \
                .*~ *~ */*~ lib/*/*~ lib/*/*/*~ \
                *.pyc */*.pyc lib/*/*.pyc lib/*/*/*.pyc \
+               lib/bup/checkout_info.py \
                randomgen memtest \
-               testfs.img lib/bup/t/testfs.img
+               testfs.img test/int/testfs.img
        for x in $$(ls cmd/*-cmd.py cmd/*-cmd.sh | grep -vF python-cmd.sh | cut -b 5-); do \
            echo "cmd/bup-$${x%-cmd.*}"; \
        done | xargs -t rm -f
-       if test -e t/mnt; then t/cleanup-mounts-under t/mnt; fi
-       if test -e t/mnt; then rm -r t/mnt; fi
-       if test -e t/tmp; then t/cleanup-mounts-under t/tmp; fi
-        # FIXME: migrate these to t/mnt/
-       if test -e lib/bup/t/testfs; \
-         then umount lib/bup/t/testfs || true; fi
-       rm -rf *.tmp *.tmp.meta t/*.tmp lib/*/*/*.tmp build lib/bup/build lib/bup/t/testfs
-       if test -e t/tmp; then t/force-delete t/tmp; fi
-       ./configure-version --clean
-       t/configure-sampledata --clean
+       if test -e test/mnt; then dev/cleanup-mounts-under test/mnt; fi
+       if test -e test/mnt; then rm -r test/mnt; fi
+       if test -e test/tmp; then dev/cleanup-mounts-under test/tmp; fi
+        # FIXME: migrate these to test/mnt/
+       if test -e test/int/testfs; \
+         then umount test/int/testfs || true; fi
+       rm -rf *.tmp *.tmp.meta test/*.tmp lib/*/*/*.tmp build lib/bup/build test/int/testfs
+       if test -e test/tmp; then dev/force-delete test/tmp; fi
+       dev/configure-sampledata --clean
         # Remove last so that cleanup tools can depend on it
        rm -rf config/bin