]>
arthur.barton.de Git - netatalk.git/log
Ralph Boehme [Fri, 22 Mar 2013 13:37:06 +0000 (14:37 +0100)]
Only configure libevent when used
Frank Lahm [Thu, 14 Mar 2013 18:54:52 +0000 (19:54 +0100)]
Setting POSIX ACLs on Linux
The VFS module for setting ACLs on Linux returned an error when
try to set an ACL for a file that doesn't have a ressource fork.
Fix this by checking for ENOENT errno and then returning with 0
from the VFS stack.
Ralph Boehme [Fri, 22 Mar 2013 12:11:48 +0000 (13:11 +0100)]
Fix a debug message
Ralph Boehme [Thu, 21 Mar 2013 16:21:59 +0000 (17:21 +0100)]
Can't set Finder label on symlinked folder with "follow symlinks = yes"
Fixes bug #508.
Ralph Boehme [Tue, 19 Mar 2013 14:26:03 +0000 (15:26 +0100)]
Increase IO size when sendfile() is not used
If sendfile() support is disabled, the current code results in an
IO size of 8k for transferring requested data to the client. Eg:
- client request to read DSI quantum size bytes (~250k) from a file
- afpd process loops read(8k, file) -> send(8k, client) until all
250k have been transferred
This should be modified to read the whole 250k in one swoop from the
file to a buffer and then send the whole buffer in one swoop to the
client.
From FR #76.
Ralph Boehme [Tue, 19 Mar 2013 12:15:10 +0000 (13:15 +0100)]
Fix ressource fork refcounting
Ralph Boehme [Tue, 19 Mar 2013 11:18:34 +0000 (12:18 +0100)]
read_file() clobbered the AFP error code
Frank Lahm [Fri, 15 Mar 2013 08:19:40 +0000 (09:19 +0100)]
Use FreeBSD sendfile() capability to send protocol header
When transmitting file contents to a client with sendfile(), on
every platform other then Solaris (where we use sendfilev()), we
send the AFP the protocol header with an additional send with
MSG_MORE before calling sendfile().
FreeBSD sendfile() supports sending protocol header (and trailer)
data similarly to Solaris sendfilev().
Frank Lahm [Fri, 15 Mar 2013 12:41:39 +0000 (13:41 +0100)]
Merge remote branch 'github/develop' into develop
franklahm [Fri, 15 Mar 2013 12:40:45 +0000 (05:40 -0700)]
Merge pull request #25 from hat001/of_findname
of_findname(): missing argument
HAT [Fri, 15 Mar 2013 11:32:21 +0000 (20:32 +0900)]
of_findname(): missing argument
Frank Lahm [Mon, 11 Mar 2013 17:42:23 +0000 (18:42 +0100)]
afpstats-service.xml afpstats_service_glue.h were missing in distribution
Frank Lahm [Mon, 11 Mar 2013 16:19:28 +0000 (17:19 +0100)]
Permissions of ._ AppleDouble rfork after conversion from v2 to ea.
Fixes bug #505.
Ralph Boehme [Tue, 5 Mar 2013 16:40:22 +0000 (17:40 +0100)]
sys_lsetxattr error messages when mounting read only filesystem
Fixes bug #504.
HAT [Sun, 10 Mar 2013 15:23:30 +0000 (00:23 +0900)]
afpd -V show dbus and dtrace
Frank Lahm [Sat, 9 Mar 2013 13:23:33 +0000 (14:23 +0100)]
Conversion from adouble v2 to ea for directories
Fixes bug #500.
Ralph Boehme [Sat, 9 Mar 2013 12:50:37 +0000 (13:50 +0100)]
Solaris fixes for bugs #501 and #502
Frank Lahm [Fri, 8 Mar 2013 17:29:13 +0000 (18:29 +0100)]
File's ressource fork can't be read if metadata EA is missing
Fixes bug #501.
Frank Lahm [Thu, 7 Mar 2013 18:03:30 +0000 (19:03 +0100)]
Fix an issue caused by read-only ._ ressource forks
Fixes bug #502.
Frank Lahm [Wed, 6 Mar 2013 18:10:06 +0000 (19:10 +0100)]
Add IPC commands to string array
Frank Lahm [Wed, 6 Mar 2013 17:35:15 +0000 (18:35 +0100)]
Check for dbus_g_bus_get_private(), older dbus-glib versions seem to miss it
Ralph Boehme [Tue, 5 Mar 2013 08:32:28 +0000 (09:32 +0100)]
Possible fixes to afpstats dbus issue
Initialize afpstats before calling configinit in main() thus ensuring
dbus glib thread initilisation is performed as we need it.
Use private dbus connection from dbus_g_bus_get_private() which should
help with issues seen where our avahi dbus thread crashed.
Ralph Boehme [Mon, 4 Mar 2013 16:45:19 +0000 (17:45 +0100)]
New option 'afpstats'
Ralph Boehme [Wed, 27 Feb 2013 07:57:55 +0000 (08:57 +0100)]
Change pkg-config check for dbus-glib
Ralph Boehme [Mon, 25 Feb 2013 17:07:01 +0000 (18:07 +0100)]
Fix distcheck error caused by pkgconfig stuff
Ralph Boehme [Mon, 25 Feb 2013 11:12:48 +0000 (12:12 +0100)]
Add PATH to helpstring
Ralph Boehme [Sun, 24 Feb 2013 09:15:05 +0000 (10:15 +0100)]
Remove unneeded include
HAT [Fri, 22 Feb 2013 14:30:10 +0000 (23:30 +0900)]
configure summary show paths
Ralph Boehme [Fri, 22 Feb 2013 11:56:43 +0000 (12:56 +0100)]
Remove duplicated test
Frank Lahm [Fri, 22 Feb 2013 09:53:55 +0000 (10:53 +0100)]
Add a distinct variable for storing result of checks
Ralph Boehme [Thu, 21 Feb 2013 14:19:02 +0000 (15:19 +0100)]
Reload groups when reloading volumes
Reload the user groups every time the volume configuration changes
and also to call initgroups() again with the possibly changed groups.
FR #71
Frank Lahm [Thu, 21 Feb 2013 13:48:09 +0000 (14:48 +0100)]
Add checking for and linking with libgthread
Ralph Boehme [Mon, 11 Feb 2013 13:42:12 +0000 (14:42 +0100)]
Add dtrace provider 'afp' and dtrace probes
There are three dtrace probes:
- all AFP functions, passing the function name as argument
- AFP read and write, passing the IO size as argument
- all CNID functions
In order to be able to simply differintiate between disk IO and
network IO, replace all occurences of read and write on sockets
with send/recv, and replace the use of writev in the logging code
with two calls to write.
As a result, using dtrace probes for read() and write() syscalls
can be used to gather metrics for disk IO, while probing send(),
recv() and writev() probe network IO.
Ralph Boehme [Tue, 5 Feb 2013 16:25:27 +0000 (17:25 +0100)]
AFP statistics via dbus IPC
Fix PAM config installation. make distcheck was failing on Solaris
in uninstall, because the uninstall target ran some `rm -f PAMFILE`
where PAMFILE is hardcoded to /etc/pam.d. The resulting EPERM
causes the make target to fail.
Ralph Boehme [Tue, 19 Feb 2013 16:35:04 +0000 (17:35 +0100)]
Several fixes in ad_conv_dehex()
Testing whether we need to perform dehexing was done by a simple
strchr(':'), thus names only containing a single ':' would trigger
dehexing even though they might not contain the relevant strings
":2e" or :2f".
Also fix a ressource leak in bfindreplace() and simplify the
check whether a rename took place in enumerate.c.
HAT [Fri, 15 Feb 2013 12:13:35 +0000 (21:13 +0900)]
typo in netatalk.c
Ralph Boehme [Fri, 15 Feb 2013 10:32:15 +0000 (11:32 +0100)]
Add checks for required packages
Ralph Boehme [Fri, 15 Feb 2013 10:19:50 +0000 (11:19 +0100)]
User homes directory names
Fix an issue with user homes when user home directory has not the
same name as the username.
Fixes bug #497.
franklahm [Thu, 14 Feb 2013 14:47:17 +0000 (06:47 -0800)]
Merge pull request #20 from hat001/redhatinit
update RedHat initscript
HAT [Thu, 14 Feb 2013 14:27:29 +0000 (23:27 +0900)]
update RedHat initscript
"graceful" is removed because SIGQUIT is gone.
"reload" use SIGHUP.
"condrestart" is added because spec file requires it.
Riccardo Magliocchetti [Wed, 13 Feb 2013 21:18:41 +0000 (22:18 +0100)]
afpd/file: fix check in deletefile
AD_RSRC_OPEN(ad) is defined as:
(((ad)->ad_reso_refcount) && (ad_reso_fileno(ad) >= 0))
So there's no way it can returns -1
Reported by coverity as CID #762087.
Riccardo Magliocchetti [Wed, 13 Feb 2013 20:58:00 +0000 (21:58 +0100)]
libatalk: avoid double close in ad_openat
Partly revert
8852315e574879a9548c31f84c6eaea59f1db90f
Reported by Coverity as CID #980995.
Riccardo Magliocchetti [Wed, 13 Feb 2013 20:54:01 +0000 (21:54 +0100)]
afpd/volume: avoid read of unitialized pointer
Reported by Coverity as CID #980994.
Frank Lahm [Wed, 13 Feb 2013 16:27:52 +0000 (17:27 +0100)]
Couldn't create folders on FreeBSD 9.1 ZFS fileystems
Fixes bug #491.
franklahm [Tue, 12 Feb 2013 06:01:29 +0000 (22:01 -0800)]
Merge pull request #18 from xrmx/coverity3
More issues reported by Coverity
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:43:53 +0000 (22:43 +0100)]
libatal/vfs: stats a path before checking if it is a directory
Reported by Coverity as CID #201301.
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:35:21 +0000 (22:35 +0100)]
afpd/directory: avoid unitialized pointer read
Initialize fullpath to null so that in case of error before its
allocation we don't call bdestroy on random memory.
Reported by Coverity as CID #201284.
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:31:24 +0000 (22:31 +0100)]
cnid_dbd: fix resource leak
Reported by Coverity as CID #968567.
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:18:01 +0000 (22:18 +0100)]
afpd/colume: fix a couple of memory leaks
Reported by Coverity as CID #201199, #201200.
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:11:46 +0000 (22:11 +0100)]
afpd/filedir: fix memory leak
Reported by Coverity as CID #201196.
Riccardo Magliocchetti [Mon, 11 Feb 2013 21:03:26 +0000 (22:03 +0100)]
afpd/file: fix memory leak
Reported by Coverity as CID #201194.
Ralph Boehme [Thu, 7 Feb 2013 11:25:13 +0000 (12:25 +0100)]
systemd service file use PIDFile and ExecReload
Add --with-lockfile=PATH configure option for specifying an
alternative path for the netatalk lockfile.
Implements FR #70.
franklahm [Sun, 10 Feb 2013 07:30:24 +0000 (23:30 -0800)]
Merge pull request #17 from hat001/staticlibevent
bundled libevent2 is static
HAT [Sun, 10 Feb 2013 03:27:35 +0000 (12:27 +0900)]
bundled libevent2 is static
franklahm [Sat, 9 Feb 2013 21:09:50 +0000 (13:09 -0800)]
Merge pull request #16 from xrmx/coverity2
More issues reported by Coverity
franklahm [Sat, 9 Feb 2013 21:09:02 +0000 (13:09 -0800)]
Merge pull request #15 from xrmx/coverity1
Fix some issues reported by Coverity scan
Riccardo Magliocchetti [Sat, 9 Feb 2013 11:11:19 +0000 (12:11 +0100)]
afpd/hash: return error if we can't allocate the hash
Instead of possible dereference of null.
Reported by Coverity as CID #968565.
Riccardo Magliocchetti [Sat, 9 Feb 2013 11:07:28 +0000 (12:07 +0100)]
afpd/acls: fix dereference before null check error
Reported by Coverity as CID #968569.
Riccardo Magliocchetti [Sat, 9 Feb 2013 10:57:46 +0000 (11:57 +0100)]
afpd: fix out of bounds write
Reported by Coverity as CID #762111.
Riccardo Magliocchetti [Sat, 9 Feb 2013 10:49:42 +0000 (11:49 +0100)]
cnid_metad: avoid out of bounds read
The check of i < MAXVOLS should be moved before referencing srv[i].
Reported by Coverity as CID #762114.
Riccardo Magliocchetti [Sat, 9 Feb 2013 10:36:29 +0000 (11:36 +0100)]
libatalk: Fix a couple of issues in ad_openat()
Reported by coverity as CID #762151, #762127.
Riccardo Magliocchetti [Fri, 1 Feb 2013 18:33:59 +0000 (19:33 +0100)]
afpd/fce_api: avoid null pointer dereference
Move path NULL check before it is actually referenced.
Reported by Coverity as CID #968570.
Riccardo Magliocchetti [Fri, 1 Feb 2013 18:23:28 +0000 (19:23 +0100)]
afpd/fork: avoid use after free on of_closefork error
Reported by Coverity as CID #201311.
Riccardo Magliocchetti [Fri, 1 Feb 2013 18:22:17 +0000 (19:22 +0100)]
afpd/hash: avoid use after free in main in case of OOM
Reported by Coverity as CID #968574, #968575.
Ralph Boehme [Wed, 6 Feb 2013 07:30:17 +0000 (08:30 +0100)]
Remove continous service feature
Ralph Boehme [Mon, 4 Feb 2013 16:07:08 +0000 (17:07 +0100)]
Merge branch 'autobuild-dsi' into develop
Riccardo Magliocchetti [Fri, 1 Feb 2013 18:21:01 +0000 (19:21 +0100)]
afpd/volume: don't leak vol_mname in afp_openvol
Reported as Coverity by CID #201201
franklahm [Thu, 31 Jan 2013 16:21:36 +0000 (08:21 -0800)]
Merge pull request #13 from hat001/dbdshowpath
dbd command show path
HAT [Wed, 30 Jan 2013 16:06:57 +0000 (01:06 +0900)]
dbd command show path
dbd command show path #2 (use fullpathname)
Ralph Boehme [Thu, 24 Jan 2013 18:00:23 +0000 (19:00 +0100)]
Increase default DSI blocksize to 1 MB, taken from 10.8 AFP server
Frank Lahm [Mon, 21 Jan 2013 17:47:50 +0000 (18:47 +0100)]
Ignore develop abi file
Frank Lahm [Mon, 21 Jan 2013 17:43:09 +0000 (18:43 +0100)]
Set version to 3.0.3dev
Frank Lahm [Mon, 21 Jan 2013 17:16:01 +0000 (18:16 +0100)]
Add 3.0.2 ABI file and set library version
Frank Lahm [Mon, 21 Jan 2013 17:10:34 +0000 (18:10 +0100)]
Set version to 3.0.2
Ralph Boehme [Mon, 21 Jan 2013 16:50:04 +0000 (17:50 +0100)]
Update NEWS
Ralph Boehme [Mon, 21 Jan 2013 14:06:39 +0000 (15:06 +0100)]
dbd failed to convert appledouble files of symlinks
dbd simply skipped symlinks, fix this by possibly deleting the
appledouble file but still skip the CNID checks.
Also remove left-over rebuild db stuff which isn't used anymore since
the large dbd rewrite at
4913dbbc5b69642dacbe7302fc25d25f47e9c00c .
Fixes #490.
Ralph Boehme [Sat, 19 Jan 2013 17:28:40 +0000 (18:28 +0100)]
Multiple fixes and new manpage extmap.conf
Ralph Boehme [Wed, 16 Jan 2013 16:34:32 +0000 (17:34 +0100)]
Fix extension mapping
Extension mapping did only work for files with a valid metadata EA.
Fixed in #487.
Ralph Boehme [Wed, 16 Jan 2013 10:00:58 +0000 (11:00 +0100)]
Fix conditional
Fix conditional compilation checks introduced in
4f6fbcfc5f685bfd67a69e014eb18df4d984ae36 .
Ralph Boehme [Mon, 14 Jan 2013 14:13:12 +0000 (15:13 +0100)]
Automatic AppleDouble conversion to EAs failing for directories
of_stat() need be called before calling ad_convert() in order to
have a valid struct stat of the element to be converted.
Fixes bug #486.
Frank Lahm [Mon, 17 Dec 2012 09:49:51 +0000 (10:49 +0100)]
Check for KerberosV API funcs krb5_free_keytab_entry_contents and krb5_kt_free_entry
Ralph Boehme [Sat, 12 Jan 2013 12:39:59 +0000 (13:39 +0100)]
Import from Docbook
Frank Lahm [Mon, 31 Dec 2012 13:50:50 +0000 (14:50 +0100)]
Consolidate all Netatalk specific conversion in pull_charset_flags()
Netatalk specific conversion like '/' <-> ':' and CAP de-/encoding
was performed partially in pull_charset_flags() and push_charset_flags().
The resulting code was unmaintainable and as a result it failed to
to the proper conversion of ':' to '/' for an UTF8 -> UTF8-MAC
conversion.
Moving all Netatalk specific conversion to pull_charset_flags()
we can now easily do the necessary conversion in one place.
* ":xx" CAP sequences are decoded if CONV_UNESCAPEHEX is used
* ':' and '/' are CAP encoded if CONV_ESCAPEHEX is used
* ':' is converted to '/' only for a conversion whos target charset
is UTF8-MAC and whos source charset is NOT UTF8-MAC
* '/' is converted to ':' only for a conversion whos source charset
is UTF8-MAC and whos target charset is NOT UTF8-MAC
* a leading '.' is CAP encoded if CONV_ESCAPEDOTS is used
This consolidation obsoletes both CONV_ALLOW_COLON and CONV_ALLOW_SLASH
conversion options.
Frank Lahm [Fri, 4 Jan 2013 14:46:34 +0000 (15:46 +0100)]
Remove CVS keywords
Ralph Boehme [Thu, 3 Jan 2013 17:34:48 +0000 (18:34 +0100)]
Remove 'duplicated volumes paths'
Ralph Boehme [Thu, 3 Jan 2013 12:44:59 +0000 (13:44 +0100)]
rights was removed in warnings cleanup
Ralph Boehme [Thu, 3 Jan 2013 12:42:22 +0000 (13:42 +0100)]
Remove MAP_FILE
Frank Lahm [Thu, 3 Jan 2013 12:27:20 +0000 (13:27 +0100)]
Fix compiler diagnostics
Frank Lahm [Thu, 3 Jan 2013 12:19:41 +0000 (13:19 +0100)]
Add correct copyright and license
Frank Lahm [Thu, 3 Jan 2013 12:17:48 +0000 (13:17 +0100)]
Comparison, not assignment
Frank Lahm [Wed, 2 Jan 2013 18:38:57 +0000 (19:38 +0100)]
On the hunt for fixing all warnings
Ralph Boehme [Wed, 2 Jan 2013 18:18:32 +0000 (19:18 +0100)]
Fix several warnings, remove const
Ralph Boehme [Wed, 2 Jan 2013 17:51:36 +0000 (18:51 +0100)]
Add copyright and license and config.h
Ralph Boehme [Wed, 2 Jan 2013 17:49:21 +0000 (18:49 +0100)]
Remove const from path
Ralph Boehme [Wed, 2 Jan 2013 17:46:45 +0000 (18:46 +0100)]
Include config.h
Ralph Boehme [Wed, 2 Jan 2013 17:42:06 +0000 (18:42 +0100)]
Fix function definition, return type is pid_t
Ralph Boehme [Wed, 2 Jan 2013 17:39:30 +0000 (18:39 +0100)]
Use mkstemp instead of mktemp
Ralph Boehme [Wed, 2 Jan 2013 17:28:37 +0000 (18:28 +0100)]
Forward declate struct vol
Ralph Boehme [Wed, 2 Jan 2013 17:09:51 +0000 (18:09 +0100)]
Check for memcpy and don't redefine if found
Spotted by cppcheck, from Riccardo Magliocchetti.
Ralph Boehme [Wed, 2 Jan 2013 17:07:50 +0000 (18:07 +0100)]
Fix O_NETATALK_ACL define in case ACL headers are not found
Spotted by cppcheck, from Riccardo Magliocchetti.