Lists_Add(): use size of destination when copying data

This fixes the following warning of clang:

/src/ngircd/lists.c:152:44:
 warning: size argument in 'strlcpy' call appears to be size of the
 source; expected the size of the destination [-Wstrlcpy-strlcat-size]

But it isn't a real problem, because the size of the source always is the
same than the size of the destination ...

diff --git a/src/ngircd/lists.c b/src/ngircd/lists.c
index 4f57ca73521f6b65f568d0aefa9c60b844a685c6..45a4874b6e94f268aa2a0942cdf249c4aec12a24 100644 (file)
--- a/src/ngircd/lists.c
+++ b/src/ngircd/lists.c
@@ -149,7 +149,8 @@ Lists_Add(struct list_head *h, const char *Mask, time_t ValidUntil,
        if (Reason) {
                newelem->reason = malloc(strlen(Reason) + 1);
                if (newelem->reason)
        if (Reason) {
                newelem->reason = malloc(strlen(Reason) + 1);
                if (newelem->reason)

-                       strlcpy(newelem->reason, Reason, strlen(Reason) + 1);
+                       strlcpy(newelem->reason, Reason,
+                               sizeof(newelem->reason));

                else
                        Log(LOG_EMERG,
                            "Can't allocate memory for new list reason text!");
                else
                        Log(LOG_EMERG,
                            "Can't allocate memory for new list reason text!");