comments

diff --git a/plugins.d/python.d.plugin b/plugins.d/python.d.plugin
index a6b410167e91fea93dc629f304bdc075fd2fa897..b349be94c6bf1422c450dc734aaf94b6ce3f2c21 100755 (executable)
--- a/plugins.d/python.d.plugin
+++ b/plugins.d/python.d.plugin
@@ -358,6 +358,10 @@ class PythonCharts(object):
                 self._stop(job, "misbehaving. Reason: " + str(e))
 
     def update(self):
+        """
+        Creates and supervises every job thread.
+        This will stay forever and ever and ever forever and ever it'll be the one...
+        """
         for job in self.jobs:
             job.start()
 

diff --git a/python.d/python_modules/base.py b/python.d/python_modules/base.py
index 03754da629a9dfc9c2b41be3e83d841733237a62..b9737facd71939fb6dd2a33428192e1b8f9fab52 100644 (file)
--- a/python.d/python_modules/base.py
+++ b/python.d/python_modules/base.py
@@ -75,6 +75,11 @@ class BaseService(threading.Thread):
                           'freq': freq}
 
     def _run_once(self):
+        """
+        Executes self.update(interval) and draws run time chart.
+        Return value presents exit status of update()
+        :return: boolean
+        """
         t_start = time.time()
         # check if it is time to execute job update() function
         if self.timetable['next'] > t_start:
@@ -103,6 +108,11 @@ class BaseService(threading.Thread):
         return True
 
     def run(self):
+        """
+        Runs job in thread. Handles retries.
+        Exits when job failed or timed out.
+        :return: None
+        """
         self.timetable['last'] = time.time()
         while True:
             try:

diff --git a/python.d/python_modules/msg.py b/python.d/python_modules/msg.py
index fbaff211ce4c8ae2c03b070dbc3e85ef2ba12c6b..3f168895510386dcaea2a2a5cc199576e5c6cfd4 100644 (file)
--- a/python.d/python_modules/msg.py
+++ b/python.d/python_modules/msg.py
@@ -12,14 +12,11 @@ def log_msg(msg_type, *args):
     Print message on stderr.
     :param msg_type: str
     """
-    sys.stderr.write(PROGRAM)
-    sys.stderr.write(" ")
-    sys.stderr.write(msg_type)
-    sys.stderr.write(": ")
+    msg = PROGRAM + " " + str(msg_type) + ":"
     for i in args:
-        sys.stderr.write(" ")
-        sys.stderr.write(str(i))
-    sys.stderr.write("\n")
+        msg += " "
+        msg += str(i)
+    sys.stderr.write(msg + "\n")
     sys.stderr.flush()