Frank Lahm [Wed, 24 Oct 2012 07:38:31 +0000 (09:38 +0200)]
Fix searching from OS X cmdline
Searching from OS X cmdline with `mdfind` will generate queries with
an empty query attribute array. In that case we must add a nil element
for every query match to the filemeta array.
Also fixed:
* marshalling of empty CNID arrays and filemeta
* return 0x23 instead of 0 when returning a non empty result list, this
is was traces of an OS X AFP server show
Frank Lahm [Tue, 23 Oct 2012 19:59:10 +0000 (21:59 +0200)]
Initialize Spotlight from session child
Spotlight initialisation must be perfomed in the session childs.
Wrap all Tracker calls between become_root()/unbecome_root().
Force bus SPARQL backend, as direct connections cause problems
with some SPARQL queries.
Frank Lahm [Wed, 17 Oct 2012 21:06:21 +0000 (23:06 +0200)]
Support for FTS and filename search
Map * and kMDItemTextContent to SPARQL FTS, map kMDItemDisplayName to SPARQL
nfo:fileName. The SPARQL query for the latter doesn't work from afpd, but
it does work with tracker-sparql.
Frank Lahm [Tue, 9 Oct 2012 16:23:57 +0000 (18:23 +0200)]
Fix a bug where Mac OS X ZIP archives can't be extracted on Netatalk shares
Mac OS X ZIP archives may contain split AppleDouble forks named "._XXX".
The client needs to be able to fully access these files but we currently
prevent access to any valid AppleDouble file whose name starts with "._".
In order to distinguish our own ._ files from the one created by OS X,
we look at the filler bytes: luckily OS X stores a string "Mac OS X" there
which can be used to detect them.
Frank Lahm [Thu, 11 Oct 2012 11:02:55 +0000 (13:02 +0200)]
Fix check for nested and duplicated volume paths
The previous modification was based on ensuring the volume paths are
'/' terminated. That allowed for a simple and quick implementation of
the neccessary tests. Unfortunately that completely broke the whole
directory machinery and cache.
This patch reverts the previous change and tries another simple
implementation that avoid copying the paths.
Frank Lahm [Wed, 10 Oct 2012 13:34:34 +0000 (15:34 +0200)]
Ensure the volume path is '/' terminated and allow nested volumes
The previos change to the way checking for duplicate and nested paths only
works if the path is terminated with a '/'.
Allow nested volumes. This was working in 2.2 and can be used eg for sharing
a ZFS snapshot directory of a volume. Afaict it only works with sane AFP
semantics by adding 'cnid sheme = tdb' to the nested volume which also
makes it read-only and by adding the name of the nested directory to
the veto name list.
Frank Lahm [Wed, 10 Oct 2012 11:51:34 +0000 (13:51 +0200)]
Remove unneccessary call to getcwd()
getcwd() was called after a chdir(vol->v_path) in order to copy
the path to vol->v_path. But as v_path is now already set in netatalk_conf.c
when parsing the volumes config, this is not neccessary anymore.
Frank Lahm [Thu, 23 Aug 2012 10:20:00 +0000 (12:20 +0200)]
Fix data corruption bug
Received data from the client was written to the read-ahead buffer
from dsi_peek() which caused data corrution.
Fix is: change the DSI command buffer from static 8192 bytes to
an allocated buffer of size DSI quantum and use this buffer in
dsi_write/write_fork. That just requires dsi_writeinit to use
memmove instead of memcpy, because now we use the same buffer.
The bug is caused by passing ADFLAGS_NOHF to ad_open() when opening a
files data fork. For files without metadata then ad_open() doesn't
return an error for the ADFLAGS_HF request to open the metadata. As a
result of the successfull ad_open return AFPFORK_META is set in the
fork struct, which implies the meta is open. Later afp_close looked at
that flag and added ADFLAGS_HF to ad_close flags, resulting in a
refcount decement of 2 although the ad_open only incremented by 1. Eg
opening such a file twice, then closing once, close the fork. Later
operations on the other still open fork fail.
afp_openfork opens the fork and metadata in one call to ad_open which
lead to an insane if/else and error checking code path. I've
seperated this in two distincs calls to ad_open(): the first opens the
fork (data or ressource), the second opens the metadata. This gives a
cleaner code path but it required a subtle modifications to the way we
refcount and flag forks as open inside ad_open: currently we use the
fd and it's recount but these do not differente between open data and
metadata in the case of adouble:ea as both use the data fork handle,
fd and it's refcount. Now we add real refcounting for the forks
different from the recount on the file fd by adding three refcounting
variables to struct.adouble and change the AD_XXX_OPEN macros to use
these.
projects / netatalk.git / log