/*
- * $Id: uams_passwd.c,v 1.13 2001-09-06 20:00:59 rufustfirefly Exp $
+ * $Id: uams_passwd.c,v 1.13.2.1 2002-02-08 00:00:01 srittau Exp $
*
* Copyright (c) 1990,1993 Regents of The University of Michigan.
* Copyright (c) 1999 Adrian Sun (asun@u.washington.edu)
/* cleartxt login */
static int passwd_login(void *obj, struct passwd **uam_pwd,
- char *ibuf, int ibuflen,
- char *rbuf, int *rbuflen)
+ char *ibuf, int ibuflen,
+ char *rbuf, int *rbuflen)
{
struct passwd *pwd;
#ifdef SHADOWPW
*rbuflen = 0;
if (uam_afpserver_option(obj, UAM_OPTION_USERNAME,
- (void *) &username, &ulen) < 0)
- return AFPERR_MISC;
+ (void *) &username, &ulen) < 0)
+ return AFPERR_MISC;
#ifdef TRU64
if( uam_afpserver_option( obj, UAM_OPTION_CLIENTNAME,
return AFPERR_MISC;
#endif /* TRU64 */
+ if (ibuflen <= 1) {
+ return( AFPERR_PARAM );
+ }
+
len = (unsigned char) *ibuf++;
- if ( len > ulen ) {
- return( AFPERR_PARAM );
+ ibuflen--;
+ if (!len || len > ibuflen || len > ulen ) {
+ return( AFPERR_PARAM );
}
memcpy(username, ibuf, len );
ibuf += len;
+ ibuflen -=len;
username[ len ] = '\0';
- if ((unsigned long) ibuf & 1) /* pad character */
- ++ibuf;
+
+ if ((unsigned long) ibuf & 1) { /* pad character */
+ ++ibuf;
+ ibuflen--;
+ }
+ if (ibuflen < PASSWDLEN) {
+ return( AFPERR_PARAM );
+ }
ibuf[ PASSWDLEN ] = '\0';
if (( pwd = uam_getname(username, ulen)) == NULL ) {
- return AFPERR_PARAM;
+ return AFPERR_PARAM;
}
syslog(LOG_INFO, "cleartext login: %s", username);
- if (uam_checkuser(pwd) < 0)
- return AFPERR_NOTAUTH;
+ if (uam_checkuser(pwd) < 0) {
+ return AFPERR_NOTAUTH;
+ }
#ifdef SHADOWPW
if (( sp = getspnam( pwd->pw_name )) == NULL ) {
pwd->pw_passwd = sp->sp_pwdp;
#endif /* SHADOWPW */
- if (!pwd->pw_passwd)
- return AFPERR_NOTAUTH;
+ if (!pwd->pw_passwd) {
+ return AFPERR_NOTAUTH;
+ }
*uam_pwd = pwd;
}
#else /* TRU64 */
p = crypt( ibuf, pwd->pw_passwd );
- if ( strcmp( p, pwd->pw_passwd ) == 0 )
- return AFP_OK;
+ if ( strcmp( p, pwd->pw_passwd ) == 0 )
+ return AFP_OK;
#endif /* TRU64 */
return AFPERR_NOTAUTH;
#if 0
/* change passwd */
static int passwd_changepw(void *obj, char *username,
- struct passwd *pwd, char *ibuf,
- int ibuflen, char *rbuf, int *rbuflen)
+ struct passwd *pwd, char *ibuf,
+ int ibuflen, char *rbuf, int *rbuflen)
{
#ifdef SHADOWPW
struct spwd *sp;
uid_t uid = geteuid();
if (uam_checkuser(pwd) < 0)
- return AFPERR_ACCESS;
+ return AFPERR_ACCESS;
/* old password */
memcpy(pw, ibuf, PASSWDLEN);
p = crypt(pw, pwd->pw_passwd );
if (strcmp( p, pwd->pw_passwd )) {
- memset(pw, 0, sizeof(pw));
- return AFPERR_NOTAUTH;
+ memset(pw, 0, sizeof(pw));
+ return AFPERR_NOTAUTH;
}
/* new password */
ibuf += PASSWDLEN;
ibuf[PASSWDLEN] = '\0';
-
+
#ifdef SHADOWPW
#else /* SHADOWPW */
#endif /* SHADOWPW */
return AFP_OK;
-}
+}
#endif /* 0 */
}
if (uam_checkuser(pwd) < 0) {
- /* syslog of error happens in uam_checkuser */
- return(-1);
+ /* syslog of error happens in uam_checkuser */
+ return(-1);
}
#ifdef SHADOWPW
}
#ifdef AFS
- if ( kcheckuser( pwd, password) == 0)
- return(0);
+ if ( kcheckuser( pwd, password) == 0)
+ return(0);
#endif /* AFS */
p = crypt(password, pwd->pw_passwd);
static int uam_setup(const char *path)
{
- if (uam_register(UAM_SERVER_LOGIN, path, "Cleartxt Passwrd",
- passwd_login, NULL, NULL) < 0)
- return -1;
- if (uam_register(UAM_SERVER_PRINTAUTH, path, "ClearTxtUAM",
- passwd_printer) < 0)
- return -1;
-
- return 0;
+ if (uam_register(UAM_SERVER_LOGIN, path, "Cleartxt Passwrd",
+ passwd_login, NULL, NULL) < 0)
+ return -1;
+ if (uam_register(UAM_SERVER_PRINTAUTH, path, "ClearTxtUAM",
+ passwd_printer) < 0)
+ return -1;
+
+ return 0;
}
static void uam_cleanup(void)
{
- uam_unregister(UAM_SERVER_LOGIN, "Cleartxt Passwrd");
- uam_unregister(UAM_SERVER_PRINTAUTH, "ClearTxtUAM");
+ uam_unregister(UAM_SERVER_LOGIN, "Cleartxt Passwrd");
+ uam_unregister(UAM_SERVER_PRINTAUTH, "ClearTxtUAM");
}
UAM_MODULE_EXPORT struct uam_export uams_clrtxt = {
- UAM_MODULE_SERVER,
- UAM_MODULE_VERSION,
- uam_setup, uam_cleanup
-};
+ UAM_MODULE_SERVER,
+ UAM_MODULE_VERSION,
+ uam_setup, uam_cleanup
+ };