Call add_error() with one arg on readlink failure

...instead of two.

This bug and its solution was found by Ben Kelly.

Signed-off-by: Gabriel Filion <gabster@lelutin.ca>
[rlb@defaultvalue.org: adjust commit message]
Reviewed-by: Rob Browning <rlb@defaultvalue.org>

diff --git a/lib/bup/metadata.py b/lib/bup/metadata.py
index 685c6630495ef8f361390576d832f8036dfe6266..8a84f11747e1ca6725275683f8b736501eebc8af 100644 (file)
--- a/lib/bup/metadata.py
+++ b/lib/bup/metadata.py
@@ -446,7 +446,7 @@ class Metadata:
             if stat.S_ISLNK(st.st_mode):
                 self.symlink_target = os.readlink(path)
         except OSError, e:
             if stat.S_ISLNK(st.st_mode):
                 self.symlink_target = os.readlink(path)
         except OSError, e:

-            add_error('readlink: %s', e)
+            add_error('readlink: %s' % e)

 
     def _encode_symlink_target(self):
         return self.symlink_target
 
     def _encode_symlink_target(self):
         return self.symlink_target