]> arthur.barton.de Git - bup.git/blobdiff - lib/bup/t/tvfs.py
vfs: use None for unknown uid/gid
[bup.git] / lib / bup / t / tvfs.py
index 1a18b6fd650eb6fea9e40e0a9d6fcf35e49040a2..2563333a6481ccb1e213a35124799d8f9a4f1588 100644 (file)
@@ -1,81 +1,87 @@
 
-from __future__ import print_function
+from __future__ import absolute_import, print_function
+from binascii import unhexlify
 from collections import namedtuple
 from errno import ELOOP, ENOTDIR
 from io import BytesIO
-from os import environ, symlink
-from stat import S_IFDIR, S_IFREG, S_ISDIR, S_ISREG
+from os import symlink
+from random import Random, randint
+from stat import S_IFDIR, S_IFLNK, S_IFREG, S_ISDIR, S_ISREG
 from sys import stderr
-from time import localtime, strftime
+from time import localtime, strftime, tzset
 
 from wvtest import *
 
-from bup import git, metadata, vfs2 as vfs
+from bup._helpers import write_random
+from bup import git, metadata, vfs
+from bup.compat import environ, fsencode, items, range
 from bup.git import BUP_CHUNKED
-from bup.helpers import exc, exo, shstr
+from bup.helpers import exc, shstr
 from bup.metadata import Metadata
 from bup.repo import LocalRepo
-from buptest import no_lingering_errors, test_tempdir
+from bup.test.vfs import tree_dict
+from buptest import ex, exo, no_lingering_errors, test_tempdir
 
-top_dir = '../../..'
-bup_tmp = os.path.realpath('../../../t/tmp')
-bup_path = top_dir + '/bup'
+top_dir = b'../../..'
+bup_tmp = os.path.realpath(b'../../../t/tmp')
+bup_path = top_dir + b'/bup'
 start_dir = os.getcwd()
 
-## The clear_cache() calls below are to make sure that the test starts
-## from a known state since at the moment the cache entry for a given
-## item (like a commit) can change.  For example, its meta value might
-## be promoted from a mode to a Metadata instance once the tree it
-## refers to is traversed.
-
 def ex(cmd, **kwargs):
     print(shstr(cmd), file=stderr)
     return exc(cmd, **kwargs)
 
-TreeDictValue = namedtuple('TreeDictValue', ('name', 'oid', 'meta'))
-
-def tree_items(repo, oid):
-    """Yield (name, entry_oid, meta) for each entry in oid.  meta will be
-    a Metadata object for any non-directories and for '.', otherwise
-    None.
+@wvtest
+def test_default_modes():
+    wvpasseq(S_IFREG | 0o644, vfs.default_file_mode)
+    wvpasseq(S_IFDIR | 0o755, vfs.default_dir_mode)
+    wvpasseq(S_IFLNK | 0o755, vfs.default_symlink_mode)
 
-    """
-    # This is a simpler approach than the one in the vfs, used to
-    # cross-check its behavior.
-    tree_data, bupm_oid = vfs.tree_data_and_bupm(repo, oid)
-    bupm = vfs._FileReader(repo, bupm_oid) if bupm_oid else None
+@wvtest
+def test_cache_behavior():
+    orig_max = vfs._cache_max_items
     try:
-        maybe_meta = lambda : Metadata.read(bupm) if bupm else None
-        m = maybe_meta()
-        if m:
-            m.size = 0
-        yield TreeDictValue(name='.', oid=oid, meta=m)
-        tree_ents = vfs.ordered_tree_entries(tree_data, bupm=True)
-        for name, mangled_name, kind, gitmode, sub_oid in tree_ents:
-            if mangled_name == '.bupm':
-                continue
-            assert name != '.'
-            if S_ISDIR(gitmode):
-                if kind == BUP_CHUNKED:
-                    yield TreeDictValue(name=name, oid=sub_oid,
-                                        meta=maybe_meta())
-                else:
-                    yield TreeDictValue(name=name, oid=sub_oid,
-                                        meta=vfs.default_dir_mode)
-            else:
-                yield TreeDictValue(name=name, oid=sub_oid, meta=maybe_meta())
+        vfs._cache_max_items = 2
+        vfs.clear_cache()
+        wvpasseq({}, vfs._cache)
+        wvpasseq([], vfs._cache_keys)
+        wvfail(vfs._cache_keys)
+        wvexcept(Exception, vfs.cache_notice, b'x', 1)
+        key_0 = b'itm:' + b'\0' * 20
+        key_1 = b'itm:' + b'\1' * 20
+        key_2 = b'itm:' + b'\2' * 20
+        vfs.cache_notice(key_0, b'something')
+        wvpasseq({key_0 : b'something'}, vfs._cache)
+        wvpasseq([key_0], vfs._cache_keys)
+        vfs.cache_notice(key_1, b'something else')
+        wvpasseq({key_0 : b'something', key_1 : b'something else'}, vfs._cache)
+        wvpasseq(frozenset([key_0, key_1]), frozenset(vfs._cache_keys))
+        vfs.cache_notice(key_2, b'and also')
+        wvpasseq(2, len(vfs._cache))
+        wvpass(frozenset(items(vfs._cache))
+               < frozenset(items({key_0 : b'something',
+                                  key_1 : b'something else',
+                                  key_2 : b'and also'})))
+        wvpasseq(2, len(vfs._cache_keys))
+        wvpass(frozenset(vfs._cache_keys) < frozenset([key_0, key_1, key_2]))
+        vfs.clear_cache()
+        wvpasseq({}, vfs._cache)
+        wvpasseq([], vfs._cache_keys)
     finally:
-        if bupm:
-            bupm.close()
+        vfs._cache_max_items = orig_max
+        vfs.clear_cache()
 
-def tree_dict(repo, oid):
-    return dict((x.name, x) for x in tree_items(repo, oid))
+## The clear_cache() calls below are to make sure that the test starts
+## from a known state since at the moment the cache entry for a given
+## item (like a commit) can change.  For example, its meta value might
+## be promoted from a mode to a Metadata instance once the tree it
+## refers to is traversed.
 
 def run_augment_item_meta_tests(repo,
                                 file_path, file_size,
                                 link_path, link_target):
     _, file_item = vfs.resolve(repo, file_path)[-1]
-    _, link_item = vfs.lresolve(repo, link_path)[-1]
+    _, link_item = vfs.resolve(repo, link_path, follow=False)[-1]
     wvpass(isinstance(file_item.meta, Metadata))
     wvpass(isinstance(link_item.meta, Metadata))
     # Note: normally, modifying item.meta values is forbidden
@@ -108,7 +114,7 @@ def run_augment_item_meta_tests(repo,
         wvpass(item is not file_item)
         wvpass(isinstance(meta, Metadata))
         wvpasseq(vfs.default_file_mode, meta.mode)
-        wvpasseq((0, 0, 0, 0, 0),
+        wvpasseq((None, None, 0, 0, 0),
                  (meta.uid, meta.gid, meta.atime, meta.mtime, meta.ctime))
     wvpass(augmented.meta.size is None)
     wvpasseq(file_size, augmented_w_size.meta.size)
@@ -131,72 +137,75 @@ def run_augment_item_meta_tests(repo,
 def test_item_mode():
     with no_lingering_errors():
         mode = S_IFDIR | 0o755
-        meta = metadata.from_path('.')
-        oid = '\0' * 20
+        meta = metadata.from_path(b'.')
+        oid = b'\0' * 20
         wvpasseq(mode, vfs.item_mode(vfs.Item(oid=oid, meta=mode)))
         wvpasseq(meta.mode, vfs.item_mode(vfs.Item(oid=oid, meta=meta)))
 
 @wvtest
 def test_reverse_suffix_duplicates():
     suffix = lambda x: tuple(vfs._reverse_suffix_duplicates(x))
-    wvpasseq(('x',), suffix(('x',)))
-    wvpasseq(('x', 'y'), suffix(('x', 'y')))
-    wvpasseq(('x-1', 'x-0'), suffix(('x',) * 2))
-    wvpasseq(['x-%02d' % n for n in reversed(range(11))],
-             list(suffix(('x',) * 11)))
-    wvpasseq(('x-1', 'x-0', 'y'), suffix(('x', 'x', 'y')))
-    wvpasseq(('x', 'y-1', 'y-0'), suffix(('x', 'y', 'y')))
-    wvpasseq(('x', 'y-1', 'y-0', 'z'), suffix(('x', 'y', 'y', 'z')))
+    wvpasseq((b'x',), suffix((b'x',)))
+    wvpasseq((b'x', b'y'), suffix((b'x', b'y')))
+    wvpasseq((b'x-1', b'x-0'), suffix((b'x',) * 2))
+    wvpasseq([b'x-%02d' % n for n in reversed(range(11))],
+             list(suffix((b'x',) * 11)))
+    wvpasseq((b'x-1', b'x-0', b'y'), suffix((b'x', b'x', b'y')))
+    wvpasseq((b'x', b'y-1', b'y-0'), suffix((b'x', b'y', b'y')))
+    wvpasseq((b'x', b'y-1', b'y-0', b'z'), suffix((b'x', b'y', b'y', b'z')))
 
 @wvtest
 def test_misc():
     with no_lingering_errors():
-        with test_tempdir('bup-tvfs-') as tmpdir:
-            bup_dir = tmpdir + '/bup'
-            environ['GIT_DIR'] = bup_dir
-            environ['BUP_DIR'] = bup_dir
+        with test_tempdir(b'bup-tvfs-') as tmpdir:
+            bup_dir = tmpdir + b'/bup'
+            environ[b'GIT_DIR'] = bup_dir
+            environ[b'BUP_DIR'] = bup_dir
             git.repodir = bup_dir
-            data_path = tmpdir + '/src'
+            data_path = tmpdir + b'/src'
             os.mkdir(data_path)
-            with open(data_path + '/file', 'w+') as tmpfile:
+            with open(data_path + b'/file', 'wb+') as tmpfile:
                 tmpfile.write(b'canary\n')
-            symlink('file', data_path + '/symlink')
-            ex((bup_path, 'init'))
-            ex((bup_path, 'index', '-v', data_path))
-            ex((bup_path, 'save', '-d', '100000', '-tvvn', 'test', '--strip',
-                data_path))
+            symlink(b'file', data_path + b'/symlink')
+            ex((bup_path, b'init'))
+            ex((bup_path, b'index', b'-v', data_path))
+            ex((bup_path, b'save', b'-d', b'100000', b'-tvvn', b'test',
+                b'--strip', data_path))
             repo = LocalRepo()
 
             wvstart('readlink')
-            ls_tree = exo(('git', 'ls-tree', 'test', 'symlink'))
-            mode, typ, oidx, name = ls_tree[0].strip().split(None, 3)
-            assert name == 'symlink'
-            link_item = vfs.Item(oid=oidx.decode('hex'), meta=int(mode, 8))
-            wvpasseq('file', vfs.readlink(repo, link_item))
-
-            ls_tree = exo(('git', 'ls-tree', 'test', 'file'))
-            mode, typ, oidx, name = ls_tree[0].strip().split(None, 3)
-            assert name == 'file'
-            file_item = vfs.Item(oid=oidx.decode('hex'), meta=int(mode, 8))
+            ls_tree = exo((b'git', b'ls-tree', b'test', b'symlink')).out
+            mode, typ, oidx, name = ls_tree.strip().split(None, 3)
+            assert name == b'symlink'
+            link_item = vfs.Item(oid=unhexlify(oidx), meta=int(mode, 8))
+            wvpasseq(b'file', vfs.readlink(repo, link_item))
+
+            ls_tree = exo((b'git', b'ls-tree', b'test', b'file')).out
+            mode, typ, oidx, name = ls_tree.strip().split(None, 3)
+            assert name == b'file'
+            file_item = vfs.Item(oid=unhexlify(oidx), meta=int(mode, 8))
             wvexcept(Exception, vfs.readlink, repo, file_item)
 
             wvstart('item_size')
             wvpasseq(4, vfs.item_size(repo, link_item))
             wvpasseq(7, vfs.item_size(repo, file_item))
-            meta = metadata.from_path(__file__)
+            meta = metadata.from_path(fsencode(__file__))
             meta.size = 42
             fake_item = file_item._replace(meta=meta)
             wvpasseq(42, vfs.item_size(repo, fake_item))
 
+            _, fakelink_item = vfs.resolve(repo, b'/test/latest', follow=False)[-1]
+            wvpasseq(17, vfs.item_size(repo, fakelink_item))
+
             wvstart('augment_item_meta')
             run_augment_item_meta_tests(repo,
-                                        '/test/latest/file', 7,
-                                        '/test/latest/symlink', 'file')
+                                        b'/test/latest/file', 7,
+                                        b'/test/latest/symlink', b'file')
 
             wvstart('copy_item')
             # FIXME: this caused StopIteration
             #_, file_item = vfs.resolve(repo, '/file')[-1]
-            _, file_item = vfs.resolve(repo, '/test/latest/file')[-1]
+            _, file_item = vfs.resolve(repo, b'/test/latest/file')[-1]
             file_copy = vfs.copy_item(file_item)
             wvpass(file_copy is not file_item)
             wvpass(file_copy.meta is not file_item.meta)
@@ -206,364 +215,188 @@ def test_misc():
             file_copy.meta.user = None
             wvpass(file_item.meta.user)
 
-@wvtest
-def test_resolve():
-    with no_lingering_errors():
-        with test_tempdir('bup-tvfs-') as tmpdir:
-            resolve = vfs.resolve
-            lresolve = vfs.lresolve
-            bup_dir = tmpdir + '/bup'
-            environ['GIT_DIR'] = bup_dir
-            environ['BUP_DIR'] = bup_dir
-            git.repodir = bup_dir
-            data_path = tmpdir + '/src'
-            save_time = 100000
-            save_time_str = strftime('%Y-%m-%d-%H%M%S', localtime(save_time))
-            os.mkdir(data_path)
-            os.mkdir(data_path + '/dir')
-            with open(data_path + '/file', 'w+') as tmpfile:
-                print('canary', file=tmpfile)
-            symlink('file', data_path + '/file-symlink')
-            symlink('dir', data_path + '/dir-symlink')
-            symlink('not-there', data_path + '/bad-symlink')
-            ex((bup_path, 'init'))
-            ex((bup_path, 'index', '-v', data_path))
-            ex((bup_path, 'save', '-d', str(save_time), '-tvvn', 'test',
-                '--strip', data_path))
-            ex((bup_path, 'tag', 'test-tag', 'test'))
-            repo = LocalRepo()
-
-            tip_hash = exo(('git', 'show-ref', 'refs/heads/test'))[0]
-            tip_oidx = tip_hash.strip().split()[0]
-            tip_oid = tip_oidx.decode('hex')
-            tip_tree_oidx = exo(('git', 'log', '--pretty=%T', '-n1',
-                                 tip_oidx))[0].strip()
-            tip_tree_oid = tip_tree_oidx.decode('hex')
-            tip_tree = tree_dict(repo, tip_tree_oid)
-            test_revlist_w_meta = vfs.RevList(meta=tip_tree['.'].meta,
-                                              oid=tip_oid)
-            expected_latest_item = vfs.Commit(meta=S_IFDIR | 0o755,
-                                              oid=tip_tree_oid,
-                                              coid=tip_oid)
-            expected_latest_item_w_meta = vfs.Commit(meta=tip_tree['.'].meta,
-                                                     oid=tip_tree_oid,
-                                                     coid=tip_oid)
-            expected_test_tag_item = expected_latest_item
-
-            wvstart('resolve: /')
-            vfs.clear_cache()
-            res = resolve(repo, '/')
-            wvpasseq(1, len(res))
-            wvpasseq((('', vfs._root),), res)
-            ignore, root_item = res[0]
-            root_content = frozenset(vfs.contents(repo, root_item))
-            wvpasseq(frozenset([('.', root_item),
-                                ('.tag', vfs._tags),
-                                ('test', test_revlist_w_meta)]),
-                     root_content)
-            for path in ('//', '/.', '/./', '/..', '/../',
-                         '/test/latest/dir/../../..',
-                         '/test/latest/dir/../../../',
-                         '/test/latest/dir/../../../.',
-                         '/test/latest/dir/../../..//',
-                         '/test//latest/dir/../../..',
-                         '/test/./latest/dir/../../..',
-                         '/test/././latest/dir/../../..',
-                         '/test/.//./latest/dir/../../..',
-                         '/test//.//.//latest/dir/../../..'
-                         '/test//./latest/dir/../../..'):
-                wvstart('resolve: ' + path)
-                vfs.clear_cache()
-                res = resolve(repo, path)
-                wvpasseq((('', vfs._root),), res)
-
-            wvstart('resolve: /.tag')
-            vfs.clear_cache()
-            res = resolve(repo, '/.tag')
-            wvpasseq(2, len(res))
-            wvpasseq((('', vfs._root), ('.tag', vfs._tags)),
-                     res)
-            ignore, tag_item = res[1]
-            tag_content = frozenset(vfs.contents(repo, tag_item))
-            wvpasseq(frozenset([('.', tag_item),
-                                ('test-tag', expected_test_tag_item)]),
-                     tag_content)
-
-            wvstart('resolve: /test')
-            vfs.clear_cache()
-            res = resolve(repo, '/test')
-            wvpasseq(2, len(res))
-            wvpasseq((('', vfs._root), ('test', test_revlist_w_meta)), res)
-            ignore, test_item = res[1]
-            test_content = frozenset(vfs.contents(repo, test_item))
-            # latest has metadata here due to caching
-            wvpasseq(frozenset([('.', test_revlist_w_meta),
-                                (save_time_str, expected_latest_item_w_meta),
-                                ('latest', expected_latest_item_w_meta)]),
-                     test_content)
-
-            wvstart('resolve: /test/latest')
-            vfs.clear_cache()
-            res = resolve(repo, '/test/latest')
-            wvpasseq(3, len(res))
-            expected_latest_item_w_meta = vfs.Commit(meta=tip_tree['.'].meta,
-                                                     oid=tip_tree_oid,
-                                                     coid=tip_oid)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta))
-            wvpasseq(expected, res)
-            ignore, latest_item = res[2]
-            latest_content = frozenset(vfs.contents(repo, latest_item))
-            expected = frozenset((x.name, vfs.Item(oid=x.oid, meta=x.meta))
-                                 for x in (tip_tree[name]
-                                           for name in ('.',
-                                                        'bad-symlink',
-                                                        'dir',
-                                                        'dir-symlink',
-                                                        'file',
-                                                        'file-symlink')))
-            wvpasseq(expected, latest_content)
-
-            wvstart('resolve: /test/latest/file')
-            vfs.clear_cache()
-            res = resolve(repo, '/test/latest/file')
-            wvpasseq(4, len(res))
-            expected_file_item_w_meta = vfs.Item(meta=tip_tree['file'].meta,
-                                                 oid=tip_tree['file'].oid)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('file', expected_file_item_w_meta))
-            wvpasseq(expected, res)
-
-            wvstart('resolve: /test/latest/bad-symlink')
-            vfs.clear_cache()
-            res = resolve(repo, '/test/latest/bad-symlink')
-            wvpasseq(4, len(res))
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('not-there', None))
-            wvpasseq(expected, res)
-
-            wvstart('lresolve: /test/latest/bad-symlink')
-            vfs.clear_cache()
-            res = lresolve(repo, '/test/latest/bad-symlink')
-            wvpasseq(4, len(res))
-            bad_symlink_value = tip_tree['bad-symlink']
-            expected_bad_symlink_item_w_meta = vfs.Item(meta=bad_symlink_value.meta,
-                                                        oid=bad_symlink_value.oid)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('bad-symlink', expected_bad_symlink_item_w_meta))
-            wvpasseq(expected, res)
-
-            wvstart('resolve: /test/latest/file-symlink')
-            vfs.clear_cache()
-            res = resolve(repo, '/test/latest/file-symlink')
-            wvpasseq(4, len(res))
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('file', expected_file_item_w_meta))
-            wvpasseq(expected, res)
-
-            wvstart('lresolve: /test/latest/file-symlink')
-            vfs.clear_cache()
-            res = lresolve(repo, '/test/latest/file-symlink')
-            wvpasseq(4, len(res))
-            file_symlink_value = tip_tree['file-symlink']
-            expected_file_symlink_item_w_meta = vfs.Item(meta=file_symlink_value.meta,
-                                                         oid=file_symlink_value.oid)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('file-symlink', expected_file_symlink_item_w_meta))
-            wvpasseq(expected, res)
-
-            wvstart('resolve: /test/latest/missing')
-            vfs.clear_cache()
-            res = resolve(repo, '/test/latest/missing')
-            wvpasseq(4, len(res))
-            name, item = res[-1]
-            wvpasseq('missing', name)
-            wvpass(item is None)
-
-            for path in ('/test/latest/file/',
-                         '/test/latest/file/.',
-                         '/test/latest/file/..',
-                         '/test/latest/file/../',
-                         '/test/latest/file/../.',
-                         '/test/latest/file/../..',
-                         '/test/latest/file/foo'):
-                wvstart('resolve: ' + path)
-                vfs.clear_cache()
-                try:
-                    resolve(repo, path)
-                except vfs.IOError as res_ex:
-                    wvpasseq(ENOTDIR, res_ex.errno)
-                    wvpasseq(['', 'test', 'latest', 'file'],
-                             [name for name, item in res_ex.terminus])
-
-            for path in ('/test/latest/file-symlink/',
-                         '/test/latest/file-symlink/.',
-                         '/test/latest/file-symlink/..',
-                         '/test/latest/file-symlink/../',
-                         '/test/latest/file-symlink/../.',
-                         '/test/latest/file-symlink/../..'):
-                wvstart('lresolve: ' + path)
-                vfs.clear_cache()
-                try:
-                    lresolve(repo, path)
-                except vfs.IOError as res_ex:
-                    wvpasseq(ENOTDIR, res_ex.errno)
-                    wvpasseq(['', 'test', 'latest', 'file'],
-                             [name for name, item in res_ex.terminus])
-
-            wvstart('resolve: non-directory parent')
-            vfs.clear_cache()
-            file_res = resolve(repo, '/test/latest/file')
-            try:
-                resolve(repo, 'foo', parent=file_res)
-            except vfs.IOError as res_ex:
-                wvpasseq(ENOTDIR, res_ex.errno)
-                wvpasseq(None, res_ex.terminus)
-
-            wvstart('lresolve: /test/latest/dir-symlink')
-            vfs.clear_cache()
-            res = lresolve(repo, '/test/latest/dir-symlink')
-            wvpasseq(4, len(res))
-            dir_symlink_value = tip_tree['dir-symlink']
-            expected_dir_symlink_item_w_meta = vfs.Item(meta=dir_symlink_value.meta,
-                                                         oid=dir_symlink_value.oid)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('dir-symlink', expected_dir_symlink_item_w_meta))
-            wvpasseq(expected, res)
-
-            dir_value = tip_tree['dir']
-            expected_dir_item = vfs.Item(oid=dir_value.oid,
-                                         meta=tree_dict(repo, dir_value.oid)['.'].meta)
-            expected = (('', vfs._root),
-                        ('test', test_revlist_w_meta),
-                        ('latest', expected_latest_item_w_meta),
-                        ('dir', expected_dir_item))
-            for resname, resolver in (('resolve', resolve),
-                                      ('lresolve', lresolve)):
-                for path in ('/test/latest/dir-symlink/',
-                             '/test/latest/dir-symlink/.'):
-                    wvstart(resname + ': ' + path)
-                    vfs.clear_cache()
-                    res = resolver(repo, path)
-                    wvpasseq(4, len(res))
-                    wvpasseq(expected, res)
-            wvstart('resolve: /test/latest/dir-symlink')
-            vfs.clear_cache()
-            res = resolve(repo, path)
-            wvpasseq(4, len(res))
-            wvpasseq(expected, res)
+def write_sized_random_content(parent_dir, size, seed):
+    verbose = 0
+    with open(b'%s/%d' % (parent_dir, size), 'wb') as f:
+        write_random(f.fileno(), size, seed, verbose)
+
+def validate_vfs_streaming_read(repo, item, expected_path, read_sizes):
+    for read_size in read_sizes:
+        with open(expected_path, 'rb') as expected:
+            with vfs.fopen(repo, item) as actual:
+                ex_buf = expected.read(read_size)
+                act_buf = actual.read(read_size)
+                while ex_buf and act_buf:
+                    wvpassge(read_size, len(ex_buf))
+                    wvpassge(read_size, len(act_buf))
+                    wvpasseq(len(ex_buf), len(act_buf))
+                    wvpass(ex_buf == act_buf)
+                    ex_buf = expected.read(read_size)
+                    act_buf = actual.read(read_size)
+                wvpasseq(b'', ex_buf)
+                wvpasseq(b'', act_buf)
+
+def validate_vfs_seeking_read(repo, item, expected_path, read_sizes):
+    def read_act(act_pos):
+        with vfs.fopen(repo, item) as actual:
+            actual.seek(act_pos)
+            wvpasseq(act_pos, actual.tell())
+            act_buf = actual.read(read_size)
+            act_pos += len(act_buf)
+            wvpasseq(act_pos, actual.tell())
+            return act_pos, act_buf
+
+    for read_size in read_sizes:
+        with open(expected_path, 'rb') as expected:
+                ex_buf = expected.read(read_size)
+                act_buf = None
+                act_pos = 0
+                while ex_buf:
+                    act_pos, act_buf = read_act(act_pos)
+                    wvpassge(read_size, len(ex_buf))
+                    wvpassge(read_size, len(act_buf))
+                    wvpasseq(len(ex_buf), len(act_buf))
+                    wvpass(ex_buf == act_buf)
+                    if not act_buf:
+                        break
+                    ex_buf = expected.read(read_size)
+                else:  # hit expected eof first
+                    act_pos, act_buf = read_act(act_pos)
+                wvpasseq(b'', ex_buf)
+                wvpasseq(b'', act_buf)
 
 @wvtest
-def test_resolve_loop():
+def test_read_and_seek():
+    # Write a set of randomly sized files containing random data whose
+    # names are their sizes, and then verify that what we get back
+    # from the vfs when seeking and reading with various block sizes
+    # matches the original content.
     with no_lingering_errors():
-        with test_tempdir('bup-tvfs-resloop-') as tmpdir:
+        with test_tempdir(b'bup-tvfs-read-') as tmpdir:
             resolve = vfs.resolve
-            lresolve = vfs.lresolve
-            bup_dir = tmpdir + '/bup'
-            environ['GIT_DIR'] = bup_dir
-            environ['BUP_DIR'] = bup_dir
+            bup_dir = tmpdir + b'/bup'
+            environ[b'GIT_DIR'] = bup_dir
+            environ[b'BUP_DIR'] = bup_dir
             git.repodir = bup_dir
             repo = LocalRepo()
-            data_path = tmpdir + '/src'
+            data_path = tmpdir + b'/src'
             os.mkdir(data_path)
-            symlink('loop', data_path + '/loop')
-            ex((bup_path, 'init'))
-            ex((bup_path, 'index', '-v', data_path))
-            ex((bup_path, 'save', '-d', '100000', '-tvvn', 'test', '--strip',
-                data_path))
-            try:
-                resolve(repo, '/test/latest/loop')
-            except vfs.IOError as res_ex:
-                wvpasseq(ELOOP, res_ex.errno)
-                wvpasseq(['', 'test', 'latest', 'loop'],
-                         [name for name, item in res_ex.terminus])
+            seed = randint(-(1 << 31), (1 << 31) - 1)
+            rand = Random()
+            rand.seed(seed)
+            print('test_read seed:', seed, file=sys.stderr)
+            max_size = 2 * 1024 * 1024
+            sizes = set((rand.randint(1, max_size) for _ in range(5)))
+            sizes.add(1)
+            sizes.add(max_size)
+            for size in sizes:
+                write_sized_random_content(data_path, size, seed)
+            ex((bup_path, b'init'))
+            ex((bup_path, b'index', b'-v', data_path))
+            ex((bup_path, b'save', b'-d', b'100000', b'-tvvn', b'test',
+                b'--strip', data_path))
+            read_sizes = set((rand.randint(1, max_size) for _ in range(10)))
+            sizes.add(1)
+            sizes.add(max_size)
+            print('test_read src sizes:', sizes, file=sys.stderr)
+            print('test_read read sizes:', read_sizes, file=sys.stderr)
+            for size in sizes:
+                res = resolve(repo, b'/test/latest/' + str(size).encode('ascii'))
+                _, item = res[-1]
+                wvpasseq(size, vfs.item_size(repo, res[-1][1]))
+                validate_vfs_streaming_read(repo, item,
+                                            b'%s/%d' % (data_path, size),
+                                            read_sizes)
+                validate_vfs_seeking_read(repo, item,
+                                          b'%s/%d' % (data_path, size),
+                                          read_sizes)
 
 @wvtest
 def test_contents_with_mismatched_bupm_git_ordering():
     with no_lingering_errors():
-        with test_tempdir('bup-tvfs-') as tmpdir:
-            bup_dir = tmpdir + '/bup'
-            environ['GIT_DIR'] = bup_dir
-            environ['BUP_DIR'] = bup_dir
+        with test_tempdir(b'bup-tvfs-') as tmpdir:
+            bup_dir = tmpdir + b'/bup'
+            environ[b'GIT_DIR'] = bup_dir
+            environ[b'BUP_DIR'] = bup_dir
             git.repodir = bup_dir
-            data_path = tmpdir + '/src'
+            data_path = tmpdir + b'/src'
             os.mkdir(data_path)
-            os.mkdir(data_path + '/foo')
-            with open(data_path + '/foo.', 'w+') as tmpfile:
+            os.mkdir(data_path + b'/foo')
+            with open(data_path + b'/foo.', 'wb+') as tmpfile:
                 tmpfile.write(b'canary\n')
-            ex((bup_path, 'init'))
-            ex((bup_path, 'index', '-v', data_path))
-            ex((bup_path, 'save', '-tvvn', 'test', '--strip',
-                data_path))
+            ex((bup_path, b'init'))
+            ex((bup_path, b'index', b'-v', data_path))
+            save_utc = 100000
+            save_name = strftime('%Y-%m-%d-%H%M%S', localtime(save_utc)).encode('ascii')
+            ex((bup_path, b'save', b'-tvvn', b'test', b'-d', b'%d' % save_utc,
+                b'--strip', data_path))
             repo = LocalRepo()
-            tip_sref = exo(('git', 'show-ref', 'refs/heads/test'))[0]
+            tip_sref = exo((b'git', b'show-ref', b'refs/heads/test')).out
             tip_oidx = tip_sref.strip().split()[0]
-            tip_tree_oidx = exo(('git', 'log', '--pretty=%T', '-n1',
-                                 tip_oidx))[0].strip()
-            tip_tree_oid = tip_tree_oidx.decode('hex')
+            tip_tree_oidx = exo((b'git', b'log', b'--pretty=%T', b'-n1',
+                                 tip_oidx)).out.strip()
+            tip_tree_oid = unhexlify(tip_tree_oidx)
             tip_tree = tree_dict(repo, tip_tree_oid)
 
-            name, item = vfs.resolve(repo, '/test/latest')[2]
-            wvpasseq('latest', name)
+            name, item = vfs.resolve(repo, b'/test/latest')[2]
+            wvpasseq(save_name, name)
             expected = frozenset((x.name, vfs.Item(oid=x.oid, meta=x.meta))
                                  for x in (tip_tree[name]
-                                           for name in ('.', 'foo', 'foo.')))
+                                           for name in (b'.', b'foo', b'foo.')))
             contents = tuple(vfs.contents(repo, item))
             wvpasseq(expected, frozenset(contents))
             # Spot check, in case tree_dict shares too much code with the vfs
-            name, item = next(((n, i) for n, i in contents if n == 'foo'))
+            name, item = next(((n, i) for n, i in contents if n == b'foo'))
             wvpass(S_ISDIR(item.meta))
-            name, item = next(((n, i) for n, i in contents if n == 'foo.'))
+            name, item = next(((n, i) for n, i in contents if n == b'foo.'))
             wvpass(S_ISREG(item.meta.mode))
 
 @wvtest
 def test_duplicate_save_dates():
     with no_lingering_errors():
-        with test_tempdir('bup-tvfs-') as tmpdir:
-            bup_dir = tmpdir + '/bup'
-            environ['GIT_DIR'] = bup_dir
-            environ['BUP_DIR'] = bup_dir
-            environ['TZ'] = 'UTC'
+        with test_tempdir(b'bup-tvfs-') as tmpdir:
+            bup_dir = tmpdir + b'/bup'
+            environ[b'GIT_DIR'] = bup_dir
+            environ[b'BUP_DIR'] = bup_dir
+            environ[b'TZ'] = b'UTC'
+            tzset()
             git.repodir = bup_dir
-            data_path = tmpdir + '/src'
+            data_path = tmpdir + b'/src'
             os.mkdir(data_path)
-            with open(data_path + '/file', 'w+') as tmpfile:
+            with open(data_path + b'/file', 'wb+') as tmpfile:
                 tmpfile.write(b'canary\n')
-            ex((bup_path, 'init'))
-            ex((bup_path, 'index', '-v', data_path))
+            ex((b'env',))
+            ex((bup_path, b'init'))
+            ex((bup_path, b'index', b'-v', data_path))
             for i in range(11):
-                ex((bup_path, 'save', '-d', '100000', '-n', 'test', data_path))
+                ex((bup_path, b'save', b'-d', b'100000', b'-n', b'test',
+                    data_path))
             repo = LocalRepo()
-            res = vfs.resolve(repo, '/test')
+            res = vfs.resolve(repo, b'/test')
             wvpasseq(2, len(res))
             name, revlist = res[-1]
-            wvpasseq('test', name)
-            wvpasseq(('.',
-                      '1970-01-02-034640-00',
-                      '1970-01-02-034640-01',
-                      '1970-01-02-034640-02',
-                      '1970-01-02-034640-03',
-                      '1970-01-02-034640-04',
-                      '1970-01-02-034640-05',
-                      '1970-01-02-034640-06',
-                      '1970-01-02-034640-07',
-                      '1970-01-02-034640-08',
-                      '1970-01-02-034640-09',
-                      '1970-01-02-034640-10',
-                      'latest'),
+            wvpasseq(b'test', name)
+            wvpasseq((b'.',
+                      b'1970-01-02-034640-00',
+                      b'1970-01-02-034640-01',
+                      b'1970-01-02-034640-02',
+                      b'1970-01-02-034640-03',
+                      b'1970-01-02-034640-04',
+                      b'1970-01-02-034640-05',
+                      b'1970-01-02-034640-06',
+                      b'1970-01-02-034640-07',
+                      b'1970-01-02-034640-08',
+                      b'1970-01-02-034640-09',
+                      b'1970-01-02-034640-10',
+                      b'latest'),
                      tuple(sorted(x[0] for x in vfs.contents(repo, revlist))))
 
-# FIXME: add tests for the want_meta=False cases.
+@wvtest
+def test_item_read_write():
+    with no_lingering_errors():
+        x = vfs.Root(meta=13)
+        stream = BytesIO()
+        vfs.write_item(stream, x)
+        print('stream:', repr(stream.getvalue()), stream.tell(), file=sys.stderr)
+        stream.seek(0)
+        wvpasseq(x, vfs.read_item(stream))