]> arthur.barton.de Git - bup.git/blobdiff - lib/bup/t/tclient.py
Don't use multiple with context clauses
[bup.git] / lib / bup / t / tclient.py
index d0ff73b3bb302088770fc30b3a8b49ddd3657351..4a3147cf3833217c64fa40b7494bc7832f33f811 100644 (file)
@@ -24,116 +24,121 @@ IDX_PAT = '/*.idx'
 
 @wvtest
 def test_server_split_with_indexes():
-    with no_lingering_errors(), test_tempdir('bup-tclient-') as tmpdir:
-        os.environ['BUP_MAIN_EXE'] = '../../../bup'
-        os.environ['BUP_DIR'] = bupdir = tmpdir
-        git.init_repo(bupdir)
-        lw = git.PackWriter()
-        c = client.Client(bupdir, create=True)
-        rw = c.new_packwriter()
-
-        lw.new_blob(s1)
-        lw.close()
-
-        rw.new_blob(s2)
-        rw.breakpoint()
-        rw.new_blob(s1)
-        rw.close()
+    with no_lingering_errors():
+        with test_tempdir('bup-tclient-') as tmpdir:
+            os.environ['BUP_MAIN_EXE'] = '../../../bup'
+            os.environ['BUP_DIR'] = bupdir = tmpdir
+            git.init_repo(bupdir)
+            lw = git.PackWriter()
+            c = client.Client(bupdir, create=True)
+            rw = c.new_packwriter()
+
+            lw.new_blob(s1)
+            lw.close()
+
+            rw.new_blob(s2)
+            rw.breakpoint()
+            rw.new_blob(s1)
+            rw.close()
     
 
 @wvtest
 def test_multiple_suggestions():
-    with no_lingering_errors(), test_tempdir('bup-tclient-') as tmpdir:
-        os.environ['BUP_MAIN_EXE'] = '../../../bup'
-        os.environ['BUP_DIR'] = bupdir = tmpdir
-        git.init_repo(bupdir)
-
-        lw = git.PackWriter()
-        lw.new_blob(s1)
-        lw.close()
-        lw = git.PackWriter()
-        lw.new_blob(s2)
-        lw.close()
-        WVPASSEQ(len(glob.glob(git.repo('objects/pack'+IDX_PAT))), 2)
-
-        c = client.Client(bupdir, create=True)
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 0)
-        rw = c.new_packwriter()
-        s1sha = rw.new_blob(s1)
-        WVPASS(rw.exists(s1sha))
-        s2sha = rw.new_blob(s2)
-        # This is a little hacky, but ensures that we test the code under test
-        while (len(glob.glob(c.cachedir+IDX_PAT)) < 2 and
-               not c.conn.has_input()):
-            pass
-        rw.new_blob(s2)
-        WVPASS(rw.objcache.exists(s1sha))
-        WVPASS(rw.objcache.exists(s2sha))
-        rw.new_blob(s3)
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 2)
-        rw.close()
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 3)
+    with no_lingering_errors():
+        with test_tempdir('bup-tclient-') as tmpdir:
+            os.environ['BUP_MAIN_EXE'] = '../../../bup'
+            os.environ['BUP_DIR'] = bupdir = tmpdir
+            git.init_repo(bupdir)
+
+            lw = git.PackWriter()
+            lw.new_blob(s1)
+            lw.close()
+            lw = git.PackWriter()
+            lw.new_blob(s2)
+            lw.close()
+            WVPASSEQ(len(glob.glob(git.repo('objects/pack'+IDX_PAT))), 2)
+
+            c = client.Client(bupdir, create=True)
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 0)
+            rw = c.new_packwriter()
+            s1sha = rw.new_blob(s1)
+            WVPASS(rw.exists(s1sha))
+            s2sha = rw.new_blob(s2)
+            # This is a little hacky, but ensures that we test the
+            # code under test
+            while (len(glob.glob(c.cachedir+IDX_PAT)) < 2 and
+                   not c.conn.has_input()):
+                pass
+            rw.new_blob(s2)
+            WVPASS(rw.objcache.exists(s1sha))
+            WVPASS(rw.objcache.exists(s2sha))
+            rw.new_blob(s3)
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 2)
+            rw.close()
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 3)
 
 
 @wvtest
 def test_dumb_client_server():
-    with no_lingering_errors(), test_tempdir('bup-tclient-') as tmpdir:
-        os.environ['BUP_MAIN_EXE'] = '../../../bup'
-        os.environ['BUP_DIR'] = bupdir = tmpdir
-        git.init_repo(bupdir)
-        open(git.repo('bup-dumb-server'), 'w').close()
-
-        lw = git.PackWriter()
-        lw.new_blob(s1)
-        lw.close()
-
-        c = client.Client(bupdir, create=True)
-        rw = c.new_packwriter()
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 1)
-        rw.new_blob(s1)
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 1)
-        rw.new_blob(s2)
-        rw.close()
-        WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 2)
+    with no_lingering_errors():
+        with test_tempdir('bup-tclient-') as tmpdir:
+            os.environ['BUP_MAIN_EXE'] = '../../../bup'
+            os.environ['BUP_DIR'] = bupdir = tmpdir
+            git.init_repo(bupdir)
+            open(git.repo('bup-dumb-server'), 'w').close()
+
+            lw = git.PackWriter()
+            lw.new_blob(s1)
+            lw.close()
+
+            c = client.Client(bupdir, create=True)
+            rw = c.new_packwriter()
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 1)
+            rw.new_blob(s1)
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 1)
+            rw.new_blob(s2)
+            rw.close()
+            WVPASSEQ(len(glob.glob(c.cachedir+IDX_PAT)), 2)
 
 
 @wvtest
 def test_midx_refreshing():
-    with no_lingering_errors(), test_tempdir('bup-tclient-') as tmpdir:
-        os.environ['BUP_MAIN_EXE'] = bupmain = '../../../bup'
-        os.environ['BUP_DIR'] = bupdir = tmpdir
-        git.init_repo(bupdir)
-        c = client.Client(bupdir, create=True)
-        rw = c.new_packwriter()
-        rw.new_blob(s1)
-        p1base = rw.breakpoint()
-        p1name = os.path.join(c.cachedir, p1base)
-        s1sha = rw.new_blob(s1)  # should not be written; it's already in p1
-        s2sha = rw.new_blob(s2)
-        p2base = rw.close()
-        p2name = os.path.join(c.cachedir, p2base)
-        del rw
-
-        pi = git.PackIdxList(bupdir + '/objects/pack')
-        WVPASSEQ(len(pi.packs), 2)
-        pi.refresh()
-        WVPASSEQ(len(pi.packs), 2)
-        WVPASSEQ(sorted([os.path.basename(i.name) for i in pi.packs]),
-                 sorted([p1base, p2base]))
-
-        p1 = git.open_idx(p1name)
-        WVPASS(p1.exists(s1sha))
-        p2 = git.open_idx(p2name)
-        WVFAIL(p2.exists(s1sha))
-        WVPASS(p2.exists(s2sha))
-
-        subprocess.call([bupmain, 'midx', '-f'])
-        pi.refresh()
-        WVPASSEQ(len(pi.packs), 1)
-        pi.refresh(skip_midx=True)
-        WVPASSEQ(len(pi.packs), 2)
-        pi.refresh(skip_midx=False)
-        WVPASSEQ(len(pi.packs), 1)
+    with no_lingering_errors():
+        with test_tempdir('bup-tclient-') as tmpdir:
+            os.environ['BUP_MAIN_EXE'] = bupmain = '../../../bup'
+            os.environ['BUP_DIR'] = bupdir = tmpdir
+            git.init_repo(bupdir)
+            c = client.Client(bupdir, create=True)
+            rw = c.new_packwriter()
+            rw.new_blob(s1)
+            p1base = rw.breakpoint()
+            p1name = os.path.join(c.cachedir, p1base)
+            s1sha = rw.new_blob(s1)  # should not be written; it's already in p1
+            s2sha = rw.new_blob(s2)
+            p2base = rw.close()
+            p2name = os.path.join(c.cachedir, p2base)
+            del rw
+
+            pi = git.PackIdxList(bupdir + '/objects/pack')
+            WVPASSEQ(len(pi.packs), 2)
+            pi.refresh()
+            WVPASSEQ(len(pi.packs), 2)
+            WVPASSEQ(sorted([os.path.basename(i.name) for i in pi.packs]),
+                     sorted([p1base, p2base]))
+
+            p1 = git.open_idx(p1name)
+            WVPASS(p1.exists(s1sha))
+            p2 = git.open_idx(p2name)
+            WVFAIL(p2.exists(s1sha))
+            WVPASS(p2.exists(s2sha))
+
+            subprocess.call([bupmain, 'midx', '-f'])
+            pi.refresh()
+            WVPASSEQ(len(pi.packs), 1)
+            pi.refresh(skip_midx=True)
+            WVPASSEQ(len(pi.packs), 2)
+            pi.refresh(skip_midx=False)
+            WVPASSEQ(len(pi.packs), 1)
 
 
 @wvtest