ansible-lint: Fix "Use shell only when shell functionality is required" warning

[AnsibleRoles.git] / roles / mysql-server / tasks / main.yml

diff --git a/roles/mysql-server/tasks/main.yml b/roles/mysql-server/tasks/main.yml
index dff91e3722f79e1a810a0e89722aad79f9e1eae6..754920faf5443436a795fdbab5cc3a4867e274d4 100644 (file)
--- a/roles/mysql-server/tasks/main.yml
+++ b/roles/mysql-server/tasks/main.yml
@@ -5,8 +5,9 @@
   tags:
     - mysql
     - fs
-  shell: test -d /var/lib/mysql/mysql
+  command: test -d /var/lib/mysql/mysql
   ignore_errors: yes
+  check_mode: no
   register: mysql_server_installed
   changed_when: false
 
@@ -58,6 +59,7 @@
 - name: install MySQL packages for client and server
   tags:
     - mysql
+    - mysqld
     - packages
   apt: >
     state=installed
@@ -68,18 +70,20 @@
     - mysqltuner
     - python-mysqldb
 
-- name: ensure service "mysql" is enabled and running
+- name: ensure service "mysql" is enabled and started
   tags:
     - services
     - mysql
+    - mysqld
   service: >
     enabled=yes
     name=mysql
-    state=running
+    state=started
 
 - name: setup MySQL "ansible" account
   tags:
     - mysql
+    - mysqld
     - mysql-users
   mysql_user: >
     login_user={{ mysql_server_ansible_user }}
@@ -94,6 +98,7 @@
 - name: setup MySQL "root" account
   tags:
     - mysql
+    - mysqld
     - mysql-users
   mysql_user: >
     login_user={{ mysql_server_ansible_user }}
@@ -107,6 +112,7 @@
 - name: Remove unwanted MySQL "root" accounts (1/2)
   tags:
     - mysql
+    - mysqld
     - mysql-users
   mysql_user: >
     login_user={{ mysql_server_ansible_user }}
@@ -122,6 +128,7 @@
 - name: Remove unwanted MySQL "root" accounts (2/2)
   tags:
     - mysql
+    - mysqld
     - mysql-users
   mysql_user: >
     login_user={{ mysql_server_ansible_user }}