X-Git-Url: https://arthur.barton.de/gitweb/?p=trigger-rcmd.git;a=blobdiff_plain;f=scripts%2Ftrigger-rcmd;h=75aeddb8ac0acbefbd5a4332f5dcd2b8fe4c860d;hp=0ec4bec33b7f0b030af12728d3157a0b3829eb2f;hb=1bd704bbae0c9c9759c988e9889fde17f39a8f81;hpb=160d43e87ff6efa7601d691416d69a3808b179db

diff --git a/scripts/trigger-rcmd b/scripts/trigger-rcmd
index 0ec4bec..75aeddb 100755
--- a/scripts/trigger-rcmd
+++ b/scripts/trigger-rcmd
@@ -1,7 +1,7 @@
 #!/bin/sh
 #
 # trigger-rcmp: Trigger remote commands
-# Copyright (c)2014-2015 Alexander Barton (alex@barton.de)
+# Copyright (c)2014-2016 Alexander Barton (alex@barton.de)
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -10,7 +10,7 @@
 # Please read the file COPYING, README and AUTHORS for more information.
 #
 
-NAME="`basename "$0"`"
+NAME=$(basename "$0")
 RCMD_D="/usr/local/etc/rcmd.d"
 
 PATH="$PATH:/usr/local/sbin:/usr/sbin"
@@ -30,16 +30,18 @@ do_rcmd() {
 	BOOT_DELAY="1m"
 	SHUTDOWN_TIME="+10"
 
+	# Read in job/configuration file, but ignore shellcheck(1) warnings:
+	# shellcheck disable=1090
 	. "$cnf"
 
 	if [ $? -ne 0 ]; then
-		echo "$NAME: failed to read \"$cnf\"!"
+		echo "$NAME: Failed to read \"$cnf\"!"
 		return 2
 	fi
 
 	NAME="$NAME($1)"
 
-	echo "$NAME: checking system \"$SYSTEM\" ..."
+	echo "$NAME: Checking system \"$SYSTEM\" ..."
 	fping -c1 -q "$SYSTEM" 2>/dev/null
 	if [ $? -ne 0 ]; then
 		if [ -n "$NO_WAKE" ]; then
@@ -48,20 +50,20 @@ do_rcmd() {
 		fi
 
 		echo "$NAME: \"$SYSTEM\" seems to be down, wake it up ..."
-		etherwake -b -i "$IFACE" `echo "$SYSTEM" | cut -d'.' -f1`
+		etherwake -b -i "$IFACE" "$(echo "$SYSTEM" | cut -d'.' -f1)"
 		if [ $? -ne 0 ]; then
-			echo "$NAME: failed to wake \"$SYSTEM\"!" >&2
+			echo "$NAME: Failed to wake \"$SYSTEM\"!" >&2
 			return 3
 		fi
-		echo "$NAME: waiting for \"$SYSTEM\" to respond ..."
-		for i in `seq 1 $TIMEOUT`; do
+		echo "$NAME: Waiting for \"$SYSTEM\" to respond ..."
+		for i in $(seq 1 $TIMEOUT); do
 			fping -c1 -q "$SYSTEM" 2>/dev/null
 			[ $? -ne 0 ] || break
 			sleep 1s
 		done
 		fping -c1 -q "$SYSTEM" 2>/dev/null
 		if [ $? -ne 0 ]; then
-			echo "$NAME: failed to wake \"$SYSTEM\"!" >&2
+			echo "$NAME: Failed to wake \"$SYSTEM\"!" >&2
 			return 4
 		fi
 		sleep "$WAKE_DELAY"
@@ -71,42 +73,44 @@ do_rcmd() {
 		rsys_was_running=1
 	fi
 
-	for i in `seq 1 $SSH_CHECKS`; do
-		echo "$NAME: checking SSH connection ($i/$SSH_CHECKS) ..."
+	for i in $(seq 1 $SSH_CHECKS); do
+		echo "$NAME: Checking SSH connection ($i/$SSH_CHECKS) ..."
 		ssh -q "$SYSTEM" true >/dev/null 2>&1 && break
 		echo "$NAME: SSH on \"$SYSTEM\" not ready. Waiting ..."
 		sleep 10s
 	done
-	echo "$NAME: ok, SSH seems to be available on \"$SYSTEM\"."
+	echo "$NAME: Ok, SSH seems to be available on \"$SYSTEM\"."
 
 	if [ "$rsys_was_running" -eq 0 ]; then
 		echo "$NAME: \"$SYSTEM\" just started up. Delaying actions for $BOOT_DELAY ..."
 		sleep "$BOOT_DELAY"
 	fi
 
-	echo "$NAME: calling \"$CMD\" on \"$SYSTEM\" ..."
+	echo "$NAME: Calling \"$CMD\" on \"$SYSTEM\" ..."
 	echo
 
+	# shellcheck disable=2029
 	ssh -q "$SYSTEM" "$CMD" </dev/null ; r=$?
 
 	echo
-	echo "$NAME: remote command ended with return code $r."
+	echo "$NAME: Remote command ended with return code $r."
 	sleep 2
 
 	if [ "$rsys_was_running" -eq 0 ]; then
-		rsys_users=`ssh -q "$SYSTEM" w | tail -n +3 | wc -l`
+		rsys_users=$(ssh -q "$SYSTEM" w | tail -n +3 | wc -l)
 		if [ "$rsys_users" = "0" ]; then
-			echo "$NAME: power off \"$SYSTEM\" again ..."
+			echo "$NAME: Power off \"$SYSTEM\" again ..."
+			# shellcheck disable=2029
 			ssh -q "$SYSTEM" "sync; shutdown -hP $SHUTDOWN_TIME" >/dev/null
 			if [ $? -ne 0 ]; then
-				echo "$NAME: failed to power off \"$SYSTEM\"!" >&2
+				echo "$NAME: Failed to power off \"$SYSTEM\"!" >&2
 				return 5
 			fi
 		else
-			echo "$NAME: not shutting down \"$SYSTEM\", \c"
-			[ $rsys_users -eq 1 ] \
-				&& echo "there is 1 user logged in!" \
-				|| echo "there are $rsys_users users logged in!"
+			echo "$NAME: Not shutting down \"$SYSTEM\", \c"
+			[ "$rsys_users" -eq 1 ] \
+				&& echo "There is 1 user logged in!" \
+				|| echo "There are $rsys_users users logged in!"
 		fi
 	else
 		echo "$NAME: \"$SYSTEM\" was already alive, not shutting down."
@@ -119,8 +123,7 @@ NO_WAKE=
 
 # Check required tools
 for t in fping ssh etherwake; do
-	type "$t" >/dev/null 2>&1
-	if [ $? -ne 0 ]; then
+	if ! command -v "$t" >/dev/null 2>&1; then
 		echo "$NAME: Required tool \"$t\" missing, aborting!"
 		exit 3
 	fi
@@ -144,12 +147,12 @@ result=0
 while [ $# -gt 0 ]; do
 	cnf="$RCMD_D/$1"
 	if [ ! -r "$cnf" ]; then
-		echo "$NAME: can't read \"$cnf\"!"
+		echo "$NAME: Can't read \"$cnf\"!"
 		r=1
 	else
-		echo "$NAME: working on \"$1\" - `date "+%Y-%m-%d %H:%M:%S"`"
+		echo "$NAME: Working on \"$1\" - $(date "+%Y-%m-%d %H:%M:%S")"
 		do_rcmd "$1" ; r=$?
-		echo "$NAME: done ($r) - `date "+%Y-%m-%d %H:%M:%S"`"
+		echo "$NAME: Done ($r) - $(date "+%Y-%m-%d %H:%M:%S")"
 	fi
 	[ $r -ne 0 ] && result=1
 	shift