]> arthur.barton.de Git - trigger-rcmd.git/blobdiff - scripts/trigger-rcmd
Fix another (last?) shellcheck(1) warning ...
[trigger-rcmd.git] / scripts / trigger-rcmd
index 97f4efafc9a75a29143de6b341916e087cbd03f0..102fe162754d5e25922b9feafeee233a3f9bb5b4 100755 (executable)
@@ -1,7 +1,7 @@
 #!/bin/sh
 #
 # trigger-rcmp: Trigger remote commands
-# Copyright (c)2014 Alexander Barton (alex@barton.de)
+# Copyright (c)2014-2020 Alexander Barton (alex@barton.de)
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # Please read the file COPYING, README and AUTHORS for more information.
 #
 
-NAME="`basename "$0"`"
+BASENAME=$(basename "$0")
+NAME="$BASENAME"
 RCMD_D="/usr/local/etc/rcmd.d"
 
 PATH="$PATH:/usr/local/sbin:/usr/sbin"
 
 do_help() {
-       echo "Usage: $0 <rcmd> [<rcmd> [...]]" >&2
+       echo "Usage: $0 [--no-wake|-n] <rcmd> [<rcmd> [...]]" >&2
        exit 2
 }
 
@@ -24,72 +25,86 @@ do_rcmd() {
        SYSTEM="localhost"
        IFACE="eth0"
        CMD="uptime"
-       TIMEOUT="180"
-
-       . "$cnf"
-
-       if [ $? -ne 0 ]; then
-               echo "$NAME: failed to read \"$cnf\"!"
+       TIMEOUT="300"
+       SSH_CHECKS="6"
+       WAKE_DELAY="10s"
+       BOOT_DELAY="1m"
+       SHUTDOWN_TIME="+10"
+
+       # Read in job/configuration file, but ignore shellcheck(1) warnings:
+       # shellcheck disable=1090
+       if ! . "$cnf"; then
+               echo "$NAME: Failed to read \"$cnf\"!"
                return 2
        fi
 
-       NAME="$NAME($1)"
-
-       echo "$NAME: checking system \"$SYSTEM\" ..."
-       fping -c1 -q "$SYSTEM" 2>/dev/null
-       if [ $? -ne 0 ]; then
+       echo "$NAME: Checking system \"$SYSTEM\" ..."
+       if ! fping -c1 -q "$SYSTEM" 2>/dev/null; then
                if [ -n "$NO_WAKE" ]; then
                        echo "$NAME: \"$SYSTEM\" seems to be down, skipping job."
                        return 9
                fi
 
                echo "$NAME: \"$SYSTEM\" seems to be down, wake it up ..."
-               etherwake -b -i "$IFACE" `echo "$SYSTEM" | cut -d'.' -f1`
-               if [ $? -ne 0 ]; then
-                       echo "$NAME: failed to wake \"$SYSTEM\"!" >&2
+               if ! etherwake -b -i "$IFACE" "$(echo "$SYSTEM" | cut -d'.' -f1)"; then
+                       echo "$NAME: Failed to wake \"$SYSTEM\"!" >&2
                        return 3
                fi
-               echo "$NAME: waiting for \"$SYSTEM\" to respond ..."
-               for i in `seq 1 $TIMEOUT`; do
-                       fping -c1 -q "$SYSTEM" 2>/dev/null
-                       [ $? -ne 0 ] || break
+               echo "$NAME: Waiting for \"$SYSTEM\" to respond ..."
+               for i in $(seq 1 $TIMEOUT); do
+                       fping -c1 -q "$SYSTEM" 2>/dev/null && break
                        sleep 1s
                done
-               fping -c1 -q "$SYSTEM" 2>/dev/null
-               if [ $? -ne 0 ]; then
-                       echo "$NAME: failed to wake \"$SYSTEM\"!" >&2
+               if ! fping -c1 -q "$SYSTEM" 2>/dev/null; then
+                       echo "$NAME: Failed to wake \"$SYSTEM\"!" >&2
                        return 4
                fi
-               sleep 3
+               sleep "$WAKE_DELAY"
                rsys_was_running=0
        else
                echo "$NAME: \"$SYSTEM\" is already alive, ok."
                rsys_was_running=1
        fi
 
-       echo "$NAME: calling \"$CMD\" on \"$SYSTEM\" ..."
+       for i in $(seq 1 $SSH_CHECKS); do
+               echo "$NAME: Checking SSH connection [publickey] ($i/$SSH_CHECKS) ..."
+               if ssh -o PreferredAuthentications=publickey -q "$SYSTEM" true >/dev/null 2>&1; then
+                       echo "$NAME: Ok, SSH seems to be available on \"$SYSTEM\"."
+                       break
+               fi
+               echo "$NAME: SSH on \"$SYSTEM\" not ready. Waiting ..."
+               sleep 10s
+       done
+
+       if [ "$rsys_was_running" -eq 0 ]; then
+               echo "$NAME: \"$SYSTEM\" just started up. Delaying actions for $BOOT_DELAY ..."
+               sleep "$BOOT_DELAY"
+       fi
+
+       echo "$NAME: Calling \"$CMD\" on \"$SYSTEM\" ..."
        echo
 
-       ssh -q "$SYSTEM" "$CMD" </dev/null ; r=$?
+       # shellcheck disable=2029
+       ssh -o PreferredAuthentications=publickey -q "$SYSTEM" "$CMD" </dev/null ; r=$?
 
        echo
-       echo "$NAME: remote command ended with return code $r."
+       echo "$NAME: Remote command ended with return code $r."
        sleep 2
 
        if [ "$rsys_was_running" -eq 0 ]; then
-               rsys_users=`ssh -q "$SYSTEM" w | tail -n +3 | wc -l`
+               rsys_users=$(ssh -q "$SYSTEM" w | tail -n +3 | wc -l)
                if [ "$rsys_users" = "0" ]; then
-                       echo "$NAME: power off \"$SYSTEM\" again ..."
-                       ssh -q "$SYSTEM" "sync; shutdown -hP +1"
-                       if [ $? -ne 0 ]; then
-                               echo "$NAME: failed to power off \"$SYSTEM\"!" >&2
+                       echo "$NAME: Power off \"$SYSTEM\" again ..."
+                       # shellcheck disable=2029
+                       if ! ssh -o PreferredAuthentications=publickey -q "$SYSTEM" "sync; shutdown -hP $SHUTDOWN_TIME" >/dev/null 2>&1; then
+                               echo "$NAME: Failed to power off \"$SYSTEM\"!" >&2
                                return 5
                        fi
                else
-                       echo "$NAME: not shutting down \"$SYSTEM\", \c"
-                       [ $rsys_users -eq 1 ] \
-                               && echo "there is 1 user logged in!" \
-                               || echo "there are $rsys_users users logged in!"
+                       echo "$NAME: Not shutting down \"$SYSTEM\", \c"
+                       [ "$rsys_users" -eq 1 ] \
+                               && echo "There is 1 user logged in!" \
+                               || echo "There are $rsys_users users logged in!"
                fi
        else
                echo "$NAME: \"$SYSTEM\" was already alive, not shutting down."
@@ -100,6 +115,14 @@ do_rcmd() {
 # Defaults
 NO_WAKE=
 
+# Check required tools
+for t in fping ssh etherwake lockfile-create; do
+       if ! command -v "$t" >/dev/null 2>&1; then
+               echo "$NAME: Required tool \"$t\" missing, aborting!"
+               exit 3
+       fi
+done
+
 while [ $# -gt 0 ]; do
        case "$1" in
          --no-wake|-n)
@@ -118,15 +141,30 @@ result=0
 while [ $# -gt 0 ]; do
        cnf="$RCMD_D/$1"
        if [ ! -r "$cnf" ]; then
-               echo "$NAME: can't read \"$cnf\"!"
+               echo "$NAME: Can't read \"$cnf\"!"
                r=1
        else
-               echo "$NAME: working on \"$1\" - `date "+%Y-%m-%d %H:%M:%S"`"
-               do_rcmd "$1" ; r=$?
-               echo "$NAME: done ($r) - `date "+%Y-%m-%d %H:%M:%S"`"
+               echo "$NAME: Working on \"$1\" - $(date "+%Y-%m-%d %H:%M:%S")"
+               NAME="$BASENAME($1)"
+               lck="/run/lock/$NAME-$1.lock"
+               if lockfile-create --quiet --use-pid --retry 2 --lock-name "$lck"; then
+                       do_rcmd "$1" ; r=$?
+                       echo "$NAME: Done ($r) - $(date "+%Y-%m-%d %H:%M:%S")"
+                       rm -f "$lck"
+               else
+                       echo "$NAME: Failed to acquire lock file, skipping job! ($lck)"
+                       r=1
+               fi
+               NAME=$BASENAME
+       fi
+       if [ $r -ne 0 ]; then
+               # Exit code indicates an error. But only flag this as error
+               # when target should have been woken up and the indicated error
+               # is not "system down" (9).
+               [ -z "$NO_WAKE" ] || [ $r -ne 9 ] && result=1
        fi
-       [ $r -ne 0 ] && result=1
        shift
-       [ $# -gt 0 ] && echo
 done
+
+echo "$NAME: All done, exit code $result - $(date "+%Y-%m-%d %H:%M:%S")"
 exit $result