From: Alexander Barton <alex@barton.de>
Date: Tue, 18 Jul 2023 09:42:07 +0000 (+0200)
Subject: Fix RPL_INVITING message: It must originate from the server
X-Git-Tag: rel-27-rc1~108
X-Git-Url: https://arthur.barton.de/gitweb/?p=ngircd.git;a=commitdiff_plain;h=0035e0d77867c961b4db6f121f2b43a8d45688bd

Fix RPL_INVITING message: It must originate from the server

All numeric replies must originate from an IRC server, never from a
client. So fix the RPL_INVITING message!

Thanks tommyrot for reporting this!

Closes #307.
---

diff --git a/src/ngircd/irc-op.c b/src/ngircd/irc-op.c
index a309ee9f..2bf9e349 100644
--- a/src/ngircd/irc-op.c
+++ b/src/ngircd/irc-op.c
@@ -222,9 +222,9 @@ IRC_INVITE(CLIENT *Client, REQUEST *Req)
 
 	if (Client_Conn(target) > NONE) {
 		/* The target user is local, so we have to send the status code */
-		if (!IRC_WriteStrClientPrefix(from, target, RPL_INVITING_MSG,
-					       Client_ID(from), Req->argv[0],
-					       colon_if_necessary, Req->argv[1]))
+		if (!IRC_WriteStrClient(from, RPL_INVITING_MSG,
+					Client_ID(from), Req->argv[0],
+					colon_if_necessary, Req->argv[1]))
 			return DISCONNECTED;
 
 		if (Client_HasMode(target, 'a') &&