From: Alexander Barton <alex@barton.de>
Date: Mon, 29 Jan 2018 22:30:53 +0000 (+0100)
Subject: Fix Get_Error() usage, take II
X-Git-Tag: rel-25-rc1~18
X-Git-Url: https://arthur.barton.de/gitweb/?p=ngircd-alex.git;a=commitdiff_plain;h=7207bef418c655107d3076b20dd797418ad82cd7

Fix Get_Error() usage, take II

This should fix the following compiler warning:

  resolve.c:113:1: warning: ‘Get_Error’ defined but not used
    [-Wunused-function]

Which can happen, because the logic of commit 543f44bf isn't sufficient:
Get_Error() is only used when neither HAVE_WORKING_GETADDRINFO nor
HAVE_GETNAMEINFO are set ...

Enhances 543f44bf.
Closes #241.
---

diff --git a/src/ngircd/resolve.c b/src/ngircd/resolve.c
index e1903254..a8a163f0 100644
--- a/src/ngircd/resolve.c
+++ b/src/ngircd/resolve.c
@@ -108,6 +108,7 @@ Resolve_Name( PROC_STAT *s, const char *Host, void (*cbfunc)(int, short))
 	return false;
 } /* Resolve_Name */
 
+#if !defined(HAVE_WORKING_GETADDRINFO) || !defined(HAVE_GETNAMEINFO)
 #ifdef h_errno
 static char *
 Get_Error( int H_Error )
@@ -126,6 +127,7 @@ Get_Error( int H_Error )
 	return "unknown error";
 }
 #endif
+#endif
 
 
 /* Do "IDENT" (aka "AUTH") lookup and append result to resolved_addr array */