From: Simon Nagl Date: Sat, 11 Feb 2017 11:08:28 +0000 (+0100) Subject: Add version to api/v1/charts X-Git-Tag: ab-debian_0.20170213.01-0ab1~1^2~10^2~1 X-Git-Url: https://arthur.barton.de/gitweb/?p=netdata.git;a=commitdiff_plain;h=541ed96c3a6bff68f9f4a87c4a68db8cc4517599 Add version to api/v1/charts Prereleases now have the suffix _prerelease if git is not there. --- diff --git a/configure.ac b/configure.ac index 16369b62..ad71b6a8 100644 --- a/configure.ac +++ b/configure.ac @@ -7,12 +7,12 @@ define([VERSION_MAJOR], [1]) define([VERSION_MINOR], [5]) define([VERSION_FIX], [1]) define([VERSION_NUMBER], VERSION_MAJOR[.]VERSION_MINOR[.]VERSION_FIX) -define([VERSION_SUFFIX], [_master]) +define([VERSION_SUFFIX], [_prerelease]) dnl Set to "1" for a first RPM release of a new version PACKAGE_RPM_RELEASE="0.0.$(echo VERSION_SUFFIX | sed s/^_//)" -define([VERSION_STRING], m4_esyscmd_s(git describe 2> /dev/null)) +define([VERSION_STRING], m4_esyscmd_s(git describe 2>/dev/null | sed 's/^v//')) m4_ifval(VERSION_STRING, [], [define([VERSION_STRING], VERSION_NUMBER[]VERSION_SUFFIX)]) AC_INIT([netdata], VERSION_STRING) diff --git a/packaging/update-tags b/packaging/update-tags index 6823fce1..51993485 100755 --- a/packaging/update-tags +++ b/packaging/update-tags @@ -135,7 +135,7 @@ then fi echo "Resetting suffix in configure.ac:" - sed -i -e 's/define(\[VERSION_SUFFIX\], \[.*])/define([VERSION_SUFFIX], [_master])/' configure.ac + sed -i -e 's/define(\[VERSION_SUFFIX\], \[.*])/define([VERSION_SUFFIX], [_prerelease])/' configure.ac sed -i -e 's:^PACKAGE_RPM_RELEASE=.*:PACKAGE_RPM_RELEASE="0.0.$(echo VERSION_SUFFIX | sed s/^_//)":' configure.ac echo "Committing new configure.ac:" diff --git a/src/common.c b/src/common.c index 92a78994..e3682e87 100644 --- a/src/common.c +++ b/src/common.c @@ -13,6 +13,7 @@ int enable_ksm = 1; volatile sig_atomic_t netdata_exit = 0; const char *os_type = NETDATA_OS_TYPE; +const char *program_version = VERSION; // ---------------------------------------------------------------------------- // memory allocation functions that handle failures diff --git a/src/common.h b/src/common.h index 143578bd..e781d47b 100644 --- a/src/common.h +++ b/src/common.h @@ -277,6 +277,8 @@ extern void get_system_HZ(void); extern volatile sig_atomic_t netdata_exit; extern const char *os_type; +extern const char *program_version; + /* fix for alpine linux */ #ifndef RUSAGE_THREAD #ifdef RUSAGE_CHILDREN diff --git a/src/main.c b/src/main.c index d73c15a8..e453107b 100644 --- a/src/main.c +++ b/src/main.c @@ -434,8 +434,7 @@ int main(int argc, char **argv) config_set("global", "run as user", optarg); break; case 'v': - // TODO: Outsource version to makefile which can compute version from git. - printf("netdata %s\n", VERSION); + printf("%s %s\n", program_name, program_version); return 0; case 'W': { diff --git a/src/rrd2json.c b/src/rrd2json.c index 904b6064..b886b25f 100644 --- a/src/rrd2json.c +++ b/src/rrd2json.c @@ -85,11 +85,13 @@ void rrd_stats_api_v1_charts(BUFFER *wb) buffer_sprintf(wb, "{\n" "\t\"hostname\": \"%s\"" + ",\n\t\"version\": \"%s\"" ",\n\t\"os\": \"%s\"" ",\n\t\"update_every\": %d" ",\n\t\"history\": %d" ",\n\t\"charts\": {" , localhost.hostname + , program_version , os_type , rrd_update_every , rrd_default_history_entries