From: Alexander Barton <alex@barton.de>
Date: Sat, 25 Feb 2017 20:14:06 +0000 (+0100)
Subject: Merge branch 'master' into ab-debian
X-Git-Tag: ab-debian_0.20170225.02-0ab1~1
X-Git-Url: https://arthur.barton.de/gitweb/?p=netdata.git;a=commitdiff_plain;h=1464189ade598ed6842fb9a0e7d4cda09bc53758;hp=67509feacb502eddf487ce5ac6b12ce2903bc0be

Merge branch 'master' into ab-debian

* master:
  set up-delay on web alarms; fixes #1832
  fail2ban_plugin: parse both conf_path and conf_dir/; regex update
---

diff --git a/conf.d/health.d/web_log.conf b/conf.d/health.d/web_log.conf
index fdcdeaa1..c668959f 100644
--- a/conf.d/health.d/web_log.conf
+++ b/conf.d/health.d/web_log.conf
@@ -42,7 +42,7 @@ families: *
    every: 10s
     warn: ($1m_requests > 120) ? ($this < (($status >= $WARNING ) ? ( 95 ) : ( 85 )) ) : ( 0 )
     crit: ($1m_requests > 120) ? ($this < (($status == $CRITICAL) ? ( 85 ) : ( 75 )) ) : ( 0 )
-   delay: down 15m multiplier 1.5 max 1h
+   delay: up 2m down 15m multiplier 1.5 max 1h
     info: the ratio of successful HTTP responses (1xx, 2xx, 304) over the last minute
       to: webmaster
 
@@ -55,7 +55,7 @@ families: *
    every: 10s
     warn: ($1m_requests > 120) ? ($this > (($status >= $WARNING ) ? (  1 ) : ( 20 )) ) : ( 0 )
     crit: ($1m_requests > 120) ? ($this > (($status == $CRITICAL) ? ( 20 ) : ( 30 )) ) : ( 0 )
-   delay: down 15m multiplier 1.5 max 1h
+   delay: up 2m down 15m multiplier 1.5 max 1h
     info: the ratio of HTTP redirects (3xx except 304) over the last minute
       to: webmaster
 
@@ -68,7 +68,7 @@ families: *
    every: 10s
     warn: ($1m_requests > 120) ? ($this > (($status >= $WARNING)  ? ( 10 ) : ( 30 )) ) : ( 0 )
     crit: ($1m_requests > 120) ? ($this > (($status == $CRITICAL) ? ( 30 ) : ( 50 )) ) : ( 0 )
-   delay: down 15m multiplier 1.5 max 1h
+   delay: up 2m down 15m multiplier 1.5 max 1h
     info: the ratio of HTTP bad requests (4xx) over the last minute
       to: webmaster
 
@@ -81,7 +81,7 @@ families: *
    every: 10s
     warn: ($1m_requests > 120) ? ($this > (($status >= $WARNING)  ? ( 1 ) : ( 2 )) ) : ( 0 )
     crit: ($1m_requests > 120) ? ($this > (($status == $CRITICAL) ? ( 2 ) : ( 5 )) ) : ( 0 )
-   delay: down 15m multiplier 1.5 max 1h
+   delay: up 2m down 15m multiplier 1.5 max 1h
     info: the ratio of HTTP internal server errors (5xx), over the last minute
       to: webmaster
 
diff --git a/python.d/fail2ban.chart.py b/python.d/fail2ban.chart.py
index 85ac2d43..c7d24e8c 100644
--- a/python.d/fail2ban.chart.py
+++ b/python.d/fail2ban.chart.py
@@ -15,7 +15,7 @@ from glob import glob
 
 priority = 60000
 retries = 60
-REGEX = compile(r'\[([A-Za-z-]+)][^\[\]]*? enabled = true')
+REGEX = compile(r'\[([A-Za-z-_]+)][^\[\]]*?(?<!# )enabled = true')
 ORDER = ['jails_group']
 
 
@@ -65,14 +65,19 @@ class Service(LogService):
         if not is_accessible(self.log_path, R_OK):
             self.error('Cannot access file %s' % self.log_path)
             return False
+        jails_list = list()
 
         if self.conf_dir:
-            jails_list, error = parse_conf_dir(self.conf_dir)
-        else:
-            jails_list, error = parse_conf_path(self.conf_path)
-
-        if not jails_list:
-            self.error(error)
+            dir_jails, error = parse_conf_dir(self.conf_dir)
+            jails_list.extend(dir_jails)
+            if not dir_jails:
+                self.error(error)
+
+        if self.conf_path:
+            path_jails, error = parse_conf_path(self.conf_path)
+            jails_list.extend(path_jails)
+            if not path_jails:
+                self.error(error)
 
         # If for some reason parse failed we still can START with default jails_list.
         self.jails_list = list(set(jails_list) - set(self.exclude)) or ['ssh']