40% faster AVL searching and DICTIONARY operations

[netdata.git] / src / rrd.c

diff --git a/src/rrd.c b/src/rrd.c
index 379b1c8b8d642b203b20a7760550e5aed6c4b0a7..ee23da0c2ebec91184c52d947d1fc46bcba7d2f3 100644 (file)
--- a/src/rrd.c
+++ b/src/rrd.c
@@ -42,8 +42,6 @@ int rrd_memory_mode = RRD_MEMORY_MODE_SAVE;
 // ----------------------------------------------------------------------------
 // RRDSET index
 
-static int rrdset_iterator(avl *a) { if(a) {}; return 0; }
-
 static int rrdset_compare(void* a, void* b) {
        if(((RRDSET *)a)->hash < ((RRDSET *)b)->hash) return -1;
        else if(((RRDSET *)a)->hash > ((RRDSET *)b)->hash) return 1;
@@ -59,13 +57,11 @@ avl_tree_lock rrdset_root_index = {
 #define rrdset_index_del(st) avl_remove_lock(&rrdset_root_index, (avl *)(st))
 
 static RRDSET *rrdset_index_find(const char *id, uint32_t hash) {
-       RRDSET *result = NULL, tmp;
-       strncpy(tmp.id, id, RRD_ID_LENGTH_MAX);
-       tmp.id[RRD_ID_LENGTH_MAX] = '\0';
+       RRDSET tmp;
+       strncpyz(tmp.id, id, RRD_ID_LENGTH_MAX);
        tmp.hash = (hash)?hash:simple_hash(tmp.id);
 
-       avl_search_lock(&(rrdset_root_index), (avl *) &tmp, rrdset_iterator, (avl **) &result);
-       return result;
+       return (RRDSET *)avl_search_lock(&(rrdset_root_index), (avl *) &tmp);
 }
 
 // ----------------------------------------------------------------------------
@@ -73,8 +69,6 @@ static RRDSET *rrdset_index_find(const char *id, uint32_t hash) {
 
 #define rrdset_from_avlname(avlname_ptr) ((RRDSET *)((avlname_ptr) - offsetof(RRDSET, avlname)))
 
-static int rrdset_iterator_name(avl *a) { if(a) {}; return 0; }
-
 static int rrdset_compare_name(void* a, void* b) {
        RRDSET *A = rrdset_from_avlname(a);
        RRDSET *B = rrdset_from_avlname(b);
@@ -105,7 +99,7 @@ static RRDSET *rrdset_index_find_name(const char *name, uint32_t hash) {
        tmp.hash_name = (hash)?hash:simple_hash(tmp.name);
 
        // fprintf(stderr, "SEARCHING: %s\n", name);
-       avl_search_lock(&(rrdset_root_index_name), (avl *) (&(tmp.avlname)), rrdset_iterator_name, (avl **) &result);
+       result = avl_search_lock(&(rrdset_root_index_name), (avl *) (&(tmp.avlname)));
        if(result) {
                RRDSET *st = rrdset_from_avlname(result);
                if(strcmp(st->magic, RRDSET_MAGIC))
@@ -122,8 +116,6 @@ static RRDSET *rrdset_index_find_name(const char *name, uint32_t hash) {
 // ----------------------------------------------------------------------------
 // RRDDIM index
 
-static int rrddim_iterator(avl *a) { if(a) {}; return 0; }
-
 static int rrddim_compare(void* a, void* b) {
        if(((RRDDIM *)a)->hash < ((RRDDIM *)b)->hash) return -1;
        else if(((RRDDIM *)a)->hash > ((RRDDIM *)b)->hash) return 1;
@@ -134,13 +126,11 @@ static int rrddim_compare(void* a, void* b) {
 #define rrddim_index_del(st,rd ) avl_remove_lock(&((st)->dimensions_index), (avl *)(rd))
 
 static RRDDIM *rrddim_index_find(RRDSET *st, const char *id, uint32_t hash) {
-       RRDDIM *result = NULL, tmp;
-       strncpy(tmp.id, id, RRD_ID_LENGTH_MAX);
-       tmp.id[RRD_ID_LENGTH_MAX] = '\0';
+       RRDDIM tmp;
+       strncpyz(tmp.id, id, RRD_ID_LENGTH_MAX);
        tmp.hash = (hash)?hash:simple_hash(tmp.id);
 
-       avl_search_lock(&(st->dimensions_index), (avl *) &tmp, rrddim_iterator, (avl **) &result);
-       return result;
+       return (RRDDIM *)avl_search_lock(&(st->dimensions_index), (avl *) &tmp);
 }
 
 // ----------------------------------------------------------------------------
@@ -212,8 +202,8 @@ int rrd_memory_mode_id(const char *name)
 
 int rrddim_algorithm_id(const char *name)
 {
-       if(strcmp(name, RRDDIM_ABSOLUTE_NAME) == 0)                     return RRDDIM_ABSOLUTE;
        if(strcmp(name, RRDDIM_INCREMENTAL_NAME) == 0)                  return RRDDIM_INCREMENTAL;
+       if(strcmp(name, RRDDIM_ABSOLUTE_NAME) == 0)                     return RRDDIM_ABSOLUTE;
        if(strcmp(name, RRDDIM_PCENT_OVER_ROW_TOTAL_NAME) == 0)                 return RRDDIM_PCENT_OVER_ROW_TOTAL;
        if(strcmp(name, RRDDIM_PCENT_OVER_DIFF_TOTAL_NAME) == 0)        return RRDDIM_PCENT_OVER_DIFF_TOTAL;
        return RRDDIM_ABSOLUTE;
@@ -267,7 +257,7 @@ void rrdset_set_name(RRDSET *st, const char *name)
        char b[CONFIG_MAX_VALUE + 1];
        char n[RRD_ID_LENGTH_MAX + 1];
 
-       snprintf(n, RRD_ID_LENGTH_MAX, "%s.%s", st->type, name);
+       snprintfz(n, RRD_ID_LENGTH_MAX, "%s.%s", st->type, name);
        rrdset_strncpy_name(b, n, CONFIG_MAX_VALUE);
        st->name = config_get(st->id, "name", b);
        st->hash_name = simple_hash(st->name);
@@ -289,7 +279,7 @@ char *rrdset_cache_dir(const char *id)
        char n[FILENAME_MAX + 1];
        rrdset_strncpy_name(b, id, FILENAME_MAX);
 
-       snprintf(n, FILENAME_MAX, "%s/%s", cache_dir, b);
+       snprintfz(n, FILENAME_MAX, "%s/%s", cache_dir, b);
        ret = config_get(id, "cache directory", n);
 
        if(rrd_memory_mode == RRD_MEMORY_MODE_MAP || rrd_memory_mode == RRD_MEMORY_MODE_SAVE) {
@@ -341,7 +331,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
        char fullfilename[FILENAME_MAX + 1];
        RRDSET *st = NULL;
 
-       snprintf(fullid, RRD_ID_LENGTH_MAX, "%s.%s", type, id);
+       snprintfz(fullid, RRD_ID_LENGTH_MAX, "%s.%s", type, id);
 
        st = rrdset_find(fullid);
        if(st) {
@@ -361,7 +351,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
 
        debug(D_RRD_CALLS, "Creating RRD_STATS for '%s.%s'.", type, id);
 
-       snprintf(fullfilename, FILENAME_MAX, "%s/main.db", cache_dir);
+       snprintfz(fullfilename, FILENAME_MAX, "%s/main.db", cache_dir);
        if(rrd_memory_mode != RRD_MEMORY_MODE_RAM) st = (RRDSET *)mymmap(fullfilename, size, ((rrd_memory_mode == RRD_MEMORY_MODE_MAP)?MAP_SHARED:MAP_PRIVATE), 0);
        if(st) {
                if(strcmp(st->magic, RRDSET_MAGIC) != 0) {
@@ -453,7 +443,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
 
        {
                char varvalue[CONFIG_MAX_VALUE + 1];
-               snprintf(varvalue, CONFIG_MAX_VALUE, "%s (%s)", title?title:"", st->name);
+               snprintfz(varvalue, CONFIG_MAX_VALUE, "%s (%s)", title?title:"", st->name);
                st->title = config_get(st->id, "title", varvalue);
        }
 
@@ -479,7 +469,7 @@ RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier
        debug(D_RRD_CALLS, "Adding dimension '%s/%s'.", st->id, id);
 
        rrdset_strncpy_name(filename, id, FILENAME_MAX);
-       snprintf(fullfilename, FILENAME_MAX, "%s/%s.db", st->cache_dir, filename);
+       snprintfz(fullfilename, FILENAME_MAX, "%s/%s.db", st->cache_dir, filename);
        if(rrd_memory_mode != RRD_MEMORY_MODE_RAM) rd = (RRDDIM *)mymmap(fullfilename, size, ((rrd_memory_mode == RRD_MEMORY_MODE_MAP)?MAP_SHARED:MAP_PRIVATE), 1);
        if(rd) {
                struct timeval now;
@@ -551,19 +541,19 @@ RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier
 
        strcpy(rd->magic, RRDDIMENSION_MAGIC);
        strcpy(rd->cache_filename, fullfilename);
-       strncpy(rd->id, id, RRD_ID_LENGTH_MAX);
+       strncpyz(rd->id, id, RRD_ID_LENGTH_MAX);
        rd->hash = simple_hash(rd->id);
 
-       snprintf(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
+       snprintfz(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
        rd->name = config_get(st->id, varname, (name && *name)?name:rd->id);
 
-       snprintf(varname, CONFIG_MAX_NAME, "dim %s algorithm", rd->id);
+       snprintfz(varname, CONFIG_MAX_NAME, "dim %s algorithm", rd->id);
        rd->algorithm = rrddim_algorithm_id(config_get(st->id, varname, rrddim_algorithm_name(algorithm)));
 
-       snprintf(varname, CONFIG_MAX_NAME, "dim %s multiplier", rd->id);
+       snprintfz(varname, CONFIG_MAX_NAME, "dim %s multiplier", rd->id);
        rd->multiplier = config_get_number(st->id, varname, multiplier);
 
-       snprintf(varname, CONFIG_MAX_NAME, "dim %s divisor", rd->id);
+       snprintfz(varname, CONFIG_MAX_NAME, "dim %s divisor", rd->id);
        rd->divisor = config_get_number(st->id, varname, divisor);
        if(!rd->divisor) rd->divisor = 1;
 
@@ -594,7 +584,7 @@ void rrddim_set_name(RRDSET *st, RRDDIM *rd, const char *name)
        debug(D_RRD_CALLS, "rrddim_set_name() %s.%s", st->name, rd->name);
 
        char varname[CONFIG_MAX_NAME + 1];
-       snprintf(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
+       snprintfz(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
        config_set_default(st->id, varname, name);
 }
 
@@ -714,12 +704,10 @@ RRDSET *rrdset_find_bytype(const char *type, const char *id)
 
        char buf[RRD_ID_LENGTH_MAX + 1];
 
-       strncpy(buf, type, RRD_ID_LENGTH_MAX - 1);
-       buf[RRD_ID_LENGTH_MAX - 1] = '\0';
+       strncpyz(buf, type, RRD_ID_LENGTH_MAX - 1);
        strcat(buf, ".");
        int len = (int) strlen(buf);
-       strncpy(&buf[len], id, (size_t) (RRD_ID_LENGTH_MAX - len));
-       buf[RRD_ID_LENGTH_MAX] = '\0';
+       strncpyz(&buf[len], id, (size_t) (RRD_ID_LENGTH_MAX - len));
 
        return(rrdset_find(buf));
 }