]> arthur.barton.de Git - netdata.git/blobdiff - src/plugin_tc.c
fixes identified by coverity
[netdata.git] / src / plugin_tc.c
index 7478cd5505f6d5fa08554dabee49ceef986b75f8..7dcfedb33e56d6db1e0a60bc55b8b39fdef44360 100644 (file)
@@ -1,24 +1,6 @@
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/types.h>
-#include <sys/resource.h>
-
-#include "avl.h"
-#include "log.h"
 #include "common.h"
-#include "appconfig.h"
-#include "rrd.h"
-#include "popen.h"
-#include "plugin_tc.h"
-#include "main.h"
-#include "../config.h"
 
-#define RRD_TYPE_TC                                    "tc"
-#define RRD_TYPE_TC_LEN                                strlen(RRD_TYPE_TC)
+#define RRD_TYPE_TC "tc"
 
 // ----------------------------------------------------------------------------
 // /sbin/tc processor
 #define TC_LINE_MAX 1024
 
 struct tc_class {
-       avl avl;
-
-       char *id;
-       uint32_t hash;
-
-       char *name;
-
-       char *leafid;
-       uint32_t leaf_hash;
-
-       char *parentid;
-       uint32_t parent_hash;
+    avl avl;
+
+    char *id;
+    uint32_t hash;
+
+    char *name;
+
+    char *leafid;
+    uint32_t leaf_hash;
+
+    char *parentid;
+    uint32_t parent_hash;
+
+    char hasparent;
+    char isleaf;
+    char isqdisc;
+    char render;
+
+    unsigned long long bytes;
+    unsigned long long packets;
+    unsigned long long dropped;
+    unsigned long long overlimits;
+    unsigned long long requeues;
+    unsigned long long lended;
+    unsigned long long borrowed;
+    unsigned long long giants;
+    unsigned long long tokens;
+    unsigned long long ctokens;
+
+    RRDDIM *rd_bytes;
+    RRDDIM *rd_packets;
+    RRDDIM *rd_dropped;
+    RRDDIM *rd_tokens;
+    RRDDIM *rd_ctokens;
+
+    char name_updated;
+    char updated;   // updated bytes
+    int  unupdated; // the number of times, this has been found un-updated
+
+    struct tc_class *next;
+    struct tc_class *prev;
+};
 
-       char hasparent;
-       char isleaf;
-       unsigned long long bytes;
-       unsigned long long packets;
-       unsigned long long dropped;
-       unsigned long long overlimits;
-       unsigned long long requeues;
-       unsigned long long lended;
-       unsigned long long borrowed;
-       unsigned long long giants;
-       unsigned long long tokens;
-       unsigned long long ctokens;
+struct tc_device {
+    avl avl;
 
-       char updated;   // updated bytes
-       char seen;              // seen in the tc list (even without bytes)
+    char *id;
+    uint32_t hash;
 
-       struct tc_class *next;
-       struct tc_class *prev;
-};
+    char *name;
+    char *family;
 
-struct tc_device {
-       avl avl;
+    char name_updated;
+    char family_updated;
 
-       char *id;
-       uint32_t hash;
+    char enabled;
+    char enabled_bytes;
+    char enabled_packets;
+    char enabled_dropped;
+    char enabled_tokens;
+    char enabled_ctokens;
+    char enabled_all_classes_qdiscs;
 
-       char *name;
-       char *family;
+    RRDSET *st_bytes;
+    RRDSET *st_packets;
+    RRDSET *st_dropped;
+    RRDSET *st_tokens;
+    RRDSET *st_ctokens;
 
-       avl_tree classes_index;
+    avl_tree classes_index;
 
-       struct tc_class *classes;
+    struct tc_class *classes;
 
-       struct tc_device *next;
-       struct tc_device *prev;
+    struct tc_device *next;
+    struct tc_device *prev;
 };
 
 
@@ -83,654 +92,977 @@ struct tc_device *tc_device_root = NULL;
 // ----------------------------------------------------------------------------
 // tc_device index
 
-static int tc_device_iterator(avl *a) { if(a) {}; return 0; }
-
 static int tc_device_compare(void* a, void* b) {
-       if(((struct tc_device *)a)->hash < ((struct tc_device *)b)->hash) return -1;
-       else if(((struct tc_device *)a)->hash > ((struct tc_device *)b)->hash) return 1;
-       else return strcmp(((struct tc_device *)a)->id, ((struct tc_device *)b)->id);
+    if(((struct tc_device *)a)->hash < ((struct tc_device *)b)->hash) return -1;
+    else if(((struct tc_device *)a)->hash > ((struct tc_device *)b)->hash) return 1;
+    else return strcmp(((struct tc_device *)a)->id, ((struct tc_device *)b)->id);
 }
 
 avl_tree tc_device_root_index = {
-               NULL,
-               tc_device_compare
+        NULL,
+        tc_device_compare
 };
 
-#define tc_device_index_add(st) avl_insert(&tc_device_root_index, (avl *)(st))
-#define tc_device_index_del(st) avl_remove(&tc_device_root_index, (avl *)(st))
+#define tc_device_index_add(st) (struct tc_device *)avl_insert(&tc_device_root_index, (avl *)(st))
+#define tc_device_index_del(st) (struct tc_device *)avl_remove(&tc_device_root_index, (avl *)(st))
 
 static inline struct tc_device *tc_device_index_find(const char *id, uint32_t hash) {
-       struct tc_device *result = NULL, tmp;
-       tmp.id = (char *)id;
-       tmp.hash = (hash)?hash:simple_hash(tmp.id);
+    struct tc_device tmp;
+    tmp.id = (char *)id;
+    tmp.hash = (hash)?hash:simple_hash(tmp.id);
 
-       avl_search(&(tc_device_root_index), (avl *) &tmp, tc_device_iterator, (avl **) &result);
-       return result;
+    return (struct tc_device *)avl_search(&(tc_device_root_index), (avl *)&tmp);
 }
 
 
 // ----------------------------------------------------------------------------
 // tc_class index
 
-static int tc_class_iterator(avl *a) { if(a) {}; return 0; }
-
 static int tc_class_compare(void* a, void* b) {
-       if(((struct tc_class *)a)->hash < ((struct tc_class *)b)->hash) return -1;
-       else if(((struct tc_class *)a)->hash > ((struct tc_class *)b)->hash) return 1;
-       else return strcmp(((struct tc_class *)a)->id, ((struct tc_class *)b)->id);
+    if(((struct tc_class *)a)->hash < ((struct tc_class *)b)->hash) return -1;
+    else if(((struct tc_class *)a)->hash > ((struct tc_class *)b)->hash) return 1;
+    else return strcmp(((struct tc_class *)a)->id, ((struct tc_class *)b)->id);
 }
 
-#define tc_class_index_add(st, rd) avl_insert(&((st)->classes_index), (avl *)(rd))
-#define tc_class_index_del(st, rd) avl_remove(&((st)->classes_index), (avl *)(rd))
+#define tc_class_index_add(st, rd) (struct tc_class *)avl_insert(&((st)->classes_index), (avl *)(rd))
+#define tc_class_index_del(st, rd) (struct tc_class *)avl_remove(&((st)->classes_index), (avl *)(rd))
 
 static inline struct tc_class *tc_class_index_find(struct tc_device *st, const char *id, uint32_t hash) {
-       struct tc_class *result = NULL, tmp;
-       tmp.id = (char *)id;
-       tmp.hash = (hash)?hash:simple_hash(tmp.id);
+    struct tc_class tmp;
+    tmp.id = (char *)id;
+    tmp.hash = (hash)?hash:simple_hash(tmp.id);
 
-       avl_search(&(st->classes_index), (avl *) &tmp, tc_class_iterator, (avl **) &result);
-       return result;
+    return (struct tc_class *)avl_search(&(st->classes_index), (avl *) &tmp);
 }
 
 // ----------------------------------------------------------------------------
 
 static inline void tc_class_free(struct tc_device *n, struct tc_class *c) {
-       debug(D_TC_LOOP, "Removing from device '%s' class '%s', parentid '%s', leafid '%s', seen=%d", n->id, c->id, c->parentid?c->parentid:"", c->leafid?c->leafid:"", c->seen);
-
-       if(c->next) c->next->prev = c->prev;
-       if(c->prev) c->prev->next = c->next;
-       if(n->classes == c) {
-               if(c->next) n->classes = c->next;
-               else n->classes = c->prev;
-       }
-
-       tc_class_index_del(n, c);
-
-       if(c->id) free(c->id);
-       if(c->name) free(c->name);
-       if(c->leafid) free(c->leafid);
-       if(c->parentid) free(c->parentid);
-
-       free(c);
+    if(c == n->classes) {
+        if(c->next)
+            n->classes = c->next;
+        else
+            n->classes = c->prev;
+    }
+    if(c->next) c->next->prev = c->prev;
+    if(c->prev) c->prev->next = c->next;
+
+    debug(D_TC_LOOP, "Removing from device '%s' class '%s', parentid '%s', leafid '%s', unused=%d", n->id, c->id, c->parentid?c->parentid:"", c->leafid?c->leafid:"", c->unupdated);
+
+    if(unlikely(tc_class_index_del(n, c) != c))
+        error("plugin_tc: INTERNAL ERROR: attempt remove class '%s' from device '%s': removed a different calls", c->id, n->id);
+
+    freez(c->id);
+    freez(c->name);
+    freez(c->leafid);
+    freez(c->parentid);
+    freez(c);
 }
 
 static inline void tc_device_classes_cleanup(struct tc_device *d) {
-       static int cleanup_every = 999;
-
-       if(cleanup_every > 0) {
-               cleanup_every = (int) -config_get_number("plugin:tc", "cleanup unused classes every", 60);
-               if(cleanup_every > 0) cleanup_every = -cleanup_every;
-               if(cleanup_every == 0) cleanup_every = -1;
-       }
-
-       struct tc_class *c = d->classes;
-       while(c) {
-               if(c->seen < cleanup_every) {
-                       struct tc_class *nc = c->next;
-                       tc_class_free(d, c);
-                       c = nc;
-               }
-               else c = c->next;
-
-               if(c) {
-                       c->updated = 0;
-                       c->seen--;
-               }
-       }
+    static int cleanup_every = 999;
+
+    if(unlikely(cleanup_every > 0)) {
+        cleanup_every = (int) config_get_number("plugin:tc", "cleanup unused classes every", 120);
+        if(cleanup_every < 0) cleanup_every = -cleanup_every;
+    }
+
+    d->name_updated = 0;
+    d->family_updated = 0;
+
+    struct tc_class *c = d->classes;
+    while(c) {
+        if(unlikely(cleanup_every && c->unupdated >= cleanup_every)) {
+            struct tc_class *nc = c->next;
+            tc_class_free(d, c);
+            c = nc;
+        }
+        else {
+            c->updated = 0;
+            c->name_updated = 0;
+
+            c = c->next;
+        }
+    }
 }
 
-static inline void tc_device_commit(struct tc_device *d)
-{
-       static int enable_new_interfaces = -1;
-
-       if(enable_new_interfaces == -1) enable_new_interfaces = config_get_boolean("plugin:tc", "enable new interfaces detected at runtime", 1);
-
-       // we only need to add leaf classes
-       struct tc_class *c, *x;
-
-       // set all classes
-       for(c = d->classes ; c ; c = c->next) {
-               c->isleaf = 1;
-               c->hasparent = 0;
-       }
-
-       // mark the classes as leafs and parents
-       for(c = d->classes ; c ; c = c->next) {
-               if(!c->updated) continue;
-
-               for(x = d->classes ; x ; x = x->next) {
-                       if(!x->updated) continue;
-
-                       if(c == x) continue;
-
-                       if(x->parentid && (
-                               (               c->hash      == x->parent_hash && strcmp(c->id,     x->parentid) == 0) ||
-                               (c->leafid   && c->leaf_hash == x->parent_hash && strcmp(c->leafid, x->parentid) == 0))) {
-                               // debug(D_TC_LOOP, "TC: In device '%s', class '%s' (leafid: '%s') has as leaf class '%s' (parentid: '%s').", d->name?d->name:d->id, c->name?c->name:c->id, c->leafid?c->leafid:c->id, x->name?x->name:x->id, x->parentid?x->parentid:x->id);
-                               c->isleaf = 0;
-                               x->hasparent = 1;
-                       }
-               }
-       }
-
-       // debugging:
-       /*
-       for ( c = d->classes ; c ; c = c->next) {
-               if(c->isleaf && c->hasparent) debug(D_TC_LOOP, "TC: Device %s, class %s, OK", d->name, c->id);
-               else debug(D_TC_LOOP, "TC: Device %s, class %s, IGNORE (isleaf: %d, hasparent: %d, parent: %s)", d->name, c->id, c->isleaf, c->hasparent, c->parentid);
-       }
-       */
-
-       // we need at least a class
-       for(c = d->classes ; c ; c = c->next) {
-               // debug(D_TC_LOOP, "TC: Device '%s', class '%s', isLeaf=%d, HasParent=%d, Seen=%d", d->name?d->name:d->id, c->name?c->name:c->id, c->isleaf, c->hasparent, c->seen);
-               if(!c->updated) continue;
-               if(c->isleaf && c->hasparent) break;
-       }
-       if(!c) {
-               debug(D_TC_LOOP, "TC: Ignoring TC device '%s'. No leaf classes.", d->name?d->name:d->id);
-               tc_device_classes_cleanup(d);
-               return;
-       }
-
-       char var_name[CONFIG_MAX_NAME + 1];
-       snprintf(var_name, CONFIG_MAX_NAME, "qos for %s", d->id);
-       if(config_get_boolean("plugin:tc", var_name, enable_new_interfaces)) {
-               RRDSET *st = rrdset_find_bytype(RRD_TYPE_TC, d->id);
-               if(!st) {
-                       debug(D_TC_LOOP, "TC: Creating new chart for device '%s'", d->name?d->name:d->id);
-
-                       st = rrdset_create(RRD_TYPE_TC, d->id, d->name?d->name:d->id, d->family?d->family:d->id, RRD_TYPE_TC ".qos", "Class Usage", "kilobits/s", 7000, rrd_update_every, RRDSET_TYPE_STACKED);
-
-                       for(c = d->classes ; c ; c = c->next) {
-                               if(!c->updated) continue;
-
-                               if(c->isleaf && c->hasparent)
-                                       rrddim_add(st, c->id, c->name?c->name:c->id, 8, 1024, RRDDIM_INCREMENTAL);
-                       }
-               }
-               else {
-                       debug(D_TC_LOOP, "TC: Updating chart for device '%s'", d->name?d->name:d->id);
-                       rrdset_next_plugins(st);
-
-                       if(d->name && strcmp(d->id, d->name) != 0) rrdset_set_name(st, d->name);
-               }
-
-               for(c = d->classes ; c ; c = c->next) {
-                       if(!c->updated) continue;
-
-                       if(c->isleaf && c->hasparent) {
-                               RRDDIM *rd = rrddim_find(st, c->id);
-
-                               if(!rd) {
-                                       debug(D_TC_LOOP, "TC: Adding to chart '%s', dimension '%s'", st->id, c->id, c->name);
-
-                                       // new class, we have to add it
-                                       rd = rrddim_add(st, c->id, c->name?c->name:c->id, 8, 1024, RRDDIM_INCREMENTAL);
-                               }
-                               else debug(D_TC_LOOP, "TC: Updating chart '%s', dimension '%s'", st->id, c->id);
-
-                               rrddim_set_by_pointer(st, rd, c->bytes);
-
-                               // if it has a name, different to the id
-                               if(c->name) {
-                                       // update the rrd dimension with the new name
-                                       debug(D_TC_LOOP, "TC: Setting chart '%s', dimension '%s' name to '%s'", st->id, rd->id, c->name);
-                                       rrddim_set_name(st, rd, c->name);
-
-                                       free(c->name);
-                                       c->name = NULL;
-                               }
-                       }
-               }
-               rrdset_done(st);
-       }
-
-       tc_device_classes_cleanup(d);
+static inline void tc_device_commit(struct tc_device *d) {
+    static int enable_new_interfaces = -1, enable_bytes = -1, enable_packets = -1, enable_dropped = -1, enable_tokens = -1, enable_ctokens = -1, enabled_all_classes_qdiscs = -1;
+
+    if(unlikely(enable_new_interfaces == -1)) {
+        enable_new_interfaces      = config_get_boolean_ondemand("plugin:tc", "enable new interfaces detected at runtime", CONFIG_BOOLEAN_YES);
+        enable_bytes               = config_get_boolean_ondemand("plugin:tc", "enable traffic charts for all interfaces", CONFIG_BOOLEAN_AUTO);
+        enable_packets             = config_get_boolean_ondemand("plugin:tc", "enable packets charts for all interfaces", CONFIG_BOOLEAN_AUTO);
+        enable_dropped             = config_get_boolean_ondemand("plugin:tc", "enable dropped charts for all interfaces", CONFIG_BOOLEAN_AUTO);
+        enable_tokens              = config_get_boolean_ondemand("plugin:tc", "enable tokens charts for all interfaces", CONFIG_BOOLEAN_NO);
+        enable_ctokens             = config_get_boolean_ondemand("plugin:tc", "enable ctokens charts for all interfaces", CONFIG_BOOLEAN_NO);
+        enabled_all_classes_qdiscs = config_get_boolean_ondemand("plugin:tc", "enable show all classes and qdiscs for all interfaces", CONFIG_BOOLEAN_NO);
+    }
+
+    if(unlikely(d->enabled == (char)-1)) {
+        char var_name[CONFIG_MAX_NAME + 1];
+        snprintfz(var_name, CONFIG_MAX_NAME, "qos for %s", d->id);
+
+        d->enabled                    = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_new_interfaces);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "traffic chart for %s", d->id);
+        d->enabled_bytes              = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_bytes);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "packets chart for %s", d->id);
+        d->enabled_packets            = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_packets);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "dropped packets chart for %s", d->id);
+        d->enabled_dropped            = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_dropped);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "tokens chart for %s", d->id);
+        d->enabled_tokens             = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_tokens);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "ctokens chart for %s", d->id);
+        d->enabled_ctokens            = (char)config_get_boolean_ondemand("plugin:tc", var_name, enable_ctokens);
+
+        snprintfz(var_name, CONFIG_MAX_NAME, "show all classes for %s", d->id);
+        d->enabled_all_classes_qdiscs = (char)config_get_boolean_ondemand("plugin:tc", var_name, enabled_all_classes_qdiscs);
+    }
+
+    // we only need to add leaf classes
+    struct tc_class *c, *x /*, *root = NULL */;
+    unsigned long long bytes_sum = 0, packets_sum = 0, dropped_sum = 0, tokens_sum = 0, ctokens_sum = 0;
+    int active_nodes = 0, updated_classes = 0, updated_qdiscs = 0;
+
+    // prepare all classes
+    // we set reasonable defaults for the rest of the code below
+
+    for(c = d->classes ; c ; c = c->next) {
+        c->render = 0;          // do not render this class
+
+        c->isleaf = 1;          // this is a leaf class
+        c->hasparent = 0;       // without a parent
+
+        if(unlikely(!c->updated))
+            c->unupdated++;     // increase its unupdated counter
+        else {
+            c->unupdated = 0;   // reset its unupdated counter
+
+            // count how many of each kind
+            if(c->isqdisc)
+                updated_qdiscs++;
+            else
+                updated_classes++;
+        }
+    }
+
+    if(unlikely(!d->enabled || (!updated_classes && !updated_qdiscs))) {
+        debug(D_TC_LOOP, "TC: Ignoring TC device '%s'. It is not enabled/updated.", d->name?d->name:d->id);
+        tc_device_classes_cleanup(d);
+        return;
+    }
+
+    if(unlikely(updated_classes && updated_qdiscs)) {
+        error("TC: device '%s' has active both classes (%d) and qdiscs (%d). Will render only qdiscs.", d->id, updated_classes, updated_qdiscs);
+
+        // set all classes to !updated
+        for(c = d->classes ; c ; c = c->next)
+            if(unlikely(!c->isqdisc && c->updated))
+                c->updated = 0;
+
+        updated_classes = 0;
+    }
+
+    // mark the classes as leafs and parents
+    //
+    // TC is hierarchical:
+    //  - classes can have other classes in them
+    //  - the same is true for qdiscs (i.e. qdiscs have classes, that have other qdiscs)
+    //
+    // we need to present a chart with leaf nodes only, so that the sum
+    // of all dimensions of the chart, will be the total utilization
+    // of the interface.
+    //
+    // here we try to find the ones we need to report
+    // by default all nodes are marked with: isleaf = 1 (see above)
+    //
+    // so, here we remove the isleaf flag from nodes in the middle
+    // and we add the hasparent flag to leaf nodes we found their parent
+    if(likely(!d->enabled_all_classes_qdiscs)) {
+        for(c = d->classes; c; c = c->next) {
+            if(unlikely(!c->updated)) continue;
+
+            //debug(D_TC_LOOP, "TC: In device '%s', %s '%s'  has leafid: '%s' and parentid '%s'.",
+            //    d->id,
+            //    c->isqdisc?"qdisc":"class",
+            //    c->id,
+            //    c->leafid?c->leafid:"NULL",
+            //    c->parentid?c->parentid:"NULL");
+
+            // find if c is leaf or not
+            for(x = d->classes; x; x = x->next) {
+                if(unlikely(!x->updated || c == x || !x->parentid)) continue;
+
+                // classes have both parentid and leafid
+                // qdiscs have only parentid
+                // the following works for both (it is an OR)
+
+                if((c->hash == x->parent_hash && strcmp(c->id, x->parentid) == 0) ||
+                   (c->leafid && c->leaf_hash == x->parent_hash && strcmp(c->leafid, x->parentid) == 0)) {
+                    // debug(D_TC_LOOP, "TC: In device '%s', %s '%s' (leafid: '%s') has as leaf %s '%s' (parentid: '%s').", d->name?d->name:d->id, c->isqdisc?"qdisc":"class", c->name?c->name:c->id, c->leafid?c->leafid:c->id, x->isqdisc?"qdisc":"class", x->name?x->name:x->id, x->parentid?x->parentid:x->id);
+                    c->isleaf = 0;
+                    x->hasparent = 1;
+                }
+            }
+        }
+    }
+
+    for(c = d->classes ; c ; c = c->next) {
+        if(unlikely(!c->updated)) continue;
+
+        // debug(D_TC_LOOP, "TC: device '%s', %s '%s' isleaf=%d, hasparent=%d", d->id, (c->isqdisc)?"qdisc":"class", c->id, c->isleaf, c->hasparent);
+
+        if(unlikely((c->isleaf && c->hasparent) || d->enabled_all_classes_qdiscs)) {
+            c->render = 1;
+            active_nodes++;
+            bytes_sum += c->bytes;
+            packets_sum += c->packets;
+            dropped_sum += c->dropped;
+            tokens_sum += c->tokens;
+            ctokens_sum += c->ctokens;
+        }
+
+        //if(unlikely(!c->hasparent)) {
+        //    if(root) error("TC: multiple root class/qdisc for device '%s' (old: '%s', new: '%s')", d->id, root->id, c->id);
+        //    root = c;
+        //    debug(D_TC_LOOP, "TC: found root class/qdisc '%s'", root->id);
+        //}
+    }
+
+#ifdef NETDATA_INTERNAL_CHECKS
+    // dump all the list to see what we know
+
+    if(unlikely(debug_flags & D_TC_LOOP)) {
+        for(c = d->classes ; c ; c = c->next) {
+            if(c->render) debug(D_TC_LOOP, "TC: final nodes dump for '%s': class %s, OK", d->name, c->id);
+            else debug(D_TC_LOOP, "TC: final nodes dump for '%s': class %s, IGNORE (updated: %d, isleaf: %d, hasparent: %d, parent: %s)", d->name?d->name:d->id, c->id, c->updated, c->isleaf, c->hasparent, c->parentid?c->parentid:"(unset)");
+        }
+    }
+#endif
+
+    if(unlikely(!active_nodes)) {
+        debug(D_TC_LOOP, "TC: Ignoring TC device '%s'. No useful classes/qdiscs.", d->name?d->name:d->id);
+        tc_device_classes_cleanup(d);
+        return;
+    }
+
+    debug(D_TC_LOOP, "TC: evaluating TC device '%s'. enabled = %d/%d (bytes: %d/%d, packets: %d/%d, dropped: %d/%d, tokens: %d/%d, ctokens: %d/%d, all_classes_qdiscs: %d/%d), classes: (bytes = %llu, packets = %llu, dropped = %llu, tokens = %llu, ctokens = %llu).",
+        d->name?d->name:d->id,
+        d->enabled, enable_new_interfaces,
+        d->enabled_bytes, enable_bytes,
+        d->enabled_packets, enable_packets,
+        d->enabled_dropped, enable_dropped,
+        d->enabled_tokens, enable_tokens,
+        d->enabled_ctokens, enable_ctokens,
+        d->enabled_all_classes_qdiscs, enabled_all_classes_qdiscs,
+        bytes_sum,
+        packets_sum,
+        dropped_sum,
+        tokens_sum,
+        ctokens_sum
+        );
+
+    // --------------------------------------------------------------------
+    // bytes
+
+    if(d->enabled_bytes == CONFIG_BOOLEAN_YES || (d->enabled_bytes == CONFIG_BOOLEAN_AUTO && bytes_sum)) {
+        d->enabled_bytes = CONFIG_BOOLEAN_YES;
+
+        if(unlikely(!d->st_bytes))
+            d->st_bytes = rrdset_create_localhost(RRD_TYPE_TC, d->id, d->name ? d->name : d->id
+                                                  , d->family ? d->family : d->id, RRD_TYPE_TC ".qos", "Class Usage"
+                                                  , "kilobits/s", 7000, localhost->rrd_update_every
+                                                  , d->enabled_all_classes_qdiscs ? RRDSET_TYPE_LINE
+                                                                                  : RRDSET_TYPE_STACKED);
+
+        else {
+            rrdset_next(d->st_bytes);
+            if(unlikely(d->name_updated)) rrdset_set_name(d->st_bytes, d->name);
+
+            // FIXME
+            // update the family
+        }
+
+        for(c = d->classes ; c ; c = c->next) {
+            if(unlikely(!c->render)) continue;
+
+            if(unlikely(!c->rd_bytes))
+                c->rd_bytes = rrddim_add(d->st_bytes, c->id, c->name?c->name:c->id, 8, 1024, RRD_ALGORITHM_INCREMENTAL);
+            else if(unlikely(c->name_updated))
+                rrddim_set_name(d->st_bytes, c->rd_bytes, c->name);
+
+            rrddim_set_by_pointer(d->st_bytes, c->rd_bytes, c->bytes);
+        }
+        rrdset_done(d->st_bytes);
+    }
+
+    // --------------------------------------------------------------------
+    // packets
+
+    if(d->enabled_packets == CONFIG_BOOLEAN_YES || (d->enabled_packets == CONFIG_BOOLEAN_AUTO && packets_sum)) {
+        d->enabled_packets = CONFIG_BOOLEAN_YES;
+
+        if(unlikely(!d->st_packets)) {
+            char id[RRD_ID_LENGTH_MAX + 1];
+            char name[RRD_ID_LENGTH_MAX + 1];
+            snprintfz(id, RRD_ID_LENGTH_MAX, "%s_packets", d->id);
+            snprintfz(name, RRD_ID_LENGTH_MAX, "%s_packets", d->name?d->name:d->id);
+
+            d->st_packets = rrdset_create_localhost(RRD_TYPE_TC, id, name, d->family ? d->family : d->id
+                                                    , RRD_TYPE_TC ".qos_packets", "Class Packets", "packets/s", 7010
+                                                    , localhost->rrd_update_every, d->enabled_all_classes_qdiscs ? RRDSET_TYPE_LINE
+                                                                                                      : RRDSET_TYPE_STACKED);
+        }
+        else {
+            rrdset_next(d->st_packets);
+
+            if(unlikely(d->name_updated)) {
+                char name[RRD_ID_LENGTH_MAX + 1];
+                snprintfz(name, RRD_ID_LENGTH_MAX, "%s_packets", d->name?d->name:d->id);
+                rrdset_set_name(d->st_packets, name);
+            }
+
+            // FIXME
+            // update the family
+        }
+
+        for(c = d->classes ; c ; c = c->next) {
+            if(unlikely(!c->render)) continue;
+
+            if(unlikely(!c->rd_packets))
+                c->rd_packets = rrddim_add(d->st_packets, c->id, c->name?c->name:c->id, 1, 1, RRD_ALGORITHM_INCREMENTAL);
+            else if(unlikely(c->name_updated))
+                rrddim_set_name(d->st_packets, c->rd_packets, c->name);
+
+            rrddim_set_by_pointer(d->st_packets, c->rd_packets, c->packets);
+        }
+        rrdset_done(d->st_packets);
+    }
+
+    // --------------------------------------------------------------------
+    // dropped
+
+    if(d->enabled_dropped == CONFIG_BOOLEAN_YES || (d->enabled_dropped == CONFIG_BOOLEAN_AUTO && dropped_sum)) {
+        d->enabled_dropped = CONFIG_BOOLEAN_YES;
+
+        if(unlikely(!d->st_dropped)) {
+            char id[RRD_ID_LENGTH_MAX + 1];
+            char name[RRD_ID_LENGTH_MAX + 1];
+            snprintfz(id, RRD_ID_LENGTH_MAX, "%s_dropped", d->id);
+            snprintfz(name, RRD_ID_LENGTH_MAX, "%s_dropped", d->name?d->name:d->id);
+
+            d->st_dropped = rrdset_create_localhost(RRD_TYPE_TC, id, name, d->family ? d->family : d->id
+                                                    , RRD_TYPE_TC ".qos_dropped", "Class Dropped Packets", "packets/s"
+                                                    , 7020, localhost->rrd_update_every
+                                                    , d->enabled_all_classes_qdiscs ? RRDSET_TYPE_LINE
+                                                                                    : RRDSET_TYPE_STACKED);
+        }
+        else {
+            rrdset_next(d->st_dropped);
+
+            if(unlikely(d->name_updated)) {
+                char name[RRD_ID_LENGTH_MAX + 1];
+                snprintfz(name, RRD_ID_LENGTH_MAX, "%s_dropped", d->name?d->name:d->id);
+                rrdset_set_name(d->st_dropped, name);
+            }
+
+            // FIXME
+            // update the family
+        }
+
+        for(c = d->classes ; c ; c = c->next) {
+            if(unlikely(!c->render)) continue;
+
+            if(unlikely(!c->rd_dropped))
+                c->rd_dropped = rrddim_add(d->st_dropped, c->id, c->name?c->name:c->id, 1, 1, RRD_ALGORITHM_INCREMENTAL);
+            else if(unlikely(c->name_updated))
+                rrddim_set_name(d->st_dropped, c->rd_dropped, c->name);
+
+            rrddim_set_by_pointer(d->st_dropped, c->rd_dropped, c->dropped);
+        }
+        rrdset_done(d->st_dropped);
+    }
+
+    // --------------------------------------------------------------------
+    // tokens
+
+    if(d->enabled_tokens == CONFIG_BOOLEAN_YES || (d->enabled_tokens == CONFIG_BOOLEAN_AUTO && tokens_sum)) {
+        d->enabled_tokens = CONFIG_BOOLEAN_YES;
+
+        if(unlikely(!d->st_tokens)) {
+            char id[RRD_ID_LENGTH_MAX + 1];
+            char name[RRD_ID_LENGTH_MAX + 1];
+            snprintfz(id, RRD_ID_LENGTH_MAX, "%s_tokens", d->id);
+            snprintfz(name, RRD_ID_LENGTH_MAX, "%s_tokens", d->name?d->name:d->id);
+
+            d->st_tokens = rrdset_create_localhost(RRD_TYPE_TC, id, name, d->family ? d->family : d->id
+                                                   , RRD_TYPE_TC ".qos_tokens", "Class Tokens", "tokens", 7030
+                                                   , localhost->rrd_update_every, RRDSET_TYPE_LINE);
+        }
+        else {
+            rrdset_next(d->st_tokens);
+
+            if(unlikely(d->name_updated)) {
+                char name[RRD_ID_LENGTH_MAX + 1];
+                snprintfz(name, RRD_ID_LENGTH_MAX, "%s_tokens", d->name?d->name:d->id);
+                rrdset_set_name(d->st_tokens, name);
+            }
+
+            // FIXME
+            // update the family
+        }
+
+        for(c = d->classes ; c ; c = c->next) {
+            if(unlikely(!c->render)) continue;
+
+            if(unlikely(!c->rd_tokens)) {
+                c->rd_tokens = rrddim_add(d->st_tokens, c->id, c->name?c->name:c->id, 1, 1, RRD_ALGORITHM_ABSOLUTE);
+            }
+            else if(unlikely(c->name_updated))
+                rrddim_set_name(d->st_tokens, c->rd_tokens, c->name);
+
+            rrddim_set_by_pointer(d->st_tokens, c->rd_tokens, c->tokens);
+        }
+        rrdset_done(d->st_tokens);
+    }
+
+    // --------------------------------------------------------------------
+    // ctokens
+
+    if(d->enabled_ctokens == CONFIG_BOOLEAN_YES || (d->enabled_ctokens == CONFIG_BOOLEAN_AUTO && ctokens_sum)) {
+        d->enabled_ctokens = CONFIG_BOOLEAN_YES;
+
+        if(unlikely(!d->st_ctokens)) {
+            char id[RRD_ID_LENGTH_MAX + 1];
+            char name[RRD_ID_LENGTH_MAX + 1];
+            snprintfz(id, RRD_ID_LENGTH_MAX, "%s_ctokens", d->id);
+            snprintfz(name, RRD_ID_LENGTH_MAX, "%s_ctokens", d->name?d->name:d->id);
+
+            d->st_ctokens = rrdset_create_localhost(RRD_TYPE_TC, id, name, d->family ? d->family : d->id
+                                                    , RRD_TYPE_TC ".qos_ctokens", "Class cTokens", "ctokens", 7040
+                                                    , localhost->rrd_update_every, RRDSET_TYPE_LINE);
+        }
+        else {
+            debug(D_TC_LOOP, "TC: Updating _ctokens chart for device '%s'", d->name?d->name:d->id);
+            rrdset_next(d->st_ctokens);
+
+            if(unlikely(d->name_updated)) {
+                char name[RRD_ID_LENGTH_MAX + 1];
+                snprintfz(name, RRD_ID_LENGTH_MAX, "%s_ctokens", d->name?d->name:d->id);
+                rrdset_set_name(d->st_ctokens, name);
+            }
+
+            // FIXME
+            // update the family
+        }
+
+        for(c = d->classes ; c ; c = c->next) {
+            if(unlikely(!c->render)) continue;
+
+            if(unlikely(!c->rd_ctokens))
+                c->rd_ctokens = rrddim_add(d->st_ctokens, c->id, c->name?c->name:c->id, 1, 1, RRD_ALGORITHM_ABSOLUTE);
+            else if(unlikely(c->name_updated))
+                rrddim_set_name(d->st_ctokens, c->rd_ctokens, c->name);
+
+            rrddim_set_by_pointer(d->st_ctokens, c->rd_ctokens, c->ctokens);
+        }
+        rrdset_done(d->st_ctokens);
+    }
+
+    tc_device_classes_cleanup(d);
 }
 
-static inline void tc_device_set_class_name(struct tc_device *d, char *id, char *name)
-{
-       struct tc_class *c = tc_class_index_find(d, id, 0);
-       if(c) {
-               if(c->name) free(c->name);
-               c->name = NULL;
-
-               if(name && *name && strcmp(c->id, name) != 0) {
-                       debug(D_TC_LOOP, "TC: Setting device '%s', class '%s' name to '%s'", d->id, id, name);
-                       c->name = strdup(name);
-               }
-       }
+static inline void tc_device_set_class_name(struct tc_device *d, char *id, char *name) {
+    if(unlikely(!name || !*name)) return;
+
+    struct tc_class *c = tc_class_index_find(d, id, 0);
+    if(likely(c)) {
+        if(likely(c->name)) {
+            if(!strcmp(c->name, name)) return;
+            freez(c->name);
+            c->name = NULL;
+        }
+
+        if(likely(name && *name && strcmp(c->id, name) != 0)) {
+            debug(D_TC_LOOP, "TC: Setting device '%s', class '%s' name to '%s'", d->id, id, name);
+            c->name = strdupz(name);
+            c->name_updated = 1;
+        }
+    }
 }
 
 static inline void tc_device_set_device_name(struct tc_device *d, char *name) {
-       if(d->name) free(d->name);
-       d->name = NULL;
-
-       if(name && *name && strcmp(d->id, name) != 0) {
-               debug(D_TC_LOOP, "TC: Setting device '%s' name to '%s'", d->id, name);
-               d->name = strdup(name);
-       }
+    if(unlikely(!name || !*name)) return;
+
+    if(d->name) {
+        if(!strcmp(d->name, name)) return;
+        freez(d->name);
+        d->name = NULL;
+    }
+
+    if(likely(name && *name && strcmp(d->id, name))) {
+        debug(D_TC_LOOP, "TC: Setting device '%s' name to '%s'", d->id, name);
+        d->name = strdupz(name);
+        d->name_updated = 1;
+    }
 }
 
 static inline void tc_device_set_device_family(struct tc_device *d, char *family) {
-       if(d->family) free(d->family);
-       d->family = NULL;
-
-       if(family && *family && strcmp(d->id, family) != 0) {
-               debug(D_TC_LOOP, "TC: Setting device '%s' family to '%s'", d->id, family);
-               d->family = strdup(family);
-       }
-       // no need for null termination - it is already null
+    freez(d->family);
+    d->family = NULL;
+
+    if(likely(family && *family && strcmp(d->id, family) != 0)) {
+        debug(D_TC_LOOP, "TC: Setting device '%s' family to '%s'", d->id, family);
+        d->family = strdupz(family);
+        d->family_updated = 1;
+    }
+    // no need for null termination - it is already null
 }
 
 static inline struct tc_device *tc_device_create(char *id)
 {
-       struct tc_device *d = tc_device_index_find(id, 0);
-
-       if(!d) {
-               debug(D_TC_LOOP, "TC: Creating device '%s'", id);
-
-               d = calloc(1, sizeof(struct tc_device));
-               if(!d) {
-                       fatal("Cannot allocate memory for tc_device %s", id);
-                       return NULL;
-               }
-
-               d->id = strdup(id);
-               d->hash = simple_hash(d->id);
-
-               avl_init(&d->classes_index, tc_class_compare);
-               tc_device_index_add(d);
-
-               if(!tc_device_root) {
-                       tc_device_root = d;
-               }
-               else {
-                       d->next = tc_device_root;
-                       tc_device_root->prev = d;
-                       tc_device_root = d;
-               }
-       }
-
-       return(d);
-}
+    struct tc_device *d = tc_device_index_find(id, 0);
 
-static inline struct tc_class *tc_class_add(struct tc_device *n, char *id, char *parentid, char *leafid)
-{
-       struct tc_class *c = tc_class_index_find(n, id, 0);
+    if(!d) {
+        debug(D_TC_LOOP, "TC: Creating device '%s'", id);
 
-       if(!c) {
-               debug(D_TC_LOOP, "TC: Creating in device '%s', class id '%s', parentid '%s', leafid '%s'", n->id, id, parentid?parentid:"", leafid?leafid:"");
+        d = callocz(1, sizeof(struct tc_device));
 
-               c = calloc(1, sizeof(struct tc_class));
-               if(!c) {
-                       fatal("Cannot allocate memory for tc class");
-                       return NULL;
-               }
+        d->id = strdupz(id);
+        d->hash = simple_hash(d->id);
+        d->enabled = (char)-1;
 
-               if(n->classes) n->classes->prev = c;
-               c->next = n->classes;
-               n->classes = c;
+        avl_init(&d->classes_index, tc_class_compare);
+        if(unlikely(tc_device_index_add(d) != d))
+            error("plugin_tc: INTERNAL ERROR: removing device '%s' removed a different device.", d->id);
 
-               c->id = strdup(id);
-               if(!c->id) {
-                       free(c);
-                       return NULL;
-               }
-               c->hash = simple_hash(c->id);
+        if(!tc_device_root) {
+            tc_device_root = d;
+        }
+        else {
+            d->next = tc_device_root;
+            tc_device_root->prev = d;
+            tc_device_root = d;
+        }
+    }
 
-               if(parentid && *parentid) {
-                       c->parentid = strdup(parentid);
-                       c->parent_hash = simple_hash(c->parentid);
-               }
+    return(d);
+}
 
-               if(leafid && *leafid) {
-                       c->leafid = strdup(leafid);
-                       c->leaf_hash = simple_hash(c->leafid);
-               }
+static inline struct tc_class *tc_class_add(struct tc_device *n, char *id, char qdisc, char *parentid, char *leafid)
+{
+    struct tc_class *c = tc_class_index_find(n, id, 0);
 
-               tc_class_index_add(n, c);
-       }
+    if(!c) {
+        debug(D_TC_LOOP, "TC: Creating in device '%s', class id '%s', parentid '%s', leafid '%s'", n->id, id, parentid?parentid:"", leafid?leafid:"");
 
-       c->seen = 1;
+        c = callocz(1, sizeof(struct tc_class));
 
-       return(c);
-}
+        if(n->classes) n->classes->prev = c;
+        c->next = n->classes;
+        n->classes = c;
 
-static inline void tc_device_free(struct tc_device *n)
-{
-       if(n->next) n->next->prev = n->prev;
-       if(n->prev) n->prev->next = n->next;
-       if(tc_device_root == n) {
-               if(n->next) tc_device_root = n->next;
-               else tc_device_root = n->prev;
-       }
+        c->id = strdupz(id);
+        c->hash = simple_hash(c->id);
 
-       tc_device_index_del(n);
+        c->isqdisc = qdisc;
+        if(parentid && *parentid) {
+            c->parentid = strdupz(parentid);
+            c->parent_hash = simple_hash(c->parentid);
+        }
 
-       while(n->classes) tc_class_free(n, n->classes);
+        if(leafid && *leafid) {
+            c->leafid = strdupz(leafid);
+            c->leaf_hash = simple_hash(c->leafid);
+        }
 
-       if(n->id) free(n->id);
-       if(n->name) free(n->name);
-       if(n->family) free(n->family);
+        if(unlikely(tc_class_index_add(n, c) != c))
+            error("plugin_tc: INTERNAL ERROR: attempt index class '%s' on device '%s': already exists", c->id, n->id);
+    }
+    return(c);
+}
 
-       free(n);
+static inline void tc_device_free(struct tc_device *n)
+{
+    if(n->next) n->next->prev = n->prev;
+    if(n->prev) n->prev->next = n->next;
+    if(tc_device_root == n) {
+        if(n->next) tc_device_root = n->next;
+        else tc_device_root = n->prev;
+    }
+
+    if(unlikely(tc_device_index_del(n) != n))
+        error("plugin_tc: INTERNAL ERROR: removing device '%s' removed a different device.", n->id);
+
+    while(n->classes) tc_class_free(n, n->classes);
+
+    freez(n->id);
+    freez(n->name);
+    freez(n->family);
+    freez(n);
 }
 
 static inline void tc_device_free_all()
 {
-       while(tc_device_root)
-               tc_device_free(tc_device_root);
+    while(tc_device_root)
+        tc_device_free(tc_device_root);
 }
 
 #define MAX_WORDS 20
 
 static inline int tc_space(char c) {
-       switch(c) {
-       case ' ':
-       case '\t':
-       case '\r':
-       case '\n':
-               return 1;
-
-       default:
-               return 0;
-       }
+    switch(c) {
+    case ' ':
+    case '\t':
+    case '\r':
+    case '\n':
+        return 1;
+
+    default:
+        return 0;
+    }
 }
 
 static inline void tc_split_words(char *str, char **words, int max_words) {
-       char *s = str;
-       int i = 0;
+    char *s = str;
+    int i = 0;
 
-       // skip all white space
-       while(tc_space(*s)) s++;
+    // skip all white space
+    while(tc_space(*s)) s++;
 
-       // store the first word
-       words[i++] = s;
+    // store the first word
+    words[i++] = s;
 
-       // while we have something
-       while(*s) {
-               // if it is a space
-               if(tc_space(*s)) {
+    // while we have something
+    while(*s) {
+        // if it is a space
+        if(unlikely(tc_space(*s))) {
 
-                       // terminate the word
-                       *s++ = '\0';
+            // terminate the word
+            *s++ = '\0';
 
-                       // skip all white space
-                       while(tc_space(*s)) s++;
+            // skip all white space
+            while(tc_space(*s)) s++;
 
-                       // if we reached the end, stop
-                       if(!*s) break;
+            // if we reached the end, stop
+            if(!*s) break;
 
-                       // store the next word
-                       if(i < max_words) words[i++] = s;
-                       else break;
-               }
-               else s++;
-       }
+            // store the next word
+            if(i < max_words) words[i++] = s;
+            else break;
+        }
+        else s++;
+    }
 
-       // terminate the words
-       while(i < max_words) words[i++] = NULL;
+    // terminate the words
+    while(i < max_words) words[i++] = NULL;
 }
 
-pid_t tc_child_pid = 0;
-void *tc_main(void *ptr)
-{
-       if(ptr) { ; }
+volatile pid_t tc_child_pid = 0;
+void *tc_main(void *ptr) {
+    struct netdata_static_thread *static_thread = (struct netdata_static_thread *)ptr;
 
-       info("TC thread created with task id %d", gettid());
+    info("TC thread created with task id %d", gettid());
 
-       if(pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL) != 0)
-               error("Cannot set pthread cancel type to DEFERRED.");
+    if(pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL) != 0)
+        error("Cannot set pthread cancel type to DEFERRED.");
 
-       if(pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL) != 0)
-               error("Cannot set pthread cancel state to ENABLE.");
+    if(pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL) != 0)
+        error("Cannot set pthread cancel state to ENABLE.");
 
-       struct rusage thread;
-       RRDSET *stcpu = NULL, *sttime = NULL;
+    struct rusage thread;
+    RRDSET *stcpu = NULL, *sttime = NULL;
 
-       char buffer[TC_LINE_MAX+1] = "";
-       char *words[MAX_WORDS] = { NULL };
+    char buffer[TC_LINE_MAX+1] = "";
+    char *words[MAX_WORDS] = { NULL };
 
-       uint32_t BEGIN_HASH = simple_hash("BEGIN");
-       uint32_t END_HASH = simple_hash("END");
-       uint32_t CLASS_HASH = simple_hash("class");
-       uint32_t SENT_HASH = simple_hash("Sent");
-       uint32_t LENDED_HASH = simple_hash("lended:");
-       uint32_t TOKENS_HASH = simple_hash("tokens:");
-       uint32_t SETDEVICENAME_HASH = simple_hash("SETDEVICENAME");
-       uint32_t SETDEVICEGROUP_HASH = simple_hash("SETDEVICEGROUP");
-       uint32_t SETCLASSNAME_HASH = simple_hash("SETCLASSNAME");
-       uint32_t WORKTIME_HASH = simple_hash("WORKTIME");
+    uint32_t BEGIN_HASH = simple_hash("BEGIN");
+    uint32_t END_HASH = simple_hash("END");
+    uint32_t QDISC_HASH = simple_hash("qdisc");
+    uint32_t CLASS_HASH = simple_hash("class");
+    uint32_t SENT_HASH = simple_hash("Sent");
+    uint32_t LENDED_HASH = simple_hash("lended:");
+    uint32_t TOKENS_HASH = simple_hash("tokens:");
+    uint32_t SETDEVICENAME_HASH = simple_hash("SETDEVICENAME");
+    uint32_t SETDEVICEGROUP_HASH = simple_hash("SETDEVICEGROUP");
+    uint32_t SETCLASSNAME_HASH = simple_hash("SETCLASSNAME");
+    uint32_t WORKTIME_HASH = simple_hash("WORKTIME");
 #ifdef DETACH_PLUGINS_FROM_NETDATA
-       uint32_t MYPID_HASH = simple_hash("MYPID");
+    uint32_t MYPID_HASH = simple_hash("MYPID");
 #endif
-       uint32_t first_hash;
-
-       for(;1;) {
-               if(unlikely(netdata_exit)) break;
-
-               FILE *fp;
-               struct tc_device *device = NULL;
-               struct tc_class *class = NULL;
-
-               snprintf(buffer, TC_LINE_MAX, "exec %s %d", config_get("plugin:tc", "script to run to get tc values", PLUGINS_DIR "/tc-qos-helper.sh"), rrd_update_every);
-               debug(D_TC_LOOP, "executing '%s'", buffer);
-               // fp = popen(buffer, "r");
-               fp = mypopen(buffer, &tc_child_pid);
-               if(!fp) {
-                       error("TC: Cannot popen(\"%s\", \"r\").", buffer);
-                       pthread_exit(NULL);
-                       return NULL;
-               }
-
-               while(fgets(buffer, TC_LINE_MAX, fp) != NULL) {
-                       if(unlikely(netdata_exit)) break;
-
-                       buffer[TC_LINE_MAX] = '\0';
-                       // debug(D_TC_LOOP, "TC: read '%s'", buffer);
-
-                       tc_split_words(buffer, words, MAX_WORDS);
-                       if(!words[0] || !*words[0]) {
-                               // debug(D_TC_LOOP, "empty line");
-                               continue;
-                       }
-                       // else debug(D_TC_LOOP, "First word is '%s'", words[0]);
-
-                       first_hash = simple_hash(words[0]);
-
-                       if(device && first_hash == CLASS_HASH && strcmp(words[0], "class") == 0) {
-                               // debug(D_TC_LOOP, "CLASS line on class id='%s', parent='%s', parentid='%s', leaf='%s', leafid='%s'", words[2], words[3], words[4], words[5], words[6]);
-
-                               // clear the last class
-                               class = NULL;
-
-                               // words[1] : class type
-                               // words[2] : N:XX
-                               // words[3] : parent or root
-                               if(words[1] && words[2] && words[3] && (strcmp(words[3], "parent") == 0 || strcmp(words[3], "root") == 0)) {
-                                       //char *type     = words[1];  // the class: htb, fq_codel, etc
-
-                                       // we are only interested for HTB classes
-                                       //if(strcmp(type, "htb") != 0) continue;
-
-                                       char *id       = words[2];      // the class major:minor
-                                       char *parent   = words[3];      // 'parent' or 'root'
-                                       char *parentid = words[4];      // the parent's id
-                                       char *leaf     = words[5];      // 'leaf'
-                                       char *leafid   = words[6];      // leafid
-
-                                       if(strcmp(parent, "root") == 0) {
-                                               parentid = NULL;
-                                               leafid = NULL;
-                                       }
-                                       else if(!leaf || strcmp(leaf, "leaf") != 0)
-                                               leafid = NULL;
-
-                                       char leafbuf[20 + 1] = "";
-                                       if(leafid && leafid[strlen(leafid) - 1] == ':') {
-                                               strncpy(leafbuf, leafid, 20 - 1);
-                                               strcat(leafbuf, "1");
-                                               leafid = leafbuf;
-                                       }
-
-                                       class = tc_class_add(device, id, parentid, leafid);
-                               }
-                       }
-                       else if(first_hash == END_HASH && strcmp(words[0], "END") == 0) {
-                               // debug(D_TC_LOOP, "END line");
-
-                               if(device) {
-                                       if(pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL) != 0)
-                                               error("Cannot set pthread cancel state to DISABLE.");
-
-                                       tc_device_commit(device);
-                                       // tc_device_free(device);
-                                       device = NULL;
-                                       class = NULL;
-
-                                       if(pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL) != 0)
-                                               error("Cannot set pthread cancel state to ENABLE.");
-                               }
-                       }
-                       else if(first_hash == BEGIN_HASH && strcmp(words[0], "BEGIN") == 0) {
-                               // debug(D_TC_LOOP, "BEGIN line on device '%s'", words[1]);
-
-                               if(device) {
-                                       // tc_device_free(device);
-                                       device = NULL;
-                                       class = NULL;
-                               }
-
-                               if(words[1] && *words[1]) {
-                                       device = tc_device_create(words[1]);
-                                       class = NULL;
-                               }
-                       }
-                       else if(device && class && first_hash == SENT_HASH && strcmp(words[0], "Sent") == 0) {
-                               // debug(D_TC_LOOP, "SENT line '%s'", words[1]);
-                               if(words[1] && *words[1]) {
-                                       class->bytes = strtoull(words[1], NULL, 10);
-                                       class->updated = 1;
-                               }
-
-                               if(words[3] && *words[3])
-                                       class->packets = strtoull(words[3], NULL, 10);
-
-                               if(words[6] && *words[6])
-                                       class->dropped = strtoull(words[6], NULL, 10);
-
-                               if(words[8] && *words[8])
-                                       class->overlimits = strtoull(words[8], NULL, 10);
-
-                               if(words[10] && *words[10])
-                                       class->requeues = strtoull(words[8], NULL, 10);
-                       }
-                       else if(device && class && class->updated && first_hash == LENDED_HASH && strcmp(words[0], "lended:") == 0) {
-                               // debug(D_TC_LOOP, "LENDED line '%s'", words[1]);
-                               if(words[1] && *words[1])
-                                       class->lended = strtoull(words[1], NULL, 10);
-
-                               if(words[3] && *words[3])
-                                       class->borrowed = strtoull(words[3], NULL, 10);
-
-                               if(words[5] && *words[5])
-                                       class->giants = strtoull(words[5], NULL, 10);
-                       }
-                       else if(device && class && class->updated && first_hash == TOKENS_HASH && strcmp(words[0], "tokens:") == 0) {
-                               // debug(D_TC_LOOP, "TOKENS line '%s'", words[1]);
-                               if(words[1] && *words[1])
-                                       class->tokens = strtoull(words[1], NULL, 10);
-
-                               if(words[3] && *words[3])
-                                       class->ctokens = strtoull(words[3], NULL, 10);
-                       }
-                       else if(device && first_hash == SETDEVICENAME_HASH && strcmp(words[0], "SETDEVICENAME") == 0) {
-                               // debug(D_TC_LOOP, "SETDEVICENAME line '%s'", words[1]);
-                               if(words[1] && *words[1]) tc_device_set_device_name(device, words[1]);
-                       }
-                       else if(device && first_hash == SETDEVICEGROUP_HASH && strcmp(words[0], "SETDEVICEGROUP") == 0) {
-                               // debug(D_TC_LOOP, "SETDEVICEGROUP line '%s'", words[1]);
-                               if(words[1] && *words[1]) tc_device_set_device_family(device, words[1]);
-                       }
-                       else if(device && first_hash == SETCLASSNAME_HASH && strcmp(words[0], "SETCLASSNAME") == 0) {
-                               // debug(D_TC_LOOP, "SETCLASSNAME line '%s' '%s'", words[1], words[2]);
-                               char *id    = words[1];
-                               char *path  = words[2];
-                               if(id && *id && path && *path) tc_device_set_class_name(device, id, path);
-                       }
-                       else if(first_hash == WORKTIME_HASH && strcmp(words[0], "WORKTIME") == 0) {
-                               // debug(D_TC_LOOP, "WORKTIME line '%s' '%s'", words[1], words[2]);
-                               getrusage(RUSAGE_THREAD, &thread);
-
-                               if(!stcpu) stcpu = rrdset_find("netdata.plugin_tc_cpu");
-                               if(!stcpu) {
-                                       stcpu = rrdset_create("netdata", "plugin_tc_cpu", NULL, "tc.helper", NULL, "NetData TC CPU usage", "milliseconds/s", 135000, rrd_update_every, RRDSET_TYPE_STACKED);
-                                       rrddim_add(stcpu, "user",  NULL,  1, 1000, RRDDIM_INCREMENTAL);
-                                       rrddim_add(stcpu, "system", NULL, 1, 1000, RRDDIM_INCREMENTAL);
-                               }
-                               else rrdset_next(stcpu);
-
-                               rrddim_set(stcpu, "user"  , thread.ru_utime.tv_sec * 1000000ULL + thread.ru_utime.tv_usec);
-                               rrddim_set(stcpu, "system", thread.ru_stime.tv_sec * 1000000ULL + thread.ru_stime.tv_usec);
-                               rrdset_done(stcpu);
-
-                               if(!sttime) stcpu = rrdset_find("netdata.plugin_tc_time");
-                               if(!sttime) {
-                                       sttime = rrdset_create("netdata", "plugin_tc_time", NULL, "tc.helper", NULL, "NetData TC script execution", "milliseconds/run", 135001, rrd_update_every, RRDSET_TYPE_AREA);
-                                       rrddim_add(sttime, "run_time",  "run time",  1, 1, RRDDIM_ABSOLUTE);
-                               }
-                               else rrdset_next(sttime);
-
-                               rrddim_set(sttime, "run_time", atoll(words[1]));
-                               rrdset_done(sttime);
-
-                       }
+    uint32_t first_hash;
+
+    snprintfz(buffer, TC_LINE_MAX, "%s/tc-qos-helper.sh", netdata_configured_plugins_dir);
+    char *tc_script = config_get("plugin:tc", "script to run to get tc values", buffer);
+    
+    for(;1;) {
+        if(unlikely(netdata_exit)) break;
+
+        FILE *fp;
+        struct tc_device *device = NULL;
+        struct tc_class *class = NULL;
+
+        snprintfz(buffer, TC_LINE_MAX, "exec %s %d", tc_script, localhost->rrd_update_every);
+        debug(D_TC_LOOP, "executing '%s'", buffer);
+
+        fp = mypopen(buffer, (pid_t *)&tc_child_pid);
+        if(unlikely(!fp)) {
+            error("TC: Cannot popen(\"%s\", \"r\").", buffer);
+            goto cleanup;
+        }
+
+        while(fgets(buffer, TC_LINE_MAX, fp) != NULL) {
+            if(unlikely(netdata_exit)) break;
+
+            buffer[TC_LINE_MAX] = '\0';
+            // debug(D_TC_LOOP, "TC: read '%s'", buffer);
+
+            tc_split_words(buffer, words, MAX_WORDS);
+
+            if(unlikely(!words[0] || !*words[0])) {
+                // debug(D_TC_LOOP, "empty line");
+                continue;
+            }
+            // else debug(D_TC_LOOP, "First word is '%s'", words[0]);
+
+            first_hash = simple_hash(words[0]);
+
+            if(unlikely(device && ((first_hash == CLASS_HASH && strcmp(words[0], "class") == 0) ||  (first_hash == QDISC_HASH && strcmp(words[0], "qdisc") == 0)))) {
+                // debug(D_TC_LOOP, "CLASS line on class id='%s', parent='%s', parentid='%s', leaf='%s', leafid='%s'", words[2], words[3], words[4], words[5], words[6]);
+
+                char *type     = words[1];  // the class/qdisc type: htb, fq_codel, etc
+                char *id       = words[2];  // the class/qdisc major:minor
+                char *parent   = words[3];  // the word 'parent' or 'root'
+                char *parentid = words[4];  // parentid
+                char *leaf     = words[5];  // the word 'leaf'
+                char *leafid   = words[6];  // leafid
+
+                int parent_is_root = 0;
+                int parent_is_parent = 0;
+                if(likely(parent)) {
+                    parent_is_parent = !strcmp(parent, "parent");
+
+                    if(!parent_is_parent)
+                        parent_is_root = !strcmp(parent, "root");
+                }
+
+                if(likely(type && id && (parent_is_root || parent_is_parent))) {
+                    char qdisc = 0;
+
+                    if(first_hash == QDISC_HASH) {
+                        qdisc = 1;
+
+                        if(!strcmp(type, "ingress")) {
+                            // we don't want to get the ingress qdisc
+                            // there should be an IFB interface for this
+
+                            class = NULL;
+                            continue;
+                        }
+
+                        if(parent_is_parent && parentid) {
+                            // eliminate the minor number from parentid
+                            // why: parentid is the id of the parent class
+                            // but major: is also the id of the parent qdisc
+
+                            char *s = parentid;
+                            while(*s && *s != ':') s++;
+                            if(*s == ':') s[1] = '\0';
+                        }
+                    }
+
+                    if(parent_is_root) {
+                        parentid = NULL;
+                        leafid = NULL;
+                    }
+                    else if(!leaf || strcmp(leaf, "leaf") != 0)
+                        leafid = NULL;
+
+                    char leafbuf[20 + 1] = "";
+                    if(leafid && leafid[strlen(leafid) - 1] == ':') {
+                        strncpyz(leafbuf, leafid, 20 - 1);
+                        strcat(leafbuf, "1");
+                        leafid = leafbuf;
+                    }
+
+                    class = tc_class_add(device, id, qdisc, parentid, leafid);
+                }
+                else {
+                    // clear the last class
+                    class = NULL;
+                }
+            }
+            else if(unlikely(first_hash == END_HASH && strcmp(words[0], "END") == 0)) {
+                // debug(D_TC_LOOP, "END line");
+
+                if(likely(device)) {
+                    if(pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, NULL) != 0)
+                        error("Cannot set pthread cancel state to DISABLE.");
+
+                    tc_device_commit(device);
+                    // tc_device_free(device);
+
+                    if(pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL) != 0)
+                        error("Cannot set pthread cancel state to ENABLE.");
+                }
+
+                device = NULL;
+                class = NULL;
+            }
+            else if(unlikely(first_hash == BEGIN_HASH && strcmp(words[0], "BEGIN") == 0)) {
+                // debug(D_TC_LOOP, "BEGIN line on device '%s'", words[1]);
+
+                if(likely(words[1] && *words[1])) {
+                    device = tc_device_create(words[1]);
+                }
+                else {
+                    // tc_device_free(device);
+                    device = NULL;
+                }
+
+                class = NULL;
+            }
+            else if(unlikely(device && class && first_hash == SENT_HASH && strcmp(words[0], "Sent") == 0)) {
+                // debug(D_TC_LOOP, "SENT line '%s'", words[1]);
+                if(likely(words[1] && *words[1])) {
+                    class->bytes = str2ull(words[1]);
+                    class->updated = 1;
+                }
+                else {
+                    class->updated = 0;
+                }
+
+                if(likely(words[3] && *words[3]))
+                    class->packets = str2ull(words[3]);
+
+                if(likely(words[6] && *words[6]))
+                    class->dropped = str2ull(words[6]);
+
+                if(likely(words[8] && *words[8]))
+                    class->overlimits = str2ull(words[8]);
+
+                if(likely(words[10] && *words[10]))
+                    class->requeues = str2ull(words[8]);
+            }
+            else if(unlikely(device && class && class->updated && first_hash == LENDED_HASH && strcmp(words[0], "lended:") == 0)) {
+                // debug(D_TC_LOOP, "LENDED line '%s'", words[1]);
+                if(likely(words[1] && *words[1]))
+                    class->lended = str2ull(words[1]);
+
+                if(likely(words[3] && *words[3]))
+                    class->borrowed = str2ull(words[3]);
+
+                if(likely(words[5] && *words[5]))
+                    class->giants = str2ull(words[5]);
+            }
+            else if(unlikely(device && class && class->updated && first_hash == TOKENS_HASH && strcmp(words[0], "tokens:") == 0)) {
+                // debug(D_TC_LOOP, "TOKENS line '%s'", words[1]);
+                if(likely(words[1] && *words[1]))
+                    class->tokens = str2ull(words[1]);
+
+                if(likely(words[3] && *words[3]))
+                    class->ctokens = str2ull(words[3]);
+            }
+            else if(unlikely(device && first_hash == SETDEVICENAME_HASH && strcmp(words[0], "SETDEVICENAME") == 0)) {
+                // debug(D_TC_LOOP, "SETDEVICENAME line '%s'", words[1]);
+                if(likely(words[1] && *words[1]))
+                    tc_device_set_device_name(device, words[1]);
+            }
+            else if(unlikely(device && first_hash == SETDEVICEGROUP_HASH && strcmp(words[0], "SETDEVICEGROUP") == 0)) {
+                // debug(D_TC_LOOP, "SETDEVICEGROUP line '%s'", words[1]);
+                if(likely(words[1] && *words[1]))
+                    tc_device_set_device_family(device, words[1]);
+            }
+            else if(unlikely(device && first_hash == SETCLASSNAME_HASH && strcmp(words[0], "SETCLASSNAME") == 0)) {
+                // debug(D_TC_LOOP, "SETCLASSNAME line '%s' '%s'", words[1], words[2]);
+                char *id    = words[1];
+                char *path  = words[2];
+                if(likely(id && *id && path && *path))
+                    tc_device_set_class_name(device, id, path);
+            }
+            else if(unlikely(first_hash == WORKTIME_HASH && strcmp(words[0], "WORKTIME") == 0)) {
+                // debug(D_TC_LOOP, "WORKTIME line '%s' '%s'", words[1], words[2]);
+                getrusage(RUSAGE_THREAD, &thread);
+
+                if(unlikely(!stcpu)) stcpu = rrdset_find_localhost("netdata.plugin_tc_cpu");
+                if(unlikely(!stcpu)) {
+                    stcpu = rrdset_create_localhost("netdata", "plugin_tc_cpu", NULL, "tc.helper", NULL
+                                                    , "NetData TC CPU usage", "milliseconds/s", 135000, localhost->rrd_update_every
+                                                    , RRDSET_TYPE_STACKED);
+                    rrddim_add(stcpu, "user",  NULL,  1, 1000, RRD_ALGORITHM_INCREMENTAL);
+                    rrddim_add(stcpu, "system", NULL, 1, 1000, RRD_ALGORITHM_INCREMENTAL);
+                }
+                else rrdset_next(stcpu);
+
+                rrddim_set(stcpu, "user"  , thread.ru_utime.tv_sec * 1000000ULL + thread.ru_utime.tv_usec);
+                rrddim_set(stcpu, "system", thread.ru_stime.tv_sec * 1000000ULL + thread.ru_stime.tv_usec);
+                rrdset_done(stcpu);
+
+                if(unlikely(!sttime)) sttime = rrdset_find_localhost("netdata.plugin_tc_time");
+                if(unlikely(!sttime)) {
+                    sttime = rrdset_create_localhost("netdata", "plugin_tc_time", NULL, "tc.helper", NULL
+                                                     , "NetData TC script execution", "milliseconds/run", 135001
+                                                     , localhost->rrd_update_every, RRDSET_TYPE_AREA);
+                    rrddim_add(sttime, "run_time",  "run time",  1, 1, RRD_ALGORITHM_ABSOLUTE);
+                }
+                else rrdset_next(sttime);
+
+                rrddim_set(sttime, "run_time", atoll(words[1]));
+                rrdset_done(sttime);
+
+            }
 #ifdef DETACH_PLUGINS_FROM_NETDATA
-                       else if(first_hash == MYPID_HASH && (strcmp(words[0], "MYPID") == 0)) {
-                               // debug(D_TC_LOOP, "MYPID line '%s'", words[1]);
-                               char *id = words[1];
-                               pid_t pid = atol(id);
+            else if(unlikely(first_hash == MYPID_HASH && (strcmp(words[0], "MYPID") == 0))) {
+                // debug(D_TC_LOOP, "MYPID line '%s'", words[1]);
+                char *id = words[1];
+                pid_t pid = atol(id);
 
-                               if(pid) tc_child_pid = pid;
+                if(likely(pid)) tc_child_pid = pid;
 
-                               debug(D_TC_LOOP, "TC: Child PID is %d.", tc_child_pid);
-                       }
+                debug(D_TC_LOOP, "TC: Child PID is %d.", tc_child_pid);
+            }
 #endif
-                       //else {
-                       //      debug(D_TC_LOOP, "IGNORED line");
-                       //}
-               }
-               // fgets() failed or loop broke
-               int code = mypclose(fp, tc_child_pid);
-               tc_child_pid = 0;
-
-               if(device) {
-                       // tc_device_free(device);
-                       device = NULL;
-                       class = NULL;
-               }
-
-               if(netdata_exit) {
-                       tc_device_free_all();
-                       pthread_exit(NULL);
-                       return NULL;
-               }
-
-               if(code == 1 || code == 127) {
-                       // 1 = DISABLE
-                       // 127 = cannot even run it
-                       error("TC: tc-qos-helper.sh exited with code %d. Disabling it.", code);
-
-                       tc_device_free_all();
-                       pthread_exit(NULL);
-                       return NULL;
-               }
-
-               sleep((unsigned int) rrd_update_every);
-       }
-
-       pthread_exit(NULL);
-       return NULL;
+            //else {
+            //  debug(D_TC_LOOP, "IGNORED line");
+            //}
+        }
+
+        // fgets() failed or loop broke
+        int code = mypclose(fp, (pid_t)tc_child_pid);
+        tc_child_pid = 0;
+
+        if(unlikely(device)) {
+            // tc_device_free(device);
+            device = NULL;
+            class = NULL;
+        }
+
+        if(unlikely(netdata_exit)) {
+            tc_device_free_all();
+            goto cleanup;
+        }
+
+        if(code == 1 || code == 127) {
+            // 1 = DISABLE
+            // 127 = cannot even run it
+            error("TC: tc-qos-helper.sh exited with code %d. Disabling it.", code);
+
+            tc_device_free_all();
+            goto cleanup;
+        }
+
+        sleep((unsigned int) localhost->rrd_update_every);
+    }
+
+cleanup:
+    info("TC thread exiting");
+
+    static_thread->enabled = 0;
+    pthread_exit(NULL);
+    return NULL;
 }