Ralph Boehme [Wed, 11 Sep 2013 09:38:11 +0000 (11:38 +0200)]
Fix handling of large number of volumes
o ensure only a maximum of 255 volumes is returned
o ensure the reply with the volume list fits in a certain buffer
size, testing with 10.8.4 saw the maximum size the client would
accept to be ~4600 bytes
Ralph Boehme [Tue, 8 Oct 2013 10:36:25 +0000 (12:36 +0200)]
Fix error in ad_openat(), bug #532
Saving from Word to a folder that is a symlink to a folder on another filesystem
results in a crash of the afpd process and the save to fail. This happens only
if the option "follow symlinks" is enabled.
Ralph Boehme [Wed, 18 Sep 2013 09:08:38 +0000 (11:08 +0200)]
Small fix in the DSI tickle handling
Due to a regression introduced in 9355ebcc5744bbd445a0c8cb8b0a0ca201d5499a
the server may send an extra DSI tickle immediately after a "volume modified"
DSI attention notification. This will only happen if the connection is
o completely idle, and
o the volume was modified by another AFP client
The result is an extra DSI tickle every 30 seconds.
Ralph Boehme [Fri, 13 Sep 2013 10:19:56 +0000 (12:19 +0200)]
Option "vol dbnest"
When set to true, the CNID database for a volume is stored in the volume root
of a share in a directory .AppleDB like in Netatalk 2. Defaults to false.
HAT [Thu, 29 Aug 2013 11:40:27 +0000 (20:40 +0900)]
twisted u_name and m_name
Fix Bug#523.
Additional Info:
The following line in ofork.c may also be wrong.
/* Somone has used write_fork, we assume file was changed, register it to file change event api */
if (ofork->of_flags & AFPFORK_MODIFIED) {
struct dir *dir = dirlookup(ofork->of_vol, ofork->of_did);
bstring forkpath = bformat("%s/%s", bdata(dir->d_fullpath), of_name(ofork));
fce_register(FCE_FILE_MODIFY, bdata(forkpath), NULL, fce_file);
bdestroy(forkpath);
}
Ralph Boehme [Thu, 25 Jul 2013 16:31:11 +0000 (18:31 +0200)]
Send optional AFP messages for vetoed files
New option "veto messages" can be used to enable sending messages.
Then whenever a client tries to access any file or directory
with a vetoed name, it will be sent an AFP message indicating
the name and the directory.
Ralph Boehme [Sun, 23 Jun 2013 17:37:00 +0000 (19:37 +0200)]
Rename all iniparser API function
Linking with PAM and using pam_windind from Samba will otherwise
result in the pam_winbind calling our iniparser functions instead
of their own copies. As both implementation differ this leads to
crashes in the worst case.
Ralph Boehme [Thu, 18 Apr 2013 08:58:44 +0000 (10:58 +0200)]
Remove size check that required a costly fstat()
In case the client request count plus offset is large then the file,
we're supposed to send the available data and set AFP error to
AFPERR_EOF.
No need to use an extra fstat() for that, we can also simply check
the whether the amount of data read from the file matches the
requested amount.
Ralph Boehme [Tue, 26 Mar 2013 05:58:44 +0000 (06:58 +0100)]
Use ostat in the dircache
Fixes a possible crash in cname() where cname_mtouname calls
dirlookup() where the curdir is freed because the dircache
detected a dev/inode cache difference and evicted the object
from the cache.
Frank Lahm [Thu, 28 Feb 2013 07:02:48 +0000 (08:02 +0100)]
Enhance ACL mapping
Change globald ACL option 'map acl' to take the following options:
"none", "rights", "mode". The default is "rights".
none = no mapping, this resembles the previous false/no setting
rights = map ACLs to Finder UARights, this resembles the previous
true/yes setting. This is the default.
mode = map ACLs to Finder UARights and UNIX mode
Frank Lahm [Sat, 6 Apr 2013 15:08:37 +0000 (17:08 +0200)]
Fix an issue with filenames containing non-ASCII characters
Fix an issue with filenames containing non-ASCII characters that
lead to a failure setting the size of a files ressource fork.
This affected application like Adobe Photoshop where saving
files may fail. Fixes bug #511.
Ralph Boehme [Wed, 27 Mar 2013 16:18:22 +0000 (17:18 +0100)]
Opening files without metadata EA may result in broken metadata EA
ad_open_hf_ea() calls ad_flush() after initializing the new metadata,
but in ad_flush() ad_flush_ea() wasn't called because we didn't
yet increment the refcount.
Fix this by increasing the refcount in ad_open_hf() before calling
into ad_open_hf_ea(), decrementing it again in case of an error.
This ensure a valid metadata EA is created, but it still doesn't
set the CNID field values. Therefor in afp_openfork() we must check
whether the ad_open() created a metadata EA and then set the CNID
info.
Finally, check for malformed metadata EAs and delete them.
Ralph Boehme [Tue, 19 Mar 2013 14:26:03 +0000 (15:26 +0100)]
Increase IO size when sendfile() is not used
If sendfile() support is disabled, the current code results in an
IO size of 8k for transferring requested data to the client. Eg:
- client request to read DSI quantum size bytes (~250k) from a file
- afpd process loops read(8k, file) -> send(8k, client) until all
250k have been transferred
This should be modified to read the whole 250k in one swoop from the
file to a buffer and then send the whole buffer in one swoop to the
client.
Frank Lahm [Fri, 15 Mar 2013 08:19:40 +0000 (09:19 +0100)]
Use FreeBSD sendfile() capability to send protocol header
When transmitting file contents to a client with sendfile(), on
every platform other then Solaris (where we use sendfilev()), we
send the AFP the protocol header with an additional send with
MSG_MORE before calling sendfile().
FreeBSD sendfile() supports sending protocol header (and trailer)
data similarly to Solaris sendfilev().
projects / netatalk.git / log