From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Wed, 13 Feb 2013 21:18:41 +0000 (+0100)
Subject: afpd/file: fix check in deletefile
X-Git-Url: https://arthur.barton.de/gitweb/?p=netatalk.git;a=commitdiff_plain;h=cc9df88163a2e018a55725f9b87c4002c84811ac

afpd/file: fix check in deletefile

AD_RSRC_OPEN(ad) is defined as:

(((ad)->ad_reso_refcount) && (ad_reso_fileno(ad) >= 0))

So there's no way it can returns -1

Reported by coverity as CID #762087.
---

diff --git a/etc/afpd/file.c b/etc/afpd/file.c
index e48afe21..e7859659 100644
--- a/etc/afpd/file.c
+++ b/etc/afpd/file.c
@@ -1580,7 +1580,7 @@ int deletefile(const struct vol *vol, int dirfd, char *file, int checkAttrib)
         adp = &ad;
     }
 
-    if ( adp && AD_RSRC_OPEN(adp) != -1 ) { /* there's a resource fork */
+    if ( adp && AD_RSRC_OPEN(adp) ) { /* there's a resource fork */
         adflags |= ADFLAGS_RF;
         /* FIXME we have a pb here because we want to know if a file is open 
          * there's a 'priority inversion' if you can't open the ressource fork RW