From: Ralph Boehme Date: Sat, 24 Nov 2012 15:34:14 +0000 (+0100) Subject: Add logtype_ad X-Git-Url: https://arthur.barton.de/gitweb/?p=netatalk.git;a=commitdiff_plain;h=9fae7d8e8f0f744b66819b308b0aff0621e5211c Add logtype_ad --- diff --git a/include/atalk/logger.h b/include/atalk/logger.h index 330eb7b6..1847c0d5 100644 --- a/include/atalk/logger.h +++ b/include/atalk/logger.h @@ -92,6 +92,7 @@ enum logtypes { logtype_dsi, logtype_uams, logtype_fce, + logtype_ad, logtype_end_of_list_marker /* don't put any logtypes after this */ }; diff --git a/libatalk/adouble/ad_conv.c b/libatalk/adouble/ad_conv.c index eaac8db9..eef80912 100644 --- a/libatalk/adouble/ad_conv.c +++ b/libatalk/adouble/ad_conv.c @@ -62,7 +62,7 @@ static int ad_conv_v22ea_hf(const char *path, const struct stat *sp, const struc uint32_t ctime, mtime, afpinfo = 0; char *emptyad; - LOG(log_debug, logtype_default,"ad_conv_v22ea_hf(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_hf(\"%s\"): BEGIN", fullpathname(path)); ad_init(&adea, vol); ad_init_old(&adv2, AD_VERSION2, adea.ad_options); @@ -97,12 +97,12 @@ static int ad_conv_v22ea_hf(const char *path, const struct stat *sp, const struc goto copy; } - LOG(log_debug, logtype_default,"ad_conv_v22ea_hf(\"%s\"): default adouble", fullpathname(path), ret); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_hf(\"%s\"): default adouble", fullpathname(path), ret); goto EC_CLEANUP; copy: /* Create a adouble:ea meta EA */ - LOG(log_debug, logtype_default,"ad_conv_v22ea_hf(\"%s\"): copying adouble", fullpathname(path), ret); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_hf(\"%s\"): copying adouble", fullpathname(path), ret); EC_ZERO_LOGSTR( ad_open(&adea, path, adflags | ADFLAGS_HF | ADFLAGS_RDWR | ADFLAGS_CREATE), "ad_conv_v22ea_hf(\"%s\"): error creating metadata EA: %s", fullpathname(path), strerror(errno)); @@ -112,7 +112,7 @@ copy: EC_CLEANUP: EC_ZERO_LOG( ad_close(&adv2, ADFLAGS_HF | ADFLAGS_SETSHRMD) ); EC_ZERO_LOG( ad_close(&adea, ADFLAGS_HF | ADFLAGS_SETSHRMD) ); - LOG(log_debug, logtype_default,"ad_conv_v22ea_hf(\"%s\"): END: %d", fullpathname(path), ret); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_hf(\"%s\"): END: %d", fullpathname(path), ret); EC_EXIT; } @@ -122,7 +122,7 @@ static int ad_conv_v22ea_rf(const char *path, const struct stat *sp, const struc struct adouble adv2; struct adouble adea; - LOG(log_debug, logtype_default,"ad_conv_v22ea_rf(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_rf(\"%s\"): BEGIN", fullpathname(path)); if (S_ISDIR(sp->st_mode)) return 0; @@ -147,7 +147,7 @@ static int ad_conv_v22ea_rf(const char *path, const struct stat *sp, const struc EC_CLEANUP: EC_ZERO_LOG( ad_close(&adv2, ADFLAGS_HF | ADFLAGS_RF) ); EC_ZERO_LOG( ad_close(&adea, ADFLAGS_HF | ADFLAGS_RF) ); - LOG(log_debug, logtype_default,"ad_conv_v22ea_rf(\"%s\"): END: %d", fullpathname(path), ret); + LOG(log_debug, logtype_ad,"ad_conv_v22ea_rf(\"%s\"): END: %d", fullpathname(path), ret); EC_EXIT; } @@ -163,7 +163,7 @@ static int ad_conv_v22ea(const char *path, const struct stat *sp, const struct v EC_ZERO( ad_conv_v22ea_rf(path, sp, vol) ); EC_NULL( adpath = ad_path(path, adflags) ); - LOG(log_debug, logtype_default,"ad_conv_v22ea_hf(\"%s\"): deleting adouble:v2 file: \"%s\"", + LOG(log_debug, logtype_ad,"ad_conv_v22ea_hf(\"%s\"): deleting adouble:v2 file: \"%s\"", path, fullpathname(adpath)); unlink(adpath); @@ -188,7 +188,7 @@ static int ad_conv_dehex(const char *path, const struct stat *sp, const struct v int adflags = S_ISDIR(sp->st_mode) ? ADFLAGS_DIR : 0; bstring newpath = NULL; - LOG(log_debug, logtype_default,"ad_conv_dehex(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad,"ad_conv_dehex(\"%s\"): BEGIN", fullpathname(path)); *newpathp = NULL; @@ -231,7 +231,7 @@ int ad_convert(const char *path, const struct stat *sp, const struct vol *vol, c EC_INIT; const char *p; - LOG(log_debug, logtype_default,"ad_convert(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad,"ad_convert(\"%s\"): BEGIN", fullpathname(path)); if (newpath) *newpath = NULL; @@ -246,7 +246,7 @@ int ad_convert(const char *path, const struct stat *sp, const struct vol *vol, c } EC_CLEANUP: - LOG(log_debug, logtype_default,"ad_convert(\"%s\"): END: %d", fullpathname(path), ret); + LOG(log_debug, logtype_ad,"ad_convert(\"%s\"): END: %d", fullpathname(path), ret); EC_EXIT; } diff --git a/libatalk/adouble/ad_flush.c b/libatalk/adouble/ad_flush.c index 91f8058b..61b34f50 100644 --- a/libatalk/adouble/ad_flush.c +++ b/libatalk/adouble/ad_flush.c @@ -61,7 +61,7 @@ int ad_rebuild_adouble_header_v2(struct adouble *ad) char *buf, *nentp; int len; - LOG(log_debug, logtype_default, "ad_rebuild_adouble_header_v2"); + LOG(log_debug, logtype_ad, "ad_rebuild_adouble_header_v2"); buf = ad->ad_data; @@ -107,7 +107,7 @@ int ad_rebuild_adouble_header_ea(struct adouble *ad) char *buf, *nentp; int len; - LOG(log_debug, logtype_default, "ad_rebuild_adouble_header_ea"); + LOG(log_debug, logtype_ad, "ad_rebuild_adouble_header_ea"); buf = ad->ad_data; @@ -155,7 +155,7 @@ static int ad_rebuild_adouble_header_osx(struct adouble *ad, char *adbuf) char *buf; int len; - LOG(log_debug, logtype_default, "ad_rebuild_adouble_header_osx"); + LOG(log_debug, logtype_ad, "ad_rebuild_adouble_header_osx"); buf = &adbuf[0]; @@ -253,7 +253,7 @@ static int ad_flush_hf(struct adouble *ad) int len; int cwd = -1; - LOG(log_debug, logtype_default, "ad_flush_hf(%s)", adflags2logstr(ad->ad_adflags)); + LOG(log_debug, logtype_ad, "ad_flush_hf(%s)", adflags2logstr(ad->ad_adflags)); struct ad_fd *adf; @@ -265,7 +265,7 @@ static int ad_flush_hf(struct adouble *ad) adf = &ad->ad_data_fork; break; default: - LOG(log_error, logtype_afpd, "ad_flush: unexpected adouble version"); + LOG(log_error, logtype_ad, "ad_flush: unexpected adouble version"); return -1; } @@ -302,7 +302,7 @@ static int ad_flush_hf(struct adouble *ad) } break; default: - LOG(log_error, logtype_afpd, "ad_flush: unexpected adouble version"); + LOG(log_error, logtype_ad, "ad_flush: unexpected adouble version"); return -1; } } @@ -329,7 +329,7 @@ static int ad_flush_rf(struct adouble *ad) if (ad->ad_vers != AD_VERSION_EA) return 0; - LOG(log_debug, logtype_default, "ad_flush_rf(%s)", adflags2logstr(ad->ad_adflags)); + LOG(log_debug, logtype_ad, "ad_flush_rf(%s)", adflags2logstr(ad->ad_adflags)); if ((ad->ad_rfp->adf_flags & O_RDWR)) { if (ad_getentryoff(ad, ADEID_RFORK)) { @@ -353,7 +353,7 @@ int ad_flush(struct adouble *ad) { EC_INIT; - LOG(log_debug, logtype_default, "ad_flush(%s)", adflags2logstr(ad->ad_adflags)); + LOG(log_debug, logtype_ad, "ad_flush(%s)", adflags2logstr(ad->ad_adflags)); if (AD_META_OPEN(ad)) { EC_ZERO( ad_flush_hf(ad) ); @@ -393,7 +393,7 @@ int ad_close(struct adouble *ad, int adflags) return err; - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_close(%s): BEGIN: {d: %d, m: %d, r: %d} " "[dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", adflags2logstr(adflags), @@ -447,7 +447,7 @@ int ad_close(struct adouble *ad, int adflags) } } - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_close(%s): END: %d {d: %d, m: %d, r: %d} " "[dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", adflags2logstr(adflags), err, diff --git a/libatalk/adouble/ad_lock.c b/libatalk/adouble/ad_lock.c index 92f0ab89..6e159cdd 100644 --- a/libatalk/adouble/ad_lock.c +++ b/libatalk/adouble/ad_lock.c @@ -64,7 +64,7 @@ static int set_lock(int fd, int cmd, struct flock *lock) { EC_INIT; - LOG(log_debug, logtype_default, "set_lock(fd: %d, %s, %s, off: %jd (%s), len: %jd): BEGIN", + LOG(log_debug, logtype_ad, "set_lock(fd: %d, %s, %s, off: %jd (%s), len: %jd): BEGIN", fd, cmd == F_SETLK ? "F_SETLK" : "F_GETLK", lock->l_type == F_RDLCK ? "F_RDLCK" : lock->l_type == F_WRLCK ? "F_WRLCK" : "F_UNLCK", (intmax_t)lock->l_start, @@ -361,7 +361,7 @@ int ad_lock(struct adouble *ad, uint32_t eid, int locktype, off_t off, off_t len int type; int ret = 0, fcntl_lock_err = 0; - LOG(log_debug, logtype_default, "ad_lock(%s, %s, off: %jd (%s), len: %jd): BEGIN", + LOG(log_debug, logtype_ad, "ad_lock(%s, %s, off: %jd (%s), len: %jd): BEGIN", eid == ADEID_DFORK ? "data" : "reso", locktypetostr(locktype), (intmax_t)off, @@ -496,7 +496,7 @@ exit: set_lock(adf->adf_fd, F_SETLK, &lock); } } - LOG(log_debug, logtype_default, "ad_lock: END: %d", ret); + LOG(log_debug, logtype_ad, "ad_lock: END: %d", ret); return ret; } @@ -507,7 +507,7 @@ int ad_tmplock(struct adouble *ad, uint32_t eid, int locktype, off_t off, off_t int err; int type; - LOG(log_debug, logtype_default, "ad_tmplock(%s, %s, off: %jd (%s), len: %jd): BEGIN", + LOG(log_debug, logtype_ad, "ad_tmplock(%s, %s, off: %jd (%s), len: %jd): BEGIN", eid == ADEID_DFORK ? "data" : "reso", locktypetostr(locktype), (intmax_t)off, @@ -564,14 +564,14 @@ int ad_tmplock(struct adouble *ad, uint32_t eid, int locktype, off_t off, off_t adf_relockrange(adf, adf->adf_fd, lock.l_start, len); exit: - LOG(log_debug, logtype_default, "ad_tmplock: END: %d", err); + LOG(log_debug, logtype_ad, "ad_tmplock: END: %d", err); return err; } /* --------------------- */ void ad_unlock(struct adouble *ad, const int fork, int unlckbrl) { - LOG(log_debug, logtype_default, "ad_unlock(unlckbrl: %d): BEGIN", unlckbrl); + LOG(log_debug, logtype_ad, "ad_unlock(unlckbrl: %d): BEGIN", unlckbrl); if (ad_data_fileno(ad) != -1) { adf_unlock(ad, &ad->ad_data_fork, fork, unlckbrl); @@ -580,7 +580,7 @@ void ad_unlock(struct adouble *ad, const int fork, int unlckbrl) adf_unlock(ad, &ad->ad_resource_fork, fork, unlckbrl); } - LOG(log_debug, logtype_default, "ad_unlock: END"); + LOG(log_debug, logtype_ad, "ad_unlock: END"); } /*! @@ -598,7 +598,7 @@ int ad_testlock(struct adouble *ad, int eid, const off_t off) int ret = 0; off_t lock_offset; - LOG(log_debug, logtype_default, "ad_testlock(%s, off: %jd (%s): BEGIN", + LOG(log_debug, logtype_ad, "ad_testlock(%s, off: %jd (%s): BEGIN", eid == ADEID_DFORK ? "data" : "reso", (intmax_t)off, shmdstrfromoff(off)); @@ -611,7 +611,7 @@ int ad_testlock(struct adouble *ad, int eid, const off_t off) ret = testlock(&ad->ad_data_fork, lock_offset, 1); - LOG(log_debug, logtype_default, "ad_testlock: END: %d", ret); + LOG(log_debug, logtype_ad, "ad_testlock: END: %d", ret); return ret; } diff --git a/libatalk/adouble/ad_open.c b/libatalk/adouble/ad_open.c index 045c33c3..bc72ff0b 100644 --- a/libatalk/adouble/ad_open.c +++ b/libatalk/adouble/ad_open.c @@ -316,10 +316,10 @@ static int new_ad_header(struct adouble *ad, const char *path, struct stat *stp, uint16_t ashort; struct stat st; - LOG(log_debug, logtype_default, "new_ad_header(\"%s\")", path); + LOG(log_debug, logtype_ad, "new_ad_header(\"%s\")", path); if (ad->ad_magic == AD_MAGIC) { - LOG(log_debug, logtype_default, "new_ad_header(\"%s\"): already initialized", path); + LOG(log_debug, logtype_ad, "new_ad_header(\"%s\"): already initialized", path); return 0; } @@ -409,7 +409,7 @@ static void parse_entries(struct adouble *ad, char *buf, uint16_t nentries) ad->ad_eid[ eid ].ade_len = len; } else if (!warning) { warning = 1; - LOG(log_warning, logtype_default, "parse_entries: bogus eid: %d", eid); + LOG(log_warning, logtype_ad, "parse_entries: bogus eid: %d", eid); } } } @@ -444,7 +444,7 @@ static int ad_header_read(const char *path _U_, struct adouble *ad, const struct ad->ad_version = ntohl( ad->ad_version ); if ((ad->ad_magic != AD_MAGIC) || (ad->ad_version != AD_VERSION2)) { - LOG(log_error, logtype_default, "ad_open: can't parse AppleDouble header."); + LOG(log_error, logtype_ad, "ad_open: can't parse AppleDouble header."); errno = EIO; return -1; } @@ -461,7 +461,7 @@ static int ad_header_read(const char *path _U_, struct adouble *ad, const struct buf += AD_HEADER_LEN; if (len > header_len - AD_HEADER_LEN) { - LOG(log_error, logtype_default, "ad_header_read: can't read entry info."); + LOG(log_error, logtype_ad, "ad_header_read: can't read entry info."); errno = EIO; return -1; } @@ -473,13 +473,13 @@ static int ad_header_read(const char *path _U_, struct adouble *ad, const struct if (!ad_getentryoff(ad, ADEID_RFORK) || (ad_getentryoff(ad, ADEID_RFORK) > sizeof(ad->ad_data)) ) { - LOG(log_error, logtype_default, "ad_header_read: problem with rfork entry offset."); + LOG(log_error, logtype_ad, "ad_header_read: problem with rfork entry offset."); errno = EIO; return -1; } if (ad_getentryoff(ad, ADEID_RFORK) > header_len) { - LOG(log_error, logtype_default, "ad_header_read: can't read in entries."); + LOG(log_error, logtype_ad, "ad_header_read: can't read in entries."); errno = EIO; return -1; } @@ -505,7 +505,7 @@ int ad_valid_header_osx(const char *path) char *buf = &adosx.ad_data[0]; ssize_t header_len; - LOG(log_debug, logtype_afpd, "ad_valid_header_osx(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad, "ad_valid_header_osx(\"%s\"): BEGIN", fullpathname(path)); EC_NEG1( fd = open(path, O_RDONLY) ); @@ -521,7 +521,7 @@ int ad_valid_header_osx(const char *path) adosx.ad_version = ntohl(adosx.ad_version); if ((adosx.ad_magic != AD_MAGIC) || (adosx.ad_version != AD_VERSION2)) { - LOG(log_warning, logtype_afpd, "ad_valid_header_osx: not an adouble:osx file"); + LOG(log_warning, logtype_ad, "ad_valid_header_osx: not an adouble:osx file"); EC_FAIL; } @@ -534,7 +534,7 @@ int ad_valid_header_osx(const char *path) EC_FAIL; EC_CLEANUP: - LOG(log_debug, logtype_afpd, "ad_valid_header_osx(\"%s\"): END: %d", fullpathname(path), ret); + LOG(log_debug, logtype_ad, "ad_valid_header_osx(\"%s\"): END: %d", fullpathname(path), ret); if (fd != -1) close(fd); if (ret != 0) @@ -569,7 +569,7 @@ static int ad_header_read_osx(const char *path _U_, struct adouble *ad, const st adosx.ad_version = ntohl(adosx.ad_version); if ((adosx.ad_magic != AD_MAGIC) || (adosx.ad_version != AD_VERSION2)) { - LOG(log_error, logtype_afpd, "ad_header_read_osx: can't parse AppleDouble header"); + LOG(log_error, logtype_ad, "ad_header_read_osx: can't parse AppleDouble header"); errno = EIO; return -1; } @@ -583,7 +583,7 @@ static int ad_header_read_osx(const char *path _U_, struct adouble *ad, const st buf += AD_HEADER_LEN; if (len > header_len - AD_HEADER_LEN) { - LOG(log_error, logtype_afpd, "ad_header_read_osx: can't read entry info."); + LOG(log_error, logtype_ad, "ad_header_read_osx: can't read entry info."); errno = EIO; return -1; } @@ -595,7 +595,7 @@ static int ad_header_read_osx(const char *path _U_, struct adouble *ad, const st || ad_getentryoff(&adosx, ADEID_RFORK) > sizeof(ad->ad_data) || ad_getentryoff(&adosx, ADEID_RFORK) > header_len ) { - LOG(log_error, logtype_afpd, "ad_header_read_osx: problem with rfork entry offset."); + LOG(log_error, logtype_ad, "ad_header_read_osx: problem with rfork entry offset."); errno = EIO; return -1; } @@ -624,12 +624,12 @@ static int ad_header_read_ea(const char *path, struct adouble *ad, const struct else header_len = sys_lgetxattr(path, AD_EA_META, ad->ad_data, AD_DATASZ_EA); if (header_len < 1) { - LOG(log_debug, logtype_default, "ad_header_read_ea: %s", strerror(errno)); + LOG(log_debug, logtype_ad, "ad_header_read_ea: %s", strerror(errno)); return -1; } if (header_len < AD_HEADER_LEN) { - LOG(log_error, logtype_default, "ad_header_read_ea: bogus AppleDouble header."); + LOG(log_error, logtype_ad, "ad_header_read_ea: bogus AppleDouble header."); errno = EIO; return -1; } @@ -641,7 +641,7 @@ static int ad_header_read_ea(const char *path, struct adouble *ad, const struct ad->ad_version = ntohl( ad->ad_version ); if ((ad->ad_magic != AD_MAGIC) || (ad->ad_version != AD_VERSION2)) { - LOG(log_error, logtype_default, "ad_header_read_ea: wrong magic or version"); + LOG(log_error, logtype_ad, "ad_header_read_ea: wrong magic or version"); errno = EIO; return -1; } @@ -654,7 +654,7 @@ static int ad_header_read_ea(const char *path, struct adouble *ad, const struct if (len + AD_HEADER_LEN > sizeof(ad->ad_data)) len = sizeof(ad->ad_data) - AD_HEADER_LEN; if (len > header_len - AD_HEADER_LEN) { - LOG(log_error, logtype_default, "ad_header_read_ea: can't read entry info."); + LOG(log_error, logtype_ad, "ad_header_read_ea: can't read entry info."); errno = EIO; return -1; } @@ -820,7 +820,7 @@ static int ad_open_df(const char *path, int adflags, mode_t mode, struct adouble int st_invalid = -1; ssize_t lsz; - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_df(\"%s\", %s): BEGIN [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -886,7 +886,7 @@ static int ad_open_df(const char *path, int adflags, mode_t mode, struct adouble ad->ad_data_fork.adf_refcount++; EC_CLEANUP: - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_df(\"%s\", %s): END: %d [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ret, ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -906,7 +906,7 @@ static int ad_open_hf_v2(const char *path, int adflags, mode_t mode, struct adou mode_t admode; int st_invalid = -1; - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_hf_v2(\"%s\", %s): BEGIN [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -930,7 +930,7 @@ static int ad_open_hf_v2(const char *path, int adflags, mode_t mode, struct adou ad_p = ad->ad_ops->ad_path(path, adflags); oflags = O_NOFOLLOW | ad2openflags(ad, ADFLAGS_HF, adflags); - LOG(log_debug, logtype_default,"ad_open_hf_v2(\"%s\"): open flags: %s", + LOG(log_debug, logtype_ad,"ad_open_hf_v2(\"%s\"): open flags: %s", fullpathname(path), openflags2logstr(oflags)); nocreatflags = oflags & ~(O_CREAT | O_EXCL); @@ -957,7 +957,7 @@ static int ad_open_hf_v2(const char *path, int adflags, mode_t mode, struct adou /* * We're expecting to create a new adouble header file here */ - LOG(log_debug, logtype_default, "ad_open(\"%s\"): creating adouble file", + LOG(log_debug, logtype_ad, "ad_open(\"%s\"): creating adouble file", fullpathname(path)); admode = mode; errno = 0; @@ -1018,7 +1018,7 @@ EC_CLEANUP: ad_meta_fileno(ad) = -1; ad->ad_mdp->adf_refcount = 0; } - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_hf_v2(\"%s\", %s): END: %d [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ret, ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -1034,7 +1034,7 @@ static int ad_open_hf_ea(const char *path, int adflags, int mode, struct adouble int oflags; int opened = 0; - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\", %s): BEGIN [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -1051,7 +1051,7 @@ static int ad_open_hf_ea(const char *path, int adflags, int mode, struct adouble if ((oflags & O_RDWR) && /* and it was already denied: */ (ad->ad_mdp->adf_flags & O_RDONLY)) { - LOG(log_error, logtype_default, "ad_open_hf_ea(%s): rw request for ro file: %s", + LOG(log_error, logtype_ad, "ad_open_hf_ea(%s): rw request for ro file: %s", fullpathname(path), strerror(errno)); errno = EACCES; EC_FAIL; @@ -1064,7 +1064,7 @@ static int ad_open_hf_ea(const char *path, int adflags, int mode, struct adouble if (adflags & ADFLAGS_DIR) /* For directories we open the directory RDONYL so we can later fchdir() */ oflags = (oflags & ~O_RDWR) | O_RDONLY; - LOG(log_debug, logtype_default, "ad_open_hf_ea(\"%s\"): opening base file for meta adouble EA", path); + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\"): opening base file for meta adouble EA", path); EC_NEG1(ad_meta_fileno(ad) = open(path, oflags)); opened = 1; ad->ad_mdp->adf_flags = oflags; @@ -1074,16 +1074,16 @@ static int ad_open_hf_ea(const char *path, int adflags, int mode, struct adouble /* Read the adouble header in and parse it.*/ if (ad->ad_ops->ad_header_read(path, ad, NULL) != 0) { if (!(adflags & ADFLAGS_CREATE)) { - LOG(log_debug, logtype_default, "ad_open_hf_ea(\"%s\"): can't read metadata EA", path); + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\"): can't read metadata EA", path); errno = ENOENT; EC_FAIL; } - LOG(log_debug, logtype_default, "ad_open_hf_ea(\"%s\"): creating metadata EA", path); + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\"): creating metadata EA", path); /* It doesnt exist, EPERM or another error */ if (!(errno == ENOATTR || errno == ENOENT)) { - LOG(log_error, logtype_default, "ad_open_hf_ea: unexpected: %s", strerror(errno)); + LOG(log_error, logtype_ad, "ad_open_hf_ea: unexpected: %s", strerror(errno)); EC_FAIL; } @@ -1091,7 +1091,7 @@ static int ad_open_hf_ea(const char *path, int adflags, int mode, struct adouble EC_NEG1_LOG(new_ad_header(ad, path, NULL, adflags)); ad->ad_mdp->adf_flags |= O_CREAT; /* mark as just created */ ad_flush(ad); - LOG(log_debug, logtype_default, "ad_open_hf_ea(\"%s\"): created metadata EA", path); + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\"): created metadata EA", path); } if (ad_meta_fileno(ad) != -1) @@ -1104,7 +1104,7 @@ EC_CLEANUP: ad_meta_fileno(ad) = -1; ad->ad_mdp->adf_refcount = 0; } - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open_hf_ea(\"%s\", %s): END: %d [dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), ret, ad_data_fileno(ad), ad->ad_data_fork.adf_refcount, @@ -1152,7 +1152,7 @@ static int ad_reso_size(const char *path, int adflags, struct adouble *ad) goto EC_CLEANUP; } - LOG(log_debug, logtype_default, "ad_reso_size(\"%s\"): BEGIN", path); + LOG(log_debug, logtype_ad, "ad_reso_size(\"%s\"): BEGIN", path); #ifdef HAVE_EAFD ssize_t easz; @@ -1176,7 +1176,7 @@ static int ad_reso_size(const char *path, int adflags, struct adouble *ad) ad->ad_rlen = 0; #endif - LOG(log_debug, logtype_default, "ad_reso_size(\"%s\"): size: %zd", path, ad->ad_rlen); + LOG(log_debug, logtype_ad, "ad_reso_size(\"%s\"): size: %zd", path, ad->ad_rlen); EC_CLEANUP: if (ret != 0) @@ -1207,7 +1207,7 @@ static int ad_open_rf_ea(const char *path, int adflags, int mode, struct adouble struct stat st; #endif - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): BEGIN", fullpathname(path)); + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): BEGIN", fullpathname(path)); oflags = O_NOFOLLOW | (ad2openflags(ad, ADFLAGS_RF, adflags) & ~O_CREAT); @@ -1243,7 +1243,7 @@ static int ad_open_rf_ea(const char *path, int adflags, int mode, struct adouble EC_FAIL; oflags |= O_CREAT; EC_NEG1_LOG( ad_reso_fileno(ad) = open(rfpath, oflags, mode) ); - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): created adouble rfork: \"%s\"", + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): created adouble rfork: \"%s\"", path, rfpath); } #endif @@ -1255,15 +1255,15 @@ static int ad_open_rf_ea(const char *path, int adflags, int mode, struct adouble EC_ZERO_LOG( fstat(ad_reso_fileno(ad), &st) ); if (ad->ad_rfp->adf_flags & O_CREAT) { /* This is a new adouble header file, create it */ - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): created adouble rfork, initializing: \"%s\"", + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): created adouble rfork, initializing: \"%s\"", path, rfpath); EC_NEG1_LOG( new_ad_header(ad, path, NULL, adflags) ); - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): created adouble rfork, flushing: \"%s\"", + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): created adouble rfork, flushing: \"%s\"", path, rfpath); ad_flush(ad); } else { /* Read the adouble header */ - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): reading adouble rfork: \"%s\"", + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): reading adouble rfork: \"%s\"", path, rfpath); EC_NEG1_LOG( ad_header_read_osx(NULL, ad, &st) ); } @@ -1288,7 +1288,7 @@ EC_CLEANUP: ad->ad_rlen = 0; } - LOG(log_debug, logtype_default, "ad_open_rf(\"%s\"): END: %d", fullpathname(path), ret); + LOG(log_debug, logtype_ad, "ad_open_rf(\"%s\"): END: %d", fullpathname(path), ret); EC_EXIT; } @@ -1508,7 +1508,7 @@ int ad_mkdir( const char *path, mode_t mode) int st_invalid; struct stat stbuf; - LOG(log_debug, logtype_default, "ad_mkdir(\"%s\", %04o) {cwd: \"%s\"}", + LOG(log_debug, logtype_ad, "ad_mkdir(\"%s\", %04o) {cwd: \"%s\"}", path, mode, getcwdpath()); st_invalid = ad_mode_st(path, &mode, &stbuf); @@ -1611,7 +1611,7 @@ int ad_open(struct adouble *ad, const char *path, int adflags, ...) va_list args; mode_t mode = 0; - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open(\"%s\", %s): BEGIN {d: %d, m: %d, r: %d}" "[dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), adflags2logstr(adflags), @@ -1678,7 +1678,7 @@ int ad_open(struct adouble *ad, const char *path, int adflags, ...) } EC_CLEANUP: - LOG(log_debug, logtype_default, + LOG(log_debug, logtype_ad, "ad_open(\"%s\"): END: %d {d: %d, m: %d, r: %d}" "[dfd: %d (ref: %d), mfd: %d (ref: %d), rfd: %d (ref: %d)]", fullpathname(path), ret, @@ -1742,7 +1742,7 @@ int ad_metadataat(int dirfd, const char *name, int flags, struct adouble *adp) if (dirfd != -1) { if (fchdir(cwdfd) != 0) { - LOG(log_error, logtype_afpd, "ad_openat: cant chdir back, exiting"); + LOG(log_error, logtype_ad, "ad_openat: cant chdir back, exiting"); exit(EXITERR_SYS); } } diff --git a/libatalk/adouble/ad_write.c b/libatalk/adouble/ad_write.c index bfed9b40..6e8a0190 100644 --- a/libatalk/adouble/ad_write.c +++ b/libatalk/adouble/ad_write.c @@ -60,7 +60,7 @@ ssize_t ad_write(struct adouble *ad, uint32_t eid, off_t off, int end, const cha return -1; } - LOG(log_debug, logtype_default, "ad_write: off: %ju, size: %zu, eabuflen: %zu", + LOG(log_debug, logtype_ad, "ad_write: off: %ju, size: %zu, eabuflen: %zu", (uintmax_t)off, buflen, ad->ad_rlen); if ( eid == ADEID_DFORK ) { @@ -174,7 +174,7 @@ EC_CLEANUP: if (ret == 0) ad->ad_rlen = size; else - LOG(log_error, logtype_default, "ad_rtruncate(\"%s\"): %s", + LOG(log_error, logtype_ad, "ad_rtruncate(\"%s\"): %s", fullpathname(ad->ad_name), strerror(errno)); EC_EXIT; } @@ -182,7 +182,7 @@ EC_CLEANUP: int ad_dtruncate(struct adouble *ad, const off_t size) { if (sys_ftruncate(ad_data_fileno(ad), size) < 0) { - LOG(log_error, logtype_default, "sys_ftruncate(fd: %d): %s", + LOG(log_error, logtype_ad, "sys_ftruncate(fd: %d): %s", ad_data_fileno(ad), strerror(errno)); return -1; } diff --git a/libatalk/util/logger.c b/libatalk/util/logger.c index 7bec1b8b..55630d1b 100644 --- a/libatalk/util/logger.c +++ b/libatalk/util/logger.c @@ -61,6 +61,7 @@ Netatalk 2001 (c) "DSI", \ "UAMS", \ "FCE", \ + "ad", \ "end_of_list_marker"} /* ========================================================================= @@ -85,7 +86,8 @@ UAM_MODULE_EXPORT logtype_conf_t type_configs[logtype_end_of_list_marker] = { DEFAULT_LOG_CONFIG, /* logtype_afpd */ DEFAULT_LOG_CONFIG, /* logtype_dsi */ DEFAULT_LOG_CONFIG, /* logtype_uams */ - DEFAULT_LOG_CONFIG /* logtype_fce */ + DEFAULT_LOG_CONFIG, /* logtype_fce */ + DEFAULT_LOG_CONFIG /* logtype_ad */ }; static void syslog_setup(int loglevel, enum logtypes logtype, int display_options, int facility); diff --git a/man/man5/afp.conf.5.tmpl b/man/man5/afp.conf.5.tmpl index e12561a2..3850cd8c 100644 --- a/man/man5/afp.conf.5.tmpl +++ b/man/man5/afp.conf.5.tmpl @@ -625,7 +625,7 @@ should be logged\&. By default afpd logs to syslog with a default logging setup equivalent to \fBdefault:note\fR .sp -logtypes: default, afpdaemon, logger, uamsdaemon +logtypes: default, afpdaemon, logger, uamsdaemon, dsi, fce, ad .sp loglevels: severe, error, warn, note, info, debug, debug6, debug7, debug8, debug9, maxdebug .if n \{\