X-Git-Url: https://arthur.barton.de/gitweb/?p=netatalk.git;a=blobdiff_plain;f=etc%2Fafpd%2Fafp_dsi.c;h=eb4b19f35d5153302e189b8911bb6d853149ed7d;hp=a841860d128616f6c9963fd99ece47415e43a34d;hb=980548c882a297d26e67397d0f72e0b991f36bf2;hpb=ac45f66c0cf86ecb2fb057c79d1f1a5afe3a729d diff --git a/etc/afpd/afp_dsi.c b/etc/afpd/afp_dsi.c index a841860d..eb4b19f3 100644 --- a/etc/afpd/afp_dsi.c +++ b/etc/afpd/afp_dsi.c @@ -39,6 +39,7 @@ #include #include #include +#include #include "switch.h" #include "auth.h" @@ -140,25 +141,6 @@ static void afp_dsi_die(int sig) } } -/* SIGQUIT handler */ -static void ipc_reconnect_handler(int sig _U_) -{ - DSI *dsi = (DSI *)AFPobj->dsi; - - if (reconnect_ipc(AFPobj) != 0) { - LOG(log_error, logtype_afpd, "ipc_reconnect_handler: failed IPC reconnect"); - afp_dsi_close(AFPobj); - exit(EXITERR_SYS); - } - - if (ipc_child_write(AFPobj->ipc_fd, IPC_GETSESSION, AFPobj->sinfo.clientid_len, AFPobj->sinfo.clientid) != 0) { - LOG(log_error, logtype_afpd, "ipc_reconnect_handler: failed IPC ID resend"); - afp_dsi_close(AFPobj); - exit(EXITERR_SYS); - } - LOG(log_note, logtype_afpd, "ipc_reconnect_handler: IPC reconnect done"); -} - /* SIGURG handler (primary reconnect) */ static void afp_dsi_transfer_session(int sig _U_) { @@ -340,9 +322,10 @@ static void alarm_handler(int sig _U_) return; } - if ((err = pollvoltime(AFPobj)) == 0) + if ((err = pollvoltime(AFPobj)) == 0) { LOG(log_debug, logtype_afpd, "afp_alarm: sending DSI tickle"); err = dsi_tickle(AFPobj->dsi); + } if (err <= 0) { if (geteuid() == 0) { LOG(log_note, logtype_afpd, "afp_alarm: unauthenticated user, connection problem"); @@ -409,7 +392,7 @@ void afp_over_dsi_sighandlers(AFPObj *obj) } /* install SIGQUIT */ - action.sa_handler = ipc_reconnect_handler; + action.sa_handler = afp_dsi_die; if ( sigaction(SIGQUIT, &action, NULL ) < 0 ) { LOG(log_error, logtype_afpd, "afp_over_dsi: sigaction: %s", strerror(errno) ); afp_dsi_die(EXITERR_SYS); @@ -492,6 +475,12 @@ void afp_over_dsi(AFPObj *obj) int flag = 1; setsockopt(dsi->socket, SOL_TCP, TCP_NODELAY, &flag, sizeof(flag)); + /* Initialize Spotlight */ + if ((obj->options.flags & OPTION_SPOTLIGHT) && (obj->options.slmod_path)) + sl_mod_load(obj->options.slmod_path); + + ipc_child_state(obj, DSI_RUNNING); + /* get stuck here until the end */ while (1) { if (sigsetjmp(recon_jmp, 1) != 0) @@ -516,15 +505,6 @@ void afp_over_dsi(AFPObj *obj) exit(0); } -#if 0 - /* got ECONNRESET in read from client => exit*/ - if (dsi->flags & DSI_GOT_ECONNRESET) { - LOG(log_note, logtype_afpd, "afp_over_dsi: client connection reset"); - afp_dsi_close(obj); - exit(0); - } -#endif - if (dsi->flags & DSI_RECONINPROG) { LOG(log_note, logtype_afpd, "afp_over_dsi: failed reconnect"); afp_dsi_close(obj); @@ -535,8 +515,11 @@ void afp_over_dsi(AFPObj *obj) if (dsi_disconnect(dsi) != 0) afp_dsi_die(EXITERR_CLNT); + ipc_child_state(obj, DSI_DISCONNECTED); + while (dsi->flags & DSI_DISCONNECTED) pause(); /* gets interrupted by SIGALARM or SIGURG tickle */ + ipc_child_state(obj, DSI_RUNNING); continue; /* continue receiving until disconnect timer expires * or a primary reconnect succeeds */ } @@ -545,11 +528,12 @@ void afp_over_dsi(AFPObj *obj) LOG(log_debug, logtype_afpd, "afp_over_dsi: got data, ending normal sleep"); dsi->flags &= ~DSI_SLEEPING; dsi->tickle = 0; + ipc_child_state(obj, DSI_RUNNING); } if (reload_request) { reload_request = 0; - load_volumes(AFPobj, closevol); + load_volumes(AFPobj, lv_none); } /* The first SIGINT enables debugging, the next restores the config */ @@ -625,10 +609,12 @@ void afp_over_dsi(AFPObj *obj) LOG(log_debug, logtype_afpd, "<== Start AFP command: %s", AfpNum2name(function)); + AFP_AFPFUNC_START(function, (char *)AfpNum2name(function)); err = (*afp_switch[function])(obj, - (char *)&dsi->commands, dsi->cmdlen, + (char *)dsi->commands, dsi->cmdlen, (char *)&dsi->data, &dsi->datalen); + AFP_AFPFUNC_DONE(function, (char *)AfpNum2name(function)); LOG(log_debug, logtype_afpd, "==> Finished AFP command: %s -> %s", AfpNum2name(function), AfpErr2name(err)); @@ -666,10 +652,14 @@ void afp_over_dsi(AFPObj *obj) LOG(log_debug, logtype_afpd, "<== Start AFP command: %s", AfpNum2name(function)); + AFP_AFPFUNC_START(function, (char *)AfpNum2name(function)); + err = (*afp_switch[function])(obj, - (char *)&dsi->commands, dsi->cmdlen, + (char *)dsi->commands, dsi->cmdlen, (char *)&dsi->data, &dsi->datalen); + AFP_AFPFUNC_DONE(function, (char *)AfpNum2name(function)); + LOG(log_debug, logtype_afpd, "==> Finished AFP command: %s -> %s", AfpNum2name(function), AfpErr2name(err));