]> arthur.barton.de Git - homebrew-alex.git/commitdiff
identd: Fix "brew audit" problems
authorAlexander Barton <alex@barton.de>
Fri, 15 Jan 2016 09:54:40 +0000 (10:54 +0100)
committerAlexander Barton <alex@barton.de>
Fri, 15 Jan 2016 09:54:40 +0000 (10:54 +0100)
* `homepage` (line 6) should be put before `url` (line 4)
* A `test do` test block should be added
* Stable: Redundant :using value in URL
* Formula should have a desc (Description).
* use "xcodebuild *args" instead of "system 'xcodebuild', *args"
* `require "formula"` is now unnecessary
* Use `system "xcodebuild", "-target", "identd", "-configuration", "Release"`
  instead of `system "xcodebuild -target identd -configuration Release"`

Signed-off-by: Alexander Barton <alex@barton.de>
Formula/identd.rb

index f9c8c94b561a5c33858092d08cd2e275d2d1b8d0..73c211709fb419d767afe57c07b47bf94f9288cc 100644 (file)
@@ -1,9 +1,8 @@
-require "formula"
-
 class Identd < Formula
-  url "http://rc.shaunrowland.com/git/identd.git", :using => :git
-  version "0.20120228"
+  desc "Simple IDENT daemon"
   homepage "http://www.shaunrowland.com/fsync/2011/05/15/identd-for-mac-os-x/"
+  url "http://rc.shaunrowland.com/git/identd.git"
+  version "0.20120228"
 
   def patches
     # manual page: remove "manual uninstall" description
@@ -15,7 +14,7 @@ class Identd < Formula
       /CODE_SIGN_IDENTITY = \".*\"/, 'CODE_SIGN_IDENTITY=""'
     inreplace "identd/identd.8",
       %r{/usr/local}, "#{HOMEBREW_PREFIX}"
-    system "xcodebuild -target identd -configuration Release"
+    xcodebuild "SYMROOT=build", "-target", "identd", "-configuration", "Release"
     sbin.install("build/Release/identd")
     man8.install("identd/identd.8")
   end