Redirect stderr of scp(1) to stdout to not indicate errors

[backup-script.git] / bin / backup-script

diff --git a/bin/backup-script b/bin/backup-script
index 89b066db8bddddcabff66b15c30df1ebfd161e62..3d3db8512592bf45fd1217afd98b869c67717ead 100755 (executable)
--- a/bin/backup-script
+++ b/bin/backup-script
@@ -646,7 +646,11 @@ for f in "${sys[@]}"; do
                        && cmd="$cmd ${user}@${system}:$source_root $sys_target/" \
                        || cmd="$cmd $source_root $sys_target/"
        elif [[ "$backup_type" == "scp" ]]; then
-               cmd="scp"
+               # scp writes some warning messages to stderr (like "Connection
+               # to ... closed by remote host."), even when there is no error
+               # and the exit code is 0 ("no error"); therefore we redirect
+               # stderr to stdout to not confuse "mail wrapper scripts" etc.
+               cmd="scp 2>&1"
                [ "$VERBOSE" -eq 0 ] && cmd="$cmd -q"
                for file in $files; do
                        cmd="$cmd ${user}@${system}:$file $sys_target/"