From 79574a461a0c3693bb9f250fd85062d0459b9db6 Mon Sep 17 00:00:00 2001 From: Alexander Barton Date: Mon, 14 Nov 2016 18:24:55 +0100 Subject: [PATCH] Correctly quote variables in Makefiles Required for user/group/path names containing spaces. For example on Cygwin! --- bup/save-user/Makefile | 8 ++++---- lib/ax/Makefile | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/bup/save-user/Makefile b/bup/save-user/Makefile index 036fece..6da3abb 100644 --- a/bup/save-user/Makefile +++ b/bup/save-user/Makefile @@ -13,7 +13,7 @@ ALL = bup-save-user include ../../Makefile.ax install-local: bup-save-user - install -d -o $(USER) -g $(GROUP) -m 755 \ - $(DESTDIR)$(PREFIX)/bin - install -p -o $(USER) -g $(GROUP) -m 755 bup-save-user \ - $(DESTDIR)$(PREFIX)/bin/bup-save-user + install -d -o "$(USER)" -g "$(GROUP)" -m 755 \ + "$(DESTDIR)$(PREFIX)/bin" + install -p -o "$(USER)" -g "$(GROUP)" -m 755 bup-save-user \ + "$(DESTDIR)$(PREFIX)/bin/bup-save-user" diff --git a/lib/ax/Makefile b/lib/ax/Makefile index a5e677f..c7e8035 100644 --- a/lib/ax/Makefile +++ b/lib/ax/Makefile @@ -13,9 +13,9 @@ ALL = README ax-common.sh include ../../Makefile.ax install-local: ax-common.sh - install -d -o $(USER) -g $(GROUP) -m 755 \ - $(DESTDIR)$(PREFIX)/lib/ax - install -p -o $(USER) -g $(GROUP) -m 644 README \ - $(DESTDIR)$(PREFIX)/lib/ax/README - install -p -o $(USER) -g $(GROUP) -m 644 ax-common.sh \ - $(DESTDIR)$(PREFIX)/lib/ax/ax-common.sh + install -d -o "$(USER)" -g "$(GROUP)" -m 755 \ + "$(DESTDIR)$(PREFIX)/lib/ax" + install -p -o "$(USER)" -g "$(GROUP)" -m 644 README \ + "$(DESTDIR)$(PREFIX)/lib/ax/README" + install -p -o "$(USER)" -g "$(GROUP)" -m 644 ax-common.sh \ + "$(DESTDIR)$(PREFIX)/lib/ax/ax-common.sh" -- 2.39.2