Correctly quote variables in Makefiles

Required for user/group/path names containing spaces.
For example on Cygwin!

diff --git a/bup/save-user/Makefile b/bup/save-user/Makefile
index 036fece5ccaf30c4100a703b3d67e817d632e108..6da3abb3075945a73f667e43ef4b1060cc6b7d9e 100644 (file)
--- a/bup/save-user/Makefile
+++ b/bup/save-user/Makefile
@@ -13,7 +13,7 @@ ALL = bup-save-user
 include ../../Makefile.ax
 
 install-local: bup-save-user
-       install -d -o $(USER) -g $(GROUP) -m 755 \
-        $(DESTDIR)$(PREFIX)/bin
-       install -p -o $(USER) -g $(GROUP) -m 755 bup-save-user \
-        $(DESTDIR)$(PREFIX)/bin/bup-save-user
+       install -d -o "$(USER)" -g "$(GROUP)" -m 755 \
+        "$(DESTDIR)$(PREFIX)/bin"
+       install -p -o "$(USER)" -g "$(GROUP)" -m 755 bup-save-user \
+        "$(DESTDIR)$(PREFIX)/bin/bup-save-user"

diff --git a/lib/ax/Makefile b/lib/ax/Makefile
index a5e677fd4dc0248c25afd6725d26c27b502f69fb..c7e80354e7e3c43b24be790fd04aac2724d9a808 100644 (file)
--- a/lib/ax/Makefile
+++ b/lib/ax/Makefile
@@ -13,9 +13,9 @@ ALL = README ax-common.sh
 include ../../Makefile.ax
 
 install-local: ax-common.sh
-       install -d -o $(USER) -g $(GROUP) -m 755 \
-        $(DESTDIR)$(PREFIX)/lib/ax
-       install -p -o $(USER) -g $(GROUP) -m 644 README \
-        $(DESTDIR)$(PREFIX)/lib/ax/README
-       install -p -o $(USER) -g $(GROUP) -m 644 ax-common.sh \
-        $(DESTDIR)$(PREFIX)/lib/ax/ax-common.sh
+       install -d -o "$(USER)" -g "$(GROUP)" -m 755 \
+        "$(DESTDIR)$(PREFIX)/lib/ax"
+       install -p -o "$(USER)" -g "$(GROUP)" -m 644 README \
+        "$(DESTDIR)$(PREFIX)/lib/ax/README"
+       install -p -o "$(USER)" -g "$(GROUP)" -m 644 ax-common.sh \
+        "$(DESTDIR)$(PREFIX)/lib/ax/ax-common.sh"