From: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Date: Fri, 1 Feb 2013 18:23:28 +0000 (+0100)
Subject: afpd/fork: avoid use after free on of_closefork error
X-Git-Url: https://arthur.barton.de/gitweb/?a=commitdiff_plain;h=9565c94223fad1292bba40215377b10d78ca4c0b;p=netatalk.git

afpd/fork: avoid use after free on of_closefork error

Reported by Coverity as CID #201311.
---

diff --git a/etc/afpd/fork.c b/etc/afpd/fork.c
index 2d59b5da..7b24b7f2 100644
--- a/etc/afpd/fork.c
+++ b/etc/afpd/fork.c
@@ -1037,7 +1037,7 @@ int afp_closefork(AFPObj *obj, char *ibuf, size_t ibuflen _U_, char *rbuf _U_, s
         ofork->of_refnum, (ofork->of_flags & AFPFORK_DATA) ? "data" : "rsrc");
 
     if (of_closefork(obj, ofork) < 0 ) {
-        LOG(log_error, logtype_afpd, "afp_closefork(%s): of_closefork: %s", of_name(ofork), strerror(errno) );
+        LOG(log_error, logtype_afpd, "afp_closefork: of_closefork: %s", strerror(errno) );
         return( AFPERR_PARAM );
     }