]> arthur.barton.de Git - ngircd-alex.git/commit
Don't read SSL client data before DNS resolver is finished
authorAlexander Barton <alex@barton.de>
Sat, 9 Mar 2013 16:44:34 +0000 (17:44 +0100)
committerAlexander Barton <alex@barton.de>
Sat, 9 Mar 2013 16:44:34 +0000 (17:44 +0100)
commitb4393277ea1cc67bc8433fcbeded3fc2186f5c54
tree22ddd59af39c56fed5cecf28cc7b01a91d39aeba
parentb33da9b8f3e46f3174093c01aa9e75b65964ecf2
Don't read SSL client data before DNS resolver is finished

Fix the cb_clientserver_ssl() callback function to not read in and store SSL
encrypted client data before the asynchronous DNS resolver sub-process has
finished: This could have resulted in discarding the resolved client hostname
and IDENT reply afterwards, because in some situations (timing dependent) the
NICK and USER commands could have already been read in from the client,
stored in the buffer, and been processed.

Thanks to Julian Brost for reporting the issue and testing, and to Federico
G. Schwindt <fgsch@lodoss.net> for helping to debug it!
src/ngircd/conn.c