X-Git-Url: https://arthur.barton.de/gitweb/?a=blobdiff_plain;f=python.d%2Ffreeradius.chart.py;h=f3de157350f6f09e191d3439a71ce40d86f47c7d;hb=7e5e0bcf61f2a482530695816202d83e4e508ed5;hp=b047f37697a53da3c040cf8dc4b384a2a68c02cb;hpb=5e7fb194e644ea46c6a4af6533de175118fcc2dc;p=netdata.git

diff --git a/python.d/freeradius.chart.py b/python.d/freeradius.chart.py
index b047f376..f3de1573 100644
--- a/python.d/freeradius.chart.py
+++ b/python.d/freeradius.chart.py
@@ -3,7 +3,6 @@
 # Author: l2isbad
 
 from base import SimpleService
-from os.path import isfile
 from re import findall
 from subprocess import Popen, PIPE
 
@@ -11,7 +10,6 @@ from subprocess import Popen, PIPE
 priority = 60000
 retries = 60
 update_every = 15
-directories = ['/bin/', '/usr/bin/', '/sbin', '/usr/sbin/']
 
 # charts order (can be overridden if you want less charts, or different order)
 ORDER = ['authentication', 'accounting', 'proxy-auth', 'proxy-acct']
@@ -62,23 +60,23 @@ class Service(SimpleService):
         self.acct = self.configuration.get('acct', False)
         self.proxy_auth = self.configuration.get('proxy_auth', False)
         self.proxy_acct = self.configuration.get('proxy_acct', False)
-        self.echo = [''.join([directory, 'echo']) for directory in directories if isfile(''.join([directory, 'echo']))][0]
-        self.radclient = [''.join([directory, 'radclient']) for directory in directories if isfile(''.join([directory, 'radclient']))][0]
+        self.echo = self.find_binary('echo')
+        self.radclient = self.find_binary('radclient')
         self.sub_echo = [self.echo, 'Message-Authenticator = 0x00, FreeRADIUS-Statistics-Type = 15, Response-Packet-Type = Access-Accept']
         self.sub_radclient = [self.radclient, '-r', '1', '-t', '1', ':'.join([self.host, self.port]), 'status', self.secret]
     
     def check(self):
         if not all([self.echo, self.radclient]):
-            self.error('Command radclient not found')
+            self.error('Can\'t locate \'radclient\' binary or binary is not executable by netdata')
             return False
         if self._get_raw_data():
             chart_choice = [True, bool(self.acct), bool(self.proxy_auth), bool(self.proxy_acct)]
             self.order = [chart for chart, choice in zip(ORDER, chart_choice) if choice]
-            self.definitions = {k:v for k, v in CHARTS.items() if k in self.order}
+            self.definitions = dict([chart for chart in CHARTS.items() if chart[0] in self.order])
             self.info('Plugin was started succesfully')
             return True
         else:
-            self.error('Request returned no data. Is server alive? Used options: host {}, port {}, secret {}'.format(self.host, self.port, self.secret))
+            self.error('Request returned no data. Is server alive? Used options: host {0}, port {1}, secret {2}'.format(self.host, self.port, self.secret))
             return False
         
 
@@ -88,7 +86,7 @@ class Service(SimpleService):
         :return: dict
         """
         result = self._get_raw_data()
-        return {k.lower():int(v) for k, v in findall(r'((?<=-)[AP][a-zA-Z-]+) = (\d+)', result)}
+        return dict([(elem[0].lower(), int(elem[1])) for elem in findall(r'((?<=-)[AP][a-zA-Z-]+) = (\d+)', result)])
         
     def _get_raw_data(self):
         """
@@ -97,8 +95,8 @@ class Service(SimpleService):
         :return: str
         """
         try:
-            process_echo = Popen(self.sub_echo,  stdout=PIPE, shell=False)
-            process_rad = Popen(self.sub_radclient, stdin=process_echo.stdout, stdout=PIPE,  shell=False)
+            process_echo = Popen(self.sub_echo, stdout=PIPE, stderr=PIPE, shell=False)
+            process_rad = Popen(self.sub_radclient, stdin=process_echo.stdout, stdout=PIPE, stderr=PIPE, shell=False)
             process_echo.stdout.close()
             raw_result = process_rad.communicate()[0]
         except Exception: