]> arthur.barton.de Git - netdata.git/blobdiff - src/rrd.c
multi-host rrdset and rrdfamily operations
[netdata.git] / src / rrd.c
index bd15c765007b043ceae6a8f42a15ea372f79f5d5..65c5f890d01b47350cc8f7310b2993a6b0622764 100644 (file)
--- a/src/rrd.c
+++ b/src/rrd.c
@@ -14,7 +14,7 @@ int rrd_delete_unupdated_dimensions = 0;
 
 int rrd_update_every = UPDATE_EVERY;
 int rrd_default_history_entries = RRD_DEFAULT_HISTORY_ENTRIES;
-int rrd_memory_mode = RRD_MEMORY_MODE_SAVE;
+RRD_MEMORY_MODE rrd_memory_mode = RRD_MEMORY_MODE_SAVE;
 
 static int rrdset_compare(void* a, void* b);
 static int rrdset_compare_name(void* a, void* b);
@@ -91,7 +91,7 @@ void rrdhost_check_wrlock_int(RRDHOST *host, const char *file, const char *funct
 static int rrdfamily_compare(void *a, void *b) {
     if(((RRDFAMILY *)a)->hash_family < ((RRDFAMILY *)b)->hash_family) return -1;
     else if(((RRDFAMILY *)a)->hash_family > ((RRDFAMILY *)b)->hash_family) return 1;
-    else return strsame(((RRDFAMILY *)a)->family, ((RRDFAMILY *)b)->family);
+    else return strcmp(((RRDFAMILY *)a)->family, ((RRDFAMILY *)b)->family);
 }
 
 #define rrdfamily_index_add(host, rc) (RRDFAMILY *)avl_insert_lock(&((host)->rrdfamily_root_index), (avl *)(rc))
@@ -105,8 +105,8 @@ static RRDFAMILY *rrdfamily_index_find(RRDHOST *host, const char *id, uint32_t h
     return (RRDFAMILY *)avl_search_lock(&(host->rrdfamily_root_index), (avl *) &tmp);
 }
 
-RRDFAMILY *rrdfamily_create(const char *id) {
-    RRDFAMILY *rc = rrdfamily_index_find(&localhost, id, 0);
+RRDFAMILY *rrdfamily_create(RRDHOST *host, const char *id) {
+    RRDFAMILY *rc = rrdfamily_index_find(host, id, 0);
     if(!rc) {
         rc = callocz(1, sizeof(RRDFAMILY));
 
@@ -116,7 +116,7 @@ RRDFAMILY *rrdfamily_create(const char *id) {
         // initialize the variables index
         avl_init_lock(&rc->variables_root_index, rrdvar_compare);
 
-        RRDFAMILY *ret = rrdfamily_index_add(&localhost, rc);
+        RRDFAMILY *ret = rrdfamily_index_add(host, rc);
         if(ret != rc)
             fatal("RRDFAMILY: INTERNAL ERROR: Expected to INSERT RRDFAMILY '%s' into index, but inserted '%s'.", rc->family, (ret)?ret->family:"NONE");
     }
@@ -125,10 +125,10 @@ RRDFAMILY *rrdfamily_create(const char *id) {
     return rc;
 }
 
-void rrdfamily_free(RRDFAMILY *rc) {
+void rrdfamily_free(RRDHOST *host, RRDFAMILY *rc) {
     rc->use_count--;
     if(!rc->use_count) {
-        RRDFAMILY *ret = rrdfamily_index_del(&localhost, rc);
+        RRDFAMILY *ret = rrdfamily_index_del(host, rc);
         if(ret != rc)
             fatal("RRDFAMILY: INTERNAL ERROR: Expected to DELETE RRDFAMILY '%s' from index, but deleted '%s'.", rc->family, (ret)?ret->family:"NONE");
 
@@ -146,7 +146,7 @@ void rrdfamily_free(RRDFAMILY *rc) {
 static int rrdset_compare(void* a, void* b) {
     if(((RRDSET *)a)->hash < ((RRDSET *)b)->hash) return -1;
     else if(((RRDSET *)a)->hash > ((RRDSET *)b)->hash) return 1;
-    else return strsame(((RRDSET *)a)->id, ((RRDSET *)b)->id);
+    else return strcmp(((RRDSET *)a)->id, ((RRDSET *)b)->id);
 }
 
 #define rrdset_index_add(host, st) (RRDSET *)avl_insert_lock(&((host)->rrdset_root_index), (avl *)(st))
@@ -173,7 +173,7 @@ static int rrdset_compare_name(void* a, void* b) {
 
     if(A->hash_name < B->hash_name) return -1;
     else if(A->hash_name > B->hash_name) return 1;
-    else return strsame(A->name, B->name);
+    else return strcmp(A->name, B->name);
 }
 
 RRDSET *rrdset_index_add_name(RRDHOST *host, RRDSET *st) {
@@ -202,7 +202,7 @@ static RRDSET *rrdset_index_find_name(RRDHOST *host, const char *name, uint32_t
     result = avl_search_lock(&host->rrdset_root_index_name, (avl *) (&(tmp.avlname)));
     if(result) {
         RRDSET *st = rrdset_from_avlname(result);
-        if(strsame(st->magic, RRDSET_MAGIC))
+        if(strcmp(st->magic, RRDSET_MAGIC))
             error("Search for RRDSET %s returned an invalid RRDSET %s (name %s)", name, st->id, st->name);
 
         // fprintf(stderr, "FOUND: %s\n", name);
@@ -219,79 +219,70 @@ static RRDSET *rrdset_index_find_name(RRDHOST *host, const char *name, uint32_t
 static int rrddim_compare(void* a, void* b) {
     if(((RRDDIM *)a)->hash < ((RRDDIM *)b)->hash) return -1;
     else if(((RRDDIM *)a)->hash > ((RRDDIM *)b)->hash) return 1;
-    else return strsame(((RRDDIM *)a)->id, ((RRDDIM *)b)->id);
+    else return strcmp(((RRDDIM *)a)->id, ((RRDDIM *)b)->id);
 }
 
 #define rrddim_index_add(st, rd) (RRDDIM *)avl_insert_lock(&((st)->dimensions_index), (avl *)(rd))
 #define rrddim_index_del(st,rd ) (RRDDIM *)avl_remove_lock(&((st)->dimensions_index), (avl *)(rd))
 
 static RRDDIM *rrddim_index_find(RRDSET *st, const char *id, uint32_t hash) {
-    RRDDIM tmp;
-    strncpyz(tmp.id, id, RRD_ID_LENGTH_MAX);
-    tmp.hash = (hash)?hash:simple_hash(tmp.id);
-
+    RRDDIM tmp = {
+            .id = id,
+            .hash = (hash)?hash:simple_hash(id)
+    };
     return (RRDDIM *)avl_search_lock(&(st->dimensions_index), (avl *) &tmp);
 }
 
 // ----------------------------------------------------------------------------
 // chart types
 
-int rrdset_type_id(const char *name)
-{
-    if(unlikely(strsame(name, RRDSET_TYPE_AREA_NAME) == 0)) return RRDSET_TYPE_AREA;
-    else if(unlikely(strsame(name, RRDSET_TYPE_STACKED_NAME) == 0)) return RRDSET_TYPE_STACKED;
-    else if(unlikely(strsame(name, RRDSET_TYPE_LINE_NAME) == 0)) return RRDSET_TYPE_LINE;
-    return RRDSET_TYPE_LINE;
-}
+inline RRDSET_TYPE rrdset_type_id(const char *name) {
+    if(unlikely(strcmp(name, RRDSET_TYPE_AREA_NAME) == 0))
+        return RRDSET_TYPE_AREA;
 
-const char *rrdset_type_name(int chart_type)
-{
-    static char line[] = RRDSET_TYPE_LINE_NAME;
-    static char area[] = RRDSET_TYPE_AREA_NAME;
-    static char stacked[] = RRDSET_TYPE_STACKED_NAME;
+    else if(unlikely(strcmp(name, RRDSET_TYPE_STACKED_NAME) == 0))
+        return RRDSET_TYPE_STACKED;
 
+    else // if(unlikely(strcmp(name, RRDSET_TYPE_LINE_NAME) == 0))
+        return RRDSET_TYPE_LINE;
+}
+
+const char *rrdset_type_name(RRDSET_TYPE chart_type) {
     switch(chart_type) {
         case RRDSET_TYPE_LINE:
-            return line;
+        default:
+            return RRDSET_TYPE_LINE_NAME;
 
         case RRDSET_TYPE_AREA:
-            return area;
+            return RRDSET_TYPE_AREA_NAME;
 
         case RRDSET_TYPE_STACKED:
-            return stacked;
+            return RRDSET_TYPE_STACKED_NAME;
     }
-    return line;
 }
 
 // ----------------------------------------------------------------------------
 // load / save
 
-const char *rrd_memory_mode_name(int id)
-{
-    static const char ram[] = RRD_MEMORY_MODE_RAM_NAME;
-    static const char map[] = RRD_MEMORY_MODE_MAP_NAME;
-    static const char save[] = RRD_MEMORY_MODE_SAVE_NAME;
-
+inline const char *rrd_memory_mode_name(RRD_MEMORY_MODE id) {
     switch(id) {
         case RRD_MEMORY_MODE_RAM:
-            return ram;
+            return RRD_MEMORY_MODE_RAM_NAME;
 
         case RRD_MEMORY_MODE_MAP:
-            return map;
+            return RRD_MEMORY_MODE_MAP_NAME;
 
         case RRD_MEMORY_MODE_SAVE:
         default:
-            return save;
+            return RRD_MEMORY_MODE_SAVE_NAME;
     }
-
-    return save;
 }
 
 int rrd_memory_mode_id(const char *name)
 {
-    if(unlikely(!strsame(name, RRD_MEMORY_MODE_RAM_NAME)))
+    if(unlikely(!strcmp(name, RRD_MEMORY_MODE_RAM_NAME)))
         return RRD_MEMORY_MODE_RAM;
-    else if(unlikely(!strsame(name, RRD_MEMORY_MODE_MAP_NAME)))
+    else if(unlikely(!strcmp(name, RRD_MEMORY_MODE_MAP_NAME)))
         return RRD_MEMORY_MODE_MAP;
 
     return RRD_MEMORY_MODE_SAVE;
@@ -300,36 +291,40 @@ int rrd_memory_mode_id(const char *name)
 // ----------------------------------------------------------------------------
 // algorithms types
 
-int rrddim_algorithm_id(const char *name)
+RRDDIM_ALGORITHM rrddim_algorithm_id(const char *name)
 {
-    if(strsame(name, RRDDIM_INCREMENTAL_NAME) == 0)          return RRDDIM_INCREMENTAL;
-    if(strsame(name, RRDDIM_ABSOLUTE_NAME) == 0)             return RRDDIM_ABSOLUTE;
-    if(strsame(name, RRDDIM_PCENT_OVER_ROW_TOTAL_NAME) == 0)         return RRDDIM_PCENT_OVER_ROW_TOTAL;
-    if(strsame(name, RRDDIM_PCENT_OVER_DIFF_TOTAL_NAME) == 0)    return RRDDIM_PCENT_OVER_DIFF_TOTAL;
-    return RRDDIM_ABSOLUTE;
+    if(strcmp(name, RRDDIM_ALGORITHM_INCREMENTAL_NAME) == 0)
+        return RRDDIM_ALGORITHM_INCREMENTAL;
+
+    else if(strcmp(name, RRDDIM_ALGORITHM_ABSOLUTE_NAME) == 0)
+        return RRDDIM_ALGORITHM_ABSOLUTE;
+
+    else if(strcmp(name, RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL_NAME) == 0)
+        return RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL;
+
+    else if(strcmp(name, RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL_NAME) == 0)
+        return RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL;
+
+    else
+        return RRDDIM_ALGORITHM_ABSOLUTE;
 }
 
-const char *rrddim_algorithm_name(int chart_type)
+const char *rrddim_algorithm_name(RRDDIM_ALGORITHM algorithm)
 {
-    static char absolute[] = RRDDIM_ABSOLUTE_NAME;
-    static char incremental[] = RRDDIM_INCREMENTAL_NAME;
-    static char percentage_of_absolute_row[] = RRDDIM_PCENT_OVER_ROW_TOTAL_NAME;
-    static char percentage_of_incremental_row[] = RRDDIM_PCENT_OVER_DIFF_TOTAL_NAME;
-
-    switch(chart_type) {
-        case RRDDIM_ABSOLUTE:
-            return absolute;
+    switch(algorithm) {
+        case RRDDIM_ALGORITHM_ABSOLUTE:
+        default:
+            return RRDDIM_ALGORITHM_ABSOLUTE_NAME;
 
-        case RRDDIM_INCREMENTAL:
-            return incremental;
+        case RRDDIM_ALGORITHM_INCREMENTAL:
+            return RRDDIM_ALGORITHM_INCREMENTAL_NAME;
 
-        case RRDDIM_PCENT_OVER_ROW_TOTAL:
-            return percentage_of_absolute_row;
+        case RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL:
+            return RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL_NAME;
 
-        case RRDDIM_PCENT_OVER_DIFF_TOTAL:
-            return percentage_of_incremental_row;
+        case RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL:
+            return RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL_NAME;
     }
-    return absolute;
 }
 
 // ----------------------------------------------------------------------------
@@ -353,7 +348,7 @@ char *rrdset_strncpyz_name(char *to, const char *from, size_t length)
 
 void rrdset_set_name(RRDSET *st, const char *name)
 {
-    if(unlikely(st->name && !strsame(st->name, name)))
+    if(unlikely(st->name && !strcmp(st->name, name)))
         return;
 
     debug(D_RRD_CALLS, "rrdset_set_name() old: %s, new: %s", st->name, name);
@@ -365,7 +360,7 @@ void rrdset_set_name(RRDSET *st, const char *name)
     rrdset_strncpyz_name(b, n, CONFIG_MAX_VALUE);
 
     if(st->name) {
-        rrdset_index_del_name(&localhost, st);
+        rrdset_index_del_name(st->rrdhost, st);
         st->name = config_set_default(st->id, "name", b);
         st->hash_name = simple_hash(st->name);
         rrdsetvar_rename_all(st);
@@ -381,7 +376,7 @@ void rrdset_set_name(RRDSET *st, const char *name)
         rrddimvar_rename_all(rd);
     pthread_rwlock_unlock(&st->rwlock);
 
-    if(unlikely(rrdset_index_add_name(&localhost, st) != st))
+    if(unlikely(rrdset_index_add_name(st->rrdhost, st) != st))
         error("RRDSET: INTERNAL ERROR: attempted to index duplicate chart name '%s'", st->name);
 }
 
@@ -392,19 +387,11 @@ char *rrdset_cache_dir(const char *id)
 {
     char *ret = NULL;
 
-    static char *cache_dir = NULL;
-    if(!cache_dir) {
-        cache_dir = config_get("global", "cache directory", CACHE_DIR);
-        int r = mkdir(cache_dir, 0755);
-        if(r != 0 && errno != EEXIST)
-            error("Cannot create directory '%s'", cache_dir);
-    }
-
     char b[FILENAME_MAX + 1];
     char n[FILENAME_MAX + 1];
     rrdset_strncpyz_name(b, id, FILENAME_MAX);
 
-    snprintfz(n, FILENAME_MAX, "%s/%s", cache_dir, b);
+    snprintfz(n, FILENAME_MAX, "%s/%s", netdata_configured_cache_dir, b);
     ret = config_get(id, "cache directory", n);
 
     if(rrd_memory_mode == RRD_MEMORY_MODE_MAP || rrd_memory_mode == RRD_MEMORY_MODE_SAVE) {
@@ -466,8 +453,9 @@ static inline void timeval_align(struct timeval *tv, int update_every) {
     tv->tv_usec = 500000;
 }
 
-RRDSET *rrdset_create(const char *type, const char *id, const char *name, const char *family, const char *context, const char *title, const char *units, long priority, int update_every, int chart_type)
-{
+RRDSET *rrdset_create(const char *type, const char *id, const char *name, const char *family, const char *context, const char *title, const char *units, long priority, int update_every, int chart_type) {
+    RRDHOST *host = &localhost;
+
     if(!type || !type[0]) {
         fatal("Cannot create rrd stats without a type.");
         return NULL;
@@ -483,9 +471,9 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
 
     snprintfz(fullid, RRD_ID_LENGTH_MAX, "%s.%s", type, id);
 
-    RRDSET *st = rrdset_find(fullid);
+    RRDSET *st = rrdset_find(host, fullid);
     if(st) {
-        error("Cannot create rrd stats for '%s', it already exists.", fullid);
+        debug(D_RRD_CALLS, "RRDSET '%s', already exists.", fullid);
         return st;
     }
 
@@ -504,12 +492,12 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
     snprintfz(fullfilename, FILENAME_MAX, "%s/main.db", cache_dir);
     if(rrd_memory_mode != RRD_MEMORY_MODE_RAM) st = (RRDSET *)mymmap(fullfilename, size, ((rrd_memory_mode == RRD_MEMORY_MODE_MAP)?MAP_SHARED:MAP_PRIVATE), 0);
     if(st) {
-        if(strsame(st->magic, RRDSET_MAGIC) != 0) {
+        if(strcmp(st->magic, RRDSET_MAGIC) != 0) {
             errno = 0;
             info("Initializing file %s.", fullfilename);
             memset(st, 0, size);
         }
-        else if(strsame(st->id, fullid) != 0) {
+        else if(strcmp(st->id, fullid) != 0) {
             errno = 0;
             error("File %s contents are not for chart %s. Clearing it.", fullfilename, fullid);
             // munmap(st, size);
@@ -560,6 +548,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
         st->mapped = RRD_MEMORY_MODE_RAM;
     }
 
+    st->rrdhost = host;
     st->memsize = size;
     st->entries = entries;
     st->update_every = update_every;
@@ -588,7 +577,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
     st->isdetail = 0;
     st->debug = 0;
 
-    // if(!strsame(st->id, "disk_util.dm-0")) {
+    // if(!strcmp(st->id, "disk_util.dm-0")) {
     //     st->debug = 1;
     //     error("enabled debugging for '%s'", st->id);
     // }
@@ -608,7 +597,7 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
     avl_init_lock(&st->variables_root_index, rrdvar_compare);
 
     pthread_rwlock_init(&st->rwlock, NULL);
-    rrdhost_rwlock(&localhost);
+    rrdhost_rwlock(host);
 
     if(name && *name) rrdset_set_name(st, name);
     else rrdset_set_name(st, id);
@@ -621,11 +610,10 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
         st->title = config_get(st->id, "title", varvalue2);
     }
 
-    st->rrdfamily = rrdfamily_create(st->family);
-    st->rrdhost = &localhost;
+    st->rrdfamily = rrdfamily_create(host, st->family);
 
-    st->next = localhost.rrdset_root;
-    localhost.rrdset_root = st;
+    st->next = host->rrdset_root;
+    host->rrdset_root = st;
 
     if(health_enabled) {
         rrdsetvar_create(st, "last_collected_t", RRDVAR_TYPE_TIME_T, &st->last_collected_time.tv_sec, 0);
@@ -635,22 +623,22 @@ RRDSET *rrdset_create(const char *type, const char *id, const char *name, const
         rrdsetvar_create(st, "update_every", RRDVAR_TYPE_INT, &st->update_every, 0);
     }
 
-    if(unlikely(rrdset_index_add(&localhost, st) != st))
+    if(unlikely(rrdset_index_add(host, st) != st))
         error("RRDSET: INTERNAL ERROR: attempt to index duplicate chart '%s'", st->id);
 
     rrdsetcalc_link_matching(st);
     rrdcalctemplate_link_matching(st);
 
-    rrdhost_unlock(&localhost);
+    rrdhost_unlock(host);
 
     return(st);
 }
 
-RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier, long divisor, int algorithm)
+RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, collected_number multiplier, collected_number divisor, RRDDIM_ALGORITHM algorithm)
 {
     RRDDIM *rd = rrddim_find(st, id);
     if(rd) {
-        error("Cannot create rrd dimension '%s/%s', it already exists.", st->id, name);
+        debug(D_RRD_CALLS, "Cannot create rrd dimension '%s/%s', it already exists.", st->id, name?name:"<NONAME>");
         return rd;
     }
 
@@ -665,81 +653,80 @@ RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier
     rrdset_strncpyz_name(filename, id, FILENAME_MAX);
     snprintfz(fullfilename, FILENAME_MAX, "%s/%s.db", st->cache_dir, filename);
 
-    if(rrd_memory_mode != RRD_MEMORY_MODE_RAM)
-        rd = (RRDDIM *)mymmap(fullfilename, size, ((rrd_memory_mode == RRD_MEMORY_MODE_MAP)?MAP_SHARED:MAP_PRIVATE), 1);
-
-    if(rd) {
-        struct timeval now;
-        now_realtime_timeval(&now);
+    if(rrd_memory_mode != RRD_MEMORY_MODE_RAM) {
+        rd = (RRDDIM *) mymmap(fullfilename, size, ((rrd_memory_mode == RRD_MEMORY_MODE_MAP) ? MAP_SHARED : MAP_PRIVATE), 1);
+        if(rd) {
+            // we have a file mapped for rd
+
+            rd->id = NULL;
+            rd->name = NULL;
+            rd->cache_filename = NULL;
+            rd->memory_mode = rrd_memory_mode;
+            rd->flags = 0x00000000;
+            rd->variables = NULL;
+            rd->next = NULL;
+            rd->rrdset = NULL;
+            memset(&rd->avl, 0, sizeof(avl));
+
+            struct timeval now;
+            now_realtime_timeval(&now);
+
+            if(strcmp(rd->magic, RRDDIMENSION_MAGIC) != 0) {
+                errno = 0;
+                info("Initializing file %s.", fullfilename);
+                memset(rd, 0, size);
+            }
+            else if(rd->memsize != size) {
+                errno = 0;
+                error("File %s does not have the desired size. Clearing it.", fullfilename);
+                memset(rd, 0, size);
+            }
+            else if(rd->multiplier != multiplier) {
+                errno = 0;
+                error("File %s does not have the same multiplier. Clearing it.", fullfilename);
+                memset(rd, 0, size);
+            }
+            else if(rd->divisor != divisor) {
+                errno = 0;
+                error("File %s does not have the same divisor. Clearing it.", fullfilename);
+                memset(rd, 0, size);
+            }
+            else if(rd->update_every != st->update_every) {
+                errno = 0;
+                error("File %s does not have the same refresh frequency. Clearing it.", fullfilename);
+                memset(rd, 0, size);
+            }
+            else if(dt_usec(&now, &rd->last_collected_time) > (rd->entries * rd->update_every * USEC_PER_SEC)) {
+                errno = 0;
+                error("File %s is too old. Clearing it.", fullfilename);
+                memset(rd, 0, size);
+            }
 
-        if(strsame(rd->magic, RRDDIMENSION_MAGIC) != 0) {
-            errno = 0;
-            info("Initializing file %s.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(rd->memsize != size) {
-            errno = 0;
-            error("File %s does not have the desired size. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(rd->multiplier != multiplier) {
-            errno = 0;
-            error("File %s does not have the same multiplier. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(rd->divisor != divisor) {
-            errno = 0;
-            error("File %s does not have the same divisor. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(rd->algorithm != algorithm) {
-            errno = 0;
-            error("File %s does not have the same algorithm. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(rd->update_every != st->update_every) {
-            errno = 0;
-            error("File %s does not have the same refresh frequency. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(dt_usec(&now, &rd->last_collected_time) > (rd->entries * rd->update_every * USEC_PER_SEC)) {
-            errno = 0;
-            error("File %s is too old. Clearing it.", fullfilename);
-            memset(rd, 0, size);
-        }
-        else if(strsame(rd->id, id) != 0) {
-            errno = 0;
-            error("File %s contents are not for dimension %s. Clearing it.", fullfilename, id);
-            // munmap(rd, size);
-            // rd = NULL;
-            memset(rd, 0, size);
+            if(rd->algorithm && rd->algorithm != algorithm)
+                error("File %s does not have the expected algorithm (expected %u '%s', found %u '%s'). Previous values may be wrong."
+                      , fullfilename, algorithm, rrddim_algorithm_name(algorithm), rd->algorithm,
+                        rrddim_algorithm_name(rd->algorithm));
         }
     }
 
-    if(rd) {
-        // we have a file mapped for rd
-        rd->mapped = rrd_memory_mode;
-        rd->flags = 0x00000000;
-        rd->variables = NULL;
-        rd->next = NULL;
-        rd->name = NULL;
-        memset(&rd->avl, 0, sizeof(avl));
-    }
-    else {
+    if(unlikely(!rd)) {
         // if we didn't manage to get a mmap'd dimension, just create one
-
         rd = callocz(1, size);
-        rd->mapped = RRD_MEMORY_MODE_RAM;
+        rd->memory_mode = RRD_MEMORY_MODE_RAM;
     }
+
     rd->memsize = size;
 
     strcpy(rd->magic, RRDDIMENSION_MAGIC);
-    strcpy(rd->cache_filename, fullfilename);
-    strncpyz(rd->id, id, RRD_ID_LENGTH_MAX);
+
+    rd->id = strdupz(id);
     rd->hash = simple_hash(rd->id);
 
+    rd->cache_filename = strdupz(fullfilename);
+
     snprintfz(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
     rd->name = config_get(st->id, varname, (name && *name)?name:rd->id);
+    rd->hash_name = simple_hash(rd->name);
 
     snprintfz(varname, CONFIG_MAX_NAME, "dim %s algorithm", rd->id);
     rd->algorithm = rrddim_algorithm_id(config_get(st->id, varname, rrddim_algorithm_name(algorithm)));
@@ -756,7 +743,7 @@ RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier
 
     // prevent incremental calculation spikes
     rd->counter = 0;
-    rd->updated = 0;
+    rrddim_flag_clear(rd, RRDDIM_FLAG_UPDATED);
     rd->calculated_value = 0;
     rd->last_calculated_value = 0;
     rd->collected_value = 0;
@@ -795,7 +782,7 @@ RRDDIM *rrddim_add(RRDSET *st, const char *id, const char *name, long multiplier
 
 void rrddim_set_name(RRDSET *st, RRDDIM *rd, const char *name)
 {
-    if(unlikely(rd->name && !strsame(rd->name, name)))
+    if(unlikely(!strcmp(rd->name, name)))
         return;
 
     debug(D_RRD_CALLS, "rrddim_set_name() from %s.%s to %s.%s", st->name, rd->name, st->name, name);
@@ -803,6 +790,7 @@ void rrddim_set_name(RRDSET *st, RRDDIM *rd, const char *name)
     char varname[CONFIG_MAX_NAME + 1];
     snprintfz(varname, CONFIG_MAX_NAME, "dim %s name", rd->id);
     rd->name = config_set_default(st->id, varname, name);
+    rd->hash_name = simple_hash(rd->name);
 
     rrddimvar_rename_all(rd);
 }
@@ -831,20 +819,26 @@ void rrddim_free(RRDSET *st, RRDDIM *rd)
         error("RRDDIM: INTERNAL ERROR: attempt to remove from index dimension '%s' on chart '%s', removed a different dimension.", rd->id, st->id);
 
     // free(rd->annotations);
-    if(rd->mapped == RRD_MEMORY_MODE_SAVE) {
-        debug(D_RRD_CALLS, "Saving dimension '%s' to '%s'.", rd->name, rd->cache_filename);
-        savememory(rd->cache_filename, rd, rd->memsize);
 
-        debug(D_RRD_CALLS, "Unmapping dimension '%s'.", rd->name);
-        munmap(rd, rd->memsize);
-    }
-    else if(rd->mapped == RRD_MEMORY_MODE_MAP) {
-        debug(D_RRD_CALLS, "Unmapping dimension '%s'.", rd->name);
-        munmap(rd, rd->memsize);
-    }
-    else {
-        debug(D_RRD_CALLS, "Removing dimension '%s'.", rd->name);
-        freez(rd);
+    switch(rd->memory_mode) {
+        case RRD_MEMORY_MODE_SAVE:
+            debug(D_RRD_CALLS, "Saving dimension '%s' to '%s'.", rd->name, rd->cache_filename);
+            savememory(rd->cache_filename, rd, rd->memsize);
+            // continue to map mode - no break;
+
+        case RRD_MEMORY_MODE_MAP:
+            debug(D_RRD_CALLS, "Unmapping dimension '%s'.", rd->name);
+            freez((void *)rd->id);
+            freez(rd->cache_filename);
+            munmap(rd, rd->memsize);
+            break;
+
+        case RRD_MEMORY_MODE_RAM:
+            debug(D_RRD_CALLS, "Removing dimension '%s'.", rd->name);
+            freez((void *)rd->id);
+            freez(rd->cache_filename);
+            freez(rd);
+            break;
     }
 }
 
@@ -876,7 +870,7 @@ void rrdset_free_all(void)
 
         st->rrdfamily->use_count--;
         if(!st->rrdfamily->use_count)
-            rrdfamily_free(st->rrdfamily);
+            rrdfamily_free(&localhost, st->rrdfamily);
 
         pthread_rwlock_unlock(&st->rwlock);
 
@@ -915,7 +909,7 @@ void rrdset_save_all(void) {
         }
 
         for(rd = st->dimensions; rd ; rd = rd->next) {
-            if(likely(rd->mapped == RRD_MEMORY_MODE_SAVE)) {
+            if(likely(rd->memory_mode == RRD_MEMORY_MODE_SAVE)) {
                 debug(D_RRD_CALLS, "Saving dimension '%s' to '%s'.", rd->name, rd->cache_filename);
                 savememory(rd->cache_filename, rd, rd->memsize);
             }
@@ -928,33 +922,28 @@ void rrdset_save_all(void) {
 }
 
 
-RRDSET *rrdset_find(const char *id)
-{
-    debug(D_RRD_CALLS, "rrdset_find() for chart %s", id);
-
-    RRDSET *st = rrdset_index_find(&localhost, id, 0);
+RRDSET *rrdset_find(RRDHOST *host, const char *id) {
+    debug(D_RRD_CALLS, "rrdset_find() for chart '%s' in host '%s'", id, host->hostname);
+    RRDSET *st = rrdset_index_find(host, id, 0);
     return(st);
 }
 
-RRDSET *rrdset_find_bytype(const char *type, const char *id)
+RRDSET *rrdset_find_bytype(RRDHOST *host, const char *type, const char *id)
 {
-    debug(D_RRD_CALLS, "rrdset_find_bytype() for chart %s.%s", type, id);
+    debug(D_RRD_CALLS, "rrdset_find_bytype() for chart '%s.%s' in host '%s'", type, id, host->hostname);
 
     char buf[RRD_ID_LENGTH_MAX + 1];
-
     strncpyz(buf, type, RRD_ID_LENGTH_MAX - 1);
     strcat(buf, ".");
     int len = (int) strlen(buf);
     strncpyz(&buf[len], id, (size_t) (RRD_ID_LENGTH_MAX - len));
 
-    return(rrdset_find(buf));
+    return(rrdset_find(host, buf));
 }
 
-RRDSET *rrdset_find_byname(const char *name)
-{
-    debug(D_RRD_CALLS, "rrdset_find_byname() for chart %s", name);
-
-    RRDSET *st = rrdset_index_find_name(&localhost, name, 0);
+RRDSET *rrdset_find_byname(RRDHOST *host, const char *name) {
+    debug(D_RRD_CALLS, "rrdset_find_byname() for chart '%s' in host '%s'", name, host->hostname);
+    RRDSET *st = rrdset_index_find_name(host, name, 0);
     return(st);
 }
 
@@ -975,12 +964,11 @@ int rrddim_hide(RRDSET *st, const char *id)
         return 1;
     }
 
-    rd->flags |= RRDDIM_FLAG_HIDDEN;
+    rrddim_flag_set(rd, RRDDIM_FLAG_HIDDEN);
     return 0;
 }
 
-int rrddim_unhide(RRDSET *st, const char *id)
-{
+int rrddim_unhide(RRDSET *st, const char *id) {
     debug(D_RRD_CALLS, "rrddim_unhide() for chart %s, dimension %s", st->name, id);
 
     RRDDIM *rd = rrddim_find(st, id);
@@ -989,7 +977,7 @@ int rrddim_unhide(RRDSET *st, const char *id)
         return 1;
     }
 
-    if(rd->flags & RRDDIM_FLAG_HIDDEN) rd->flags ^= RRDDIM_FLAG_HIDDEN;
+    rrddim_flag_clear(rd, RRDDIM_FLAG_HIDDEN);
     return 0;
 }
 
@@ -999,7 +987,7 @@ collected_number rrddim_set_by_pointer(RRDSET *st, RRDDIM *rd, collected_number
 
     now_realtime_timeval(&rd->last_collected_time);
     rd->collected_value = value;
-    rd->updated = 1;
+    rrddim_flag_set(rd, RRDDIM_FLAG_UPDATED);
     rd->counter++;
 
     // fprintf(stderr, "%s.%s %llu " COLLECTED_NUMBER_FORMAT " dt %0.6f" " rate " CALCULATED_NUMBER_FORMAT "\n", st->name, rd->name, st->usec_since_last_update, value, (float)((double)st->usec_since_last_update / (double)1000000), (calculated_number)((value - rd->last_collected_value) * (calculated_number)rd->multiplier / (calculated_number)rd->divisor * 1000000.0 / (calculated_number)st->usec_since_last_update));
@@ -1042,8 +1030,10 @@ void rrdset_next_usec(RRDSET *st, usec_t microseconds)
     }
     else {
         // microseconds has the time since the last collection
+#ifdef NETDATA_INTERNAL_CHECKS
         usec_t now_usec = timeval_usec(&now);
         usec_t last_usec = timeval_usec(&st->last_collected_time);
+#endif
         usec_t since_last_usec = dt_usec(&now, &st->last_collected_time);
 
         // verify the microseconds given is good
@@ -1202,7 +1192,8 @@ usec_t rrdset_done(RRDSET *st)
     int dimensions;
     st->collected_total = 0;
     for( rd = st->dimensions, dimensions = 0 ; rd ; rd = rd->next, dimensions++ )
-        if(likely(rd->updated)) st->collected_total += rd->collected_value;
+        if(likely(rrddim_flag_check(rd, RRDDIM_FLAG_UPDATED)))
+            st->collected_total += rd->collected_value;
 
     uint32_t storage_flags = SN_EXISTS;
 
@@ -1211,7 +1202,7 @@ usec_t rrdset_done(RRDSET *st)
     // at this stage we do not interpolate anything
     for( rd = st->dimensions ; rd ; rd = rd->next ) {
 
-        if(unlikely(!rd->updated)) {
+        if(unlikely(!rrddim_flag_check(rd, RRDDIM_FLAG_UPDATED))) {
             rd->calculated_value = 0;
             continue;
         }
@@ -1229,7 +1220,7 @@ usec_t rrdset_done(RRDSET *st)
             );
 
         switch(rd->algorithm) {
-            case RRDDIM_ABSOLUTE:
+            case RRDDIM_ALGORITHM_ABSOLUTE:
                 rd->calculated_value = (calculated_number)rd->collected_value
                     * (calculated_number)rd->multiplier
                     / (calculated_number)rd->divisor;
@@ -1248,7 +1239,7 @@ usec_t rrdset_done(RRDSET *st)
                         );
                 break;
 
-            case RRDDIM_PCENT_OVER_ROW_TOTAL:
+            case RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL:
                 if(unlikely(!st->collected_total))
                     rd->calculated_value = 0;
                 else
@@ -1271,7 +1262,7 @@ usec_t rrdset_done(RRDSET *st)
                         );
                 break;
 
-            case RRDDIM_INCREMENTAL:
+            case RRDDIM_ALGORITHM_INCREMENTAL:
                 if(unlikely(rd->counter <= 1)) {
                     rd->calculated_value = 0;
                     continue;
@@ -1284,7 +1275,10 @@ usec_t rrdset_done(RRDSET *st)
                             , st->name, rd->name
                             , rd->last_collected_value
                             , rd->collected_value);
-                    if(!(rd->flags & RRDDIM_FLAG_DONT_DETECT_RESETS_OR_OVERFLOWS)) storage_flags = SN_EXISTS_RESET;
+
+                    if(!(rrddim_flag_check(rd, RRDDIM_FLAG_DONT_DETECT_RESETS_OR_OVERFLOWS)))
+                        storage_flags = SN_EXISTS_RESET;
+
                     rd->last_collected_value = rd->collected_value;
                 }
 
@@ -1308,7 +1302,7 @@ usec_t rrdset_done(RRDSET *st)
                         );
                 break;
 
-            case RRDDIM_PCENT_OVER_DIFF_TOTAL:
+            case RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL:
                 if(unlikely(rd->counter <= 1)) {
                     rd->calculated_value = 0;
                     continue;
@@ -1321,7 +1315,10 @@ usec_t rrdset_done(RRDSET *st)
                     , st->name, rd->name
                     , rd->last_collected_value
                     , rd->collected_value);
-                    if(!(rd->flags & RRDDIM_FLAG_DONT_DETECT_RESETS_OR_OVERFLOWS)) storage_flags = SN_EXISTS_RESET;
+
+                    if(!(rrddim_flag_check(rd, RRDDIM_FLAG_DONT_DETECT_RESETS_OR_OVERFLOWS)))
+                        storage_flags = SN_EXISTS_RESET;
+
                     rd->last_collected_value = rd->collected_value;
                 }
 
@@ -1407,7 +1404,7 @@ usec_t rrdset_done(RRDSET *st)
             calculated_number new_value;
 
             switch(rd->algorithm) {
-                case RRDDIM_INCREMENTAL:
+                case RRDDIM_ALGORITHM_INCREMENTAL:
                     new_value = (calculated_number)
                         (      rd->calculated_value
                             * (calculated_number)(next_store_ut - last_collect_ut)
@@ -1442,9 +1439,9 @@ usec_t rrdset_done(RRDSET *st)
                     }
                     break;
 
-                case RRDDIM_ABSOLUTE:
-                case RRDDIM_PCENT_OVER_ROW_TOTAL:
-                case RRDDIM_PCENT_OVER_DIFF_TOTAL:
+                case RRDDIM_ALGORITHM_ABSOLUTE:
+                case RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL:
+                case RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL:
                 default:
                     if(iterations == 1) {
                         // this is the last iteration
@@ -1486,7 +1483,7 @@ usec_t rrdset_done(RRDSET *st)
                 continue;
             }
 
-            if(likely(rd->updated && rd->counter > 1 && iterations < st->gap_when_lost_iterations_above)) {
+            if(likely(rrddim_flag_check(rd, RRDDIM_FLAG_UPDATED) && rd->counter > 1 && iterations < st->gap_when_lost_iterations_above)) {
                 rd->values[st->current_entry] = pack_storage_number(new_value, storage_flags );
                 rd->last_stored_value = new_value;
 
@@ -1548,13 +1545,14 @@ usec_t rrdset_done(RRDSET *st)
     st->last_collected_total  = st->collected_total;
 
     for( rd = st->dimensions; rd ; rd = rd->next ) {
-        if(unlikely(!rd->updated)) continue;
+        if(unlikely(!rrddim_flag_check(rd, RRDDIM_FLAG_UPDATED)))
+            continue;
 
         if(unlikely(st->debug)) debug(D_RRD_STATS, "%s/%s: setting last_collected_value (old: " COLLECTED_NUMBER_FORMAT ") to last_collected_value (new: " COLLECTED_NUMBER_FORMAT ")", st->id, rd->name, rd->last_collected_value, rd->collected_value);
         rd->last_collected_value = rd->collected_value;
 
         switch(rd->algorithm) {
-            case RRDDIM_INCREMENTAL:
+            case RRDDIM_ALGORITHM_INCREMENTAL:
                 if(unlikely(!first_entry)) {
                     if(unlikely(st->debug)) debug(D_RRD_STATS, "%s/%s: setting last_calculated_value (old: " CALCULATED_NUMBER_FORMAT ") to last_calculated_value (new: " CALCULATED_NUMBER_FORMAT ")", st->id, rd->name, rd->last_calculated_value + rd->calculated_value, rd->calculated_value);
                     rd->last_calculated_value += rd->calculated_value;
@@ -1564,9 +1562,9 @@ usec_t rrdset_done(RRDSET *st)
                 }
                 break;
 
-            case RRDDIM_ABSOLUTE:
-            case RRDDIM_PCENT_OVER_ROW_TOTAL:
-            case RRDDIM_PCENT_OVER_DIFF_TOTAL:
+            case RRDDIM_ALGORITHM_ABSOLUTE:
+            case RRDDIM_ALGORITHM_PCENT_OVER_ROW_TOTAL:
+            case RRDDIM_ALGORITHM_PCENT_OVER_DIFF_TOTAL:
                 if(unlikely(st->debug)) debug(D_RRD_STATS, "%s/%s: setting last_calculated_value (old: " CALCULATED_NUMBER_FORMAT ") to last_calculated_value (new: " CALCULATED_NUMBER_FORMAT ")", st->id, rd->name, rd->last_calculated_value, rd->calculated_value);
                 rd->last_calculated_value = rd->calculated_value;
                 break;
@@ -1574,7 +1572,7 @@ usec_t rrdset_done(RRDSET *st)
 
         rd->calculated_value = 0;
         rd->collected_value = 0;
-        rd->updated = 0;
+        rrddim_flag_clear(rd, RRDDIM_FLAG_UPDATED);
 
         if(unlikely(st->debug)) debug(D_RRD_STATS, "%s/%s: END "
             " last_collected_value = " COLLECTED_NUMBER_FORMAT