]> arthur.barton.de Git - netdata.git/blob - src/proc_diskstats.c
diskstats: Monitor disk inodes
[netdata.git] / src / proc_diskstats.c
1 #ifdef HAVE_CONFIG_H
2 #include <config.h>
3 #endif
4 #include <dirent.h>
5 #include <fcntl.h>
6 #include <stdio.h>
7 #include <stdlib.h>
8 #include <string.h>
9 #include <sys/stat.h>
10 #include <sys/statvfs.h>
11 #include <sys/types.h>
12 #include <unistd.h>
13
14
15 #include "common.h"
16 #include "log.h"
17 #include "appconfig.h"
18 #include "procfile.h"
19 #include "rrd.h"
20 #include "plugin_proc.h"
21
22 #include "proc_self_mountinfo.h"
23
24 #define RRD_TYPE_DISK "disk"
25
26 #define DISK_TYPE_PHYSICAL  1
27 #define DISK_TYPE_PARTITION 2
28 #define DISK_TYPE_CONTAINER 3
29
30 struct disk {
31         unsigned long major;
32         unsigned long minor;
33         int type;
34         char *mount_point;
35         struct disk *next;
36 } *disk_root = NULL;
37
38 struct disk *get_disk(unsigned long major, unsigned long minor) {
39         static char path_find_block_device[FILENAME_MAX + 1] = "";
40         static struct mountinfo *mountinfo_root = NULL;
41         struct disk *d;
42
43         // search for it in our RAM list.
44         // this is sequential, but since we just walk through
45         // and the number of disks / partitions in a system
46         // should not be that many, it should be acceptable
47         for(d = disk_root; d ; d = d->next)
48                 if(unlikely(d->major == major && d->minor == minor))
49                         break;
50
51         // if we found it, return it
52         if(likely(d))
53                 return d;
54
55         if(unlikely(!path_find_block_device[0])) {
56                 char dirname[FILENAME_MAX + 1];
57                 snprintfz(dirname, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/dev/block/%lu:%lu/%s");
58                 snprintfz(path_find_block_device, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get block device infos", dirname));
59         }
60
61         // not found
62         // create a new disk structure
63         d = (struct disk *)malloc(sizeof(struct disk));
64         if(!d) fatal("Cannot allocate memory for struct disk in proc_diskstats.");
65
66         d->major = major;
67         d->minor = minor;
68         d->type = DISK_TYPE_PHYSICAL; // Default type. Changed later if not correct.
69         d->next = NULL;
70
71         // append it to the list
72         if(!disk_root)
73                 disk_root = d;
74         else {
75                 struct disk *last;
76                 for(last = disk_root; last->next ;last = last->next);
77                 last->next = d;
78         }
79
80         // ------------------------------------------------------------------------
81         // find the type of the device
82
83         // find if it is a partition
84         // by checking if /sys/dev/block/MAJOR:MINOR/partition is readable.
85         char buffer[FILENAME_MAX + 1];
86         snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "partition");
87         if(access(buffer, R_OK) == 0) {
88                 d->type = DISK_TYPE_PARTITION;
89         } else {
90                 // find if it is a container
91                 // by checking if /sys/dev/block/MAJOR:MINOR/slaves has entries
92                 int is_container = 0;
93                 snprintfz(buffer, FILENAME_MAX, path_find_block_device, major, minor, "slaves/");
94                 DIR *dirp = opendir(buffer);    
95                 if (dirp != NULL) {
96                 struct dirent *dp;
97                         while(dp = readdir(dirp)) {
98                                 // . and .. are also files in empty folders.
99                                 if(strcmp(dp->d_name, ".") == 0 || strcmp(dp->d_name, "..") == 0) {
100                                         continue;
101                                 }
102                                 d->type = DISK_TYPE_CONTAINER;
103                                 // Stop the loop after we found one file.
104                                 break;
105                         }
106                         if(closedir(dirp) == -1)
107                                 error("Unable to close dir %s", buffer);
108                 }
109         }
110
111         // ------------------------------------------------------------------------
112         // check if we can find its mount point
113
114         // mountinfo_find() can be called with NULL mountinfo_root
115         struct mountinfo *mi = mountinfo_find(mountinfo_root, d->major, d->minor);
116         if(unlikely(!mi)) {
117                 // mountinfo_free() can be called with NULL mountinfo_root
118                 mountinfo_free(mountinfo_root);
119
120                 // re-read mountinfo in case something changed
121                 mountinfo_root = mountinfo_read();
122
123                 // search again for this disk
124                 mi = mountinfo_find(mountinfo_root, d->major, d->minor);
125         }
126
127         if(mi)
128                 d->mount_point = strdup(mi->mount_point);
129                 // no need to check for NULL
130         else
131                 d->mount_point = NULL;
132
133         return d;
134 }
135
136 int do_proc_diskstats(int update_every, unsigned long long dt) {
137         static procfile *ff = NULL;
138         static char path_to_get_hw_sector_size[FILENAME_MAX + 1] = "";
139         static int enable_autodetection;
140         static int enable_physical_disks, enable_virtual_disks, enable_partitions, enable_mountpoints, enable_space_metrics;
141         static int do_io, do_ops, do_mops, do_iotime, do_qops, do_util, do_backlog, do_space, do_inodes;
142         static struct statvfs buff_statvfs;
143         static struct stat buff_stat;
144
145         enable_autodetection = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "enable new disks detected at runtime", CONFIG_ONDEMAND_ONDEMAND);
146
147         enable_physical_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for physical disks", CONFIG_ONDEMAND_ONDEMAND);
148         enable_virtual_disks = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for virtual disks", CONFIG_ONDEMAND_NO);
149         enable_partitions = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for partitions", CONFIG_ONDEMAND_NO);
150         enable_mountpoints = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "performance metrics for mounted filesystems", CONFIG_ONDEMAND_NO);
151         enable_space_metrics = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space metrics for mounted filesystems", CONFIG_ONDEMAND_ONDEMAND);
152
153         do_io      = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "bandwidth for all disks", CONFIG_ONDEMAND_ONDEMAND);
154         do_ops     = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
155         do_mops    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "merged operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
156         do_iotime  = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "i/o time for all disks", CONFIG_ONDEMAND_ONDEMAND);
157         do_qops    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "queued operations for all disks", CONFIG_ONDEMAND_ONDEMAND);
158         do_util    = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "utilization percentage for all disks", CONFIG_ONDEMAND_ONDEMAND);
159         do_backlog = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "backlog for all disks", CONFIG_ONDEMAND_ONDEMAND);
160         do_space   = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "space usage for all disks", CONFIG_ONDEMAND_ONDEMAND);
161         do_inodes  = config_get_boolean_ondemand("plugin:proc:/proc/diskstats", "inodes usage for all disks", CONFIG_ONDEMAND_ONDEMAND);
162
163         if(!ff) {
164                 char filename[FILENAME_MAX + 1];
165                 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/proc/diskstats");
166                 ff = procfile_open(config_get("plugin:proc:/proc/diskstats", "filename to monitor", filename), " \t", PROCFILE_FLAG_DEFAULT);
167         }
168         if(!ff) return 1;
169
170         if(!path_to_get_hw_sector_size[0]) {
171                 char filename[FILENAME_MAX + 1];
172                 snprintfz(filename, FILENAME_MAX, "%s%s", global_host_prefix, "/sys/block/%s/queue/hw_sector_size");
173                 snprintfz(path_to_get_hw_sector_size, FILENAME_MAX, "%s", config_get("plugin:proc:/proc/diskstats", "path to get h/w sector size", filename));
174         }
175
176         ff = procfile_readall(ff);
177         if(!ff) return 0; // we return 0, so that we will retry to open it next time
178
179         uint32_t lines = procfile_lines(ff), l;
180         uint32_t words;
181
182         for(l = 0; l < lines ;l++) {
183                 // --------------------------------------------------------------------------
184                 // Read parameters
185                 char *disk;
186                 unsigned long long      major = 0, minor = 0,
187                                                         reads = 0,  mreads = 0,  readsectors = 0,  readms = 0,
188                                                         writes = 0, mwrites = 0, writesectors = 0, writems = 0,
189                                                         queued_ios = 0, busy_ms = 0, backlog_ms = 0,
190                                                         space_avail = 0, space_avail_root = 0, space_used = 0,
191                                                         inodes_avail = 0, inodes_avail_root = 0, inodes_used = 0;
192
193                 unsigned long long      last_reads = 0,  last_readsectors = 0,  last_readms = 0,
194                                                         last_writes = 0, last_writesectors = 0, last_writems = 0,
195                                                         last_busy_ms = 0;
196
197                 words = procfile_linewords(ff, l);
198                 if(words < 14) continue;
199
200                 major                   = strtoull(procfile_lineword(ff, l, 0), NULL, 10);
201                 minor                   = strtoull(procfile_lineword(ff, l, 1), NULL, 10);
202                 disk                    = procfile_lineword(ff, l, 2);
203
204                 // # of reads completed # of writes completed
205                 // This is the total number of reads or writes completed successfully.
206                 reads                   = strtoull(procfile_lineword(ff, l, 3), NULL, 10);      // rd_ios
207                 writes                  = strtoull(procfile_lineword(ff, l, 7), NULL, 10);      // wr_ios
208
209                 // # of reads merged # of writes merged
210                 // Reads and writes which are adjacent to each other may be merged for
211             // efficiency.  Thus two 4K reads may become one 8K read before it is
212             // ultimately handed to the disk, and so it will be counted (and queued)
213                 mreads                  = strtoull(procfile_lineword(ff, l, 4), NULL, 10);      // rd_merges_or_rd_sec
214                 mwrites                 = strtoull(procfile_lineword(ff, l, 8), NULL, 10);      // wr_merges
215
216                 // # of sectors read # of sectors written
217                 // This is the total number of sectors read or written successfully.
218                 readsectors     = strtoull(procfile_lineword(ff, l, 5), NULL, 10);      // rd_sec_or_wr_ios
219                 writesectors    = strtoull(procfile_lineword(ff, l, 9), NULL, 10);      // wr_sec
220
221                 // # of milliseconds spent reading # of milliseconds spent writing
222                 // This is the total number of milliseconds spent by all reads or writes (as
223                 // measured from __make_request() to end_that_request_last()).
224                 readms                  = strtoull(procfile_lineword(ff, l, 6), NULL, 10);      // rd_ticks_or_wr_sec
225                 writems                 = strtoull(procfile_lineword(ff, l, 10), NULL, 10);     // wr_ticks
226
227                 // # of I/Os currently in progress
228                 // The only field that should go to zero. Incremented as requests are
229                 // given to appropriate struct request_queue and decremented as they finish.
230                 queued_ios              = strtoull(procfile_lineword(ff, l, 11), NULL, 10);     // ios_pgr
231
232                 // # of milliseconds spent doing I/Os
233                 // This field increases so long as field queued_ios is nonzero.
234                 busy_ms                 = strtoull(procfile_lineword(ff, l, 12), NULL, 10);     // tot_ticks
235
236                 // weighted # of milliseconds spent doing I/Os
237                 // This field is incremented at each I/O start, I/O completion, I/O
238                 // merge, or read of these stats by the number of I/Os in progress
239                 // (field queued_ios) times the number of milliseconds spent doing I/O since the
240                 // last update of this field.  This can provide an easy measure of both
241                 // I/O completion time and the backlog that may be accumulating.
242                 backlog_ms              = strtoull(procfile_lineword(ff, l, 13), NULL, 10);     // rq_ticks
243
244                 // --------------------------------------------------------------------------
245                 // remove slashes from disk names
246                 char *s;
247                 for(s = disk; *s ;s++) if(*s == '/') *s = '_';
248                 struct disk *d = get_disk(major, minor);
249                 // Find mount point and family
250                 char *mount_point = d->mount_point;
251                 char *family = d->mount_point;
252                 if(!family) family = disk;
253
254                 // --------------------------------------------------------------------------
255                 // Check if device is enabled by autodetection or config
256                 int def_enable = -1;
257                 char var_name[4096 + 1];
258                 snprintfz(var_name, 4096, "plugin:proc:/proc/diskstats:%s", disk);
259
260                 if(def_enable == -1) def_enable = config_get_boolean_ondemand(var_name, "enable", CONFIG_ONDEMAND_ONDEMAND);
261                 if(def_enable == CONFIG_ONDEMAND_NO) continue;
262
263                 int def_performance = CONFIG_ONDEMAND_NO, def_space = CONFIG_ONDEMAND_NO;
264                 if(enable_autodetection)  {
265                         if(enable_physical_disks && (d->type == DISK_TYPE_PHYSICAL)) {
266                                 def_performance = enable_physical_disks;
267                         } else if(enable_virtual_disks && (d->type == DISK_TYPE_CONTAINER)) {
268                                 def_performance = enable_virtual_disks;
269                         } else if(enable_partitions && (d->type == DISK_TYPE_PARTITION)) {
270                                 def_performance = enable_partitions;
271                         } else if(enable_mountpoints && (d->mount_point != NULL)) {
272                                 def_performance = enable_mountpoints;
273                         }
274
275                         if(enable_space_metrics && (d->mount_point != NULL)) {
276                                 def_space = enable_space_metrics;
277                         }
278                 }
279
280                 RRDSET *st;
281
282                 // --------------------------------------------------------------------------
283                 // Do performance metrics
284                 def_performance = config_get_boolean_ondemand(var_name, "enable performance metrics", def_performance);
285                 if( (def_performance == CONFIG_ONDEMAND_YES) || (def_performance == CONFIG_ONDEMAND_ONDEMAND && reads && writes) ) {
286                         int ddo_io = do_io, ddo_ops = do_ops, ddo_mops = do_mops, ddo_iotime = do_iotime, ddo_qops = do_qops, ddo_util = do_util, ddo_backlog = do_backlog;
287
288                         ddo_io          = config_get_boolean_ondemand(var_name, "bandwidth", ddo_io);
289                         ddo_ops         = config_get_boolean_ondemand(var_name, "operations", ddo_ops);
290                         ddo_mops        = config_get_boolean_ondemand(var_name, "merged operations", ddo_mops);
291                         ddo_iotime      = config_get_boolean_ondemand(var_name, "i/o time", ddo_iotime);
292                         ddo_qops        = config_get_boolean_ondemand(var_name, "queued operations", ddo_qops);
293                         ddo_util        = config_get_boolean_ondemand(var_name, "utilization percentage", ddo_util);
294                         ddo_backlog = config_get_boolean_ondemand(var_name, "backlog", ddo_backlog);
295
296                         // by default, do not add charts that do not have values
297                         if(ddo_io == CONFIG_ONDEMAND_ONDEMAND && !reads && !writes) ddo_io = 0;
298                         if(ddo_mops == CONFIG_ONDEMAND_ONDEMAND && mreads == 0 && mwrites == 0) ddo_mops = 0;
299                         if(ddo_iotime == CONFIG_ONDEMAND_ONDEMAND && readms == 0 && writems == 0) ddo_iotime = 0;
300                         if(ddo_util == CONFIG_ONDEMAND_ONDEMAND && busy_ms == 0) ddo_util = 0;
301                         if(ddo_backlog == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_backlog = 0;
302                         if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND && backlog_ms == 0) ddo_qops = 0;
303
304                         // for absolute values, we need to switch the setting to 'yes'
305                         // to allow it refresh from now on
306                         if(ddo_qops == CONFIG_ONDEMAND_ONDEMAND) config_set(var_name, "queued operations", "yes");
307
308                         // --------------------------------------------------------------------
309                         int sector_size = 512;
310                         if(ddo_io) {
311                                 st = rrdset_find_bytype(RRD_TYPE_DISK, disk);
312                                 if(!st) {
313                                         char tf[FILENAME_MAX + 1], *t;
314                                         char ssfilename[FILENAME_MAX + 1];
315
316                                         strncpyz(tf, disk, FILENAME_MAX);
317
318                                         // replace all / with !
319                                         while((t = strchr(tf, '/'))) *t = '!';
320
321                                         snprintfz(ssfilename, FILENAME_MAX, path_to_get_hw_sector_size, tf);
322                                         FILE *fpss = fopen(ssfilename, "r");
323                                         if(fpss) {
324                                                 char ssbuffer[1025];
325                                                 char *tmp = fgets(ssbuffer, 1024, fpss);
326
327                                                 if(tmp) {
328                                                         sector_size = atoi(tmp);
329                                                         if(sector_size <= 0) {
330                                                                 error("Invalid sector size %d for device %s in %s. Assuming 512.", sector_size, disk, ssfilename);
331                                                                 sector_size = 512;
332                                                         }
333                                                 }
334                                                 else error("Cannot read data for sector size for device %s from %s. Assuming 512.", disk, ssfilename);
335
336                                                 fclose(fpss);
337                                         }
338                                         else error("Cannot read sector size for device %s from %s. Assuming 512.", disk, ssfilename);
339
340                                         st = rrdset_create(RRD_TYPE_DISK, disk, NULL, family, "disk.io", "Disk I/O Bandwidth", "kilobytes/s", 2000, update_every, RRDSET_TYPE_AREA);
341
342                                         rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_INCREMENTAL);
343                                         rrddim_add(st, "writes", NULL, sector_size * -1, 1024, RRDDIM_INCREMENTAL);
344                                 }
345                                 else rrdset_next_usec(st, dt);
346
347                                 last_readsectors  = rrddim_set(st, "reads", readsectors);
348                                 last_writesectors = rrddim_set(st, "writes", writesectors);
349                                 rrdset_done(st);
350                         }
351
352                         // --------------------------------------------------------------------
353                         if(ddo_ops) {
354                                 st = rrdset_find_bytype("disk_ops", disk);
355                                 if(!st) {
356                                         st = rrdset_create("disk_ops", disk, NULL, family, "disk.ops", "Disk Completed I/O Operations", "operations/s", 2001, update_every, RRDSET_TYPE_LINE);
357                                         st->isdetail = 1;
358
359                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
360                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
361                                 }
362                                 else rrdset_next_usec(st, dt);
363
364                                 last_reads  = rrddim_set(st, "reads", reads);
365                                 last_writes = rrddim_set(st, "writes", writes);
366                                 rrdset_done(st);
367                         }
368
369                         // --------------------------------------------------------------------
370                         if(ddo_qops) {
371                                 st = rrdset_find_bytype("disk_qops", disk);
372                                 if(!st) {
373                                         st = rrdset_create("disk_qops", disk, NULL, family, "disk.qops", "Disk Current I/O Operations", "operations", 2002, update_every, RRDSET_TYPE_LINE);
374                                         st->isdetail = 1;
375
376                                         rrddim_add(st, "operations", NULL, 1, 1, RRDDIM_ABSOLUTE);
377                                 }
378                                 else rrdset_next_usec(st, dt);
379
380                                 rrddim_set(st, "operations", queued_ios);
381                                 rrdset_done(st);
382                         }
383
384                         // --------------------------------------------------------------------
385                         if(ddo_backlog) {
386                                 st = rrdset_find_bytype("disk_backlog", disk);
387                                 if(!st) {
388                                         st = rrdset_create("disk_backlog", disk, NULL, family, "disk.backlog", "Disk Backlog", "backlog (ms)", 2003, update_every, RRDSET_TYPE_AREA);
389                                         st->isdetail = 1;
390
391                                         rrddim_add(st, "backlog", NULL, 1, 10, RRDDIM_INCREMENTAL);
392                                 }
393                                 else rrdset_next_usec(st, dt);
394
395                                 rrddim_set(st, "backlog", backlog_ms);
396                                 rrdset_done(st);
397                         }
398
399                         // --------------------------------------------------------------------
400                         if(ddo_util) {
401                                 st = rrdset_find_bytype("disk_util", disk);
402                                 if(!st) {
403                                         st = rrdset_create("disk_util", disk, NULL, family, "disk.util", "Disk Utilization Time", "% of time working", 2004, update_every, RRDSET_TYPE_AREA);
404                                         st->isdetail = 1;
405
406                                         rrddim_add(st, "utilization", NULL, 1, 10, RRDDIM_INCREMENTAL);
407                                 }
408                                 else rrdset_next_usec(st, dt);
409
410                                 last_busy_ms = rrddim_set(st, "utilization", busy_ms);
411                                 rrdset_done(st);
412                         }
413
414                         // --------------------------------------------------------------------
415                         if(ddo_mops) {
416                                 st = rrdset_find_bytype("disk_mops", disk);
417                                 if(!st) {
418                                         st = rrdset_create("disk_mops", disk, NULL, family, "disk.mops", "Disk Merged Operations", "merged operations/s", 2021, update_every, RRDSET_TYPE_LINE);
419                                         st->isdetail = 1;
420
421                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
422                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
423                                 }
424                                 else rrdset_next_usec(st, dt);
425
426                                 rrddim_set(st, "reads", mreads);
427                                 rrddim_set(st, "writes", mwrites);
428                                 rrdset_done(st);
429                         }
430
431                         // --------------------------------------------------------------------
432                         if(ddo_iotime) {
433                                 st = rrdset_find_bytype("disk_iotime", disk);
434                                 if(!st) {
435                                         st = rrdset_create("disk_iotime", disk, NULL, family, "disk.iotime", "Disk Total I/O Time", "milliseconds/s", 2022, update_every, RRDSET_TYPE_LINE);
436                                         st->isdetail = 1;
437
438                                         rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_INCREMENTAL);
439                                         rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_INCREMENTAL);
440                                 }
441                                 else rrdset_next_usec(st, dt);
442
443                                 last_readms  = rrddim_set(st, "reads", readms);
444                                 last_writems = rrddim_set(st, "writes", writems);
445                                 rrdset_done(st);
446                         }
447
448                         // --------------------------------------------------------------------
449                         // calculate differential charts
450                         // only if this is not the first time we run
451                         if(dt) {
452                                 if(ddo_iotime && ddo_ops) {
453                                         st = rrdset_find_bytype("disk_await", disk);
454                                         if(!st) {
455                                                 st = rrdset_create("disk_await", disk, NULL, family, "disk.await", "Average Completed I/O Operation Time", "ms per operation", 2005, update_every, RRDSET_TYPE_LINE);
456                                                 st->isdetail = 1;
457
458                                                 rrddim_add(st, "reads", NULL, 1, 1, RRDDIM_ABSOLUTE);
459                                                 rrddim_add(st, "writes", NULL, -1, 1, RRDDIM_ABSOLUTE);
460                                         }
461                                         else rrdset_next_usec(st, dt);
462
463                                         rrddim_set(st, "reads", (reads - last_reads) ? (readms - last_readms) / (reads - last_reads) : 0);
464                                         rrddim_set(st, "writes", (writes - last_writes) ? (writems - last_writems) / (writes - last_writes) : 0);
465                                         rrdset_done(st);
466                                 }
467
468                                 if(ddo_io && ddo_ops) {
469                                         st = rrdset_find_bytype("disk_avgsz", disk);
470                                         if(!st) {
471                                                 st = rrdset_create("disk_avgsz", disk, NULL, family, "disk.avgsz", "Average Completed I/O Operation Bandwidth", "kilobytes per operation", 2006, update_every, RRDSET_TYPE_AREA);
472                                                 st->isdetail = 1;
473
474                                                 rrddim_add(st, "reads", NULL, sector_size, 1024, RRDDIM_ABSOLUTE);
475                                                 rrddim_add(st, "writes", NULL, -sector_size, 1024, RRDDIM_ABSOLUTE);
476                                         }
477                                         else rrdset_next_usec(st, dt);
478
479                                         rrddim_set(st, "reads", (reads - last_reads) ? (readsectors - last_readsectors) / (reads - last_reads) : 0);
480                                         rrddim_set(st, "writes", (writes - last_writes) ? (writesectors - last_writesectors) / (writes - last_writes) : 0);
481                                         rrdset_done(st);
482                                 }
483
484                                 if(ddo_util && ddo_ops) {
485                                         st = rrdset_find_bytype("disk_svctm", disk);
486                                         if(!st) {
487                                                 st = rrdset_create("disk_svctm", disk, NULL, family, "disk.svctm", "Average Service Time", "ms per operation", 2007, update_every, RRDSET_TYPE_LINE);
488                                                 st->isdetail = 1;
489
490                                                 rrddim_add(st, "svctm", NULL, 1, 1, RRDDIM_ABSOLUTE);
491                                         }
492                                         else rrdset_next_usec(st, dt);
493
494                                         rrddim_set(st, "svctm", ((reads - last_reads) + (writes - last_writes)) ? (busy_ms - last_busy_ms) / ((reads - last_reads) + (writes - last_writes)) : 0);
495                                         rrdset_done(st);
496                                 }
497                         }
498                 }
499
500                 // --------------------------------------------------------------------------
501                 // Do space metrics
502                 def_space = config_get_boolean_ondemand(var_name, "enable space metrics", def_space);           
503                 if(def_space != CONFIG_ONDEMAND_NO) {
504                         int ddo_space = do_space, ddo_inodes = do_inodes;
505
506                         ddo_space = config_get_boolean_ondemand(var_name, "space", ddo_space);
507                         ddo_inodes = config_get_boolean_ondemand(var_name, "inodes", ddo_space);
508                         if(mount_point && (ddo_space || ddo_inodes) ) {
509                                 // collect space metrics using statvfs
510                                 if (statvfs(mount_point, &buff_statvfs) < 0) {
511                                         error("Failed checking disk space usage of %s", family);
512                                 } else {
513                                         // verify we collected the metrics for the right disk.
514                                         // if not the mountpoint has changed.
515                                         if(stat(mount_point, &buff_stat) == -1) {
516                                                 error("Failed to call stat for %s", family);
517                                         } else {
518                                                 if(major(buff_stat.st_dev) == major && minor(buff_stat.st_dev) == minor)
519                                                 {
520                                                         if(ddo_space) {
521                                                                 space_avail = buff_statvfs.f_bavail * buff_statvfs.f_bsize;
522                                                                 space_avail_root = (buff_statvfs.f_bfree - buff_statvfs.f_bavail) * buff_statvfs.f_bsize;
523                                                                 space_used = (buff_statvfs.f_blocks - buff_statvfs.f_bfree) * buff_statvfs.f_bsize;
524
525                                                                 st = rrdset_find_bytype("disk_space", disk);
526                                                                 if(!st) {
527                                                                         st = rrdset_create("disk_space", disk, NULL, family, "disk.space", "Disk Space Usage", "GB", 2023, update_every, RRDSET_TYPE_STACKED);
528                                                                         st->isdetail = 1;
529
530                                                                         rrddim_add(st, "avail", NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
531                                                                         rrddim_add(st, "reserved_for_root", "reserved for root", 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
532                                                                         rrddim_add(st, "used" , NULL, 1, 1000*1000*1000, RRDDIM_ABSOLUTE);
533                                                                 }
534                                                                 else rrdset_next_usec(st, dt);
535
536                                                                 rrddim_set(st, "avail", space_avail);
537                                                                 rrddim_set(st, "reserved_for_root", space_avail_root);
538                                                                 rrddim_set(st, "used", space_used);
539                                                                 rrdset_done(st);
540                                                         }
541                                                         if(ddo_inodes) {
542                                                                 inodes_avail = buff_statvfs.f_favail;
543                                                                 inodes_avail_root = buff_statvfs.f_ffree - buff_statvfs.f_favail;
544                                                                 inodes_used = buff_statvfs.f_files - buff_statvfs.f_ffree;
545
546                                                                 st = rrdset_find_bytype("disk_inodes", disk);
547                                                                 if(!st) {
548                                                                         st = rrdset_create("disk_inodes", disk, NULL, family, "disk.inodes", "Disk Inodes Usage", "Inodes", 2024, update_every, RRDSET_TYPE_STACKED);
549                                                                         st->isdetail = 1;
550
551                                                                         rrddim_add(st, "avail", NULL, 1, 1, RRDDIM_ABSOLUTE);
552                                                                         rrddim_add(st, "reserved_for_root", "reserved for root", 1, 1, RRDDIM_ABSOLUTE);
553                                                                         rrddim_add(st, "used" , NULL, 1, 1, RRDDIM_ABSOLUTE);
554                                                                 }
555                                                                 else rrdset_next_usec(st, dt);
556
557                                                                 rrddim_set(st, "avail", inodes_avail);
558                                                                 rrddim_set(st, "reserved_for_root", inodes_avail_root);
559                                                                 rrddim_set(st, "used", inodes_used);
560                                                                 rrdset_done(st);
561                                                         }
562                                                 }
563                                         }
564                                 }
565                         }
566                 }
567         }
568         return 0;
569 }