From: Alexander Barton <alex@barton.de>
Date: Sun, 24 May 2020 21:24:51 +0000 (+0200)
Subject: Revert "Set the "last data" time to "last ping" time when updating the latter"
X-Git-Tag: rel-26-rc2~12
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git;a=commitdiff_plain;h=0d503945cb527e275ef6644a234a6876ff61322b;hp=bae68eb612ef0d8aa515e03c1479e2a57d243dee

Revert "Set the "last data" time to "last ping" time when updating the latter"

This patch completely broke the PING-PONG logic: now ngIRCd never
disconnects any stale peers but keeps sending out PINGs over and over
again ...

The real issue (server disconnects right after connect) will be fixed in
the next commit, but let's revert to the somewhat "half-broken but
'known' state" first ...

This reverts commit 79a917f954bef8089967786bd3597a6e5ff5c336.
---

diff --git a/src/ngircd/conn-func.c b/src/ngircd/conn-func.c
index 4a2d32d6..72d38b86 100644
--- a/src/ngircd/conn-func.c
+++ b/src/ngircd/conn-func.c
@@ -51,7 +51,7 @@ GLOBAL void
 Conn_UpdatePing(CONN_ID Idx)
 {
 	assert(Idx > NONE);
-	My_Connections[Idx].lastping = My_Connections[Idx].lastdata = time(NULL);
+	My_Connections[Idx].lastping = time(NULL);
 }
 
 /*