X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd.git;a=blobdiff_plain;f=src%2Fngircd%2Fchannel.c;h=5e3b9a802dc1d4ad28a8d7e6753ea792066675ca;hp=1b7164f5ac40d914e033aa184eee48c66c6ba971;hb=d8950c5dd092c092688c75cf0ec42cd950c7f7c4;hpb=8067bab10613dbc63b8c54e67b355fead674556a diff --git a/src/ngircd/channel.c b/src/ngircd/channel.c index 1b7164f5..5e3b9a80 100644 --- a/src/ngircd/channel.c +++ b/src/ngircd/channel.c @@ -17,7 +17,7 @@ #include "portab.h" -static char UNUSED id[] = "$Id: channel.c,v 1.55 2006/04/23 10:33:37 fw Exp $"; +static char UNUSED id[] = "$Id: channel.c,v 1.58 2006/10/02 21:55:49 fw Exp $"; #include "imp.h" #include @@ -106,14 +106,15 @@ Channel_InitPredefined( void ) if (chan) { Channel_ModeAdd(chan, 'P'); - Channel_SetTopic(chan, NULL, + if (array_start(&Conf_Channel[i].topic) != NULL) + Channel_SetTopic(chan, NULL, array_start(&Conf_Channel[i].topic)); array_free(&Conf_Channel[i].topic); c = Conf_Channel[i].modes; while (*c) Channel_ModeAdd(chan, *c++); - + Log(LOG_INFO, "Created pre-defined channel \"%s\".", Conf_Channel[i].name ); } @@ -172,7 +173,7 @@ Channel_Join( CLIENT *Client, char *Name ) { /* Gibt es noch nicht? Dann neu anlegen: */ chan = Channel_Create( Name ); - if( ! chan ) return false; + if (!chan) return false; } /* User dem Channel hinzufuegen */ @@ -213,7 +214,6 @@ Channel_Kick( CLIENT *Client, CLIENT *Origin, char *Name, char *Reason ) assert( Name != NULL ); assert( Reason != NULL ); - /* Channel suchen */ chan = Channel_Search( Name ); if( ! chan ) { @@ -462,25 +462,13 @@ Channel_GetChannel( CL2CHAN *Cl2Chan ) GLOBAL bool -Channel_IsValidName( char *Name ) +Channel_IsValidName( const char *Name ) { - /* Pruefen, ob Name als Channelname gueltig */ - - char *ptr, badchars[10]; - assert( Name != NULL ); if(( Name[0] != '#' ) || ( strlen( Name ) >= CHANNEL_NAME_LEN )) return false; - ptr = Name; - strcpy( badchars, " ,:\007" ); - while( *ptr ) - { - if( strchr( badchars, *ptr )) return false; - ptr++; - } - - return true; + return Name[strcspn(Name, " ,:\007")] == 0; } /* Channel_IsValidName */ @@ -547,7 +535,7 @@ Channel_UserModeAdd( CHANNEL *Chan, CLIENT *Client, char Mode ) cl2chan = Get_Cl2Chan( Chan, Client ); assert( cl2chan != NULL ); - + x[0] = Mode; x[1] = '\0'; if( ! strchr( cl2chan->modes, x[0] )) { @@ -593,7 +581,7 @@ GLOBAL char * Channel_UserModes( CHANNEL *Chan, CLIENT *Client ) { /* return Users' Channel-Modes */ - + CL2CHAN *cl2chan; assert( Chan != NULL ); @@ -660,12 +648,9 @@ Channel_SetTopic(CHANNEL *Chan, CLIENT *Client, char *Topic) if (len < array_bytes(&Chan->topic)) array_free(&Chan->topic); - if (!array_copyb(&Chan->topic, Topic, len)) + if (len >= COMMAND_LEN || !array_copyb(&Chan->topic, Topic, len+1)) Log(LOG_WARNING, "could not set new Topic \"%s\" on %s: %s", Topic, Chan->name, strerror(errno)); - - array_cat0(&Chan->topic); - #ifndef STRICT_RFC Chan->topic_time = time(NULL); if (Client != NULL && Client_Type(Client) != CLIENT_SERVER) @@ -697,7 +682,7 @@ Channel_SetKey( CHANNEL *Chan, char *Key ) assert( Key != NULL ); strlcpy( Chan->key, Key, sizeof( Chan->key )); - Log( LOG_DEBUG, "Channel %s: Key is now \"%s\".", Chan->name, Chan->key ); + LogDebug("Channel %s: Key is now \"%s\".", Chan->name, Chan->key ); } /* Channel_SetKey */ @@ -707,7 +692,7 @@ Channel_SetMaxUsers( CHANNEL *Chan, long Count ) assert( Chan != NULL ); Chan->maxusers = Count; - Log( LOG_DEBUG, "Channel %s: Member limit is now %ld.", Chan->name, Chan->maxusers ); + LogDebug("Channel %s: Member limit is now %lu.", Chan->name, Chan->maxusers ); } /* Channel_SetMaxUsers */ @@ -752,7 +737,7 @@ Channel_Create( char *Name ) CHANNEL *c; assert( Name != NULL ); - + c = (CHANNEL *)malloc( sizeof( CHANNEL )); if( ! c ) { @@ -764,9 +749,7 @@ Channel_Create( char *Name ) c->hash = Hash( c->name ); c->next = My_Channels; My_Channels = c; -#ifdef DEBUG - Log( LOG_DEBUG, "Created new channel structure for \"%s\".", Name ); -#endif + LogDebug("Created new channel structure for \"%s\".", Name); return c; } /* Channel_Create */ @@ -850,25 +833,42 @@ Remove_Client( int Type, CHANNEL *Chan, CLIENT *Client, CLIENT *Origin, char *Re switch( Type ) { case REMOVE_QUIT: - /* QUIT: andere Server wurden bereits informiert, vgl. Client_Destroy(); - * hier also "nur" noch alle User in betroffenen Channeln infomieren */ + /* QUIT: other servers have already been notified, see Client_Destroy(); + * so only inform other clients in same channel. */ assert( InformServer == false ); - Log( LOG_DEBUG, "User \"%s\" left channel \"%s\" (%s).", Client_Mask( Client ), c->name, Reason ); + LogDebug("User \"%s\" left channel \"%s\" (%s).", + Client_Mask( Client ), c->name, Reason ); break; case REMOVE_KICK: - /* User wurde geKICKed: ggf. andere Server sowie alle betroffenen User - * im entsprechenden Channel informieren */ - if( InformServer ) IRC_WriteStrServersPrefix( Client_NextHop( Origin ), Origin, "KICK %s %s :%s", c->name, Client_ID( Client ), Reason ); - IRC_WriteStrChannelPrefix( Client, c, Origin, false, "KICK %s %s :%s", c->name, Client_ID( Client ), Reason ); - if(( Client_Conn( Client ) > NONE ) && ( Client_Type( Client ) == CLIENT_USER )) IRC_WriteStrClientPrefix( Client, Origin, "KICK %s %s :%s", c->name, Client_ID( Client ), Reason ); - Log( LOG_DEBUG, "User \"%s\" has been kicked of \"%s\" by \"%s\": %s.", Client_Mask( Client ), c->name, Client_ID( Origin ), Reason ); + /* User was KICKed: inform other servers and all users in channel */ + if( InformServer ) + IRC_WriteStrServersPrefix( Client_NextHop( Origin ), + Origin, "KICK %s %s :%s", c->name, Client_ID( Client ), Reason); + IRC_WriteStrChannelPrefix(Client, c, Origin, false, "KICK %s %s :%s", + c->name, Client_ID( Client ), Reason ); + if ((Client_Conn(Client) > NONE) && + (Client_Type(Client) == CLIENT_USER)) + { + IRC_WriteStrClientPrefix(Client, Origin, "KICK %s %s :%s", + c->name, Client_ID( Client ), Reason); + } + LogDebug("User \"%s\" has been kicked of \"%s\" by \"%s\": %s.", + Client_Mask( Client ), c->name, Client_ID(Origin), Reason); break; - default: - /* PART */ - if( InformServer ) IRC_WriteStrServersPrefix( Origin, Client, "PART %s :%s", c->name, Reason ); - IRC_WriteStrChannelPrefix( Origin, c, Client, false, "PART %s :%s", c->name, Reason ); - if(( Client_Conn( Origin ) > NONE ) && ( Client_Type( Origin ) == CLIENT_USER )) IRC_WriteStrClientPrefix( Origin, Client, "PART %s :%s", c->name, Reason ); - Log( LOG_DEBUG, "User \"%s\" left channel \"%s\" (%s).", Client_Mask( Client ), c->name, Reason ); + default: /* PART */ + if (InformServer) + IRC_WriteStrServersPrefix(Origin, Client, "PART %s :%s", c->name, Reason); + + IRC_WriteStrChannelPrefix(Origin, c, Client, false, "PART %s :%s", + c->name, Reason); + + if ((Client_Conn(Origin) > NONE) && + (Client_Type(Origin) == CLIENT_USER)) + { + IRC_WriteStrClientPrefix( Origin, Client, "PART %s :%s", c->name, Reason); + LogDebug("User \"%s\" left channel \"%s\" (%s).", + Client_Mask(Client), c->name, Reason); + } } /* Wenn Channel nun leer und nicht pre-defined: loeschen */