From b8643477ba74bc09a896883f85a1325ec83ecc5e Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Sat, 19 Apr 2008 16:17:11 +0200 Subject: [PATCH 1/1] Channel_Mode: check return type of Invite/Ban Add/Del function --- src/ngircd/irc-mode.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ngircd/irc-mode.c b/src/ngircd/irc-mode.c index 2ebbc91d..9b2b53d0 100644 --- a/src/ngircd/irc-mode.c +++ b/src/ngircd/irc-mode.c @@ -486,10 +486,8 @@ Channel_Mode( CLIENT *Client, REQUEST *Req, CLIENT *Origin, CHANNEL *Channel ) if (arg_arg > mode_arg) { /* modify list */ if (modeok) { - if (set) - Add_Ban_Invite(*mode_ptr, Origin, Client, Channel, Req->argv[arg_arg]); - else - Del_Ban_Invite(*mode_ptr, Origin, Client, Channel, Req->argv[arg_arg]); + ok = set ? Add_Ban_Invite(*mode_ptr, Origin, Client, Channel, Req->argv[arg_arg]) + : Del_Ban_Invite(*mode_ptr, Origin, Client, Channel, Req->argv[arg_arg]); } else { ok = IRC_WriteStrClient(Origin, ERR_CHANOPRIVSNEEDED_MSG, Client_ID(Origin), Channel_Name(Channel)); -- 2.39.2