From 8ec17063a6e651229e04605592ce3d6114075655 Mon Sep 17 00:00:00 2001 From: Alexander Barton Date: Tue, 17 Apr 2012 12:54:38 +0200 Subject: [PATCH] Lists_Add(): use size of destination when copying data This fixes the following warning of clang: /src/ngircd/lists.c:152:44: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] But it isn't a real problem, because the size of the source always is the same than the size of the destination ... --- src/ngircd/lists.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ngircd/lists.c b/src/ngircd/lists.c index 4f57ca73..45a4874b 100644 --- a/src/ngircd/lists.c +++ b/src/ngircd/lists.c @@ -149,7 +149,8 @@ Lists_Add(struct list_head *h, const char *Mask, time_t ValidUntil, if (Reason) { newelem->reason = malloc(strlen(Reason) + 1); if (newelem->reason) - strlcpy(newelem->reason, Reason, strlen(Reason) + 1); + strlcpy(newelem->reason, Reason, + sizeof(newelem->reason)); else Log(LOG_EMERG, "Can't allocate memory for new list reason text!"); -- 2.39.2