From 7faa3ed7d6613f23e998604461f543e763278f7e Mon Sep 17 00:00:00 2001 From: Alexander Barton Date: Tue, 22 May 2012 13:29:31 +0200 Subject: [PATCH] Pidfile_Create(): Don't leak file descriptor on error path Detected by cppcheck: [src/ngircd/ngircd.c:502]: (error) Resource leak: pidfd --- src/ngircd/ngircd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c index f28ff05b..8a93bcb0 100644 --- a/src/ngircd/ngircd.c +++ b/src/ngircd/ngircd.c @@ -498,7 +498,8 @@ Pidfile_Create(pid_t pid) len = snprintf(pidbuf, sizeof pidbuf, "%ld\n", (long)pid); if (len < 0 || len >= (int)sizeof pidbuf) { - Log( LOG_ERR, "Error converting pid"); + Log(LOG_ERR, "Error converting pid"); + close(pidfd); return; } -- 2.39.2