From 42db159d26519da751896cbf83bcf0d5def1df59 Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Tue, 5 Feb 2008 11:46:55 +0000 Subject: [PATCH] Fix wrong strncpy usage if CVSDATE defined Hello_User() used strncpy with overlapping src/dest. Use memmove instead. --- src/ngircd/irc-login.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c index a095ddc0..1f7038ee 100644 --- a/src/ngircd/irc-login.c +++ b/src/ngircd/irc-login.c @@ -14,7 +14,7 @@ #include "portab.h" -static char UNUSED id[] = "$Id: irc-login.c,v 1.54 2007/11/21 12:16:36 alex Exp $"; +static char UNUSED id[] = "$Id: irc-login.c,v 1.55 2008/02/05 11:46:55 fw Exp $"; #include "imp.h" #include @@ -601,8 +601,8 @@ Hello_User( CLIENT *Client ) /* Version and system type */ #ifdef CVSDATE strlcpy( ver, CVSDATE, sizeof( ver )); - strncpy( ver + 4, ver + 5, 2 ); - strncpy( ver + 6, ver + 8, 3 ); + memmove( ver + 4, ver + 5, 2 ); + memmove( ver + 6, ver + 8, 3 ); snprintf( vertxt, sizeof( vertxt ), "%s(%s)", PACKAGE_VERSION, ver ); if( ! IRC_WriteStrClient( Client, RPL_YOURHOST_MSG, Client_ID( Client ), Client_ID( Client_ThisServer( )), vertxt, TARGET_CPU, TARGET_VENDOR, TARGET_OS )) return false; #else -- 2.39.2