From: Alexander Barton <alex@barton.de>
Date: Sat, 1 Aug 2015 12:21:32 +0000 (+0200)
Subject: First check if channel has mode "N", then check membership
X-Git-Tag: rel-23-rc1~17
X-Git-Url: https://arthur.barton.de/cgi-bin/gitweb.cgi?p=ngircd-alex.git;a=commitdiff_plain;h=b8482fd3cfdb429aec75575958f4d5d4e9ae22df

First check if channel has mode "N", then check membership

This should be more efficient.
---

diff --git a/src/ngircd/irc-login.c b/src/ngircd/irc-login.c
index 35026e55..9fca622b 100644
--- a/src/ngircd/irc-login.c
+++ b/src/ngircd/irc-login.c
@@ -266,8 +266,8 @@ IRC_NICK( CLIENT *Client, REQUEST *Req )
 			   !Client_HasMode(Client, 'o')) {
 				chan = Channel_First();
 				while (chan) {
-					if(Channel_IsMemberOf(chan, Client) &&
-					   Channel_HasMode(chan, 'N'))
+					if(Channel_HasMode(chan, 'N') &&
+					   Channel_IsMemberOf(chan, Client))
 						return IRC_WriteErrClient(Client,
 									  ERR_NONICKCHANGE_MSG,
 									  Client_ID(Client),